)]}'
{"dragonflow/tests/stresstest/test_subnets.py":[{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"43fa6cbd22df98796f418307a9b092f39a3473e3","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        creds \u003d credentials()"},{"line_number":32,"context_line":"        tenant_name \u003d creds[\u0027project_name\u0027]"},{"line_number":33,"context_line":"        auth_url \u003d creds[\u0027auth_url\u0027] + \"/v2.0\""},{"line_number":34,"context_line":"        print creds"},{"line_number":35,"context_line":"        self.neutron \u003d client.Client(\u00272.0\u0027, username\u003dcreds[\u0027username\u0027],"},{"line_number":36,"context_line":"             password\u003dcreds[\u0027password\u0027], auth_url\u003dauth_url,"},{"line_number":37,"context_line":"             tenant_name\u003dtenant_name)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a89bdaa_e53c4e95","line":34,"updated":"2016-09-13 08:07:55.000000000","message":"Is this print needed?","commit_id":"0b22f6dbdf1981aa0680de6f1a2a01ad3c3c543a"},{"author":{"_account_id":18903,"name":"Yuli","email":"stremovsky@gmail.com","username":"yuli"},"change_message_id":"9c33520230798851e3afe7a6f4b9fa9a8f1b66a0","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        creds \u003d credentials()"},{"line_number":32,"context_line":"        tenant_name \u003d creds[\u0027project_name\u0027]"},{"line_number":33,"context_line":"        auth_url \u003d creds[\u0027auth_url\u0027] + \"/v2.0\""},{"line_number":34,"context_line":"        print creds"},{"line_number":35,"context_line":"        self.neutron \u003d client.Client(\u00272.0\u0027, username\u003dcreds[\u0027username\u0027],"},{"line_number":36,"context_line":"             password\u003dcreds[\u0027password\u0027], auth_url\u003dauth_url,"},{"line_number":37,"context_line":"             tenant_name\u003dtenant_name)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a8bc5a2_97743cfe","line":34,"in_reply_to":"9a89bdaa_e53c4e95","updated":"2016-09-22 08:48:34.000000000","message":"Done","commit_id":"0b22f6dbdf1981aa0680de6f1a2a01ad3c3c543a"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"43fa6cbd22df98796f418307a9b092f39a3473e3","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    def create_get_net(self, name):"},{"line_number":50,"context_line":"        networks \u003d self.neutron.list_networks(name\u003dname)[\u0027networks\u0027]"},{"line_number":51,"context_line":"        networks_count \u003d len(networks)"},{"line_number":52,"context_line":"        if networks_count \u003e 0:"},{"line_number":53,"context_line":"            return networks[0][\u0027id\u0027]"},{"line_number":54,"context_line":"        network \u003d {\u0027name\u0027: name, \u0027admin_state_up\u0027: True, \u0027shared\u0027: False}"},{"line_number":55,"context_line":"        network \u003d self.neutron.create_network({\u0027network\u0027: network})"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a89bdaa_05b13201","line":52,"updated":"2016-09-13 08:07:55.000000000","message":"Why not just put len(networks) directly in the condition?","commit_id":"0b22f6dbdf1981aa0680de6f1a2a01ad3c3c543a"},{"author":{"_account_id":18903,"name":"Yuli","email":"stremovsky@gmail.com","username":"yuli"},"change_message_id":"9c33520230798851e3afe7a6f4b9fa9a8f1b66a0","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    def create_get_net(self, name):"},{"line_number":50,"context_line":"        networks \u003d self.neutron.list_networks(name\u003dname)[\u0027networks\u0027]"},{"line_number":51,"context_line":"        networks_count \u003d len(networks)"},{"line_number":52,"context_line":"        if networks_count \u003e 0:"},{"line_number":53,"context_line":"            return networks[0][\u0027id\u0027]"},{"line_number":54,"context_line":"        network \u003d {\u0027name\u0027: name, \u0027admin_state_up\u0027: True, \u0027shared\u0027: False}"},{"line_number":55,"context_line":"        network \u003d self.neutron.create_network({\u0027network\u0027: network})"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a8bc5a2_974b5cb0","line":52,"in_reply_to":"9a89bdaa_05b13201","updated":"2016-09-22 08:48:34.000000000","message":"Done","commit_id":"0b22f6dbdf1981aa0680de6f1a2a01ad3c3c543a"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"43fa6cbd22df98796f418307a9b092f39a3473e3","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        return network[\u0027network\u0027][\u0027id\u0027]"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def create_subnet_and_link_to_router(self, router_id, net_id, name, cidr):"},{"line_number":59,"context_line":"        subnet \u003d {"},{"line_number":60,"context_line":"            \u0027cidr\u0027: cidr,"},{"line_number":61,"context_line":"            \u0027name\u0027: name,"},{"line_number":62,"context_line":"            \u0027ip_version\u0027: 4,"},{"line_number":63,"context_line":"            \u0027network_id\u0027: net_id"},{"line_number":64,"context_line":"        }"},{"line_number":65,"context_line":"        subnet \u003d self.neutron.create_subnet(body\u003d{\u0027subnet\u0027: subnet})"},{"line_number":66,"context_line":"        subnet_id \u003d subnet[\u0027subnet\u0027][\u0027id\u0027]"},{"line_number":67,"context_line":"        self.neutron.add_interface_router(router_id,"},{"line_number":68,"context_line":"             body\u003d{\u0027subnet_id\u0027: subnet_id})"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a89bdaa_6593de5b","line":65,"range":{"start_line":59,"start_character":0,"end_line":65,"end_character":68},"updated":"2016-09-13 08:07:55.000000000","message":"Why not call self.create_subnet?","commit_id":"0b22f6dbdf1981aa0680de6f1a2a01ad3c3c543a"},{"author":{"_account_id":18903,"name":"Yuli","email":"stremovsky@gmail.com","username":"yuli"},"change_message_id":"9c33520230798851e3afe7a6f4b9fa9a8f1b66a0","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        return network[\u0027network\u0027][\u0027id\u0027]"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def create_subnet_and_link_to_router(self, router_id, net_id, name, cidr):"},{"line_number":59,"context_line":"        subnet \u003d {"},{"line_number":60,"context_line":"            \u0027cidr\u0027: cidr,"},{"line_number":61,"context_line":"            \u0027name\u0027: name,"},{"line_number":62,"context_line":"            \u0027ip_version\u0027: 4,"},{"line_number":63,"context_line":"            \u0027network_id\u0027: net_id"},{"line_number":64,"context_line":"        }"},{"line_number":65,"context_line":"        subnet \u003d self.neutron.create_subnet(body\u003d{\u0027subnet\u0027: subnet})"},{"line_number":66,"context_line":"        subnet_id \u003d subnet[\u0027subnet\u0027][\u0027id\u0027]"},{"line_number":67,"context_line":"        self.neutron.add_interface_router(router_id,"},{"line_number":68,"context_line":"             body\u003d{\u0027subnet_id\u0027: subnet_id})"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a8bc5a2_97a7dc4e","line":65,"range":{"start_line":59,"start_character":0,"end_line":65,"end_character":68},"in_reply_to":"9a89bdaa_6593de5b","updated":"2016-09-22 08:48:34.000000000","message":"Done","commit_id":"0b22f6dbdf1981aa0680de6f1a2a01ad3c3c543a"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"43fa6cbd22df98796f418307a9b092f39a3473e3","unresolved":false,"context_lines":[{"line_number":74,"context_line":"            \u0027ip_version\u0027: 4,"},{"line_number":75,"context_line":"            \u0027network_id\u0027: network_id"},{"line_number":76,"context_line":"        }"},{"line_number":77,"context_line":"        subnet \u003d self.neutron.create_subnet(body\u003d{\u0027subnet\u0027: subnet})"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def test1(self):"},{"line_number":80,"context_line":"        nun_subnets \u003d 0"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a89bdaa_057f7217","line":77,"range":{"start_line":77,"start_character":0,"end_line":77,"end_character":68},"updated":"2016-09-13 08:07:55.000000000","message":"1. variable reuse - please use two separate variables.\n2. This variable is never read. Did you mean to return it?","commit_id":"0b22f6dbdf1981aa0680de6f1a2a01ad3c3c543a"},{"author":{"_account_id":18903,"name":"Yuli","email":"stremovsky@gmail.com","username":"yuli"},"change_message_id":"9c33520230798851e3afe7a6f4b9fa9a8f1b66a0","unresolved":false,"context_lines":[{"line_number":74,"context_line":"            \u0027ip_version\u0027: 4,"},{"line_number":75,"context_line":"            \u0027network_id\u0027: network_id"},{"line_number":76,"context_line":"        }"},{"line_number":77,"context_line":"        subnet \u003d self.neutron.create_subnet(body\u003d{\u0027subnet\u0027: subnet})"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def test1(self):"},{"line_number":80,"context_line":"        nun_subnets \u003d 0"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a8bc5a2_577474ce","line":77,"range":{"start_line":77,"start_character":0,"end_line":77,"end_character":68},"in_reply_to":"9a89bdaa_057f7217","updated":"2016-09-22 08:48:34.000000000","message":"Done","commit_id":"0b22f6dbdf1981aa0680de6f1a2a01ad3c3c543a"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"43fa6cbd22df98796f418307a9b092f39a3473e3","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        subnet \u003d self.neutron.create_subnet(body\u003d{\u0027subnet\u0027: subnet})"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def test1(self):"},{"line_number":80,"context_line":"        nun_subnets \u003d 0"},{"line_number":81,"context_line":"        start \u003d time.time()"},{"line_number":82,"context_line":"        for j in range(1, 2):"},{"line_number":83,"context_line":"            network_id \u003d self.create_get_net(\u0027TEST-NETWORK-\u0027 + str(j))"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a89bdaa_25847609","line":80,"range":{"start_line":80,"start_character":10,"end_line":80,"end_character":12},"updated":"2016-09-13 08:07:55.000000000","message":"typo: num_subnets?","commit_id":"0b22f6dbdf1981aa0680de6f1a2a01ad3c3c543a"},{"author":{"_account_id":18903,"name":"Yuli","email":"stremovsky@gmail.com","username":"yuli"},"change_message_id":"9c33520230798851e3afe7a6f4b9fa9a8f1b66a0","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        subnet \u003d self.neutron.create_subnet(body\u003d{\u0027subnet\u0027: subnet})"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def test1(self):"},{"line_number":80,"context_line":"        nun_subnets \u003d 0"},{"line_number":81,"context_line":"        start \u003d time.time()"},{"line_number":82,"context_line":"        for j in range(1, 2):"},{"line_number":83,"context_line":"            network_id \u003d self.create_get_net(\u0027TEST-NETWORK-\u0027 + str(j))"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a8bc5a2_d74ec495","line":80,"range":{"start_line":80,"start_character":10,"end_line":80,"end_character":12},"in_reply_to":"9a89bdaa_25847609","updated":"2016-09-22 08:48:34.000000000","message":"Done","commit_id":"0b22f6dbdf1981aa0680de6f1a2a01ad3c3c543a"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"43fa6cbd22df98796f418307a9b092f39a3473e3","unresolved":false,"context_lines":[{"line_number":79,"context_line":"    def test1(self):"},{"line_number":80,"context_line":"        nun_subnets \u003d 0"},{"line_number":81,"context_line":"        start \u003d time.time()"},{"line_number":82,"context_line":"        for j in range(1, 2):"},{"line_number":83,"context_line":"            network_id \u003d self.create_get_net(\u0027TEST-NETWORK-\u0027 + str(j))"},{"line_number":84,"context_line":"            for i in range(255):"},{"line_number":85,"context_line":"                cidr \u003d \u00271.\u0027 + str(j) + \u0027.\u0027 + str(i) + \u0027.0/24\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a89bdaa_b4527511","line":82,"updated":"2016-09-13 08:07:55.000000000","message":"range(1,2) returns [1] and then this loops runs only once. Was that the intention? range(n) returns a list of length n.","commit_id":"0b22f6dbdf1981aa0680de6f1a2a01ad3c3c543a"},{"author":{"_account_id":18903,"name":"Yuli","email":"stremovsky@gmail.com","username":"yuli"},"change_message_id":"9c33520230798851e3afe7a6f4b9fa9a8f1b66a0","unresolved":false,"context_lines":[{"line_number":79,"context_line":"    def test1(self):"},{"line_number":80,"context_line":"        nun_subnets \u003d 0"},{"line_number":81,"context_line":"        start \u003d time.time()"},{"line_number":82,"context_line":"        for j in range(1, 2):"},{"line_number":83,"context_line":"            network_id \u003d self.create_get_net(\u0027TEST-NETWORK-\u0027 + str(j))"},{"line_number":84,"context_line":"            for i in range(255):"},{"line_number":85,"context_line":"                cidr \u003d \u00271.\u0027 + str(j) + \u0027.\u0027 + str(i) + \u0027.0/24\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a8bc5a2_f73ae0e6","line":82,"in_reply_to":"9a89bdaa_b4527511","updated":"2016-09-22 08:48:34.000000000","message":"Yes, I was doing tests where I need to create more networks.","commit_id":"0b22f6dbdf1981aa0680de6f1a2a01ad3c3c543a"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"43fa6cbd22df98796f418307a9b092f39a3473e3","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        start \u003d time.time()"},{"line_number":82,"context_line":"        for j in range(1, 2):"},{"line_number":83,"context_line":"            network_id \u003d self.create_get_net(\u0027TEST-NETWORK-\u0027 + str(j))"},{"line_number":84,"context_line":"            for i in range(255):"},{"line_number":85,"context_line":"                cidr \u003d \u00271.\u0027 + str(j) + \u0027.\u0027 + str(i) + \u0027.0/24\u0027"},{"line_number":86,"context_line":"                subnet_name \u003d \u0027SUBNET-\u0027 + str(j) + \u0027-\u0027 + str(i)"},{"line_number":87,"context_line":"                self.create_subnet(network_id, subnet_name, cidr)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a89bdaa_f4cb1da2","line":84,"range":{"start_line":84,"start_character":16,"end_line":84,"end_character":17},"updated":"2016-09-13 08:07:55.000000000","message":"Please use meaningful variable names, and not \u0027i\u0027 and \u0027j\u0027.","commit_id":"0b22f6dbdf1981aa0680de6f1a2a01ad3c3c543a"},{"author":{"_account_id":20287,"name":"hujie","email":"mike.hu@huawei.com","username":"hujie"},"change_message_id":"f49cd45d535175e2db099c7300b53c868d479a9a","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        start \u003d time.time()"},{"line_number":82,"context_line":"        for j in range(1, 2):"},{"line_number":83,"context_line":"            network_id \u003d self.create_get_net(\u0027TEST-NETWORK-\u0027 + str(j))"},{"line_number":84,"context_line":"            for i in range(255):"},{"line_number":85,"context_line":"                cidr \u003d \u00271.\u0027 + str(j) + \u0027.\u0027 + str(i) + \u0027.0/24\u0027"},{"line_number":86,"context_line":"                subnet_name \u003d \u0027SUBNET-\u0027 + str(j) + \u0027-\u0027 + str(i)"},{"line_number":87,"context_line":"                self.create_subnet(network_id, subnet_name, cidr)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8ec9b2_c5a1d395","line":84,"range":{"start_line":84,"start_character":20,"end_line":84,"end_character":32},"updated":"2016-09-18 07:41:44.000000000","message":"consider use constant variables to indicate how many networks and subnets you want to use for testing.","commit_id":"0b22f6dbdf1981aa0680de6f1a2a01ad3c3c543a"},{"author":{"_account_id":23235,"name":"Lihi Wishnitzer","email":"lihiwish@gmail.com","username":"lihiwish"},"change_message_id":"445e31e2d66cf3f105ed9d5477a2ce61cd43ea39","unresolved":false,"context_lines":[{"line_number":83,"context_line":"            network_id \u003d self.create_get_net(\u0027TEST-NETWORK-\u0027 + str(j))"},{"line_number":84,"context_line":"            for i in range(255):"},{"line_number":85,"context_line":"                cidr \u003d \u00271.\u0027 + str(j) + \u0027.\u0027 + str(i) + \u0027.0/24\u0027"},{"line_number":86,"context_line":"                subnet_name \u003d \u0027SUBNET-\u0027 + str(j) + \u0027-\u0027 + str(i)"},{"line_number":87,"context_line":"                self.create_subnet(network_id, subnet_name, cidr)"},{"line_number":88,"context_line":"                nun_subnets \u003d nun_subnets + 1"},{"line_number":89,"context_line":"        end \u003d time.time()"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8ec9b2_580abed3","line":86,"range":{"start_line":86,"start_character":16,"end_line":86,"end_character":63},"updated":"2016-09-14 12:04:08.000000000","message":"Why not use:\nsubnet_name_pattern \u003d \u0027SUBNET-{}-{}\u0027\nsubnet_name \u003d subnet_name_pattern.format(i, j)","commit_id":"0b22f6dbdf1981aa0680de6f1a2a01ad3c3c543a"},{"author":{"_account_id":18903,"name":"Yuli","email":"stremovsky@gmail.com","username":"yuli"},"change_message_id":"9c33520230798851e3afe7a6f4b9fa9a8f1b66a0","unresolved":false,"context_lines":[{"line_number":83,"context_line":"            network_id \u003d self.create_get_net(\u0027TEST-NETWORK-\u0027 + str(j))"},{"line_number":84,"context_line":"            for i in range(255):"},{"line_number":85,"context_line":"                cidr \u003d \u00271.\u0027 + str(j) + \u0027.\u0027 + str(i) + \u0027.0/24\u0027"},{"line_number":86,"context_line":"                subnet_name \u003d \u0027SUBNET-\u0027 + str(j) + \u0027-\u0027 + str(i)"},{"line_number":87,"context_line":"                self.create_subnet(network_id, subnet_name, cidr)"},{"line_number":88,"context_line":"                nun_subnets \u003d nun_subnets + 1"},{"line_number":89,"context_line":"        end \u003d time.time()"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a8bc5a2_d22a527e","line":86,"range":{"start_line":86,"start_character":16,"end_line":86,"end_character":63},"in_reply_to":"7a8ec9b2_580abed3","updated":"2016-09-22 08:48:34.000000000","message":"Done","commit_id":"0b22f6dbdf1981aa0680de6f1a2a01ad3c3c543a"},{"author":{"_account_id":23235,"name":"Lihi Wishnitzer","email":"lihiwish@gmail.com","username":"lihiwish"},"change_message_id":"445e31e2d66cf3f105ed9d5477a2ce61cd43ea39","unresolved":false,"context_lines":[{"line_number":87,"context_line":"                self.create_subnet(network_id, subnet_name, cidr)"},{"line_number":88,"context_line":"                nun_subnets \u003d nun_subnets + 1"},{"line_number":89,"context_line":"        end \u003d time.time()"},{"line_number":90,"context_line":"        total \u003d end - start"},{"line_number":91,"context_line":"        print(\"TEST1: time spend to create %d subnets: %d\""},{"line_number":92,"context_line":"              % (nun_subnets, total))"},{"line_number":93,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8ec9b2_7dd12ccd","line":90,"range":{"start_line":90,"start_character":8,"end_line":90,"end_character":13},"updated":"2016-09-14 12:04:08.000000000","message":"I think \"total_time\" is a better name.","commit_id":"0b22f6dbdf1981aa0680de6f1a2a01ad3c3c543a"},{"author":{"_account_id":18903,"name":"Yuli","email":"stremovsky@gmail.com","username":"yuli"},"change_message_id":"9c33520230798851e3afe7a6f4b9fa9a8f1b66a0","unresolved":false,"context_lines":[{"line_number":87,"context_line":"                self.create_subnet(network_id, subnet_name, cidr)"},{"line_number":88,"context_line":"                nun_subnets \u003d nun_subnets + 1"},{"line_number":89,"context_line":"        end \u003d time.time()"},{"line_number":90,"context_line":"        total \u003d end - start"},{"line_number":91,"context_line":"        print(\"TEST1: time spend to create %d subnets: %d\""},{"line_number":92,"context_line":"              % (nun_subnets, total))"},{"line_number":93,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5a8bc5a2_d2517210","line":90,"range":{"start_line":90,"start_character":8,"end_line":90,"end_character":13},"in_reply_to":"7a8ec9b2_7dd12ccd","updated":"2016-09-22 08:48:34.000000000","message":"Done","commit_id":"0b22f6dbdf1981aa0680de6f1a2a01ad3c3c543a"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"43fa6cbd22df98796f418307a9b092f39a3473e3","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        print(\"TEST1: time spend to create %d subnets: %d\""},{"line_number":92,"context_line":"              % (nun_subnets, total))"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    def test2(self):"},{"line_number":95,"context_line":"        nun_subnets \u003d 0"},{"line_number":96,"context_line":"        router_id \u003d self.create_get_router(\u0027TEST-ROUTER-1\u0027)"},{"line_number":97,"context_line":"        for j in range(1, 2):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a89bdaa_54bbe90e","line":94,"updated":"2016-09-13 08:07:55.000000000","message":"Same comments from test1","commit_id":"0b22f6dbdf1981aa0680de6f1a2a01ad3c3c543a"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"43fa6cbd22df98796f418307a9b092f39a3473e3","unresolved":false,"context_lines":[{"line_number":96,"context_line":"        router_id \u003d self.create_get_router(\u0027TEST-ROUTER-1\u0027)"},{"line_number":97,"context_line":"        for j in range(1, 2):"},{"line_number":98,"context_line":"            network_id \u003d self.create_get_net(\u0027TEST-NETWORK-\u0027 + str(j))"},{"line_number":99,"context_line":"            start \u003d time.time()"},{"line_number":100,"context_line":"            for i in range(255):"},{"line_number":101,"context_line":"                cidr \u003d \u00271.\u0027 + str(j) + \u0027.\u0027 + str(i) + \u0027.0/24\u0027"},{"line_number":102,"context_line":"                subnet_name \u003d \u0027TEST-SUBNET-\u0027 + str(j) + \u0027-\u0027 + str(i)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a89bdaa_144c0141","line":99,"updated":"2016-09-13 08:07:55.000000000","message":"start is initialised from inside the loop?","commit_id":"0b22f6dbdf1981aa0680de6f1a2a01ad3c3c543a"},{"author":{"_account_id":18903,"name":"Yuli","email":"stremovsky@gmail.com","username":"yuli"},"change_message_id":"9c33520230798851e3afe7a6f4b9fa9a8f1b66a0","unresolved":false,"context_lines":[{"line_number":96,"context_line":"        router_id \u003d self.create_get_router(\u0027TEST-ROUTER-1\u0027)"},{"line_number":97,"context_line":"        for j in range(1, 2):"},{"line_number":98,"context_line":"            network_id \u003d self.create_get_net(\u0027TEST-NETWORK-\u0027 + str(j))"},{"line_number":99,"context_line":"            start \u003d time.time()"},{"line_number":100,"context_line":"            for i in range(255):"},{"line_number":101,"context_line":"                cidr \u003d \u00271.\u0027 + str(j) + \u0027.\u0027 + str(i) + \u0027.0/24\u0027"},{"line_number":102,"context_line":"                subnet_name \u003d \u0027TEST-SUBNET-\u0027 + str(j) + \u0027-\u0027 + str(i)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a8bc5a2_f2dcae48","line":99,"in_reply_to":"9a89bdaa_144c0141","updated":"2016-09-22 08:48:34.000000000","message":"Done","commit_id":"0b22f6dbdf1981aa0680de6f1a2a01ad3c3c543a"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"43fa6cbd22df98796f418307a9b092f39a3473e3","unresolved":false,"context_lines":[{"line_number":110,"context_line":"        total \u003d end - start"},{"line_number":111,"context_line":"        print(\"TEST2: time spend to create %d subnets: %d\""},{"line_number":112,"context_line":"              % (nun_subnets, total))"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    def clean_network(self, name):"},{"line_number":115,"context_line":"        print(\"Clean test results\")"},{"line_number":116,"context_line":"        networks \u003d self.neutron.list_networks(name\u003dname)[\u0027networks\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a89bdaa_34702572","line":113,"updated":"2016-09-13 08:07:55.000000000","message":"test1 and test2 are very similar. Maybe move common parts to external functions?","commit_id":"0b22f6dbdf1981aa0680de6f1a2a01ad3c3c543a"},{"author":{"_account_id":18903,"name":"Yuli","email":"stremovsky@gmail.com","username":"yuli"},"change_message_id":"9c33520230798851e3afe7a6f4b9fa9a8f1b66a0","unresolved":false,"context_lines":[{"line_number":110,"context_line":"        total \u003d end - start"},{"line_number":111,"context_line":"        print(\"TEST2: time spend to create %d subnets: %d\""},{"line_number":112,"context_line":"              % (nun_subnets, total))"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    def clean_network(self, name):"},{"line_number":115,"context_line":"        print(\"Clean test results\")"},{"line_number":116,"context_line":"        networks \u003d self.neutron.list_networks(name\u003dname)[\u0027networks\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a8bc5a2_12e2fa03","line":113,"in_reply_to":"9a89bdaa_34702572","updated":"2016-09-22 08:48:34.000000000","message":"I will think about this.","commit_id":"0b22f6dbdf1981aa0680de6f1a2a01ad3c3c543a"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"43fa6cbd22df98796f418307a9b092f39a3473e3","unresolved":false,"context_lines":[{"line_number":111,"context_line":"        print(\"TEST2: time spend to create %d subnets: %d\""},{"line_number":112,"context_line":"              % (nun_subnets, total))"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    def clean_network(self, name):"},{"line_number":115,"context_line":"        print(\"Clean test results\")"},{"line_number":116,"context_line":"        networks \u003d self.neutron.list_networks(name\u003dname)[\u0027networks\u0027]"},{"line_number":117,"context_line":"        for net in networks:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a89bdaa_b40a75d0","line":114,"updated":"2016-09-13 08:07:55.000000000","message":"I think you should store in-memory the objects you create, and only remove those. Don\u0027t delete networks that already existed in the environment.","commit_id":"0b22f6dbdf1981aa0680de6f1a2a01ad3c3c543a"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"3e6f6524044e1abd69403304d6ab9a11ebee38b2","unresolved":false,"context_lines":[{"line_number":111,"context_line":"        print(\"TEST2: time spend to create %d subnets: %d\""},{"line_number":112,"context_line":"              % (nun_subnets, total))"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    def clean_network(self, name):"},{"line_number":115,"context_line":"        print(\"Clean test results\")"},{"line_number":116,"context_line":"        networks \u003d self.neutron.list_networks(name\u003dname)[\u0027networks\u0027]"},{"line_number":117,"context_line":"        for net in networks:"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8ec9b2_6dde25de","line":114,"in_reply_to":"7a8ec9b2_c5f6338e","updated":"2016-09-18 12:50:37.000000000","message":"@HuJie, Yes. In effect it is supposed to delete only networks created for this test. In the Grand Scheme of Things, the test should revert the system to the state it had before the test started.\n\nMy suggestion was one way to do it. Using the name as identifier may also work, but I don\u0027t think it is complete here.","commit_id":"0b22f6dbdf1981aa0680de6f1a2a01ad3c3c543a"},{"author":{"_account_id":20287,"name":"hujie","email":"mike.hu@huawei.com","username":"hujie"},"change_message_id":"f49cd45d535175e2db099c7300b53c868d479a9a","unresolved":false,"context_lines":[{"line_number":111,"context_line":"        print(\"TEST2: time spend to create %d subnets: %d\""},{"line_number":112,"context_line":"              % (nun_subnets, total))"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    def clean_network(self, name):"},{"line_number":115,"context_line":"        print(\"Clean test results\")"},{"line_number":116,"context_line":"        networks \u003d self.neutron.list_networks(name\u003dname)[\u0027networks\u0027]"},{"line_number":117,"context_line":"        for net in networks:"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8ec9b2_c5f6338e","line":114,"in_reply_to":"9a89bdaa_b40a75d0","updated":"2016-09-18 07:41:44.000000000","message":"@Omer, the code here do not delete all the networks in the environment, it is filtered by the network-name which only use the test-network-name in this test.","commit_id":"0b22f6dbdf1981aa0680de6f1a2a01ad3c3c543a"},{"author":{"_account_id":20287,"name":"hujie","email":"mike.hu@huawei.com","username":"hujie"},"change_message_id":"f49cd45d535175e2db099c7300b53c868d479a9a","unresolved":false,"context_lines":[{"line_number":136,"context_line":""},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"def main():"},{"line_number":139,"context_line":"    test \u003d StressTest()"},{"line_number":140,"context_line":"    test.test1()"},{"line_number":141,"context_line":"    test.clean_network(\u0027TEST-NETWORK-1\u0027)"},{"line_number":142,"context_line":"    test.test2()"},{"line_number":143,"context_line":"    test.clean_network(\u0027TEST-NETWORK-1\u0027)"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"if __name__ \u003d\u003d \u0027__main__\u0027:"},{"line_number":146,"context_line":"    sys.exit(main())"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8ec9b2_a54207ac","line":143,"range":{"start_line":139,"start_character":4,"end_line":143,"end_character":40},"updated":"2016-09-18 07:41:44.000000000","message":"consider add clean router logic if you create a new one.","commit_id":"0b22f6dbdf1981aa0680de6f1a2a01ad3c3c543a"},{"author":{"_account_id":20287,"name":"hujie","email":"mike.hu@huawei.com","username":"hujie"},"change_message_id":"450a1d6b3b357abc2ce814529c962b3984666f82","unresolved":false,"context_lines":[{"line_number":131,"context_line":""},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"def main():"},{"line_number":134,"context_line":"    test \u003d StressTest()"},{"line_number":135,"context_line":"    test.test1()"},{"line_number":136,"context_line":"    test.clean_network(\u0027TEST-NETWORK-1\u0027)"},{"line_number":137,"context_line":"    test.test2()"},{"line_number":138,"context_line":"    test.clean_network(\u0027TEST-NETWORK-1\u0027)"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"if __name__ \u003d\u003d \u0027__main__\u0027:"},{"line_number":141,"context_line":"    sys.exit(main())"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a8bc5a2_09e80c7c","line":138,"range":{"start_line":134,"start_character":4,"end_line":138,"end_character":40},"updated":"2016-09-22 08:56:12.000000000","message":"why ignore router clean logic if you created a router in the create_get_router() method? Or you can follow omer\u0027s suggest to have a cache mechanism:)","commit_id":"fd13f64b18035692e15071f07160c677853338d0"}]}