)]}'
{"dragonflow/neutron/ml2/mech_driver.py":[{"author":{"_account_id":22060,"name":"jingting","email":"kangjingting@huawei.com","username":"jingting"},"change_message_id":"e1910ea535f3bbc4cb277b109d3468c6d54e7434","unresolved":false,"context_lines":[{"line_number":160,"context_line":"    def delete_security_group_rule(self, resource, event, trigger, **kwargs):"},{"line_number":161,"context_line":"        context \u003d kwargs[\u0027context\u0027]"},{"line_number":162,"context_line":"        sgr_id \u003d kwargs[\u0027security_group_rule_id\u0027]"},{"line_number":163,"context_line":"        sg_id \u003d kwargs[\u0027security_group_id\u0027]"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"        core_plugin \u003d manager.NeutronManager.get_plugin()"},{"line_number":166,"context_line":"        sg \u003d core_plugin.get_security_group(context, sg_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a8bc5a2_d33bc536","line":163,"range":{"start_line":163,"start_character":24,"end_line":163,"end_character":41},"updated":"2016-09-24 03:18:06.000000000","message":"is there any difference to get sg_id from kwargs, comparing to getting from sgr? I see there are two related patches in df and neutron","commit_id":"76ece8fb76a2074af36f574efc42d04df1776fb1"},{"author":{"_account_id":22060,"name":"jingting","email":"kangjingting@huawei.com","username":"jingting"},"change_message_id":"6eca986c9cad6671e620a403116b84b9fc409cf8","unresolved":false,"context_lines":[{"line_number":160,"context_line":"    def delete_security_group_rule(self, resource, event, trigger, **kwargs):"},{"line_number":161,"context_line":"        context \u003d kwargs[\u0027context\u0027]"},{"line_number":162,"context_line":"        sgr_id \u003d kwargs[\u0027security_group_rule_id\u0027]"},{"line_number":163,"context_line":"        sg_id \u003d kwargs[\u0027security_group_id\u0027]"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"        core_plugin \u003d manager.NeutronManager.get_plugin()"},{"line_number":166,"context_line":"        sg \u003d core_plugin.get_security_group(context, sg_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a8bc5a2_733cb1e2","line":163,"range":{"start_line":163,"start_character":24,"end_line":163,"end_character":41},"in_reply_to":"5a8bc5a2_13744dfb","updated":"2016-09-24 03:47:50.000000000","message":"good work!","commit_id":"76ece8fb76a2074af36f574efc42d04df1776fb1"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"5bebbdab0d754814c3048dfd05d530ae8f3e268c","unresolved":false,"context_lines":[{"line_number":160,"context_line":"    def delete_security_group_rule(self, resource, event, trigger, **kwargs):"},{"line_number":161,"context_line":"        context \u003d kwargs[\u0027context\u0027]"},{"line_number":162,"context_line":"        sgr_id \u003d kwargs[\u0027security_group_rule_id\u0027]"},{"line_number":163,"context_line":"        sg_id \u003d kwargs[\u0027security_group_id\u0027]"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"        core_plugin \u003d manager.NeutronManager.get_plugin()"},{"line_number":166,"context_line":"        sg \u003d core_plugin.get_security_group(context, sg_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a8bc5a2_13744dfb","line":163,"range":{"start_line":163,"start_character":24,"end_line":163,"end_character":41},"in_reply_to":"5a8bc5a2_d33bc536","updated":"2016-09-24 03:24:25.000000000","message":"In the after_delete event, sgr is actually deleted, so there is no way to get sgr from neutron db.\n\nWhy after_delete event? Currently, we are using before_delete, which is not reasonable. before_delete is used to verify the resource can be deleted, not to apply changes for the deleted resource. plus, we can\u0027t get updated revision_number in the before_delete event.","commit_id":"76ece8fb76a2074af36f574efc42d04df1776fb1"}],"dragonflow/tests/unit/test_mech_driver.py":[{"author":{"_account_id":20287,"name":"hujie","email":"mike.hu@huawei.com","username":"hujie"},"change_message_id":"0cd8e6fa52a6776b7e35196bc010dcf5c5dac464","unresolved":false,"context_lines":[{"line_number":395,"context_line":"        return kwargs"},{"line_number":396,"context_line":""},{"line_number":397,"context_line":"    def _get_security_group_rule_kwargs(self, rules, sgr_id, context):"},{"line_number":398,"context_line":"        kwargs \u003d {\u0027security_group_rule\u0027: rules,"},{"line_number":399,"context_line":"                  \u0027security_group_rule_id\u0027: sgr_id,"},{"line_number":400,"context_line":"                  \u0027context\u0027: context}"},{"line_number":401,"context_line":"        return kwargs"},{"line_number":402,"context_line":""},{"line_number":403,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5a8bc5a2_466f6892","line":400,"range":{"start_line":398,"start_character":8,"end_line":400,"end_character":37},"updated":"2016-09-22 06:27:12.000000000","message":"it has no security_group_id key here, so the python27 error appears","commit_id":"76ece8fb76a2074af36f574efc42d04df1776fb1"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"5bebbdab0d754814c3048dfd05d530ae8f3e268c","unresolved":false,"context_lines":[{"line_number":395,"context_line":"        return kwargs"},{"line_number":396,"context_line":""},{"line_number":397,"context_line":"    def _get_security_group_rule_kwargs(self, rules, sgr_id, context):"},{"line_number":398,"context_line":"        kwargs \u003d {\u0027security_group_rule\u0027: rules,"},{"line_number":399,"context_line":"                  \u0027security_group_rule_id\u0027: sgr_id,"},{"line_number":400,"context_line":"                  \u0027context\u0027: context}"},{"line_number":401,"context_line":"        return kwargs"},{"line_number":402,"context_line":""},{"line_number":403,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5a8bc5a2_3361493a","line":400,"range":{"start_line":398,"start_character":8,"end_line":400,"end_character":37},"in_reply_to":"5a8bc5a2_466f6892","updated":"2016-09-24 03:24:25.000000000","message":"it is in the neutron dependent patch. the patch is not merged yet, so the ut fails.","commit_id":"76ece8fb76a2074af36f574efc42d04df1776fb1"}]}