)]}'
{"dragonflow/neutron/services/l3_router_plugin.py":[{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"b0b3757fd95b3baa9e85fadef1f6c46392121b9a","unresolved":false,"context_lines":[{"line_number":171,"context_line":"    @lock_db.wrap_db_lock(lock_db.RESOURCE_DF_PLUGIN)"},{"line_number":172,"context_line":"    def create_floatingip(self, context, floatingip):"},{"line_number":173,"context_line":"        try:"},{"line_number":174,"context_line":"            floatingip_port \u003d None"},{"line_number":175,"context_line":"            floatingip_dict \u003d super(DFL3RouterPlugin, self).create_floatingip("},{"line_number":176,"context_line":"                context, floatingip,"},{"line_number":177,"context_line":"                initial_status\u003dconst.FLOATINGIP_STATUS_DOWN)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a89bdaa_b5d641ef","line":174,"updated":"2016-09-11 16:22:50.000000000","message":"nit: Wouldn\u0027t it be better to define this before the \u0027try\u0027? Since it is used after the try/except blocks end, and future developers won\u0027t accidentally put code that throws exceptions before it.","commit_id":"0e697bc9053b12b5a240482f2e779a2edd555cd6"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"3e30db6d53752a14df876e55163f1a765f6feec9","unresolved":false,"context_lines":[{"line_number":171,"context_line":"    @lock_db.wrap_db_lock(lock_db.RESOURCE_DF_PLUGIN)"},{"line_number":172,"context_line":"    def create_floatingip(self, context, floatingip):"},{"line_number":173,"context_line":"        try:"},{"line_number":174,"context_line":"            floatingip_port \u003d None"},{"line_number":175,"context_line":"            floatingip_dict \u003d super(DFL3RouterPlugin, self).create_floatingip("},{"line_number":176,"context_line":"                context, floatingip,"},{"line_number":177,"context_line":"                initial_status\u003dconst.FLOATINGIP_STATUS_DOWN)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a89bdaa_535ee812","line":174,"in_reply_to":"9a89bdaa_b5d641ef","updated":"2016-09-12 03:26:36.000000000","message":"Done","commit_id":"0e697bc9053b12b5a240482f2e779a2edd555cd6"}]}