)]}'
{"dragonflow/tests/unit/test_dnat_app.py":[{"author":{"_account_id":20336,"name":"heshan","email":"shan.he@huawei.com","username":"shanhe"},"change_message_id":"d28677f4e9d15f34f5aafcc31c6a500867829f54","unresolved":false,"context_lines":[{"line_number":44,"context_line":"                       constants.INGRESS_CLASSIFICATION_DISPATCH_TABLE,"},{"line_number":45,"context_line":"                       constants.PRIORITY_DEFAULT,"},{"line_number":46,"context_line":"                       constants.INGRESS_NAT_TABLE,"},{"line_number":47,"context_line":"                       match\u003dmock.ANY),"},{"line_number":48,"context_line":"             mock.call(self.datapath,"},{"line_number":49,"context_line":"                       constants.L3_LOOKUP_TABLE,"},{"line_number":50,"context_line":"                       constants.PRIORITY_MEDIUM,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8ec9b2_9100f567","line":47,"range":{"start_line":47,"start_character":29,"end_line":47,"end_character":37},"updated":"2016-09-18 01:41:57.000000000","message":"It\u0027s better to differentiate match of flow, or else errors maybe hidden.","commit_id":"70f3f7790ea0cfa7c6ba7dd6fcf1efc0f8161114"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"39ab2a7d830f0d5bd7362e7f2e13f1d33b0929c9","unresolved":false,"context_lines":[{"line_number":44,"context_line":"                       constants.INGRESS_CLASSIFICATION_DISPATCH_TABLE,"},{"line_number":45,"context_line":"                       constants.PRIORITY_DEFAULT,"},{"line_number":46,"context_line":"                       constants.INGRESS_NAT_TABLE,"},{"line_number":47,"context_line":"                       match\u003dmock.ANY),"},{"line_number":48,"context_line":"             mock.call(self.datapath,"},{"line_number":49,"context_line":"                       constants.L3_LOOKUP_TABLE,"},{"line_number":50,"context_line":"                       constants.PRIORITY_MEDIUM,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8ec9b2_51502d32","line":47,"range":{"start_line":47,"start_character":29,"end_line":47,"end_character":37},"in_reply_to":"7a8ec9b2_9100f567","updated":"2016-09-18 02:06:33.000000000","message":"The match should be checked in a smaller size of UT. At this point, the math is actually a mocked object, which is not able to check its content.\n\nI added this UT here is to test the bug [1]. The target is to make sure the logic of add_local_port in dnat don\u0027t raise any exception. And it is actually executed(the assert here make sure that).\n\nI will add further test to verify match(and even \u0027inst\u0027), if other regression issue needs so. But for the case in [1], I think it is good enough. Plus, as mentioned, I can\u0027t verify match in such size of UT.\n\nwhat do you think?\n\n[1]https://bugs.launchpad.net/dragonflow/+bug/1622176","commit_id":"70f3f7790ea0cfa7c6ba7dd6fcf1efc0f8161114"}]}