)]}'
{"dragonflow/db/api_nb.py":[{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"06af448288ff55c38e67726fb247f9e30810e2ca","unresolved":false,"context_lines":[{"line_number":948,"context_line":"        return self.lrouter[\u0027version\u0027]"},{"line_number":949,"context_line":""},{"line_number":950,"context_line":"    def is_distributed(self):"},{"line_number":951,"context_line":"        return self.lrouter.get(\u0027distributed\u0027, True)"},{"line_number":952,"context_line":""},{"line_number":953,"context_line":"    def get_routes(self):"},{"line_number":954,"context_line":"        return self.lrouter.get(\u0027routes\u0027, [])"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a8bc5a2_862d4caa","line":951,"range":{"start_line":951,"start_character":0,"end_line":951,"end_character":52},"updated":"2016-09-26 12:59:49.000000000","message":"Should the distributed be default False? I see code in other places set default to False.\n\nhttps://github.com/openstack/dragonflow/blob/32a4a079edec6d8f5ec8969c86ff03cbf5d57ae1/dragonflow/neutron/agent/l3/df_router.py#L60\n\nhttps://github.com/openstack/dragonflow/blob/32a4a079edec6d8f5ec8969c86ff03cbf5d57ae1/dragonflow/neutron/services/l3_router_plugin.py#L110\n\nhttps://github.com/openstack/dragonflow/blob/32a4a079edec6d8f5ec8969c86ff03cbf5d57ae1/dragonflow/neutron/services/l3_router_plugin.py#L129","commit_id":"a87d1ac9a519a3f3c195d60ac842c4f55f6d15f1"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"06af448288ff55c38e67726fb247f9e30810e2ca","unresolved":false,"context_lines":[{"line_number":950,"context_line":"    def is_distributed(self):"},{"line_number":951,"context_line":"        return self.lrouter.get(\u0027distributed\u0027, True)"},{"line_number":952,"context_line":""},{"line_number":953,"context_line":"    def get_routes(self):"},{"line_number":954,"context_line":"        return self.lrouter.get(\u0027routes\u0027, [])"},{"line_number":955,"context_line":""},{"line_number":956,"context_line":"    def get_external_gateway(self):"},{"line_number":957,"context_line":"        return self.lrouter.get(\u0027gateway\u0027, {})"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a8bc5a2_ba889c72","line":954,"range":{"start_line":953,"start_character":0,"end_line":954,"end_character":45},"updated":"2016-09-26 12:59:49.000000000","message":"This might be unfair to patch[1], as that patch enables routes in router and also add this getter. Any of your patches merged first will case unnecessary conflict.\n\n[1] https://review.openstack.org/#/c/323057/30/dragonflow/db/api_nb.py@950","commit_id":"a87d1ac9a519a3f3c195d60ac842c4f55f6d15f1"}]}