)]}'
{"doc/source/specs/port_qos.rst":[{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"9ae0c98ff5333d43dfa5d5b63dedf0e07d604c1e","unresolved":false,"context_lines":[{"line_number":26,"context_line":"qos object has some attributes listed in the followed table:"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"+--------------------+---------------------------------------------+"},{"line_number":29,"context_line":"|   attribute name   |               description                   |"},{"line_number":30,"context_line":"|                    |                                             |"},{"line_number":31,"context_line":"+--------------------+---------------------------------------------+"},{"line_number":32,"context_line":"|   id               |   identify                                  |"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a98d1f4_256df432","line":29,"range":{"start_line":29,"start_character":4,"end_line":29,"end_character":48},"updated":"2016-09-28 13:25:54.000000000","message":"Since these are table headings, you ought to capitalize them","commit_id":"45a8256193668e8cdbaed77d3351a91ca793dca7"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"404e80230a9456a2410d05a746fe15bdcbb240f6","unresolved":false,"context_lines":[{"line_number":26,"context_line":"qos object has some attributes listed in the followed table:"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"+--------------------+---------------------------------------------+"},{"line_number":29,"context_line":"|   attribute name   |               description                   |"},{"line_number":30,"context_line":"|                    |                                             |"},{"line_number":31,"context_line":"+--------------------+---------------------------------------------+"},{"line_number":32,"context_line":"|   id               |   identify                                  |"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a98d1f4_d167ae23","line":29,"range":{"start_line":29,"start_character":4,"end_line":29,"end_character":48},"in_reply_to":"3a98d1f4_256df432","updated":"2016-09-28 14:22:40.000000000","message":"Done","commit_id":"45a8256193668e8cdbaed77d3351a91ca793dca7"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"9ae0c98ff5333d43dfa5d5b63dedf0e07d604c1e","unresolved":false,"context_lines":[{"line_number":28,"context_line":"+--------------------+---------------------------------------------+"},{"line_number":29,"context_line":"|   attribute name   |               description                   |"},{"line_number":30,"context_line":"|                    |                                             |"},{"line_number":31,"context_line":"+--------------------+---------------------------------------------+"},{"line_number":32,"context_line":"|   id               |   identify                                  |"},{"line_number":33,"context_line":"|                    |                                             |"},{"line_number":34,"context_line":"+--------------------+---------------------------------------------+"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a98d1f4_a51104b2","line":31,"range":{"start_line":31,"start_character":0,"end_line":31,"end_character":68},"updated":"2016-09-28 13:25:54.000000000","message":"I\u0027d suggest a row of \u003d\u003d\u003d\u003d here to render the heading row properly.","commit_id":"45a8256193668e8cdbaed77d3351a91ca793dca7"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"404e80230a9456a2410d05a746fe15bdcbb240f6","unresolved":false,"context_lines":[{"line_number":28,"context_line":"+--------------------+---------------------------------------------+"},{"line_number":29,"context_line":"|   attribute name   |               description                   |"},{"line_number":30,"context_line":"|                    |                                             |"},{"line_number":31,"context_line":"+--------------------+---------------------------------------------+"},{"line_number":32,"context_line":"|   id               |   identify                                  |"},{"line_number":33,"context_line":"|                    |                                             |"},{"line_number":34,"context_line":"+--------------------+---------------------------------------------+"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a98d1f4_1172f6e5","line":31,"range":{"start_line":31,"start_character":0,"end_line":31,"end_character":68},"in_reply_to":"3a98d1f4_a51104b2","updated":"2016-09-28 14:22:40.000000000","message":"Done","commit_id":"45a8256193668e8cdbaed77d3351a91ca793dca7"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"9ae0c98ff5333d43dfa5d5b63dedf0e07d604c1e","unresolved":false,"context_lines":[{"line_number":30,"context_line":"|                    |                                             |"},{"line_number":31,"context_line":"+--------------------+---------------------------------------------+"},{"line_number":32,"context_line":"|   id               |   identify                                  |"},{"line_number":33,"context_line":"|                    |                                             |"},{"line_number":34,"context_line":"+--------------------+---------------------------------------------+"},{"line_number":35,"context_line":"|   type             |   type of QoS                               |"},{"line_number":36,"context_line":"|                    |                                             |"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a98d1f4_859088ee","line":33,"range":{"start_line":33,"start_character":0,"end_line":33,"end_character":68},"updated":"2016-09-28 13:25:54.000000000","message":"You probably don\u0027t need the blank lines. I think this makes it render as underlines rather than as a fully boxed table.","commit_id":"45a8256193668e8cdbaed77d3351a91ca793dca7"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"404e80230a9456a2410d05a746fe15bdcbb240f6","unresolved":false,"context_lines":[{"line_number":30,"context_line":"|                    |                                             |"},{"line_number":31,"context_line":"+--------------------+---------------------------------------------+"},{"line_number":32,"context_line":"|   id               |   identify                                  |"},{"line_number":33,"context_line":"|                    |                                             |"},{"line_number":34,"context_line":"+--------------------+---------------------------------------------+"},{"line_number":35,"context_line":"|   type             |   type of QoS                               |"},{"line_number":36,"context_line":"|                    |                                             |"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a98d1f4_f13aeae6","line":33,"range":{"start_line":33,"start_character":0,"end_line":33,"end_character":68},"in_reply_to":"3a98d1f4_859088ee","updated":"2016-09-28 14:22:40.000000000","message":"restview renders correctly, but I\u0027ll remove them if it renders correctly without them. There\u0027s no reason to keep blank lines that don\u0027t contribute.","commit_id":"45a8256193668e8cdbaed77d3351a91ca793dca7"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"9ae0c98ff5333d43dfa5d5b63dedf0e07d604c1e","unresolved":false,"context_lines":[{"line_number":69,"context_line":""},{"line_number":70,"context_line":"The egress and ingress directions are from the VM point of view."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"The type of qos includes \"all\" and \"dscp\". Besides the basic attributes"},{"line_number":73,"context_line":"id, type, etc, the qos may have all of the attributes in the qos_policy"},{"line_number":74,"context_line":"when the type of qos is \"all\" and only have the dscp attribute in the"},{"line_number":75,"context_line":"qos_policy when the type of qos is \"dscp\"."}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a98d1f4_05871810","line":72,"range":{"start_line":72,"start_character":12,"end_line":72,"end_character":15},"updated":"2016-09-28 13:25:54.000000000","message":"As long as you\u0027re touching this file for a cosmetic update, I\u0027d suggest changing qos to QoS both because that\u0027s the traditional capitalization and also for consistency since this document uses both QoS and qos with no clear reason for when each is used.","commit_id":"45a8256193668e8cdbaed77d3351a91ca793dca7"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"404e80230a9456a2410d05a746fe15bdcbb240f6","unresolved":false,"context_lines":[{"line_number":69,"context_line":""},{"line_number":70,"context_line":"The egress and ingress directions are from the VM point of view."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"The type of qos includes \"all\" and \"dscp\". Besides the basic attributes"},{"line_number":73,"context_line":"id, type, etc, the qos may have all of the attributes in the qos_policy"},{"line_number":74,"context_line":"when the type of qos is \"all\" and only have the dscp attribute in the"},{"line_number":75,"context_line":"qos_policy when the type of qos is \"dscp\"."}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a98d1f4_712fbaa1","line":72,"range":{"start_line":72,"start_character":12,"end_line":72,"end_character":15},"in_reply_to":"3a98d1f4_05871810","updated":"2016-09-28 14:22:40.000000000","message":"Done","commit_id":"45a8256193668e8cdbaed77d3351a91ca793dca7"},{"author":{"_account_id":20297,"name":"duankebo","email":"duankebo@huawei.com","username":"duankebo"},"change_message_id":"bfec76c51e7f66ef69c7441e5a3a8bd49d92c170","unresolved":false,"context_lines":[{"line_number":55,"context_line":"|   dscp             |   Differentiated Services Code Point        |"},{"line_number":56,"context_line":"+--------------------+---------------------------------------------+"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"The egress and ingress directions are from the VM point of view."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"The type of QoS includes \"all\" and \"dscp\". Besides the basic attributes"},{"line_number":61,"context_line":"id, type, etc, the QoS may have all of the attributes in the qos_policy"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a98d1f4_dd9fa05d","line":58,"range":{"start_line":58,"start_character":47,"end_line":58,"end_character":49},"updated":"2016-09-29 03:05:43.000000000","message":"VM\u0027s","commit_id":"2e76ca20b7ff0dc17e98875f583408c4eed572cd"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"7839c60457e885335627875f08e84e43e631ea03","unresolved":false,"context_lines":[{"line_number":55,"context_line":"|   dscp             |   Differentiated Services Code Point        |"},{"line_number":56,"context_line":"+--------------------+---------------------------------------------+"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"The egress and ingress directions are from the VM point of view."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"The type of QoS includes \"all\" and \"dscp\". Besides the basic attributes"},{"line_number":61,"context_line":"id, type, etc, the QoS may have all of the attributes in the qos_policy"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a98d1f4_75605ccf","line":58,"range":{"start_line":58,"start_character":47,"end_line":58,"end_character":49},"in_reply_to":"3a98d1f4_dd9fa05d","updated":"2016-09-29 07:04:44.000000000","message":"Done","commit_id":"2e76ca20b7ff0dc17e98875f583408c4eed572cd"},{"author":{"_account_id":20297,"name":"duankebo","email":"duankebo@huawei.com","username":"duankebo"},"change_message_id":"bfec76c51e7f66ef69c7441e5a3a8bd49d92c170","unresolved":false,"context_lines":[{"line_number":99,"context_line":"of the QoS to ingress_policing_bust and ingress_policing_rate of the"},{"line_number":100,"context_line":"corresponding interface on the OVS for limiting the bandwidth of egress traffic"},{"line_number":101,"context_line":"of the port. In addition, the QoS app creates a queue attached to the port and"},{"line_number":102,"context_line":"sets the rx_averateLimit and dscp of QoS to other_config and dscp of the queue"},{"line_number":103,"context_line":"on the OVS for limiting the bandwidth of ingress traffic of the port."},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"Port Removed"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a98d1f4_bd23b404","line":102,"range":{"start_line":102,"start_character":44,"end_line":102,"end_character":56},"updated":"2016-09-29 03:05:43.000000000","message":"\"other_config\"?","commit_id":"2e76ca20b7ff0dc17e98875f583408c4eed572cd"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"7839c60457e885335627875f08e84e43e631ea03","unresolved":false,"context_lines":[{"line_number":99,"context_line":"of the QoS to ingress_policing_bust and ingress_policing_rate of the"},{"line_number":100,"context_line":"corresponding interface on the OVS for limiting the bandwidth of egress traffic"},{"line_number":101,"context_line":"of the port. In addition, the QoS app creates a queue attached to the port and"},{"line_number":102,"context_line":"sets the rx_averateLimit and dscp of QoS to other_config and dscp of the queue"},{"line_number":103,"context_line":"on the OVS for limiting the bandwidth of ingress traffic of the port."},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"Port Removed"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a98d1f4_f5aaacd3","line":102,"range":{"start_line":102,"start_character":44,"end_line":102,"end_character":56},"in_reply_to":"3a98d1f4_bd23b404","updated":"2016-09-29 07:04:44.000000000","message":"Field names are not quoted in the rest of this document. In theory they should be marked in italics, but going over the text and finding all field names and modifying them is beyond the scope of this patch.","commit_id":"2e76ca20b7ff0dc17e98875f583408c4eed572cd"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"971f4a26859cba6a639e013c7bec3cf619fdfc67","unresolved":false,"context_lines":[{"line_number":124,"context_line":"for the port, the configuration is similar with the description in"},{"line_number":125,"context_line":"\"Port Created\" section above."},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"For scenario 2, the Qos app will update the configuration according to the new"},{"line_number":128,"context_line":"QoS object."},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"For scenario 3, the Qos app will delete the configuration for the port."}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a98d1f4_5a8f1923","line":127,"range":{"start_line":127,"start_character":20,"end_line":127,"end_character":23},"updated":"2016-09-29 00:34:30.000000000","message":"If this is going to be a cosmetic update, I think it would be better to unify the term of QoS here.","commit_id":"2e76ca20b7ff0dc17e98875f583408c4eed572cd"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"7839c60457e885335627875f08e84e43e631ea03","unresolved":false,"context_lines":[{"line_number":124,"context_line":"for the port, the configuration is similar with the description in"},{"line_number":125,"context_line":"\"Port Created\" section above."},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"For scenario 2, the Qos app will update the configuration according to the new"},{"line_number":128,"context_line":"QoS object."},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"For scenario 3, the Qos app will delete the configuration for the port."}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a98d1f4_f5738caf","line":127,"range":{"start_line":127,"start_character":20,"end_line":127,"end_character":23},"in_reply_to":"3a98d1f4_5a8f1923","updated":"2016-09-29 07:04:44.000000000","message":"I missed this one. Will do.","commit_id":"2e76ca20b7ff0dc17e98875f583408c4eed572cd"}]}