)]}'
{"dragonflow/db/drivers/ovsdb_vswitch_impl.py":[{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"452741fda87d203548a349c497a6567a66862cb1","unresolved":false,"context_lines":[{"line_number":174,"context_line":"        self.vsctl_timeout \u003d timeout"},{"line_number":175,"context_line":"        self.ovsdb \u003d None"},{"line_number":176,"context_line":"        self.integration_bridge \u003d cfg.CONF.df.integration_bridge"},{"line_number":177,"context_line":"        vlog.Vlog.init()"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"    def initialize(self, nb_api):"},{"line_number":180,"context_line":"        db_connection \u003d (\u0027%s:%s:%s\u0027 % (self.protocol, self.ip, self.port))"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a95cdbc_6e797b93","line":177,"updated":"2016-10-05 07:57:03.000000000","message":"I\u0027m not sure about this. This is correct in devstack environment, but will it behave correctly in a deployment?","commit_id":"47630724c0dfa70be97ee98afe140741e4efce23"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"cd4048fd0bf5defe09f5feef3410cee23e5cb90d","unresolved":false,"context_lines":[{"line_number":174,"context_line":"        self.vsctl_timeout \u003d timeout"},{"line_number":175,"context_line":"        self.ovsdb \u003d None"},{"line_number":176,"context_line":"        self.integration_bridge \u003d cfg.CONF.df.integration_bridge"},{"line_number":177,"context_line":"        vlog.Vlog.init()"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"    def initialize(self, nb_api):"},{"line_number":180,"context_line":"        db_connection \u003d (\u0027%s:%s:%s\u0027 % (self.protocol, self.ip, self.port))"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a95cdbc_8a28c19b","line":177,"in_reply_to":"1a95cdbc_02af472a","updated":"2016-10-10 07:44:53.000000000","message":"@XiaoHongHui, the log can be put in /var/log/df-ovs.log (as @MaLi suggested). This will both solve the bug (won\u0027t generate unignored files in the wrong place) and keep the ovs logs easily reachable. The /var/log location is suggested due to [1].\n\n[1] http://docs.openstack.org/ops-guide/ops-logging.html","commit_id":"47630724c0dfa70be97ee98afe140741e4efce23"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"a1005806523fcbc43f9c95278f2eab63c70184b6","unresolved":false,"context_lines":[{"line_number":174,"context_line":"        self.vsctl_timeout \u003d timeout"},{"line_number":175,"context_line":"        self.ovsdb \u003d None"},{"line_number":176,"context_line":"        self.integration_bridge \u003d cfg.CONF.df.integration_bridge"},{"line_number":177,"context_line":"        vlog.Vlog.init()"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"    def initialize(self, nb_api):"},{"line_number":180,"context_line":"        db_connection \u003d (\u0027%s:%s:%s\u0027 % (self.protocol, self.ip, self.port))"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a95cdbc_6f4d5499","line":177,"in_reply_to":"1a95cdbc_6e797b93","updated":"2016-10-09 02:35:33.000000000","message":"vlog.Vlog.init() will output the ovs log to current console, syslog, according to [1]. And if the file name is given. The same log will output to the file. So yes, I think it will behave correctly in deployment, because in a deployment the console log of dragonflow will most likely be output to a file, and we will not lose the log of ovs. \n\n[1] https://github.com/openvswitch/ovs/blob/960e99dcdd1423041b14c9b42c9d8a666d682502/python/ovs/vlog.py#L232-L238","commit_id":"47630724c0dfa70be97ee98afe140741e4efce23"},{"author":{"_account_id":7805,"name":"Li Ma","email":"skywalker.nick@gmail.com","username":"Nick"},"change_message_id":"4dedf9302af5051f01dcc91fb5608b5dc3a4b8bf","unresolved":false,"context_lines":[{"line_number":174,"context_line":"        self.vsctl_timeout \u003d timeout"},{"line_number":175,"context_line":"        self.ovsdb \u003d None"},{"line_number":176,"context_line":"        self.integration_bridge \u003d cfg.CONF.df.integration_bridge"},{"line_number":177,"context_line":"        vlog.Vlog.init()"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"    def initialize(self, nb_api):"},{"line_number":180,"context_line":"        db_connection \u003d (\u0027%s:%s:%s\u0027 % (self.protocol, self.ip, self.port))"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a95cdbc_02af472a","line":177,"in_reply_to":"1a95cdbc_6f4d5499","updated":"2016-10-09 04:01:28.000000000","message":"I suggest we record ovs-related log into a separated log file, like \u0027df-ovs.log\u0027.","commit_id":"47630724c0dfa70be97ee98afe140741e4efce23"},{"author":{"_account_id":18903,"name":"Yuli","email":"stremovsky@gmail.com","username":"yuli"},"change_message_id":"e2d29d1844da6906b7a47bf9cdc8001ba8ee89e5","unresolved":false,"context_lines":[{"line_number":174,"context_line":"        self.vsctl_timeout \u003d timeout"},{"line_number":175,"context_line":"        self.ovsdb \u003d None"},{"line_number":176,"context_line":"        self.integration_bridge \u003d cfg.CONF.df.integration_bridge"},{"line_number":177,"context_line":"        vlog.Vlog.init()"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"    def initialize(self, nb_api):"},{"line_number":180,"context_line":"        db_connection \u003d (\u0027%s:%s:%s\u0027 % (self.protocol, self.ip, self.port))"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a95cdbc_1e15d2e3","line":177,"in_reply_to":"1a95cdbc_8a28c19b","updated":"2016-10-10 07:59:10.000000000","message":"May be we should add this to configuration file ?","commit_id":"47630724c0dfa70be97ee98afe140741e4efce23"}]}