)]}'
{"dragonflow/controller/dhcp_app.py":[{"author":{"_account_id":20287,"name":"hujie","email":"mike.hu@huawei.com","username":"hujie"},"change_message_id":"09a01863663699815c25b9128de4bf035cf937b7","unresolved":false,"context_lines":[{"line_number":403,"context_line":"        if self.get_datapath() is None:"},{"line_number":404,"context_line":"            return"},{"line_number":405,"context_line":""},{"line_number":406,"context_line":"        if netaddr.valid_ipv4(lport.get_ip()) is False:"},{"line_number":407,"context_line":"            LOG.info(_LE(\"No support for non IpV4 protocol\"))"},{"line_number":408,"context_line":"            return"},{"line_number":409,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1a95cdbc_1371c5e0","line":406,"range":{"start_line":406,"start_character":11,"end_line":406,"end_character":55},"updated":"2016-10-06 09:25:42.000000000","message":"suggest use if not netaddr.valid_ipv4(lport.get_ip())","commit_id":"28102fe12e16d6d15f83d4b01611cfd53781fe9c"},{"author":{"_account_id":23235,"name":"Lihi Wishnitzer","email":"lihiwish@gmail.com","username":"lihiwish"},"change_message_id":"1ce7905aa4b96a4cc8b894aaa96103dc9761e5b3","unresolved":false,"context_lines":[{"line_number":403,"context_line":"        if self.get_datapath() is None:"},{"line_number":404,"context_line":"            return"},{"line_number":405,"context_line":""},{"line_number":406,"context_line":"        if netaddr.valid_ipv4(lport.get_ip()) is False:"},{"line_number":407,"context_line":"            LOG.info(_LE(\"No support for non IpV4 protocol\"))"},{"line_number":408,"context_line":"            return"},{"line_number":409,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1a95cdbc_26867cb9","line":406,"range":{"start_line":406,"start_character":11,"end_line":406,"end_character":55},"in_reply_to":"1a95cdbc_1371c5e0","updated":"2016-10-06 11:19:53.000000000","message":"Done","commit_id":"28102fe12e16d6d15f83d4b01611cfd53781fe9c"},{"author":{"_account_id":20287,"name":"hujie","email":"mike.hu@huawei.com","username":"hujie"},"change_message_id":"09a01863663699815c25b9128de4bf035cf937b7","unresolved":false,"context_lines":[{"line_number":404,"context_line":"            return"},{"line_number":405,"context_line":""},{"line_number":406,"context_line":"        if netaddr.valid_ipv4(lport.get_ip()) is False:"},{"line_number":407,"context_line":"            LOG.info(_LE(\"No support for non IpV4 protocol\"))"},{"line_number":408,"context_line":"            return"},{"line_number":409,"context_line":""},{"line_number":410,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1a95cdbc_73820996","line":407,"range":{"start_line":407,"start_character":16,"end_line":407,"end_character":25},"updated":"2016-10-06 09:25:42.000000000","message":"use error instead of info","commit_id":"28102fe12e16d6d15f83d4b01611cfd53781fe9c"},{"author":{"_account_id":23235,"name":"Lihi Wishnitzer","email":"lihiwish@gmail.com","username":"lihiwish"},"change_message_id":"1ce7905aa4b96a4cc8b894aaa96103dc9761e5b3","unresolved":false,"context_lines":[{"line_number":404,"context_line":"            return"},{"line_number":405,"context_line":""},{"line_number":406,"context_line":"        if netaddr.valid_ipv4(lport.get_ip()) is False:"},{"line_number":407,"context_line":"            LOG.info(_LE(\"No support for non IpV4 protocol\"))"},{"line_number":408,"context_line":"            return"},{"line_number":409,"context_line":""},{"line_number":410,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1a95cdbc_469548dc","line":407,"range":{"start_line":407,"start_character":16,"end_line":407,"end_character":25},"in_reply_to":"1a95cdbc_73820996","updated":"2016-10-06 11:19:53.000000000","message":"Done","commit_id":"28102fe12e16d6d15f83d4b01611cfd53781fe9c"},{"author":{"_account_id":11343,"name":"Gal Sagie","email":"gal.sagie@gmail.com","username":"GalSagie"},"change_message_id":"73c0e61ed4033209ff21dbe06d06cac28898e135","unresolved":false,"context_lines":[{"line_number":403,"context_line":"        if self.get_datapath() is None:"},{"line_number":404,"context_line":"            return"},{"line_number":405,"context_line":""},{"line_number":406,"context_line":"        if not netaddr.valid_ipv4(lport.get_ip()):"},{"line_number":407,"context_line":"            LOG.error(_LE(\"No support for non IpV4 protocol\"))"},{"line_number":408,"context_line":"            return"},{"line_number":409,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1a95cdbc_f2ccee8a","line":406,"updated":"2016-10-08 14:36:14.000000000","message":"Should also be checked in the remove","commit_id":"1ace31de3d043aea175780a34c6d2050a8bd2d12"},{"author":{"_account_id":23235,"name":"Lihi Wishnitzer","email":"lihiwish@gmail.com","username":"lihiwish"},"change_message_id":"b61356f9a9c75aee1008b9632afe86f21542e929","unresolved":false,"context_lines":[{"line_number":403,"context_line":"        if self.get_datapath() is None:"},{"line_number":404,"context_line":"            return"},{"line_number":405,"context_line":""},{"line_number":406,"context_line":"        if not netaddr.valid_ipv4(lport.get_ip()):"},{"line_number":407,"context_line":"            LOG.error(_LE(\"No support for non IpV4 protocol\"))"},{"line_number":408,"context_line":"            return"},{"line_number":409,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1a95cdbc_34ec6f29","line":406,"in_reply_to":"1a95cdbc_f2ccee8a","updated":"2016-10-10 08:42:43.000000000","message":"Done","commit_id":"1ace31de3d043aea175780a34c6d2050a8bd2d12"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"cfbf5619fa92ca3bd32707d64ff9c774d185da57","unresolved":false,"context_lines":[{"line_number":374,"context_line":""},{"line_number":375,"context_line":"    def remove_local_port(self, lport):"},{"line_number":376,"context_line":"        if not netaddr.valid_ipv4(lport.get_ip()):"},{"line_number":377,"context_line":"            LOG.error(_LE(\"No support for non IPv4 protocol\"))"},{"line_number":378,"context_line":"            return"},{"line_number":379,"context_line":""},{"line_number":380,"context_line":"        tunnel_key \u003d lport.get_tunnel_key()"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa6399be_fde32631","line":377,"updated":"2016-10-13 08:35:09.000000000","message":"nit: Should be warning","commit_id":"53d22d75489e03369a6c84a962e25122dde08b64"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"cfbf5619fa92ca3bd32707d64ff9c774d185da57","unresolved":false,"context_lines":[{"line_number":407,"context_line":"            return"},{"line_number":408,"context_line":""},{"line_number":409,"context_line":"        if not netaddr.valid_ipv4(lport.get_ip()):"},{"line_number":410,"context_line":"            LOG.error(_LE(\"No support for non IPv4 protocol\"))"},{"line_number":411,"context_line":"            return"},{"line_number":412,"context_line":""},{"line_number":413,"context_line":"        lport_id \u003d lport.get_id()"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa6399be_7dce36b5","line":410,"updated":"2016-10-13 08:35:09.000000000","message":"nit: Should be warning","commit_id":"53d22d75489e03369a6c84a962e25122dde08b64"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"70f7cb08cf44264e1e604b7480a46ef12e8ef46b","unresolved":false,"context_lines":[{"line_number":100,"context_line":"        if is_pkt_ipv4:"},{"line_number":101,"context_line":"            pkt_ip \u003d pkt.get_protocol(ipv4.ipv4)"},{"line_number":102,"context_line":"        else:"},{"line_number":103,"context_line":"            LOG.warning(_LE(\"No support for non IPv4 protocol\"))"},{"line_number":104,"context_line":"            return"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"        if pkt_ip is None:"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa6399be_d80c943d","line":103,"range":{"start_line":103,"start_character":16,"end_line":103,"end_character":23},"updated":"2016-10-13 17:10:18.000000000","message":"Please keep this error, since you are already respinning.","commit_id":"b3ee6a2f2cad7bfd31b30f420ebbb8c6ed89b0b2"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"70f7cb08cf44264e1e604b7480a46ef12e8ef46b","unresolved":false,"context_lines":[{"line_number":374,"context_line":""},{"line_number":375,"context_line":"    def remove_local_port(self, lport):"},{"line_number":376,"context_line":"        if not netaddr.valid_ipv4(lport.get_ip()):"},{"line_number":377,"context_line":"            LOG.warning(_LE(\"No support for non IPv4 protocol\"))"},{"line_number":378,"context_line":"            return"},{"line_number":379,"context_line":""},{"line_number":380,"context_line":"        tunnel_key \u003d lport.get_tunnel_key()"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa6399be_35059913","line":377,"updated":"2016-10-13 17:10:18.000000000","message":"When called with warning, translation function should be _LW.","commit_id":"b3ee6a2f2cad7bfd31b30f420ebbb8c6ed89b0b2"}]}