)]}'
{"dragonflow/db/api_nb.py":[{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"0db12ece4a4a7397ebc0daac4f4dd3e8bf8c4d91","unresolved":false,"context_lines":[{"line_number":150,"context_line":"        topics \u003d self.driver.get_all_entries(\u0027portstats\u0027)"},{"line_number":151,"context_line":"        if topics:"},{"line_number":152,"context_line":"            return random.choice(topics)"},{"line_number":153,"context_line":"        else:"},{"line_number":154,"context_line":"            return db_common.SEND_ALL_TOPIC"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"    def create_port_status(self, server_ip):"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba5da102_216df432","line":153,"updated":"2016-10-26 08:35:28.000000000","message":"If this happens, that means that all neutron servers are down. This is Bad(TM). I think we need at least a warning.","commit_id":"4ff525f263b2dcc7ee4cbe1c190b2334d70d3aa4"},{"author":{"_account_id":20287,"name":"hujie","email":"mike.hu@huawei.com","username":"hujie"},"change_message_id":"16ea4fa0c809038992337a2223005bb2dd04fdf2","unresolved":false,"context_lines":[{"line_number":151,"context_line":"        if topics:"},{"line_number":152,"context_line":"            return random.choice(topics)"},{"line_number":153,"context_line":"        else:"},{"line_number":154,"context_line":"            return db_common.SEND_ALL_TOPIC"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"    def create_port_status(self, server_ip):"},{"line_number":157,"context_line":"        self.driver.create_key(\u0027portstats\u0027, server_ip,"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba5da102_07ff0b02","line":154,"range":{"start_line":154,"start_character":19,"end_line":154,"end_character":43},"updated":"2016-10-27 04:52:47.000000000","message":"Currently, there are no mechanism to delete the entry when neutron server is down, especially here it invoke get_all_entries(), it may get the invalid neutron server ip, if the topics is None, I think the situation could be the connection is break between df and db, so it got nothing, but I do not think it is suitable to return SEND_ALL_TOPIC topic here, otherwise other df will receive the useless event.","commit_id":"4ff525f263b2dcc7ee4cbe1c190b2334d70d3aa4"}]}
