)]}'
{"dragonflow/tests/unit/test_object_refresher.py":[{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"3e2e8aafb8e20af5eb37f88d2cb7b9d275f216f1","unresolved":false,"context_lines":[{"line_number":68,"context_line":"                             self.test_objs,"},{"line_number":69,"context_line":"                             \u0027Deleted object is still in the cache\u0027)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    def test_restart_df_controller(self):"},{"line_number":72,"context_line":"        fake_delete_method \u003d mock.Mock()"},{"line_number":73,"context_line":"        refresher \u003d df_db_objects_refresh.DfObjectRefresher("},{"line_number":74,"context_line":"            \u0027Mock\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5da102_4cb2384d","line":71,"updated":"2016-11-03 16:15:22.000000000","message":"Could you please explain what you are testing here?","commit_id":"5776127d5af0f7d81227bf2dfea34c32653949d0"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"e105e922de148b674ca3451ed5a169f4dbbb61b5","unresolved":false,"context_lines":[{"line_number":68,"context_line":"                             self.test_objs,"},{"line_number":69,"context_line":"                             \u0027Deleted object is still in the cache\u0027)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    def test_restart_df_controller(self):"},{"line_number":72,"context_line":"        fake_delete_method \u003d mock.Mock()"},{"line_number":73,"context_line":"        refresher \u003d df_db_objects_refresh.DfObjectRefresher("},{"line_number":74,"context_line":"            \u0027Mock\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5da102_59190621","line":71,"in_reply_to":"ba5da102_4cb2384d","updated":"2016-11-04 01:48:26.000000000","message":"This test will cover code execution of DfObjectRefresher when restart df controller. Currently, the code execution will report exception. With this UT, we can make sure the exception is not thrown. I will add some comments here.","commit_id":"5776127d5af0f7d81227bf2dfea34c32653949d0"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"3e2e8aafb8e20af5eb37f88d2cb7b9d275f216f1","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        fake_delete_method \u003d mock.Mock()"},{"line_number":73,"context_line":"        refresher \u003d df_db_objects_refresh.DfObjectRefresher("},{"line_number":74,"context_line":"            \u0027Mock\u0027,"},{"line_number":75,"context_line":"            lambda: set(),"},{"line_number":76,"context_line":"            self._db_read_objects,"},{"line_number":77,"context_line":"            self._cache_update_object,"},{"line_number":78,"context_line":"            lambda: fake_delete_method)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5da102_ec2b0c80","line":75,"updated":"2016-11-03 16:15:22.000000000","message":"nit: lambda: set() -\u003e set","commit_id":"5776127d5af0f7d81227bf2dfea34c32653949d0"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"e105e922de148b674ca3451ed5a169f4dbbb61b5","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        fake_delete_method \u003d mock.Mock()"},{"line_number":73,"context_line":"        refresher \u003d df_db_objects_refresh.DfObjectRefresher("},{"line_number":74,"context_line":"            \u0027Mock\u0027,"},{"line_number":75,"context_line":"            lambda: set(),"},{"line_number":76,"context_line":"            self._db_read_objects,"},{"line_number":77,"context_line":"            self._cache_update_object,"},{"line_number":78,"context_line":"            lambda: fake_delete_method)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5da102_99df1e0c","line":75,"in_reply_to":"ba5da102_ec2b0c80","updated":"2016-11-04 01:48:26.000000000","message":"Done","commit_id":"5776127d5af0f7d81227bf2dfea34c32653949d0"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"3e2e8aafb8e20af5eb37f88d2cb7b9d275f216f1","unresolved":false,"context_lines":[{"line_number":75,"context_line":"            lambda: set(),"},{"line_number":76,"context_line":"            self._db_read_objects,"},{"line_number":77,"context_line":"            self._cache_update_object,"},{"line_number":78,"context_line":"            lambda: fake_delete_method)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        refresher.read()"},{"line_number":81,"context_line":"        refresher.update()"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5da102_8c1c506b","line":78,"updated":"2016-11-03 16:15:22.000000000","message":"I think you don\u0027t need a lambda here. With the lambda, fake_delete_method is never called (only the lambda that returns it)","commit_id":"5776127d5af0f7d81227bf2dfea34c32653949d0"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"e105e922de148b674ca3451ed5a169f4dbbb61b5","unresolved":false,"context_lines":[{"line_number":75,"context_line":"            lambda: set(),"},{"line_number":76,"context_line":"            self._db_read_objects,"},{"line_number":77,"context_line":"            self._cache_update_object,"},{"line_number":78,"context_line":"            lambda: fake_delete_method)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        refresher.read()"},{"line_number":81,"context_line":"        refresher.update()"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5da102_b9e222d3","line":78,"in_reply_to":"ba5da102_8c1c506b","updated":"2016-11-04 01:48:26.000000000","message":"Done","commit_id":"5776127d5af0f7d81227bf2dfea34c32653949d0"}]}