)]}'
{"dragonflow/cmd/eventlet/df_metadata_service.py":[{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"6bbba8b07200dc2171f28c10cba240152e8cc997","unresolved":false,"context_lines":[{"line_number":10,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":11,"context_line":"#    under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"from oslo_config import cfg"},{"line_number":14,"context_line":"from oslo_log import log"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from neutron.agent.common import utils"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a629dbe_923a7bcc","line":13,"range":{"start_line":13,"start_character":24,"end_line":13,"end_character":27},"updated":"2016-11-07 16:38:10.000000000","message":"Maybe do without this import entirely? Use only dragonflow.conf?","commit_id":"032caa02c73a76088b81001d2544eac387a9da63"},{"author":{"_account_id":13912,"name":"rajiv","email":"thenakliman@gmail.com","username":"rajiv.kumar"},"change_message_id":"a8d051f08ad0cf00d617be9207ddcdc365a53110","unresolved":false,"context_lines":[{"line_number":10,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":11,"context_line":"#    under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"from oslo_config import cfg"},{"line_number":14,"context_line":"from oslo_log import log"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from neutron.agent.common import utils"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a629dbe_14663ced","line":13,"range":{"start_line":13,"start_character":24,"end_line":13,"end_character":27},"in_reply_to":"9a629dbe_923a7bcc","updated":"2016-11-08 09:20:20.000000000","message":"Omer,\nI have broken this blueprint in many patches, where each patch change configurations location related to one group only.\n\nI can not remove it now, because tt is still being used for fetching information from other groups. Once all the groups has been centralized, i will change it, as per your comment.","commit_id":"032caa02c73a76088b81001d2544eac387a9da63"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"6bbba8b07200dc2171f28c10cba240152e8cc997","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from dragonflow._i18n import _LI"},{"line_number":23,"context_line":"from dragonflow.common import common_params"},{"line_number":24,"context_line":"from dragonflow.conf import CONF"},{"line_number":25,"context_line":"from dragonflow.controller import metadata_service_app"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"import sys"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a629dbe_52570302","line":24,"updated":"2016-11-07 16:38:10.000000000","message":"Please import modules, and not objects within modules. Additionally, you can import dragonflow.conf as cfg, and then not need to change the rest of the code.","commit_id":"032caa02c73a76088b81001d2544eac387a9da63"},{"author":{"_account_id":13912,"name":"rajiv","email":"thenakliman@gmail.com","username":"rajiv.kumar"},"change_message_id":"a8d051f08ad0cf00d617be9207ddcdc365a53110","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from dragonflow._i18n import _LI"},{"line_number":23,"context_line":"from dragonflow.common import common_params"},{"line_number":24,"context_line":"from dragonflow.conf import CONF"},{"line_number":25,"context_line":"from dragonflow.controller import metadata_service_app"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"import sys"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a629dbe_749bf8c9","line":24,"in_reply_to":"9a629dbe_52570302","updated":"2016-11-08 09:20:20.000000000","message":"It will be addressed in last patch of this blueprint.","commit_id":"032caa02c73a76088b81001d2544eac387a9da63"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"f3715f858e9634ddefe124eab6fed6b46e97369c","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from dragonflow._i18n import _LI"},{"line_number":23,"context_line":"from dragonflow.common import common_params"},{"line_number":24,"context_line":"from dragonflow.conf import CONF"},{"line_number":25,"context_line":"from dragonflow.controller import metadata_service_app"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"import sys"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a629dbe_02d999f3","line":24,"range":{"start_line":24,"start_character":32,"end_line":24,"end_character":32},"updated":"2016-11-08 11:36:41.000000000","message":"I think import dragonflow.conf as cfg can work both for new config and old config, no need to go back here in another patch.\n\ndragonflow.conf.CONF is just the same as oslo_config.cfg.CONF, right?","commit_id":"2cd118225a3e984f705a3dd4b3709acafb73c339"},{"author":{"_account_id":13912,"name":"rajiv","email":"thenakliman@gmail.com","username":"rajiv.kumar"},"change_message_id":"813619e8af776b7ce7603a2850ed828d4247b63f","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from dragonflow._i18n import _LI"},{"line_number":23,"context_line":"from dragonflow.common import common_params"},{"line_number":24,"context_line":"from dragonflow.conf import CONF"},{"line_number":25,"context_line":"from dragonflow.controller import metadata_service_app"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"import sys"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a629dbe_429d4c58","line":24,"range":{"start_line":24,"start_character":32,"end_line":24,"end_character":32},"in_reply_to":"9a629dbe_02d999f3","updated":"2016-11-08 13:03:15.000000000","message":"+1. I missed that part :). Thanks for pointing out.","commit_id":"2cd118225a3e984f705a3dd4b3709acafb73c339"},{"author":{"_account_id":13912,"name":"rajiv","email":"thenakliman@gmail.com","username":"rajiv.kumar"},"change_message_id":"4b3fa4f11741c5d2ad34cb40624ebcd392c89c55","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from dragonflow._i18n import _LI"},{"line_number":23,"context_line":"from dragonflow.common import common_params"},{"line_number":24,"context_line":"from dragonflow.conf import CONF"},{"line_number":25,"context_line":"from dragonflow.controller import metadata_service_app"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"import sys"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a629dbe_4813ab0d","line":24,"range":{"start_line":24,"start_character":32,"end_line":24,"end_character":32},"in_reply_to":"9a629dbe_429d4c58","updated":"2016-11-08 13:41:51.000000000","message":"I tried to remove this line, but it failed. All the options are registered, when module is loaded first time loaded and if we directly import using oslo_config then module is not loaded. Therefore it fails.\n\nWhat do you think, we should do?","commit_id":"2cd118225a3e984f705a3dd4b3709acafb73c339"}],"dragonflow/conf/df_metadata_service.py":[{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"1774ac9ddb3e9004f529b150e5ee535780ee0102","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from oslo_config import cfg"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"df_metadata_opts \u003d ["},{"line_number":21,"context_line":"    cfg.IPOpt("},{"line_number":22,"context_line":"        \u0027ip\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a629dbe_a9913bf3","line":19,"updated":"2016-11-10 14:38:38.000000000","message":"Use from dragonflow._i18n import _ here","commit_id":"d55f6b2b9ef65e6ba1bf304bca284458ac93daa8"}],"dragonflow/conf/metadata_service_app.py":[{"author":{"_account_id":20287,"name":"hujie","email":"mike.hu@huawei.com","username":"hujie"},"change_message_id":"53b49f7eb163e5c43092468b2d227b3b455a12ca","unresolved":false,"context_lines":[{"line_number":12,"context_line":"#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from oslo_config import cfg"},{"line_number":18,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a629dbe_e70cb744","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":0},"updated":"2016-11-08 11:22:40.000000000","message":"pls consider rename this file to df_metadata_service or metadata_service_conf or something like that which seems more clear than xxx_app:)","commit_id":"2cd118225a3e984f705a3dd4b3709acafb73c339"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"f3715f858e9634ddefe124eab6fed6b46e97369c","unresolved":false,"context_lines":[{"line_number":12,"context_line":"#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from oslo_config import cfg"},{"line_number":18,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a629dbe_82f3e972","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":0},"in_reply_to":"9a629dbe_e70cb744","updated":"2016-11-08 11:36:41.000000000","message":"+1","commit_id":"2cd118225a3e984f705a3dd4b3709acafb73c339"}],"dragonflow/conf/opts.py":[{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"6bbba8b07200dc2171f28c10cba240152e8cc997","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"def list_opts():"},{"line_number":27,"context_line":"    metadata_service_app.register_opts()"},{"line_number":28,"context_line":"    return ["},{"line_number":29,"context_line":"        (\u0027df\u0027, common_params.DF_OPTS),"},{"line_number":30,"context_line":"        (\u0027df_ryu\u0027, df_local_controller.DF_RYU_OPTS),"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a629dbe_f25f370c","line":27,"updated":"2016-11-07 16:38:10.000000000","message":"Is this line needed, if it also appears in dragonflow.conf.__init__?","commit_id":"032caa02c73a76088b81001d2544eac387a9da63"},{"author":{"_account_id":13912,"name":"rajiv","email":"thenakliman@gmail.com","username":"rajiv.kumar"},"change_message_id":"a8d051f08ad0cf00d617be9207ddcdc365a53110","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"def list_opts():"},{"line_number":27,"context_line":"    metadata_service_app.register_opts()"},{"line_number":28,"context_line":"    return ["},{"line_number":29,"context_line":"        (\u0027df\u0027, common_params.DF_OPTS),"},{"line_number":30,"context_line":"        (\u0027df_ryu\u0027, df_local_controller.DF_RYU_OPTS),"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a629dbe_54b7d438","line":27,"in_reply_to":"9a629dbe_f25f370c","updated":"2016-11-08 09:20:20.000000000","message":"I will fix it in next patch.","commit_id":"032caa02c73a76088b81001d2544eac387a9da63"}],"dragonflow/controller/metadata_service_app.py":[{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"6bbba8b07200dc2171f28c10cba240152e8cc997","unresolved":false,"context_lines":[{"line_number":28,"context_line":"from dragonflow._i18n import _, _LW, _LE"},{"line_number":29,"context_line":"from dragonflow.common import exceptions"},{"line_number":30,"context_line":"from dragonflow.common import utils as df_utils"},{"line_number":31,"context_line":"from dragonflow.conf import CONF"},{"line_number":32,"context_line":"from dragonflow.controller.common import arp_responder"},{"line_number":33,"context_line":"from dragonflow.controller.common import constants as const"},{"line_number":34,"context_line":"from dragonflow.controller import df_base_app"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a629dbe_7281674a","line":31,"updated":"2016-11-07 16:38:10.000000000","message":"Same here re: importing objects","commit_id":"032caa02c73a76088b81001d2544eac387a9da63"},{"author":{"_account_id":13912,"name":"rajiv","email":"thenakliman@gmail.com","username":"rajiv.kumar"},"change_message_id":"a8d051f08ad0cf00d617be9207ddcdc365a53110","unresolved":false,"context_lines":[{"line_number":28,"context_line":"from dragonflow._i18n import _, _LW, _LE"},{"line_number":29,"context_line":"from dragonflow.common import exceptions"},{"line_number":30,"context_line":"from dragonflow.common import utils as df_utils"},{"line_number":31,"context_line":"from dragonflow.conf import CONF"},{"line_number":32,"context_line":"from dragonflow.controller.common import arp_responder"},{"line_number":33,"context_line":"from dragonflow.controller.common import constants as const"},{"line_number":34,"context_line":"from dragonflow.controller import df_base_app"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a629dbe_b47cb073","line":31,"in_reply_to":"9a629dbe_7281674a","updated":"2016-11-08 09:20:20.000000000","message":"Last patch.","commit_id":"032caa02c73a76088b81001d2544eac387a9da63"}],"dragonflow/tests/fullstack/test_metadata_service.py":[{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"ebbc95d132210fd12a04dd26af4eba2d4ebe0316","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def setUp(self):"},{"line_number":31,"context_line":"        super(TestMetadataService, self).setUp()"},{"line_number":32,"context_line":"        cfg.CONF.register_opts(df_metadata_service_conf.df_metadata_opts,"},{"line_number":33,"context_line":"                               group\u003d\u0027df_metadata\u0027)"},{"line_number":34,"context_line":"        # Override defaults to avoid collision with existing metadata service"},{"line_number":35,"context_line":"        cfg.CONF.df_metadata.ip \u003d \u00271.1.1.1\u0027"},{"line_number":36,"context_line":"        cfg.CONF.df.metadata_interface \u003d \u0027tap-md-test\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a629dbe_9e766bd5","line":33,"range":{"start_line":32,"start_character":0,"end_line":33,"end_character":51},"updated":"2016-11-10 14:30:14.000000000","message":"why not just call df_metadata_service_conf.register_opts?","commit_id":"d55f6b2b9ef65e6ba1bf304bca284458ac93daa8"}],"etc/oslo-config-generator/dragonflow.ini":[{"author":{"_account_id":7805,"name":"Li Ma","email":"skywalker.nick@gmail.com","username":"Nick"},"change_message_id":"897d82f30229e64175504a60cda7eeb9ae19b046","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[DEFAULT]"},{"line_number":2,"context_line":"output_file \u003d etc/dragonflow.ini.sample"},{"line_number":3,"context_line":"wrap_width \u003d 79"},{"line_number":4,"context_line":"namespace \u003d dragonflow/conf"}],"source_content_type":"text/x-properties","patch_set":7,"id":"7a77a97e_005eaa11","line":4,"range":{"start_line":4,"start_character":0,"end_line":4,"end_character":27},"updated":"2016-11-17 04:07:06.000000000","message":"https://github.com/openstack/dragonflow/blob/master/setup.cfg#L76-L77","commit_id":"a2f457f5f6cf0fc16ada932dab813d6eaf019721"},{"author":{"_account_id":13912,"name":"rajiv","email":"thenakliman@gmail.com","username":"rajiv.kumar"},"change_message_id":"6956d2067ea4206780f913056bedb4b5d59a65bd","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[DEFAULT]"},{"line_number":2,"context_line":"output_file \u003d etc/dragonflow.ini.sample"},{"line_number":3,"context_line":"wrap_width \u003d 79"},{"line_number":4,"context_line":"namespace \u003d dragonflow/conf"}],"source_content_type":"text/x-properties","patch_set":7,"id":"7a77a97e_e04c4eca","line":4,"range":{"start_line":4,"start_character":0,"end_line":4,"end_character":27},"in_reply_to":"7a77a97e_005eaa11","updated":"2016-11-17 04:33:10.000000000","message":"I think, namespace should be listed in setup.cfg \u0027entrypoint\u0027 section. therefore i think, setup.cfg should be changed as per your comment. I agree.\n\n\u003e\u003e please do not change namespace.\nDo you want to say, namespace should be \"dragonflow\".\nI checked nova\u0027s code, they have changed namespace therefore i did it. If there is some reason, i will revert it. Please let me know.","commit_id":"a2f457f5f6cf0fc16ada932dab813d6eaf019721"},{"author":{"_account_id":7805,"name":"Li Ma","email":"skywalker.nick@gmail.com","username":"Nick"},"change_message_id":"b7bda0a3218e7c33a1f58976ed0a13ee2c03cbc2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[DEFAULT]"},{"line_number":2,"context_line":"output_file \u003d etc/dragonflow.ini.sample"},{"line_number":3,"context_line":"wrap_width \u003d 79"},{"line_number":4,"context_line":"namespace \u003d dragonflow/conf"}],"source_content_type":"text/x-properties","patch_set":7,"id":"7a77a97e_dadf3767","line":4,"range":{"start_line":4,"start_character":0,"end_line":4,"end_character":27},"in_reply_to":"7a77a97e_e04c4eca","updated":"2016-11-17 10:08:54.000000000","message":"https://github.com/openstack/nova/blob/master/setup.cfg#L28-L29\nNova uses nova.conf not nova/conf. AFAIK, it is just naming.","commit_id":"a2f457f5f6cf0fc16ada932dab813d6eaf019721"}],"setup.cfg":[{"author":{"_account_id":7805,"name":"Li Ma","email":"skywalker.nick@gmail.com","username":"Nick"},"change_message_id":"7d59b6b4d8395c21ea8eae5b0cc90acc8127579b","unresolved":false,"context_lines":[{"line_number":74,"context_line":"neutron.service_plugins \u003d"},{"line_number":75,"context_line":"    df-l3 \u003d dragonflow.neutron.services.l3_router_plugin:DFL3RouterPlugin"},{"line_number":76,"context_line":"oslo.config.opts \u003d"},{"line_number":77,"context_line":"    dragonflow \u003d dragonflow.conf.opts:list_opts"}],"source_content_type":"text/x-ttcn-cfg","patch_set":10,"id":"7a77a97e_32db4b1d","line":77,"updated":"2016-11-22 08:35:47.000000000","message":"https://review.openstack.org/#/c/394282/10/etc/oslo-config-generator/dragonflow.ini\n\nShould the namespace be identical?\ndragonflow or dragonflow.conf?","commit_id":"8379258b019e056cf1d14424978a1dfeb6eb6230"},{"author":{"_account_id":13912,"name":"rajiv","email":"thenakliman@gmail.com","username":"rajiv.kumar"},"change_message_id":"876d888faf60b5d7790e84c33ece69916d6aa17f","unresolved":false,"context_lines":[{"line_number":74,"context_line":"neutron.service_plugins \u003d"},{"line_number":75,"context_line":"    df-l3 \u003d dragonflow.neutron.services.l3_router_plugin:DFL3RouterPlugin"},{"line_number":76,"context_line":"oslo.config.opts \u003d"},{"line_number":77,"context_line":"    dragonflow \u003d dragonflow.conf.opts:list_opts"}],"source_content_type":"text/x-ttcn-cfg","patch_set":10,"id":"7a77a97e_af20beb1","line":77,"in_reply_to":"7a77a97e_32db4b1d","updated":"2016-11-22 14:45:50.000000000","message":"HI Li Ma,\n\nAs per my understandinghttp://docs.openstack.org/developer/oslo.config/generator.html#defining-option-discovery-entry-points, it must be callable which returns list of (group, [opt1, opt2]). If i make following changes\n\ndragonflow.conf.opts:list_opts --\u003e dragonflow.opts:list_opts\n\nThen above statements will not be valid because after modification it will not be a callable. Path of opts file has been changed in the patch therefore it has been changed.\n\nIf my understanding is wrong, please let me know, i will change accordingly.\n\nIf you can provide more detail for example, what is the problem with current changes and how they will impact. it will help me to better understand your point.","commit_id":"8379258b019e056cf1d14424978a1dfeb6eb6230"}]}