)]}'
{"dragonflow/controller/df_local_controller.py":[{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"cddba6e8ed4df42b21b742354e7340b499c1ba1e","unresolved":false,"context_lines":[{"line_number":266,"context_line":"        )"},{"line_number":267,"context_line":"        lswitch \u003d self.db_store.get_lswitch(lport.get_lswitch_id())"},{"line_number":268,"context_line":"        if not lswitch:"},{"line_number":269,"context_line":"            LOG.debug((\"Could not find lswitch for lport: %s\"), lport.get_id())"},{"line_number":270,"context_line":"            return"},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"        network_type \u003d lswitch.get_network_type()"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a629dbe_851cce14","line":269,"range":{"start_line":269,"start_character":22,"end_line":269,"end_character":62},"updated":"2016-11-08 13:19:25.000000000","message":"extra parenthesis， see line 258, besides should we report a warning or even error here?","commit_id":"4a412b796351c5fd0602715dfff3a6b5bb05624f"},{"author":{"_account_id":20287,"name":"hujie","email":"mike.hu@huawei.com","username":"hujie"},"change_message_id":"5e3f7fa68b799cc3686a80f4ac94ea3fe9e61a33","unresolved":false,"context_lines":[{"line_number":266,"context_line":"        )"},{"line_number":267,"context_line":"        lswitch \u003d self.db_store.get_lswitch(lport.get_lswitch_id())"},{"line_number":268,"context_line":"        if not lswitch:"},{"line_number":269,"context_line":"            LOG.debug((\"Could not find lswitch for lport: %s\"), lport.get_id())"},{"line_number":270,"context_line":"            return"},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"        network_type \u003d lswitch.get_network_type()"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a629dbe_e171dee1","line":269,"range":{"start_line":269,"start_character":22,"end_line":269,"end_character":62},"in_reply_to":"9a629dbe_851cce14","updated":"2016-11-09 02:06:21.000000000","message":"yes, you are right, I think warning is enough.","commit_id":"4a412b796351c5fd0602715dfff3a6b5bb05624f"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"4177b67190a86755bf130f0317ddadff0825c909","unresolved":false,"context_lines":[{"line_number":265,"context_line":"            lport.get_lswitch_id(),"},{"line_number":266,"context_line":"        )"},{"line_number":267,"context_line":"        lswitch \u003d self.db_store.get_lswitch(lport.get_lswitch_id())"},{"line_number":268,"context_line":"        if not lswitch:"},{"line_number":269,"context_line":"            LOG.warning(_LW(\"Could not find lswitch for lport: %s\"),"},{"line_number":270,"context_line":"                        lport.get_id())"},{"line_number":271,"context_line":"            return"},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"        network_type \u003d lswitch.get_network_type()"},{"line_number":274,"context_line":"        segment_id \u003d lswitch.get_segment_id()"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a629dbe_153ebe8b","line":271,"range":{"start_line":268,"start_character":0,"end_line":271,"end_character":18},"updated":"2016-11-10 13:37:50.000000000","message":"Since you have a -1... then\n\n\nI wil say, the  shortcircuit code is always at the top of a method. So that once the code is returned here, no extra code will be executed.","commit_id":"707bf4a948c9f1a595547e2d0137c3c7ce706724"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"a09ae3e3c46eaea5acb960d5f58393f05b3ba58c","unresolved":false,"context_lines":[{"line_number":258,"context_line":"        if not lswitch:"},{"line_number":259,"context_line":"            LOG.warning(_LW(\"Could not find lswitch for lport: %s\"),"},{"line_number":260,"context_line":"                        lport.get_id())"},{"line_number":261,"context_line":"            return"},{"line_number":262,"context_line":"        lport.set_external_value(\u0027local_network_id\u0027,"},{"line_number":263,"context_line":"                                 lswitch.get_unique_key())"},{"line_number":264,"context_line":"        network_type \u003d lswitch.get_network_type()"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a74a57a_d659feff","line":261,"range":{"start_line":261,"start_character":0,"end_line":261,"end_character":18},"updated":"2016-11-24 21:14:24.000000000","message":"I have seen cases where the switch does not appear in db_store, but does appear in nb_api. (Maybe due to a race condition the port event arrived before the lswitch event).\nHave you seen such a behaviour in your tests?\nAre there plans to address that scenario?","commit_id":"16cfdf318be3accb6bda694642ae9b6396a4e13f"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"51a019d36a91ca6795badaab87fcdecdc2b8c60f","unresolved":false,"context_lines":[{"line_number":258,"context_line":"        if not lswitch:"},{"line_number":259,"context_line":"            LOG.warning(_LW(\"Could not find lswitch for lport: %s\"),"},{"line_number":260,"context_line":"                        lport.get_id())"},{"line_number":261,"context_line":"            return"},{"line_number":262,"context_line":"        lport.set_external_value(\u0027local_network_id\u0027,"},{"line_number":263,"context_line":"                                 lswitch.get_unique_key())"},{"line_number":264,"context_line":"        network_type \u003d lswitch.get_network_type()"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a74a57a_190b462b","line":261,"range":{"start_line":261,"start_character":0,"end_line":261,"end_character":18},"in_reply_to":"5a74a57a_a3e99d82","updated":"2016-11-28 16:58:55.000000000","message":"All right. Let\u0027s merge this. The scenario I saw seems stable, so it can be retested once this is merged and we\u0027ll take it from there.","commit_id":"16cfdf318be3accb6bda694642ae9b6396a4e13f"},{"author":{"_account_id":20287,"name":"hujie","email":"mike.hu@huawei.com","username":"hujie"},"change_message_id":"3c9afc1e69c728f70c6e794f8bd53d36695f9119","unresolved":false,"context_lines":[{"line_number":258,"context_line":"        if not lswitch:"},{"line_number":259,"context_line":"            LOG.warning(_LW(\"Could not find lswitch for lport: %s\"),"},{"line_number":260,"context_line":"                        lport.get_id())"},{"line_number":261,"context_line":"            return"},{"line_number":262,"context_line":"        lport.set_external_value(\u0027local_network_id\u0027,"},{"line_number":263,"context_line":"                                 lswitch.get_unique_key())"},{"line_number":264,"context_line":"        network_type \u003d lswitch.get_network_type()"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a74a57a_a3e99d82","line":261,"range":{"start_line":261,"start_character":0,"end_line":261,"end_character":18},"in_reply_to":"5a74a57a_d659feff","updated":"2016-11-25 02:21:43.000000000","message":"I think this and that scenario are both the db consistent issue, maybe the lswitch event is lost because of network connection issue at that time, or maybe the lswitch obj is not stored into cache because of some exception happens in the processing, here we just to consider this issue and avoid the situation when lswitch is None, and the db consistent issue could be resolved by this patch:\nhttps://review.openstack.org/#/c/336377/","commit_id":"16cfdf318be3accb6bda694642ae9b6396a4e13f"}]}