)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"6d684a93780414efdbdc38750645d2f26ef51682","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Irena Berezovsky \u003cirenab.dev@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-11-17 13:49:22 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":" Set l3 agent binary name to appear as DragonFlow binary"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":" Closes-Bug: #1641923"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a77a97e_6fa99f23","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":1},"updated":"2016-11-20 09:22:08.000000000","message":"extra space","commit_id":"48c3b336bb95d2254d67abd900913a83140318e2"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"8aa4a2a57f8af1c31ebffbbdc3dd866e7074fd7a","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Irena Berezovsky \u003cirenab.dev@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-11-17 13:49:22 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":" Set l3 agent binary name to appear as DragonFlow binary"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":" Closes-Bug: #1641923"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a77a97e_cf363302","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":1},"in_reply_to":"7a77a97e_6fa99f23","updated":"2016-11-20 09:28:47.000000000","message":"Done","commit_id":"48c3b336bb95d2254d67abd900913a83140318e2"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"6d684a93780414efdbdc38750645d2f26ef51682","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":" Set l3 agent binary name to appear as DragonFlow binary"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":" Closes-Bug: #1641923"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: If472af92c3edca7b25b746bdee0a6c4b92277092"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a77a97e_af65771e","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":1},"updated":"2016-11-20 09:22:08.000000000","message":"ditto","commit_id":"48c3b336bb95d2254d67abd900913a83140318e2"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"8aa4a2a57f8af1c31ebffbbdc3dd866e7074fd7a","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":" Set l3 agent binary name to appear as DragonFlow binary"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":" Closes-Bug: #1641923"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: If472af92c3edca7b25b746bdee0a6c4b92277092"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a77a97e_ef392ff3","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":1},"in_reply_to":"7a77a97e_af65771e","updated":"2016-11-20 09:28:47.000000000","message":"Done","commit_id":"48c3b336bb95d2254d67abd900913a83140318e2"}],"dragonflow/neutron/agent/l3/df_router.py":[{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"f80e8b396f01d11522956dd57088dce600c3ddb3","unresolved":false,"context_lines":[{"line_number":39,"context_line":"class DfL3NATAgentWithStateReport(agent.L3NATAgentWithStateReport):"},{"line_number":40,"context_line":"    def __init__(self, host, conf\u003dNone):"},{"line_number":41,"context_line":"        super(DfL3NATAgentWithStateReport, self).__init__(host\u003dhost, conf\u003dconf)"},{"line_number":42,"context_line":"        self.agent_state[\u0027binary\u0027] \u003d \u0027neutron-df-l3-agent\u0027"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def _create_router(self, router_id, router):"},{"line_number":45,"context_line":"        args \u003d []"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a77a97e_3017d155","line":42,"range":{"start_line":42,"start_character":38,"end_line":42,"end_character":57},"updated":"2016-11-22 02:42:17.000000000","message":"The binary name is actually \"df-l3-agent\" without neutron as prefix.","commit_id":"44417617f184cb5ec45278653c254fb95686f4cb"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"040cb13e3c23b565216269d3c77cafd1211dfbb2","unresolved":false,"context_lines":[{"line_number":39,"context_line":"class DfL3NATAgentWithStateReport(agent.L3NATAgentWithStateReport):"},{"line_number":40,"context_line":"    def __init__(self, host, conf\u003dNone):"},{"line_number":41,"context_line":"        super(DfL3NATAgentWithStateReport, self).__init__(host\u003dhost, conf\u003dconf)"},{"line_number":42,"context_line":"        self.agent_state[\u0027binary\u0027] \u003d \u0027neutron-df-l3-agent\u0027"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def _create_router(self, router_id, router):"},{"line_number":45,"context_line":"        args \u003d []"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a77a97e_c211685f","line":42,"range":{"start_line":42,"start_character":38,"end_line":42,"end_character":57},"in_reply_to":"7a77a97e_3017d155","updated":"2016-11-22 07:45:41.000000000","message":"Since its mostly based on neutron L3 agent and reported in the neutron agents list. I think better to keep it with neutron prefix","commit_id":"44417617f184cb5ec45278653c254fb95686f4cb"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"6f8844e6119855ec0ff290679ff8dbd245703251","unresolved":false,"context_lines":[{"line_number":39,"context_line":"class DfL3NATAgentWithStateReport(agent.L3NATAgentWithStateReport):"},{"line_number":40,"context_line":"    def __init__(self, host, conf\u003dNone):"},{"line_number":41,"context_line":"        super(DfL3NATAgentWithStateReport, self).__init__(host\u003dhost, conf\u003dconf)"},{"line_number":42,"context_line":"        self.agent_state[\u0027binary\u0027] \u003d \u0027neutron-df-l3-agent\u0027"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def _create_router(self, router_id, router):"},{"line_number":45,"context_line":"        args \u003d []"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a77a97e_c5716fe2","line":42,"range":{"start_line":42,"start_character":38,"end_line":42,"end_character":57},"in_reply_to":"7a77a97e_45463fc0","updated":"2016-11-22 09:00:54.000000000","message":"Updating the \u0027binary\u0027 field to reflect the executed binary name","commit_id":"44417617f184cb5ec45278653c254fb95686f4cb"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"8d73dfe9b4c58264e782def82a681ba3552d79dc","unresolved":false,"context_lines":[{"line_number":39,"context_line":"class DfL3NATAgentWithStateReport(agent.L3NATAgentWithStateReport):"},{"line_number":40,"context_line":"    def __init__(self, host, conf\u003dNone):"},{"line_number":41,"context_line":"        super(DfL3NATAgentWithStateReport, self).__init__(host\u003dhost, conf\u003dconf)"},{"line_number":42,"context_line":"        self.agent_state[\u0027binary\u0027] \u003d \u0027neutron-df-l3-agent\u0027"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def _create_router(self, router_id, router):"},{"line_number":45,"context_line":"        args \u003d []"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a77a97e_efae4ce6","line":42,"range":{"start_line":42,"start_character":38,"end_line":42,"end_character":57},"in_reply_to":"7a77a97e_c211685f","updated":"2016-11-22 08:07:45.000000000","message":"the binary is actually the name of executed file under /usr/bin It is true that it is mostly base on neutron l3 agent. But it loses the meaning of this patch if you use \u0027neutron-df-l3-agent\u0027 instead of \u0027df-l3-agent\u0027","commit_id":"44417617f184cb5ec45278653c254fb95686f4cb"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"0e51a7a36dde98ace6bc12e1d8e3707706cf8265","unresolved":false,"context_lines":[{"line_number":39,"context_line":"class DfL3NATAgentWithStateReport(agent.L3NATAgentWithStateReport):"},{"line_number":40,"context_line":"    def __init__(self, host, conf\u003dNone):"},{"line_number":41,"context_line":"        super(DfL3NATAgentWithStateReport, self).__init__(host\u003dhost, conf\u003dconf)"},{"line_number":42,"context_line":"        self.agent_state[\u0027binary\u0027] \u003d \u0027neutron-df-l3-agent\u0027"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def _create_router(self, router_id, router):"},{"line_number":45,"context_line":"        args \u003d []"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a77a97e_45463fc0","line":42,"range":{"start_line":42,"start_character":38,"end_line":42,"end_character":57},"in_reply_to":"7a77a97e_efae4ce6","updated":"2016-11-22 08:55:28.000000000","message":"The original binary was called neutron-l3-agent, and that\u0027s what appeared in the table.\n\nIf it is expected that the displayed binary is the same as the executed binary, then yes, it should be \u0027df-l3-agent\u0027.\n\nWe can also change the binary\u0027s name, but I think that\u0027s a bit much.\n\nNot -1, I\u0027ll let you decide how to take it.","commit_id":"44417617f184cb5ec45278653c254fb95686f4cb"}]}