)]}'
{"devstack/plugin.sh":[{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"5234637808fa8266ece6aabcc39e13d2b59066b3","unresolved":false,"context_lines":[{"line_number":185,"context_line":"    fi"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"    # Generate DF config file"},{"line_number":188,"context_line":"    local _pwd\u003d$(pwd)"},{"line_number":189,"context_line":"    (cd $DRAGONFLOW_DIR \u0026\u0026 exec ./tools/generate_config_file_samples.sh)"},{"line_number":190,"context_line":"    cd $_pwd"},{"line_number":191,"context_line":"    mkdir -p $Q_PLUGIN_EXTRA_CONF_PATH"},{"line_number":192,"context_line":"    cp $DRAGONFLOW_DIR/etc/dragonflow.ini.sample $DRAGONFLOW_CONF"},{"line_number":193,"context_line":""}],"source_content_type":"text/x-sh","patch_set":1,"id":"7a77a97e_e48ccd81","line":190,"range":{"start_line":188,"start_character":0,"end_line":190,"end_character":12},"updated":"2016-11-21 16:49:51.000000000","message":"If we\u0027re already changing this, would you mind also changing this to use pushd ; popd rather than pwd magic?","commit_id":"f3add9847bfd7f1cfeead6ae9e4b05362b9d3479"},{"author":{"_account_id":23766,"name":"Dima Kuznetsov","email":"dima.kuznetsov@toganetworks.com","username":"dimak"},"change_message_id":"c360eab85a62a22632b8f9773ada5bc8d3984fbc","unresolved":false,"context_lines":[{"line_number":185,"context_line":"    fi"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"    # Generate DF config file"},{"line_number":188,"context_line":"    local _pwd\u003d$(pwd)"},{"line_number":189,"context_line":"    (cd $DRAGONFLOW_DIR \u0026\u0026 exec ./tools/generate_config_file_samples.sh)"},{"line_number":190,"context_line":"    cd $_pwd"},{"line_number":191,"context_line":"    mkdir -p $Q_PLUGIN_EXTRA_CONF_PATH"},{"line_number":192,"context_line":"    cp $DRAGONFLOW_DIR/etc/dragonflow.ini.sample $DRAGONFLOW_CONF"},{"line_number":193,"context_line":""}],"source_content_type":"text/x-sh","patch_set":1,"id":"7a77a97e_c4199124","line":190,"range":{"start_line":188,"start_character":0,"end_line":190,"end_character":12},"in_reply_to":"7a77a97e_e48ccd81","updated":"2016-11-21 16:54:10.000000000","message":"will change","commit_id":"f3add9847bfd7f1cfeead6ae9e4b05362b9d3479"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"13f8341397d7ca434180315e763e09d10eb90500","unresolved":false,"context_lines":[{"line_number":179,"context_line":"        Q_SERVICE_PLUGIN_CLASSES\u003d\"\""},{"line_number":180,"context_line":"    else"},{"line_number":181,"context_line":"        DF_APPS_LIST\u003d$ML2_APPS_LIST"},{"line_number":182,"context_line":"        if is_service_enabled q-qos ; then"},{"line_number":183,"context_line":"            configure_qos"},{"line_number":184,"context_line":"        fi"},{"line_number":185,"context_line":"    fi"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"    # Generate DF config file"}],"source_content_type":"text/x-sh","patch_set":2,"id":"7a77a97e_461c9377","line":184,"range":{"start_line":182,"start_character":0,"end_line":184,"end_character":10},"updated":"2016-11-22 03:29:14.000000000","message":"actually, in df, qos will work with neutron-server. Compute node will only need to config the qos app.","commit_id":"8ee439b93e6c8d83ce5f4d8c013e882fea17ab38"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"48271e17614d330679bd5888123e8a980853be57","unresolved":false,"context_lines":[{"line_number":179,"context_line":"        Q_SERVICE_PLUGIN_CLASSES\u003d\"\""},{"line_number":180,"context_line":"    else"},{"line_number":181,"context_line":"        DF_APPS_LIST\u003d$ML2_APPS_LIST"},{"line_number":182,"context_line":"        if is_service_enabled q-qos ; then"},{"line_number":183,"context_line":"            configure_qos"},{"line_number":184,"context_line":"        fi"},{"line_number":185,"context_line":"    fi"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"    # Generate DF config file"}],"source_content_type":"text/x-sh","patch_set":2,"id":"7a77a97e_8f0958e0","line":184,"range":{"start_line":182,"start_character":0,"end_line":184,"end_character":10},"in_reply_to":"7a77a97e_1dc10581","updated":"2016-11-22 08:13:12.000000000","message":"in compute node, qos will work by using qos app, which is still in-progress. \n\nhttps://review.openstack.org/#/c/337497/","commit_id":"8ee439b93e6c8d83ce5f4d8c013e882fea17ab38"},{"author":{"_account_id":23766,"name":"Dima Kuznetsov","email":"dima.kuznetsov@toganetworks.com","username":"dimak"},"change_message_id":"36ab6ea0b4f5d12df0d0edc6c899d90767446c88","unresolved":false,"context_lines":[{"line_number":179,"context_line":"        Q_SERVICE_PLUGIN_CLASSES\u003d\"\""},{"line_number":180,"context_line":"    else"},{"line_number":181,"context_line":"        DF_APPS_LIST\u003d$ML2_APPS_LIST"},{"line_number":182,"context_line":"        if is_service_enabled q-qos ; then"},{"line_number":183,"context_line":"            configure_qos"},{"line_number":184,"context_line":"        fi"},{"line_number":185,"context_line":"    fi"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"    # Generate DF config file"}],"source_content_type":"text/x-sh","patch_set":2,"id":"7a77a97e_1dc10581","line":184,"range":{"start_line":182,"start_character":0,"end_line":184,"end_character":10},"in_reply_to":"7a77a97e_461c9377","updated":"2016-11-22 08:08:43.000000000","message":"Is q-qos enabled on compute?","commit_id":"8ee439b93e6c8d83ce5f4d8c013e882fea17ab38"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"13f8341397d7ca434180315e763e09d10eb90500","unresolved":false,"context_lines":[{"line_number":202,"context_line":"        iniset $DRAGONFLOW_CONF df monitor_table_poll_time \"$DF_MONITOR_TABLE_POLL_TIME\""},{"line_number":203,"context_line":"        iniset $DRAGONFLOW_CONF df publisher_rate_limit_timeout \"$PUBLISHER_RATE_LIMIT_TIMEOUT\""},{"line_number":204,"context_line":"        iniset $DRAGONFLOW_CONF df publisher_rate_limit_count \"$PUBLISHER_RATE_LIMIT_COUNT\""},{"line_number":205,"context_line":"        iniset $NEUTRON_CONF DEFAULT advertise_mtu \"True\""},{"line_number":206,"context_line":"        iniset $NEUTRON_CONF DEFAULT core_plugin \"$Q_PLUGIN_CLASS\""},{"line_number":207,"context_line":"        iniset $NEUTRON_CONF DEFAULT service_plugins \"$Q_SERVICE_PLUGIN_CLASSES\""},{"line_number":208,"context_line":""}],"source_content_type":"text/x-sh","patch_set":2,"id":"7a77a97e_c87b517a","line":205,"range":{"start_line":205,"start_character":0,"end_line":205,"end_character":57},"updated":"2016-11-22 03:29:14.000000000","message":"I think it is a command config, it will be used dhcp app, which should run in all nodes.\n\nBut back check in neutron, it is default to be True and marked deprecated_for_removal. So, maybe we should just remove this option and its usage in df. I think that could be in another patch.","commit_id":"8ee439b93e6c8d83ce5f4d8c013e882fea17ab38"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"48271e17614d330679bd5888123e8a980853be57","unresolved":false,"context_lines":[{"line_number":202,"context_line":"        iniset $DRAGONFLOW_CONF df monitor_table_poll_time \"$DF_MONITOR_TABLE_POLL_TIME\""},{"line_number":203,"context_line":"        iniset $DRAGONFLOW_CONF df publisher_rate_limit_timeout \"$PUBLISHER_RATE_LIMIT_TIMEOUT\""},{"line_number":204,"context_line":"        iniset $DRAGONFLOW_CONF df publisher_rate_limit_count \"$PUBLISHER_RATE_LIMIT_COUNT\""},{"line_number":205,"context_line":"        iniset $NEUTRON_CONF DEFAULT advertise_mtu \"True\""},{"line_number":206,"context_line":"        iniset $NEUTRON_CONF DEFAULT core_plugin \"$Q_PLUGIN_CLASS\""},{"line_number":207,"context_line":"        iniset $NEUTRON_CONF DEFAULT service_plugins \"$Q_SERVICE_PLUGIN_CLASSES\""},{"line_number":208,"context_line":""}],"source_content_type":"text/x-sh","patch_set":2,"id":"7a77a97e_cf13500c","line":205,"range":{"start_line":205,"start_character":0,"end_line":205,"end_character":57},"in_reply_to":"7a77a97e_bd9e5105","updated":"2016-11-22 08:13:12.000000000","message":"Sounds good","commit_id":"8ee439b93e6c8d83ce5f4d8c013e882fea17ab38"},{"author":{"_account_id":23766,"name":"Dima Kuznetsov","email":"dima.kuznetsov@toganetworks.com","username":"dimak"},"change_message_id":"36ab6ea0b4f5d12df0d0edc6c899d90767446c88","unresolved":false,"context_lines":[{"line_number":202,"context_line":"        iniset $DRAGONFLOW_CONF df monitor_table_poll_time \"$DF_MONITOR_TABLE_POLL_TIME\""},{"line_number":203,"context_line":"        iniset $DRAGONFLOW_CONF df publisher_rate_limit_timeout \"$PUBLISHER_RATE_LIMIT_TIMEOUT\""},{"line_number":204,"context_line":"        iniset $DRAGONFLOW_CONF df publisher_rate_limit_count \"$PUBLISHER_RATE_LIMIT_COUNT\""},{"line_number":205,"context_line":"        iniset $NEUTRON_CONF DEFAULT advertise_mtu \"True\""},{"line_number":206,"context_line":"        iniset $NEUTRON_CONF DEFAULT core_plugin \"$Q_PLUGIN_CLASS\""},{"line_number":207,"context_line":"        iniset $NEUTRON_CONF DEFAULT service_plugins \"$Q_SERVICE_PLUGIN_CLASSES\""},{"line_number":208,"context_line":""}],"source_content_type":"text/x-sh","patch_set":2,"id":"7a77a97e_bd9e5105","line":205,"range":{"start_line":205,"start_character":0,"end_line":205,"end_character":57},"in_reply_to":"7a77a97e_c87b517a","updated":"2016-11-22 08:08:43.000000000","message":"For the time being I\u0027ll move it to the common path, we can get rid of it once we drop it from dhcp app.","commit_id":"8ee439b93e6c8d83ce5f4d8c013e882fea17ab38"},{"author":{"_account_id":9044,"name":"Will","email":"wangjian.ika@bytedance.com","username":"Will"},"change_message_id":"e1b3e34137956a7ee3a061e4d0fdda8b95c93194","unresolved":false,"context_lines":[{"line_number":242,"context_line":"    iniset $DRAGONFLOW_CONF df port_status_notifier \"$PORT_STATUS_NOTIFIER\""},{"line_number":243,"context_line":"    iniset $DRAGONFLOW_CONF df enable_port_status_notifier \"$ENABLE_PORT_STATUS_NOTIFIER\""},{"line_number":244,"context_line":"    iniset $DRAGONFLOW_CONF df local_ip \"$HOST_IP\""},{"line_number":245,"context_line":"    iniset $DRAGONFLOW_CONF df tunnel_type \"$TUNNEL_TYPE\""},{"line_number":246,"context_line":"    iniset $DRAGONFLOW_CONF df integration_bridge \"$INTEGRATION_BRIDGE\""},{"line_number":247,"context_line":"    iniset $DRAGONFLOW_CONF df apps_list \"$DF_APPS_LIST\""},{"line_number":248,"context_line":"    iniset $DRAGONFLOW_CONF df_l2_app l2_responder \"$DF_L2_RESPONDER\""}],"source_content_type":"text/x-sh","patch_set":2,"id":"7a77a97e_d0785d2e","line":245,"range":{"start_line":245,"start_character":0,"end_line":245,"end_character":57},"updated":"2016-11-22 02:15:12.000000000","message":"I think it is not common","commit_id":"8ee439b93e6c8d83ce5f4d8c013e882fea17ab38"},{"author":{"_account_id":9044,"name":"Will","email":"wangjian.ika@bytedance.com","username":"Will"},"change_message_id":"61048af75b3898d87c36fc870d948338bad5ca26","unresolved":false,"context_lines":[{"line_number":242,"context_line":"    iniset $DRAGONFLOW_CONF df port_status_notifier \"$PORT_STATUS_NOTIFIER\""},{"line_number":243,"context_line":"    iniset $DRAGONFLOW_CONF df enable_port_status_notifier \"$ENABLE_PORT_STATUS_NOTIFIER\""},{"line_number":244,"context_line":"    iniset $DRAGONFLOW_CONF df local_ip \"$HOST_IP\""},{"line_number":245,"context_line":"    iniset $DRAGONFLOW_CONF df tunnel_type \"$TUNNEL_TYPE\""},{"line_number":246,"context_line":"    iniset $DRAGONFLOW_CONF df integration_bridge \"$INTEGRATION_BRIDGE\""},{"line_number":247,"context_line":"    iniset $DRAGONFLOW_CONF df apps_list \"$DF_APPS_LIST\""},{"line_number":248,"context_line":"    iniset $DRAGONFLOW_CONF df_l2_app l2_responder \"$DF_L2_RESPONDER\""}],"source_content_type":"text/x-sh","patch_set":2,"id":"7a77a97e_32e7cb41","line":245,"range":{"start_line":245,"start_character":0,"end_line":245,"end_character":57},"in_reply_to":"7a77a97e_6fbb1c76","updated":"2016-11-22 08:29:05.000000000","message":"Got it","commit_id":"8ee439b93e6c8d83ce5f4d8c013e882fea17ab38"},{"author":{"_account_id":23766,"name":"Dima Kuznetsov","email":"dima.kuznetsov@toganetworks.com","username":"dimak"},"change_message_id":"36ab6ea0b4f5d12df0d0edc6c899d90767446c88","unresolved":false,"context_lines":[{"line_number":242,"context_line":"    iniset $DRAGONFLOW_CONF df port_status_notifier \"$PORT_STATUS_NOTIFIER\""},{"line_number":243,"context_line":"    iniset $DRAGONFLOW_CONF df enable_port_status_notifier \"$ENABLE_PORT_STATUS_NOTIFIER\""},{"line_number":244,"context_line":"    iniset $DRAGONFLOW_CONF df local_ip \"$HOST_IP\""},{"line_number":245,"context_line":"    iniset $DRAGONFLOW_CONF df tunnel_type \"$TUNNEL_TYPE\""},{"line_number":246,"context_line":"    iniset $DRAGONFLOW_CONF df integration_bridge \"$INTEGRATION_BRIDGE\""},{"line_number":247,"context_line":"    iniset $DRAGONFLOW_CONF df apps_list \"$DF_APPS_LIST\""},{"line_number":248,"context_line":"    iniset $DRAGONFLOW_CONF df_l2_app l2_responder \"$DF_L2_RESPONDER\""}],"source_content_type":"text/x-sh","patch_set":2,"id":"7a77a97e_9da515b7","line":245,"range":{"start_line":245,"start_character":0,"end_line":245,"end_character":57},"in_reply_to":"7a77a97e_8616ab53","updated":"2016-11-22 08:08:43.000000000","message":"It was present in both paths.","commit_id":"8ee439b93e6c8d83ce5f4d8c013e882fea17ab38"},{"author":{"_account_id":9044,"name":"Will","email":"wangjian.ika@bytedance.com","username":"Will"},"change_message_id":"e9a239466bd4379a194c82cd58aaa73e76e3c6ac","unresolved":false,"context_lines":[{"line_number":242,"context_line":"    iniset $DRAGONFLOW_CONF df port_status_notifier \"$PORT_STATUS_NOTIFIER\""},{"line_number":243,"context_line":"    iniset $DRAGONFLOW_CONF df enable_port_status_notifier \"$ENABLE_PORT_STATUS_NOTIFIER\""},{"line_number":244,"context_line":"    iniset $DRAGONFLOW_CONF df local_ip \"$HOST_IP\""},{"line_number":245,"context_line":"    iniset $DRAGONFLOW_CONF df tunnel_type \"$TUNNEL_TYPE\""},{"line_number":246,"context_line":"    iniset $DRAGONFLOW_CONF df integration_bridge \"$INTEGRATION_BRIDGE\""},{"line_number":247,"context_line":"    iniset $DRAGONFLOW_CONF df apps_list \"$DF_APPS_LIST\""},{"line_number":248,"context_line":"    iniset $DRAGONFLOW_CONF df_l2_app l2_responder \"$DF_L2_RESPONDER\""}],"source_content_type":"text/x-sh","patch_set":2,"id":"7a77a97e_eff72c8a","line":245,"range":{"start_line":245,"start_character":0,"end_line":245,"end_character":57},"in_reply_to":"7a77a97e_9da515b7","updated":"2016-11-22 08:18:04.000000000","message":"@Hong Hui Xiao @Dima Kuznetsov, I find it is used only in df-controllers side, thought it was presend in both pathes","commit_id":"8ee439b93e6c8d83ce5f4d8c013e882fea17ab38"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"13f8341397d7ca434180315e763e09d10eb90500","unresolved":false,"context_lines":[{"line_number":242,"context_line":"    iniset $DRAGONFLOW_CONF df port_status_notifier \"$PORT_STATUS_NOTIFIER\""},{"line_number":243,"context_line":"    iniset $DRAGONFLOW_CONF df enable_port_status_notifier \"$ENABLE_PORT_STATUS_NOTIFIER\""},{"line_number":244,"context_line":"    iniset $DRAGONFLOW_CONF df local_ip \"$HOST_IP\""},{"line_number":245,"context_line":"    iniset $DRAGONFLOW_CONF df tunnel_type \"$TUNNEL_TYPE\""},{"line_number":246,"context_line":"    iniset $DRAGONFLOW_CONF df integration_bridge \"$INTEGRATION_BRIDGE\""},{"line_number":247,"context_line":"    iniset $DRAGONFLOW_CONF df apps_list \"$DF_APPS_LIST\""},{"line_number":248,"context_line":"    iniset $DRAGONFLOW_CONF df_l2_app l2_responder \"$DF_L2_RESPONDER\""}],"source_content_type":"text/x-sh","patch_set":2,"id":"7a77a97e_8616ab53","line":245,"range":{"start_line":245,"start_character":0,"end_line":245,"end_character":57},"in_reply_to":"7a77a97e_d0785d2e","updated":"2016-11-22 03:29:14.000000000","message":"Why not?","commit_id":"8ee439b93e6c8d83ce5f4d8c013e882fea17ab38"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"3019229d95fb6f7b7520258e3c61b096de3d5c09","unresolved":false,"context_lines":[{"line_number":242,"context_line":"    iniset $DRAGONFLOW_CONF df port_status_notifier \"$PORT_STATUS_NOTIFIER\""},{"line_number":243,"context_line":"    iniset $DRAGONFLOW_CONF df enable_port_status_notifier \"$ENABLE_PORT_STATUS_NOTIFIER\""},{"line_number":244,"context_line":"    iniset $DRAGONFLOW_CONF df local_ip \"$HOST_IP\""},{"line_number":245,"context_line":"    iniset $DRAGONFLOW_CONF df tunnel_type \"$TUNNEL_TYPE\""},{"line_number":246,"context_line":"    iniset $DRAGONFLOW_CONF df integration_bridge \"$INTEGRATION_BRIDGE\""},{"line_number":247,"context_line":"    iniset $DRAGONFLOW_CONF df apps_list \"$DF_APPS_LIST\""},{"line_number":248,"context_line":"    iniset $DRAGONFLOW_CONF df_l2_app l2_responder \"$DF_L2_RESPONDER\""}],"source_content_type":"text/x-sh","patch_set":2,"id":"7a77a97e_6fbb1c76","line":245,"range":{"start_line":245,"start_character":0,"end_line":245,"end_character":57},"in_reply_to":"7a77a97e_eff72c8a","updated":"2016-11-22 08:22:10.000000000","message":"df-controller will run in every node in the df cluster, so the config will be used as a common config.","commit_id":"8ee439b93e6c8d83ce5f4d8c013e882fea17ab38"}]}