)]}'
{"dragonflow/ovsdb/impl_idl.py":[{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"9fd7a87b915349e43fffd41025aa2dd8f2c7f226","unresolved":false,"context_lines":[{"line_number":125,"context_line":"    def start(self, nb_api):"},{"line_number":126,"context_line":"        DFOvsdbApi.ovsdb_connection.idl_class \u003d functools.partial("},{"line_number":127,"context_line":"                DFOvsdbApi.ovsdb_connection.idl_class, nb_api)"},{"line_number":128,"context_line":"        DFOvsdbApi.ovsdb_connection.start(nb_api)"},{"line_number":129,"context_line":"        self.idl \u003d DFOvsdbApi.ovsdb_connection.idl"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"    def add_tunnel_port(self, chassis):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a74a57a_bd4591b4","line":128,"range":{"start_line":128,"start_character":0,"end_line":128,"end_character":49},"updated":"2016-11-30 01:26:19.000000000","message":"Since the method \"start\" of connection.Connection is not overriden here, passing nb_api will not be appropriate.\n\nAnd we can remove the start method of DFOvsdbApi, and move its content to the __init__ method, so that the idl_class of Connection don\u0027t need to be written twice here.","commit_id":"f2960d160cfa2e2c03e999383a654953aa99f8ff"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"1f695e9126eb34c1d1c86ec5d41826a55e8f74fa","unresolved":false,"context_lines":[{"line_number":125,"context_line":"    def start(self, nb_api):"},{"line_number":126,"context_line":"        DFOvsdbApi.ovsdb_connection.idl_class \u003d functools.partial("},{"line_number":127,"context_line":"                DFOvsdbApi.ovsdb_connection.idl_class, nb_api)"},{"line_number":128,"context_line":"        DFOvsdbApi.ovsdb_connection.start(nb_api)"},{"line_number":129,"context_line":"        self.idl \u003d DFOvsdbApi.ovsdb_connection.idl"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"    def add_tunnel_port(self, chassis):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a74a57a_e0baf909","line":128,"range":{"start_line":128,"start_character":0,"end_line":128,"end_character":49},"in_reply_to":"5a74a57a_bd4591b4","updated":"2016-11-30 05:09:34.000000000","message":"I\u0027ll move nb_api to __init__.\n\nBut I think keeping start and __init__ separate is still a good idea. One creates the object, the other tells it to connect and start working. I like that separation.","commit_id":"f2960d160cfa2e2c03e999383a654953aa99f8ff"}]}