)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"617f76ec5f9ad4b7f551fb17ef48ed2106c69da6","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     itamaro \u003citamar.ofek@huawei.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-11-30 10:07:56 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"classification app spec"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I909a0cf3a650c72428d0be78bb5b3747acbcdfc2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5a74a57a_ad39d143","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":14},"updated":"2016-11-30 12:01:18.000000000","message":"Capital C","commit_id":"5c279d216c60589dfa2addfb062bbc94c7b0317f"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"617f76ec5f9ad4b7f551fb17ef48ed2106c69da6","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2016-11-30 10:07:56 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"classification app spec"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I909a0cf3a650c72428d0be78bb5b3747acbcdfc2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5a74a57a_6d2fb9f6","line":8,"updated":"2016-11-30 12:01:18.000000000","message":"missing link to launchpad bp","commit_id":"5c279d216c60589dfa2addfb062bbc94c7b0317f"}],"doc/source/specs/classification_app.rst":[{"author":{"_account_id":20287,"name":"hujie","email":"mike.hu@huawei.com","username":"hujie"},"change_message_id":"fa11d46debe07bcdf6c39a206b360e0ed411b567","unresolved":false,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":7,"context_line":"Classification App"},{"line_number":8,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":9,"context_line":"The classification is a separate processing which takes place throughout"},{"line_number":10,"context_line":"the port\u0027s life-cycle."},{"line_number":11,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"5a74a57a_b6f75d8b","line":8,"range":{"start_line":8,"start_character":18,"end_line":8,"end_character":42},"updated":"2016-11-30 13:44:05.000000000","message":"notice the format","commit_id":"5c279d216c60589dfa2addfb062bbc94c7b0317f"},{"author":{"_account_id":22060,"name":"jingting","email":"kangjingting@huawei.com","username":"jingting"},"change_message_id":"8a4a923eae5079b4a82756dc40158ddbedf6e511","unresolved":false,"context_lines":[{"line_number":10,"context_line":"the port\u0027s life-cycle."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"When a packet enters the integration bridge, it is"},{"line_number":13,"context_line":"classified. Information, such as its network ID and source are stored"},{"line_number":14,"context_line":"in the OVS metadata, i.e. in metadata field and registers."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"This information is then used by other Dragonflow applications throughout"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5a74a57a_6c6c1209","line":13,"range":{"start_line":13,"start_character":52,"end_line":13,"end_character":58},"updated":"2016-11-30 12:44:53.000000000","message":"what source?","commit_id":"5c279d216c60589dfa2addfb062bbc94c7b0317f"},{"author":{"_account_id":20287,"name":"hujie","email":"mike.hu@huawei.com","username":"hujie"},"change_message_id":"fa11d46debe07bcdf6c39a206b360e0ed411b567","unresolved":false,"context_lines":[{"line_number":10,"context_line":"the port\u0027s life-cycle."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"When a packet enters the integration bridge, it is"},{"line_number":13,"context_line":"classified. Information, such as its network ID and source are stored"},{"line_number":14,"context_line":"in the OVS metadata, i.e. in metadata field and registers."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"This information is then used by other Dragonflow applications throughout"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5a74a57a_0d89d7ca","line":13,"range":{"start_line":13,"start_character":52,"end_line":13,"end_character":58},"in_reply_to":"5a74a57a_6c6c1209","updated":"2016-11-30 13:44:05.000000000","message":"+1","commit_id":"5c279d216c60589dfa2addfb062bbc94c7b0317f"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"617f76ec5f9ad4b7f551fb17ef48ed2106c69da6","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Reusability can be further {pushed forwards} by extracting common methods"},{"line_number":30,"context_line":"to a common locations and libraries."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Proposed Change"},{"line_number":33,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"5a74a57a_73995c1f","line":31,"updated":"2016-11-30 12:01:18.000000000","message":"Would it allow to apply classification at different points of packet processing? If so, worth to mention it as well","commit_id":"5c279d216c60589dfa2addfb062bbc94c7b0317f"},{"author":{"_account_id":18347,"name":"Itamar Ofek","email":"itamofek@netscape.net","username":"itamaro"},"change_message_id":"17f103e20996705f585e13c08b6c53037f0412e4","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Reusability can be further {pushed forwards} by extracting common methods"},{"line_number":30,"context_line":"to a common locations and libraries."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Proposed Change"},{"line_number":33,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a71b18c_3d9353a5","line":31,"in_reply_to":"5a74a57a_73995c1f","updated":"2016-12-01 14:31:07.000000000","message":"In the future it may, right now it will only take the classification out of L2App code","commit_id":"5c279d216c60589dfa2addfb062bbc94c7b0317f"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"617f76ec5f9ad4b7f551fb17ef48ed2106c69da6","unresolved":false,"context_lines":[{"line_number":39,"context_line":"its own Dragonflow application."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"The classification application will install flows on table 0, where the"},{"line_number":42,"context_line":"packet is received. It will set the following metdata information:"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"* metadata \u003c- Unique network ID"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"5a74a57a_3390c4ec","line":42,"range":{"start_line":42,"start_character":46,"end_line":42,"end_character":53},"updated":"2016-11-30 12:01:18.000000000","message":"metadata","commit_id":"5c279d216c60589dfa2addfb062bbc94c7b0317f"},{"author":{"_account_id":22060,"name":"jingting","email":"kangjingting@huawei.com","username":"jingting"},"change_message_id":"8a4a923eae5079b4a82756dc40158ddbedf6e511","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"* metadata \u003c- Unique network ID"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"* reg6 \u003c- Unique ID of the packet source (port ID)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"The classification application adds the relevant flows upon the creation"},{"line_number":49,"context_line":"of a new port, i.e. on the callback `add_local_port`."}],"source_content_type":"text/x-rst","patch_set":1,"id":"5a74a57a_a739e5da","line":46,"range":{"start_line":46,"start_character":42,"end_line":46,"end_character":49},"updated":"2016-11-30 12:44:53.000000000","message":"port_unique_key?","commit_id":"5c279d216c60589dfa2addfb062bbc94c7b0317f"},{"author":{"_account_id":22060,"name":"jingting","email":"kangjingting@huawei.com","username":"jingting"},"change_message_id":"8a4a923eae5079b4a82756dc40158ddbedf6e511","unresolved":false,"context_lines":[{"line_number":52,"context_line":"is:"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"::"},{"line_number":55,"context_line":"    cookie\u003d0x0, duration\u003d498548.745s, table\u003d0, n_packets\u003d10, n_bytes\u003d864, idle_age\u003d65534, hard_age\u003d65534, priority\u003d100,in_port\u003d3 actions\u003dload:0x3-\u003eNXM_NX_REG6[],load:0x1-\u003eOXM_OF_METADATA[],resubmit(,1)"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"The classification application removes the relevant flows upon the"},{"line_number":58,"context_line":"removal of a port, i.e. on the callback `remove_local_port`."}],"source_content_type":"text/x-rst","patch_set":1,"id":"5a74a57a_07bb790f","line":55,"updated":"2016-11-30 12:44:53.000000000","message":"would this app just process this flow or do something else?","commit_id":"5c279d216c60589dfa2addfb062bbc94c7b0317f"},{"author":{"_account_id":18347,"name":"Itamar Ofek","email":"itamofek@netscape.net","username":"itamaro"},"change_message_id":"17f103e20996705f585e13c08b6c53037f0412e4","unresolved":false,"context_lines":[{"line_number":52,"context_line":"is:"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"::"},{"line_number":55,"context_line":"    cookie\u003d0x0, duration\u003d498548.745s, table\u003d0, n_packets\u003d10, n_bytes\u003d864, idle_age\u003d65534, hard_age\u003d65534, priority\u003d100,in_port\u003d3 actions\u003dload:0x3-\u003eNXM_NX_REG6[],load:0x1-\u003eOXM_OF_METADATA[],resubmit(,1)"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"The classification application removes the relevant flows upon the"},{"line_number":58,"context_line":"removal of a port, i.e. on the callback `remove_local_port`."}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a71b18c_2ae22004","line":55,"in_reply_to":"5a74a57a_07bb790f","updated":"2016-12-01 14:31:07.000000000","message":"Maybe in the future","commit_id":"5c279d216c60589dfa2addfb062bbc94c7b0317f"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"d4509c7ac1d2ee0b75bb5b6fdae57592801735f5","unresolved":false,"context_lines":[{"line_number":29,"context_line":"application, enables clear, straightforward, readable, and reusable code"},{"line_number":30,"context_line":"that deals only with classification."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Reusability can be further {pushed forwards} by extracting common methods"},{"line_number":33,"context_line":"to a common locations and libraries."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Proposed Change"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3a71b18c_70a4d0a5","line":32,"range":{"start_line":32,"start_character":27,"end_line":32,"end_character":44},"updated":"2016-12-02 08:39:38.000000000","message":"Curly brackets?","commit_id":"b83ef39d82ba42368f051090c24ded2ac044739a"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"d4509c7ac1d2ee0b75bb5b6fdae57592801735f5","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Reusability can be further {pushed forwards} by extracting common methods"},{"line_number":33,"context_line":"to a common locations and libraries."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Proposed Change"},{"line_number":36,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"3a71b18c_10babcc0","line":34,"updated":"2016-12-02 08:39:38.000000000","message":"Perhaps add your response to @irenab here?","commit_id":"b83ef39d82ba42368f051090c24ded2ac044739a"},{"author":{"_account_id":18347,"name":"Itamar Ofek","email":"itamofek@netscape.net","username":"itamaro"},"change_message_id":"5fd3e610656eba2e60421090f286719389749085","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Reusability can be further {pushed forwards} by extracting common methods"},{"line_number":33,"context_line":"to a common locations and libraries."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Proposed Change"},{"line_number":36,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"3a71b18c_4ff2a070","line":34,"in_reply_to":"3a71b18c_10babcc0","updated":"2016-12-04 07:22:10.000000000","message":"The initial version will only extract classification code from L2App. However it can and should be further used for other classification scenarios such as NSH","commit_id":"b83ef39d82ba42368f051090c24ded2ac044739a"},{"author":{"_account_id":20287,"name":"hujie","email":"mike.hu@huawei.com","username":"hujie"},"change_message_id":"dac99d8f0d4df76875bec31cbe134a400e8d01e0","unresolved":false,"context_lines":[{"line_number":12,"context_line":"The classification is a separate processing which takes place throughout"},{"line_number":13,"context_line":"the port\u0027s life-cycle."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"When a packet enters the integration bridge, it is"},{"line_number":16,"context_line":"classified. Information, such as its network ID and source\u0027s unique port"},{"line_number":17,"context_line":"id are stored in the OVS metadata, i.e. in metadata field and registers."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"This information is then used by other Dragonflow applications throughout"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3a71b18c_088dfe7a","line":16,"range":{"start_line":15,"start_character":45,"end_line":16,"end_character":72},"updated":"2016-12-04 13:25:51.000000000","message":"nit: it seem there are still have enough space for the first line:)","commit_id":"d63895dbc4a047a92a168a04258589acadacde71"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"ad8f1e5b10b3fbfc3c8fea8d0f1e0f15becf0cff","unresolved":false,"context_lines":[{"line_number":71,"context_line":"* The new application will be reusable, regardless of which L2 application is"},{"line_number":72,"context_line":"  used"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"* The new application will be simple, and will contain only"},{"line_number":75,"context_line":"  classification-relevant code. This will improve readability and"},{"line_number":76,"context_line":"  maintainability."},{"line_number":77,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"3a71b18c_244c979d","line":74,"range":{"start_line":74,"start_character":6,"end_line":74,"end_character":21},"updated":"2016-12-05 08:49:39.000000000","message":"Do you suggest the new application to be extendable to add more classification attributes in the future: https://wiki.openstack.org/wiki/Neutron/CommonFlowClassifier#Overview","commit_id":"d63895dbc4a047a92a168a04258589acadacde71"},{"author":{"_account_id":18347,"name":"Itamar Ofek","email":"itamofek@netscape.net","username":"itamaro"},"change_message_id":"784d6fa7c16c71afa10b8575b48868c7fda38f65","unresolved":false,"context_lines":[{"line_number":71,"context_line":"* The new application will be reusable, regardless of which L2 application is"},{"line_number":72,"context_line":"  used"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"* The new application will be simple, and will contain only"},{"line_number":75,"context_line":"  classification-relevant code. This will improve readability and"},{"line_number":76,"context_line":"  maintainability."},{"line_number":77,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"3a71b18c_7fb29807","line":74,"range":{"start_line":74,"start_character":6,"end_line":74,"end_character":21},"in_reply_to":"3a71b18c_244c979d","updated":"2016-12-05 08:56:22.000000000","message":"Yes","commit_id":"d63895dbc4a047a92a168a04258589acadacde71"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"e53ae3808d8294e7a8282fde513616bbd76ad440","unresolved":false,"context_lines":[{"line_number":71,"context_line":"* The new application will be reusable, regardless of which L2 application is"},{"line_number":72,"context_line":"  used"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"* The new application will be simple, and will contain only"},{"line_number":75,"context_line":"  classification-relevant code. This will improve readability and"},{"line_number":76,"context_line":"  maintainability."},{"line_number":77,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"3a71b18c_9a7062de","line":74,"range":{"start_line":74,"start_character":6,"end_line":74,"end_character":21},"in_reply_to":"3a71b18c_7fb29807","updated":"2016-12-05 09:33:05.000000000","message":"May worth to add it to the spec","commit_id":"d63895dbc4a047a92a168a04258589acadacde71"},{"author":{"_account_id":23235,"name":"Lihi Wishnitzer","email":"lihiwish@gmail.com","username":"lihiwish"},"change_message_id":"b9f09566c9e5d77ce1cfd36783d251b786faf0e3","unresolved":false,"context_lines":[{"line_number":71,"context_line":"* The new application will be reusable, regardless of which L2 application is"},{"line_number":72,"context_line":"  used"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"* The new application will be simple, and will contain only"},{"line_number":75,"context_line":"  classification-relevant code. This will improve readability and"},{"line_number":76,"context_line":"  maintainability."},{"line_number":77,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"3a71b18c_f5496761","line":74,"range":{"start_line":74,"start_character":6,"end_line":74,"end_character":21},"in_reply_to":"3a71b18c_9a7062de","updated":"2016-12-05 09:42:39.000000000","message":"+1","commit_id":"d63895dbc4a047a92a168a04258589acadacde71"},{"author":{"_account_id":7805,"name":"Li Ma","email":"skywalker.nick@gmail.com","username":"Nick"},"change_message_id":"88e0f3fb53e26e0e2394a77ec83820b9d028e64a","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Classification App"},{"line_number":8,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":" https://blueprints.launchpad.net/dragonflow/+spec/classification-app"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"The classification is a separate processing which takes place throughout"},{"line_number":13,"context_line":"the port\u0027s life-cycle."}],"source_content_type":"text/x-rst","patch_set":5,"id":"3a71b18c_bfb0b044","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":1},"updated":"2016-12-10 03:07:40.000000000","message":"a space","commit_id":"ac3e58d9940ad5634a85a1237e791eca2e023381"},{"author":{"_account_id":7805,"name":"Li Ma","email":"skywalker.nick@gmail.com","username":"Nick"},"change_message_id":"88e0f3fb53e26e0e2394a77ec83820b9d028e64a","unresolved":false,"context_lines":[{"line_number":32,"context_line":"Reusability can be further pushed forwards by extracting common methods"},{"line_number":33,"context_line":"to a common locations and libraries."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"This change will allow appling classification at different points of packet"},{"line_number":36,"context_line":"processing in the future, for example to support NSH use cases."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Proposed Change"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3a71b18c_9fa7740a","line":35,"range":{"start_line":35,"start_character":23,"end_line":35,"end_character":30},"updated":"2016-12-10 03:07:40.000000000","message":"applying?","commit_id":"ac3e58d9940ad5634a85a1237e791eca2e023381"}]}