)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"70673acdee7f869966955f4e2e86f6f53b624b83","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"action + \"_\" + resource(single object)"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"action + \"_all_\" + resource(multi objects)"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"action:create/update/delete/get"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3a71b18c_a0d1c1cf","line":13,"updated":"2016-12-02 05:34:56.000000000","message":"Maybe make this action_all_resources? e.g. lswitch/all_lswitches, lrouter/all_lrouters, lport/all_lports?","commit_id":"bc25555cf1db6af12396ae6fe1700e799faa07d9"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"70673acdee7f869966955f4e2e86f6f53b624b83","unresolved":false,"context_lines":[{"line_number":18,"context_line":"lswitch/lport/lrouter/security_group/floatingip..."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: I55dd69d6b84a45b03ef7392280c8e8f75d7f5312"},{"line_number":21,"context_line":"Partial-bug: #1636888"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3a71b18c_a05aa181","line":21,"updated":"2016-12-02 05:34:56.000000000","message":"This means there will be other patches for the other types of resources?","commit_id":"bc25555cf1db6af12396ae6fe1700e799faa07d9"}],"dragonflow/db/api_nb.py":[{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"9d67d25ff2ddcfd24fc09b142b3332a8ff8db1b9","unresolved":false,"context_lines":[{"line_number":666,"context_line":"            res.append(db_models.SecurityGroup(secgroup_value))"},{"line_number":667,"context_line":"        return res"},{"line_number":668,"context_line":""},{"line_number":669,"context_line":"    def get_all_lswitches(self, topic\u003dNone):"},{"line_number":670,"context_line":"        res \u003d []"},{"line_number":671,"context_line":"        for lswitch_value in self.driver.get_all_entries("},{"line_number":672,"context_line":"                db_models.LogicalSwitch.table_name, topic):"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a71b18c_80d0d020","line":669,"range":{"start_line":669,"start_character":8,"end_line":669,"end_character":25},"updated":"2016-12-05 23:35:51.000000000","message":"I am wondering if we should change it to \"get_all_lswitch\"(get_all_lswitches is the right way from grammar), so that the functions can be fully dynamic(use tablename to construct all the methods).","commit_id":"6b747f216682fd578eaed313514c59229661ba1c"}],"dragonflow/db/db_store.py":[{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"e0053213f7d3b7f6d9978976a31101b188bdcb8c","unresolved":false,"context_lines":[{"line_number":250,"context_line":"    def get_security_group_keys(self, topic\u003dNone):"},{"line_number":251,"context_line":"        return self.keys(models.SecurityGroup.table_name, topic)"},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"    def get_all_lswitches(self, topic\u003dNone):"},{"line_number":254,"context_line":"        return self.values(models.LogicalSwitch.table_name, topic)"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"    def update_floatingip(self, floatingip_id, floatingip, topic\u003dNone):"},{"line_number":257,"context_line":"        self.set(models.Floatingip.table_name,"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a71b18c_2e23c6a8","line":254,"range":{"start_line":253,"start_character":0,"end_line":254,"end_character":66},"updated":"2016-12-09 03:20:32.000000000","message":"After checking dimak\u0027s work at api_nb, I think we can combine these two refactor together. They both do one thing, making the code more be uniform. So, maybe you can add a similar curd_helper here. After all, the curd of all the resources looks similar. And you can avoid the plural problems by using get_all method here.","commit_id":"3c153d7d269f851750bcb5de84f358f994a6baa2"}]}