)]}'
{"dragonflow/controller/l3_app.py":[{"author":{"_account_id":23766,"name":"Dima Kuznetsov","email":"dima.kuznetsov@toganetworks.com","username":"dimak"},"change_message_id":"80623c6631152e5077214f54c8c8f2a63d58335f","unresolved":false,"context_lines":[{"line_number":47,"context_line":"                                  const.EGRESS_TABLE)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    def router_updated(self, router, original_router):"},{"line_number":50,"context_line":"        if not original_router:"},{"line_number":51,"context_line":"            LOG.info(_LI(\"Logical Router created \u003d %s\"), router)"},{"line_number":52,"context_line":"            self._add_new_lrouter(router)"},{"line_number":53,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a71b18c_a258858b","line":50,"range":{"start_line":50,"start_character":8,"end_line":50,"end_character":31},"updated":"2016-12-05 16:07:04.000000000","message":"I think \u0027is None\u0027 condition is a bit better here.\n\nThough we always pass LogicalRouter or None here, this looks like we check if original_router is false or evaluated to false.","commit_id":"95739378d59b3b50f2ce40b827a06e5e3a040e65"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"e18f633235e056c27b7c258098f0667d3c6bc37d","unresolved":false,"context_lines":[{"line_number":47,"context_line":"                                  const.EGRESS_TABLE)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    def router_updated(self, router, original_router):"},{"line_number":50,"context_line":"        if not original_router:"},{"line_number":51,"context_line":"            LOG.info(_LI(\"Logical Router created \u003d %s\"), router)"},{"line_number":52,"context_line":"            self._add_new_lrouter(router)"},{"line_number":53,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a71b18c_1c7fd966","line":50,"range":{"start_line":50,"start_character":8,"end_line":50,"end_character":31},"in_reply_to":"3a71b18c_a258858b","updated":"2016-12-05 17:27:04.000000000","message":"Looks fine to me. If original_router is empty string, empty dict, list, or set, None, or 0, in any case it\u0027s not the previous router before modification.","commit_id":"95739378d59b3b50f2ce40b827a06e5e3a040e65"}],"dragonflow/db/api_nb.py":[{"author":{"_account_id":23766,"name":"Dima Kuznetsov","email":"dima.kuznetsov@toganetworks.com","username":"dimak"},"change_message_id":"80623c6631152e5077214f54c8c8f2a63d58335f","unresolved":false,"context_lines":[{"line_number":221,"context_line":"                secgroup_id \u003d key"},{"line_number":222,"context_line":"                self.controller.security_group_deleted(secgroup_id)"},{"line_number":223,"context_line":"        elif db_models.LogicalPort.table_name \u003d\u003d table:"},{"line_number":224,"context_line":"            if action \u003d\u003d \u0027set\u0027 or action \u003d\u003d \u0027create\u0027:"},{"line_number":225,"context_line":"                lport \u003d db_models.LogicalPort(value)"},{"line_number":226,"context_line":"                self.controller.logical_port_updated(lport)"},{"line_number":227,"context_line":"            elif action \u003d\u003d \u0027delete\u0027:"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a71b18c_02b05989","line":224,"range":{"start_line":224,"start_character":12,"end_line":224,"end_character":53},"updated":"2016-12-05 16:07:04.000000000","message":"Although it is all over the file, I think \n\n if action in (\u0027create\u0027, \u0027set\u0027)\n\nis a bit cleaner.","commit_id":"95739378d59b3b50f2ce40b827a06e5e3a040e65"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"e18f633235e056c27b7c258098f0667d3c6bc37d","unresolved":false,"context_lines":[{"line_number":221,"context_line":"                secgroup_id \u003d key"},{"line_number":222,"context_line":"                self.controller.security_group_deleted(secgroup_id)"},{"line_number":223,"context_line":"        elif db_models.LogicalPort.table_name \u003d\u003d table:"},{"line_number":224,"context_line":"            if action \u003d\u003d \u0027set\u0027 or action \u003d\u003d \u0027create\u0027:"},{"line_number":225,"context_line":"                lport \u003d db_models.LogicalPort(value)"},{"line_number":226,"context_line":"                self.controller.logical_port_updated(lport)"},{"line_number":227,"context_line":"            elif action \u003d\u003d \u0027delete\u0027:"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a71b18c_5cc31189","line":224,"range":{"start_line":224,"start_character":12,"end_line":224,"end_character":53},"in_reply_to":"3a71b18c_02b05989","updated":"2016-12-05 17:27:04.000000000","message":"I think this can be done in another patch, over the entire file.","commit_id":"95739378d59b3b50f2ce40b827a06e5e3a040e65"},{"author":{"_account_id":20287,"name":"hujie","email":"mike.hu@huawei.com","username":"hujie"},"change_message_id":"c29ff23fa8d6a65a662258a1aa757e72e989e25e","unresolved":false,"context_lines":[{"line_number":221,"context_line":"                secgroup_id \u003d key"},{"line_number":222,"context_line":"                self.controller.security_group_deleted(secgroup_id)"},{"line_number":223,"context_line":"        elif db_models.LogicalPort.table_name \u003d\u003d table:"},{"line_number":224,"context_line":"            if action \u003d\u003d \u0027set\u0027 or action \u003d\u003d \u0027create\u0027:"},{"line_number":225,"context_line":"                lport \u003d db_models.LogicalPort(value)"},{"line_number":226,"context_line":"                self.controller.logical_port_updated(lport)"},{"line_number":227,"context_line":"            elif action \u003d\u003d \u0027delete\u0027:"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a71b18c_8f763bd5","line":224,"range":{"start_line":224,"start_character":12,"end_line":224,"end_character":53},"in_reply_to":"3a71b18c_5cc31189","updated":"2016-12-06 02:44:24.000000000","message":"ok np","commit_id":"95739378d59b3b50f2ce40b827a06e5e3a040e65"}]}