)]}'
{"dragonflow/tests/unit/test_df_local_controller.py":[{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"2e033537d5c97d6f709f8b9955c1b78c9b6a5532","unresolved":false,"context_lines":[{"line_number":218,"context_line":"    @mock.patch.object(ryu_base_app.RyuDFAdapter,"},{"line_number":219,"context_line":"                       \u0027notify_associate_floatingip\u0027)"},{"line_number":220,"context_line":"    @mock.patch.object(db_store.DbStore, \u0027update_floatingip\u0027)"},{"line_number":221,"context_line":"    def test_associate_floatingip(self, mock_update, mock_notify):"},{"line_number":222,"context_line":"        lport_id \u003d \u0027fake_lport_id\u0027"},{"line_number":223,"context_line":"        fip_id \u003d \u0027fake_fip_id\u0027"},{"line_number":224,"context_line":"        fip \u003d self._get_mock_floatingip(lport_id, fip_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_79100a02","line":221,"range":{"start_line":221,"start_character":8,"end_line":221,"end_character":33},"updated":"2016-12-03 21:31:48.000000000","message":"You can ignore this comment...  Sometimes I think the original method name is correct, as we are testing \"_associate_floatingip\" here.  But this is trivial.","commit_id":"0b39275751395fb3f74bd578bb0e7f668ed1dcd6"},{"author":{"_account_id":20287,"name":"hujie","email":"mike.hu@huawei.com","username":"hujie"},"change_message_id":"ec27b68a73d8e2d2bbfa79017930a00b4225d87d","unresolved":false,"context_lines":[{"line_number":218,"context_line":"    @mock.patch.object(ryu_base_app.RyuDFAdapter,"},{"line_number":219,"context_line":"                       \u0027notify_associate_floatingip\u0027)"},{"line_number":220,"context_line":"    @mock.patch.object(db_store.DbStore, \u0027update_floatingip\u0027)"},{"line_number":221,"context_line":"    def test_associate_floatingip(self, mock_update, mock_notify):"},{"line_number":222,"context_line":"        lport_id \u003d \u0027fake_lport_id\u0027"},{"line_number":223,"context_line":"        fip_id \u003d \u0027fake_fip_id\u0027"},{"line_number":224,"context_line":"        fip \u003d self._get_mock_floatingip(lport_id, fip_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_bc2610cc","line":221,"range":{"start_line":221,"start_character":8,"end_line":221,"end_character":33},"in_reply_to":"3a71b18c_5cba5cc1","updated":"2016-12-04 03:54:38.000000000","message":"@wangjian, sorry, I did not notice it yet, but I think it looks strange to have \"__\" in test method, maybe we could wait for others\u0027 suggestion:)","commit_id":"0b39275751395fb3f74bd578bb0e7f668ed1dcd6"},{"author":{"_account_id":9044,"name":"Will","email":"wangjian.ika@bytedance.com","username":"Will"},"change_message_id":"f5e3705adace961497ec70df519cba97c7ebcec3","unresolved":false,"context_lines":[{"line_number":218,"context_line":"    @mock.patch.object(ryu_base_app.RyuDFAdapter,"},{"line_number":219,"context_line":"                       \u0027notify_associate_floatingip\u0027)"},{"line_number":220,"context_line":"    @mock.patch.object(db_store.DbStore, \u0027update_floatingip\u0027)"},{"line_number":221,"context_line":"    def test_associate_floatingip(self, mock_update, mock_notify):"},{"line_number":222,"context_line":"        lport_id \u003d \u0027fake_lport_id\u0027"},{"line_number":223,"context_line":"        fip_id \u003d \u0027fake_fip_id\u0027"},{"line_number":224,"context_line":"        fip \u003d self._get_mock_floatingip(lport_id, fip_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_5cba5cc1","line":221,"range":{"start_line":221,"start_character":8,"end_line":221,"end_character":33},"in_reply_to":"3a71b18c_79100a02","updated":"2016-12-04 02:15:29.000000000","message":"I think we have came to an agreement on this problem in this patch, line 112, so I prefer follow the agreement has been made.\nhttps://review.openstack.org/#/c/390083/6/dragonflow/tests/unit/test_df_local_controller.py,","commit_id":"0b39275751395fb3f74bd578bb0e7f668ed1dcd6"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"28022b4ba0b08c7ebfbaeee5d9991d059b495a81","unresolved":false,"context_lines":[{"line_number":218,"context_line":"    @mock.patch.object(ryu_base_app.RyuDFAdapter,"},{"line_number":219,"context_line":"                       \u0027notify_associate_floatingip\u0027)"},{"line_number":220,"context_line":"    @mock.patch.object(db_store.DbStore, \u0027update_floatingip\u0027)"},{"line_number":221,"context_line":"    def test_associate_floatingip(self, mock_update, mock_notify):"},{"line_number":222,"context_line":"        lport_id \u003d \u0027fake_lport_id\u0027"},{"line_number":223,"context_line":"        fip_id \u003d \u0027fake_fip_id\u0027"},{"line_number":224,"context_line":"        fip \u003d self._get_mock_floatingip(lport_id, fip_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_a44799ba","line":221,"range":{"start_line":221,"start_character":8,"end_line":221,"end_character":33},"in_reply_to":"3a71b18c_bc2610cc","updated":"2016-12-06 03:57:22.000000000","message":"I think double underline (\"__\") is better. This way it stresses that this is an internal function. Since testing is developer oriented, I prefer that to something that looks better, but is less accurate.\n\nNote that this test function specifically tests DfLocalController._associate_floatingip, and not the process of associating floating ips. I think the test name should reflect that.\n\nI think it would also be clearer for future contributors modifying _associate_floatingip and trying to understand the scope of this test.","commit_id":"0b39275751395fb3f74bd578bb0e7f668ed1dcd6"}]}