)]}'
{"dragonflow/controller/dhcp_app.py":[{"author":{"_account_id":13912,"name":"rajiv","email":"thenakliman@gmail.com","username":"rajiv.kumar"},"change_message_id":"39d90b35b381da1ff5a61910c50d6919daec0652","unresolved":false,"context_lines":[{"line_number":208,"context_line":"                                  src\u003ddhcp_server_address,"},{"line_number":209,"context_line":"                                  proto\u003dpkt_ipv4.proto))"},{"line_number":210,"context_line":"        dhcp_ack_pkt.add_protocol(udp.udp(src_port\u003d67, dst_port\u003d68))"},{"line_number":211,"context_line":"        dhcp_ack_pkt.add_protocol(dhcp.dhcp(op\u003dDHCP_ACK,"},{"line_number":212,"context_line":"                                            chaddr\u003dpkt_ethernet.src,"},{"line_number":213,"context_line":"                                            siaddr\u003ddhcp_server_address,"},{"line_number":214,"context_line":"                                            boot_file\u003ddhcp_packet.boot_file,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_7870f9dc","line":211,"updated":"2016-12-05 03:54:37.000000000","message":"I think, op\u003d2 is the correct value. op\u003d1 represents a request and op\u003d2 represents a reply. I used following references\nhttp://www.tcpipguide.com/free/t_DHCPMessageFormat.htm\nhttps://www.ietf.org/rfc/rfc2131.txt\nhttps://en.wikipedia.org/wiki/Dynamic_Host_Configuration_Protocol#DHCP_acknowledgement\n\nCan you please verify again at your end as well?","commit_id":"106810d5db0e6f950ded08620086662fbae3659e"},{"author":{"_account_id":13912,"name":"rajiv","email":"thenakliman@gmail.com","username":"rajiv.kumar"},"change_message_id":"4ec9d65bd2ef41b384eef83e6c0b785e80b6fc05","unresolved":false,"context_lines":[{"line_number":208,"context_line":"                                  src\u003ddhcp_server_address,"},{"line_number":209,"context_line":"                                  proto\u003dpkt_ipv4.proto))"},{"line_number":210,"context_line":"        dhcp_ack_pkt.add_protocol(udp.udp(src_port\u003d67, dst_port\u003d68))"},{"line_number":211,"context_line":"        dhcp_ack_pkt.add_protocol(dhcp.dhcp(op\u003dDHCP_ACK,"},{"line_number":212,"context_line":"                                            chaddr\u003dpkt_ethernet.src,"},{"line_number":213,"context_line":"                                            siaddr\u003ddhcp_server_address,"},{"line_number":214,"context_line":"                                            boot_file\u003ddhcp_packet.boot_file,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_f3442ab8","line":211,"in_reply_to":"3a71b18c_1391a647","updated":"2016-12-05 04:38:11.000000000","message":"I think, this change is not correct. Original value is correct therefore it worked earlier.\n\nCan you please check provided links? If my understanding is wrong, please let me know.","commit_id":"106810d5db0e6f950ded08620086662fbae3659e"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"abc816a8874161e2c5680deb4f902ad9a873c85d","unresolved":false,"context_lines":[{"line_number":208,"context_line":"                                  src\u003ddhcp_server_address,"},{"line_number":209,"context_line":"                                  proto\u003dpkt_ipv4.proto))"},{"line_number":210,"context_line":"        dhcp_ack_pkt.add_protocol(udp.udp(src_port\u003d67, dst_port\u003d68))"},{"line_number":211,"context_line":"        dhcp_ack_pkt.add_protocol(dhcp.dhcp(op\u003dDHCP_ACK,"},{"line_number":212,"context_line":"                                            chaddr\u003dpkt_ethernet.src,"},{"line_number":213,"context_line":"                                            siaddr\u003ddhcp_server_address,"},{"line_number":214,"context_line":"                                            boot_file\u003ddhcp_packet.boot_file,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_1391a647","line":211,"in_reply_to":"3a71b18c_7870f9dc","updated":"2016-12-05 04:31:18.000000000","message":"According to the code, it is the right thing here. I wonder why it works before.","commit_id":"106810d5db0e6f950ded08620086662fbae3659e"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"ada0bb15ddd726a08ad58965da7669d21685c63b","unresolved":false,"context_lines":[{"line_number":208,"context_line":"                                  src\u003ddhcp_server_address,"},{"line_number":209,"context_line":"                                  proto\u003dpkt_ipv4.proto))"},{"line_number":210,"context_line":"        dhcp_ack_pkt.add_protocol(udp.udp(src_port\u003d67, dst_port\u003d68))"},{"line_number":211,"context_line":"        dhcp_ack_pkt.add_protocol(dhcp.dhcp(op\u003dDHCP_ACK,"},{"line_number":212,"context_line":"                                            chaddr\u003dpkt_ethernet.src,"},{"line_number":213,"context_line":"                                            siaddr\u003ddhcp_server_address,"},{"line_number":214,"context_line":"                                            boot_file\u003ddhcp_packet.boot_file,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_e42d3fa9","line":211,"in_reply_to":"3a71b18c_f3442ab8","updated":"2016-12-05 08:50:39.000000000","message":"You are right, I mix up the op code and message type, it should be either 1(DHCP Request) or 2(DHCP Reply) so the original code is right.\n\nhttps://github.com/osrg/ryu/blob/a3c1a8e06bd6c487ee8d242e0039b0cf701da447/ryu/lib/packet/dhcp.py#L106","commit_id":"106810d5db0e6f950ded08620086662fbae3659e"}]}