)]}'
{"dragonflow/controller/df_db_objects_refresh.py":[{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"161ce6cbc2aad54b978d33d3155b0efac64efcdf","unresolved":false,"context_lines":[{"line_number":77,"context_line":"                                   df_controller.qos_policy_deleted))"},{"line_number":78,"context_line":"    items.append(DfObjectRefresher(\u0027Switches\u0027,"},{"line_number":79,"context_line":"                                   db_store.get_lswitch_keys,"},{"line_number":80,"context_line":"                                   nb_api.lswitch.get_all,"},{"line_number":81,"context_line":"                                   df_controller.logical_switch_updated,"},{"line_number":82,"context_line":"                                   df_controller.logical_switch_deleted))"},{"line_number":83,"context_line":"    items.append(DfObjectRefresher(\u0027Security Groups\u0027,"}],"source_content_type":"text/x-python","patch_set":10,"id":"3a71b18c_2b857806","line":80,"range":{"start_line":80,"start_character":35,"end_line":80,"end_character":58},"updated":"2016-12-09 02:55:29.000000000","message":"Maybe the comment should be in the parent patch, but I am thinking, can we use nb_api this way:\n\nnb_api.get_all(LogocalSwitch.table_name)\n\nnb_api.create(LogocalSwitch.table_name, param_list)\n\nSo, we can use nb_api as a dispatcher， and the code looks cleaner. What do you think?","commit_id":"bd7362fcd1dc23d9db080465b3eb2a323412e933"},{"author":{"_account_id":23766,"name":"Dima Kuznetsov","email":"dima.kuznetsov@toganetworks.com","username":"dimak"},"change_message_id":"6d87b437c019411dcb1cf8ec7c3598d9f479fe1f","unresolved":false,"context_lines":[{"line_number":77,"context_line":"                                   df_controller.qos_policy_deleted))"},{"line_number":78,"context_line":"    items.append(DfObjectRefresher(\u0027Switches\u0027,"},{"line_number":79,"context_line":"                                   db_store.get_lswitch_keys,"},{"line_number":80,"context_line":"                                   nb_api.lswitch.get_all,"},{"line_number":81,"context_line":"                                   df_controller.logical_switch_updated,"},{"line_number":82,"context_line":"                                   df_controller.logical_switch_deleted))"},{"line_number":83,"context_line":"    items.append(DfObjectRefresher(\u0027Security Groups\u0027,"}],"source_content_type":"text/x-python","patch_set":10,"id":"3a71b18c_fddce6e5","line":80,"range":{"start_line":80,"start_character":35,"end_line":80,"end_character":58},"in_reply_to":"3a71b18c_2b857806","updated":"2016-12-11 11:36:29.000000000","message":"We can do that although I\u0027m not sure I like better.\n\nIt is convenient when you\u0027re using the models anonymously (like in db consistency):\n\nfor model in [some, model, list]:\n    all_instances \u003d nb_api.get_all(model)\n\nAnd we can easily add some lookup for this.\n\nMost of the time we know which one we want and having a member dedicated to a specific model saves some effort.\n\nI don\u0027t oppose to having both but I think the present form should not be abandoned in favor of the suggested one.","commit_id":"bd7362fcd1dc23d9db080465b3eb2a323412e933"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"6dade089a2da8a00d995a882b07fa690a44e4cf8","unresolved":false,"context_lines":[{"line_number":77,"context_line":"                                   df_controller.qos_policy_deleted))"},{"line_number":78,"context_line":"    items.append(DfObjectRefresher(\u0027Switches\u0027,"},{"line_number":79,"context_line":"                                   db_store.get_lswitch_keys,"},{"line_number":80,"context_line":"                                   nb_api.lswitch.get_all,"},{"line_number":81,"context_line":"                                   df_controller.logical_switch_updated,"},{"line_number":82,"context_line":"                                   df_controller.logical_switch_deleted))"},{"line_number":83,"context_line":"    items.append(DfObjectRefresher(\u0027Security Groups\u0027,"}],"source_content_type":"text/x-python","patch_set":10,"id":"1a6eadb0_f1b6513c","line":80,"range":{"start_line":80,"start_character":35,"end_line":80,"end_character":58},"in_reply_to":"3a71b18c_fddce6e5","updated":"2016-12-13 02:26:01.000000000","message":"See my comment at https://review.openstack.org/#/c/407009","commit_id":"bd7362fcd1dc23d9db080465b3eb2a323412e933"}],"dragonflow/db/api_nb.py":[{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"d50a83d07f6932ccd43ef96e3423c9105c0a3339","unresolved":false,"context_lines":[{"line_number":840,"context_line":"            ]"},{"line_number":841,"context_line":"            self.update(**obj)"},{"line_number":842,"context_line":""},{"line_number":843,"context_line":"    class _LswitchCRUDHelper(_CRUDHelper):"},{"line_number":844,"context_line":"        def add_subnet(self, id, topic, version, subnet_id, **columns):"},{"line_number":845,"context_line":"            subnet \u003d {"},{"line_number":846,"context_line":"                \u0027id\u0027: subnet_id,"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a71b18c_1cb86774","line":843,"updated":"2016-12-07 08:31:07.000000000","message":"If we\u0027re already doing this, maybe create a CRUDHelper for subnets too?","commit_id":"81919c9801b20e2e9dde967cb221195359bc359c"},{"author":{"_account_id":23766,"name":"Dima Kuznetsov","email":"dima.kuznetsov@toganetworks.com","username":"dimak"},"change_message_id":"0bd6aee6fd38f47cb4bdc431bdc7b404f09f9cf3","unresolved":false,"context_lines":[{"line_number":840,"context_line":"            ]"},{"line_number":841,"context_line":"            self.update(**obj)"},{"line_number":842,"context_line":""},{"line_number":843,"context_line":"    class _LswitchCRUDHelper(_CRUDHelper):"},{"line_number":844,"context_line":"        def add_subnet(self, id, topic, version, subnet_id, **columns):"},{"line_number":845,"context_line":"            subnet \u003d {"},{"line_number":846,"context_line":"                \u0027id\u0027: subnet_id,"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a71b18c_e4dafb16","line":843,"in_reply_to":"3a71b18c_1cb86774","updated":"2016-12-08 09:23:37.000000000","message":"I thought of doing that but it takes out the bond between an lswitch and its subnet. Not sure which is better semantically.","commit_id":"81919c9801b20e2e9dde967cb221195359bc359c"}]}