)]}'
{"dragonflow/db/db_consistent.py":[{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"ea424eee61e835e1a60ed393b2a79382e4a678a0","unresolved":false,"context_lines":[{"line_number":218,"context_line":"            df_id \u003d df_object.get_id()"},{"line_number":219,"context_line":"            df_version \u003d df_object.get_version()"},{"line_number":220,"context_line":"            if not df_version:"},{"line_number":221,"context_line":"                LOG.error(_LE(\"Version is None in df_object: %s\"), df_object)"},{"line_number":222,"context_line":"                continue"},{"line_number":223,"context_line":"            local_object \u003d local_object_map.pop(df_id, None)"},{"line_number":224,"context_line":"            if local_object:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_47726312","side":"PARENT","line":221,"updated":"2016-12-11 23:43:50.000000000","message":"I think it is not to delete this error message just because publisher table doesn\u0027t have version. The log here is still usefull for other tables, when something about version goes wrong.","commit_id":"19242f23239780017218220eacd08dde2952f203"},{"author":{"_account_id":13912,"name":"rajiv","email":"thenakliman@gmail.com","username":"rajiv.kumar"},"change_message_id":"6fce49c543f606a4076df50c673e04127067d3a4","unresolved":false,"context_lines":[{"line_number":218,"context_line":"            df_id \u003d df_object.get_id()"},{"line_number":219,"context_line":"            df_version \u003d df_object.get_version()"},{"line_number":220,"context_line":"            if not df_version:"},{"line_number":221,"context_line":"                LOG.error(_LE(\"Version is None in df_object: %s\"), df_object)"},{"line_number":222,"context_line":"                continue"},{"line_number":223,"context_line":"            local_object \u003d local_object_map.pop(df_id, None)"},{"line_number":224,"context_line":"            if local_object:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6eadb0_89d449ec","side":"PARENT","line":221,"in_reply_to":"1a6eadb0_204e08c1","updated":"2016-12-16 15:59:28.000000000","message":"I do agree that message should be there but conditional. As pointed out by oanson, this message should appear in case, version exist in a table but it is none. If version does not exist, we should not report any error message. Because it is the expected behavior not an Error.","commit_id":"19242f23239780017218220eacd08dde2952f203"},{"author":{"_account_id":20287,"name":"hujie","email":"mike.hu@huawei.com","username":"hujie"},"change_message_id":"ac5bab5d6d1ff3c55a2ce57b7e1968508a12517e","unresolved":false,"context_lines":[{"line_number":218,"context_line":"            df_id \u003d df_object.get_id()"},{"line_number":219,"context_line":"            df_version \u003d df_object.get_version()"},{"line_number":220,"context_line":"            if not df_version:"},{"line_number":221,"context_line":"                LOG.error(_LE(\"Version is None in df_object: %s\"), df_object)"},{"line_number":222,"context_line":"                continue"},{"line_number":223,"context_line":"            local_object \u003d local_object_map.pop(df_id, None)"},{"line_number":224,"context_line":"            if local_object:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6eadb0_204e08c1","side":"PARENT","line":221,"in_reply_to":"1a6eadb0_5caeade6","updated":"2016-12-16 02:29:57.000000000","message":"yes, I keep this log because it is usefull not only for publisher but also for other resources which have no version by exception or in some special situations in our production environment :)","commit_id":"19242f23239780017218220eacd08dde2952f203"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"b23990f2644c33b15c2125d62b12c57011e513b9","unresolved":false,"context_lines":[{"line_number":218,"context_line":"            df_id \u003d df_object.get_id()"},{"line_number":219,"context_line":"            df_version \u003d df_object.get_version()"},{"line_number":220,"context_line":"            if not df_version:"},{"line_number":221,"context_line":"                LOG.error(_LE(\"Version is None in df_object: %s\"), df_object)"},{"line_number":222,"context_line":"                continue"},{"line_number":223,"context_line":"            local_object \u003d local_object_map.pop(df_id, None)"},{"line_number":224,"context_line":"            if local_object:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6eadb0_fcb2b805","side":"PARENT","line":221,"in_reply_to":"1a6eadb0_89d449ec","updated":"2016-12-18 13:28:13.000000000","message":"Consistency should be done only on objects with versions. Even if the object class doesn\u0027t have a version, there\u0027s still an error. (Although it might be a different one than the one here.)","commit_id":"19242f23239780017218220eacd08dde2952f203"},{"author":{"_account_id":13912,"name":"rajiv","email":"thenakliman@gmail.com","username":"rajiv.kumar"},"change_message_id":"4ea3bc422056fcc424a11fdd9b371f5933fc7e83","unresolved":false,"context_lines":[{"line_number":218,"context_line":"            df_id \u003d df_object.get_id()"},{"line_number":219,"context_line":"            df_version \u003d df_object.get_version()"},{"line_number":220,"context_line":"            if not df_version:"},{"line_number":221,"context_line":"                LOG.error(_LE(\"Version is None in df_object: %s\"), df_object)"},{"line_number":222,"context_line":"                continue"},{"line_number":223,"context_line":"            local_object \u003d local_object_map.pop(df_id, None)"},{"line_number":224,"context_line":"            if local_object:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_4bdb4d7c","side":"PARENT","line":221,"in_reply_to":"3a71b18c_47726312","updated":"2016-12-12 02:51:50.000000000","message":"do you think, we should check, whether a table has version or not and then generate error logs.","commit_id":"19242f23239780017218220eacd08dde2952f203"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"d895a0e117889f936097c0af081b72ae2652b603","unresolved":false,"context_lines":[{"line_number":218,"context_line":"            df_id \u003d df_object.get_id()"},{"line_number":219,"context_line":"            df_version \u003d df_object.get_version()"},{"line_number":220,"context_line":"            if not df_version:"},{"line_number":221,"context_line":"                LOG.error(_LE(\"Version is None in df_object: %s\"), df_object)"},{"line_number":222,"context_line":"                continue"},{"line_number":223,"context_line":"            local_object \u003d local_object_map.pop(df_id, None)"},{"line_number":224,"context_line":"            if local_object:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_eb0b39d3","side":"PARENT","line":221,"in_reply_to":"3a71b18c_4bdb4d7c","updated":"2016-12-12 02:59:15.000000000","message":"Maybe we can just ignore publisher here.","commit_id":"19242f23239780017218220eacd08dde2952f203"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"750305a8134a7d4474d0db4ae174cf6e34918aa6","unresolved":false,"context_lines":[{"line_number":218,"context_line":"            df_id \u003d df_object.get_id()"},{"line_number":219,"context_line":"            df_version \u003d df_object.get_version()"},{"line_number":220,"context_line":"            if not df_version:"},{"line_number":221,"context_line":"                LOG.error(_LE(\"Version is None in df_object: %s\"), df_object)"},{"line_number":222,"context_line":"                continue"},{"line_number":223,"context_line":"            local_object \u003d local_object_map.pop(df_id, None)"},{"line_number":224,"context_line":"            if local_object:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_aee94f1c","side":"PARENT","line":221,"in_reply_to":"3a71b18c_ab31410d","updated":"2016-12-12 03:41:03.000000000","message":"I meant we can ignore publisher in _compare_df_and_local_data, since it will not be refreshed anyway. See 7a892bafc3e08375ee8470cdd1cd4c4067aa5056","commit_id":"19242f23239780017218220eacd08dde2952f203"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"da9cfc65f96a304975c9bfebb29be3da3c519a24","unresolved":false,"context_lines":[{"line_number":218,"context_line":"            df_id \u003d df_object.get_id()"},{"line_number":219,"context_line":"            df_version \u003d df_object.get_version()"},{"line_number":220,"context_line":"            if not df_version:"},{"line_number":221,"context_line":"                LOG.error(_LE(\"Version is None in df_object: %s\"), df_object)"},{"line_number":222,"context_line":"                continue"},{"line_number":223,"context_line":"            local_object \u003d local_object_map.pop(df_id, None)"},{"line_number":224,"context_line":"            if local_object:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6eadb0_5caeade6","side":"PARENT","line":221,"in_reply_to":"3a71b18c_aee94f1c","updated":"2016-12-15 12:54:14.000000000","message":"This log message was very helpful detecting the issue with the publisher table here (which was removed). I would like to keep it. If a table doesn\u0027t have a version, it should not reach here. If it does have a version, but it\u0027s missing, there should be an error.","commit_id":"19242f23239780017218220eacd08dde2952f203"},{"author":{"_account_id":13912,"name":"rajiv","email":"thenakliman@gmail.com","username":"rajiv.kumar"},"change_message_id":"7954f019904defec7ef8e8e44047a284cb844594","unresolved":false,"context_lines":[{"line_number":218,"context_line":"            df_id \u003d df_object.get_id()"},{"line_number":219,"context_line":"            df_version \u003d df_object.get_version()"},{"line_number":220,"context_line":"            if not df_version:"},{"line_number":221,"context_line":"                LOG.error(_LE(\"Version is None in df_object: %s\"), df_object)"},{"line_number":222,"context_line":"                continue"},{"line_number":223,"context_line":"            local_object \u003d local_object_map.pop(df_id, None)"},{"line_number":224,"context_line":"            if local_object:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_ab31410d","side":"PARENT","line":221,"in_reply_to":"3a71b18c_eb0b39d3","updated":"2016-12-12 03:32:47.000000000","message":"You mean, it is ok, if errors are thrown.","commit_id":"19242f23239780017218220eacd08dde2952f203"}]}