)]}'
{"dragonflow/neutron/services/qos/notification_drivers/df_qos_notification_driver.py":[{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"645fad5501243b27462cb715eeee5747841bc1d5","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        policy_id \u003d policy[\u0027id\u0027]"},{"line_number":66,"context_line":"        # Only id will be in policy in the argument. Get full policy from"},{"line_number":67,"context_line":"        # nb db."},{"line_number":68,"context_line":"        policy_obj \u003d self.nb_api.get_qos_policy(policy_id)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        self.nb_api.delete_qos_policy(policy_id, policy_obj.get_topic())"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6eadb0_72df1f0d","line":70,"range":{"start_line":68,"start_character":0,"end_line":70,"end_character":72},"updated":"2016-12-15 09:39:58.000000000","message":"Getting the policy just to be able to delete it by topic seems redundant. Why not just delete directly by id?","commit_id":"2b1a74afec8a8409ba4e8410c0fa3543fa320796"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"7835b96df270664862f5c04f6fdd4ae6d17394a1","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        policy_id \u003d policy[\u0027id\u0027]"},{"line_number":66,"context_line":"        # Only id will be in policy in the argument. Get full policy from"},{"line_number":67,"context_line":"        # nb db."},{"line_number":68,"context_line":"        policy_obj \u003d self.nb_api.get_qos_policy(policy_id)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        self.nb_api.delete_qos_policy(policy_id, policy_obj.get_topic())"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6eadb0_eda512a2","line":70,"range":{"start_line":68,"start_character":0,"end_line":70,"end_character":72},"in_reply_to":"1a6eadb0_72df1f0d","updated":"2016-12-15 09:56:01.000000000","message":"Because some nb db driver(i.e. redis) only support deletion with complete key. If the topic is not specified, the key can\u0027t be complete. And there will be a notification which also needs topic, in delete operation.","commit_id":"2b1a74afec8a8409ba4e8410c0fa3543fa320796"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"00d41a156190d7bff09ef14df8e4bbb7ec6cd9c3","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        policy_id \u003d policy[\u0027id\u0027]"},{"line_number":66,"context_line":"        # Only id will be in policy in the argument. Get full policy from"},{"line_number":67,"context_line":"        # nb db."},{"line_number":68,"context_line":"        policy_obj \u003d self.nb_api.get_qos_policy(policy_id)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        self.nb_api.delete_qos_policy(policy_id, policy_obj.get_topic())"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6eadb0_227b302b","line":70,"range":{"start_line":68,"start_character":0,"end_line":70,"end_character":72},"in_reply_to":"1a6eadb0_eda512a2","updated":"2016-12-18 07:21:11.000000000","message":"Sounds like a bug in Redis. The topic is supposed to be an optional optimisation. Guess we\u0027ll have to fix that later.","commit_id":"2b1a74afec8a8409ba4e8410c0fa3543fa320796"}]}