)]}'
{"dragonflow/neutron/ml2/mech_driver.py":[{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"0c24ddd78141e1b1b11147f543a90162cf7e07f6","unresolved":false,"context_lines":[{"line_number":574,"context_line":"        # Here we do not want port status update to trigger"},{"line_number":575,"context_line":"        # sending event to other compute node."},{"line_number":576,"context_line":"        if (cfg.CONF.df.enable_port_status_notifier and"},{"line_number":577,"context_line":"           n_const.DEVICE_OWNER_COMPUTE_PREFIX"},{"line_number":578,"context_line":"           in updated_port[\u0027device_owner\u0027] and"},{"line_number":579,"context_line":"           context.status !\u003d context.original_status and"},{"line_number":580,"context_line":"           (context.status \u003d\u003d n_const.PORT_STATUS_DOWN or"},{"line_number":581,"context_line":"           context.status \u003d\u003d n_const.PORT_STATUS_ACTIVE)):"},{"line_number":582,"context_line":"            return None"},{"line_number":583,"context_line":""},{"line_number":584,"context_line":"        # If a subnet enabled dhcp, the DFMechDriver will create a dhcp server"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6eadb0_f44ddf3e","line":581,"range":{"start_line":577,"start_character":0,"end_line":581,"end_character":58},"updated":"2016-12-15 08:50:09.000000000","message":"This indention looks weird, try to make another 4 spaces for these lines(which is also pep8\u0027s suggestion)\n\nhttps://www.python.org/dev/peps/pep-0008/#indentation","commit_id":"8b31014a0394c5152bd3d39e876ed1eb609744a0"}],"dragonflow/tests/fullstack/test_l2_flows.py":[{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"0c24ddd78141e1b1b11147f543a90162cf7e07f6","unresolved":false,"context_lines":[{"line_number":185,"context_line":"                    if ingress_action in flow[\u0027actions\u0027]:"},{"line_number":186,"context_line":"                        ingress_check \u003d True"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"        if l2_lookup_multicast_check is None or \\"},{"line_number":189,"context_line":"           l2_lookup_unicast_check is None or \\"},{"line_number":190,"context_line":"           ingress_check is None:"},{"line_number":191,"context_line":"            return None"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"        return True"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6eadb0_14209b47","line":190,"range":{"start_line":188,"start_character":0,"end_line":190,"end_character":33},"updated":"2016-12-15 08:50:09.000000000","message":"If you are changing here, try this\n\nif (l2_lookup_multicast_check is None or\n        l2_lookup_unicast_check is None or\n        ingress_check is None):","commit_id":"8b31014a0394c5152bd3d39e876ed1eb609744a0"},{"author":{"_account_id":23766,"name":"Dima Kuznetsov","email":"dima.kuznetsov@toganetworks.com","username":"dimak"},"change_message_id":"de61ef7860b15d7d26a95fdd14b21f74d4696a01","unresolved":false,"context_lines":[{"line_number":185,"context_line":"                    if ingress_action in flow[\u0027actions\u0027]:"},{"line_number":186,"context_line":"                        ingress_check \u003d True"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"        if l2_lookup_multicast_check is None or \\"},{"line_number":189,"context_line":"           l2_lookup_unicast_check is None or \\"},{"line_number":190,"context_line":"           ingress_check is None:"},{"line_number":191,"context_line":"            return None"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"        return True"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6eadb0_2d4d4ac4","line":190,"range":{"start_line":188,"start_character":0,"end_line":190,"end_character":33},"in_reply_to":"1a6eadb0_14209b47","updated":"2016-12-15 09:59:21.000000000","message":"Ultimately its a matter of taste, I find \n \n if (\n     expressions\n ):\n     code\n\nmore visually pleasant","commit_id":"8b31014a0394c5152bd3d39e876ed1eb609744a0"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"0c24ddd78141e1b1b11147f543a90162cf7e07f6","unresolved":false,"context_lines":[{"line_number":250,"context_line":"                    if ingress_action in flow[\u0027actions\u0027]:"},{"line_number":251,"context_line":"                        ingress_check \u003d True"},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"        if l2_lookup_multicast_check is None or \\"},{"line_number":254,"context_line":"           l2_lookup_unicast_check is None or \\"},{"line_number":255,"context_line":"           l2_lookup_unkown_check is None or \\"},{"line_number":256,"context_line":"           egress_check is None or \\"},{"line_number":257,"context_line":"           ingress_check is None:"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"            return None"},{"line_number":260,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6eadb0_74d54f1a","line":257,"range":{"start_line":253,"start_character":0,"end_line":257,"end_character":33},"updated":"2016-12-15 08:50:09.000000000","message":"same comment here.","commit_id":"8b31014a0394c5152bd3d39e876ed1eb609744a0"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"1f1869c69ce84da62d0a367c59d5e689fb957b37","unresolved":false,"context_lines":[{"line_number":370,"context_line":"                    if ingress_action in flow[\u0027actions\u0027]:"},{"line_number":371,"context_line":"                        ingress_check \u003d True"},{"line_number":372,"context_line":""},{"line_number":373,"context_line":"        if l2_lookup_multicast_check is None or \\"},{"line_number":374,"context_line":"           l2_lookup_unicast_check is None or \\"},{"line_number":375,"context_line":"           l2_lookup_unkown_check is None or \\"},{"line_number":376,"context_line":"           egress_check is None or \\"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6eadb0_f2fb2fbf","line":373,"updated":"2016-12-15 09:35:29.000000000","message":"This is inconsistent with the changes above.\n\nIn any case, if we\u0027re already here, maybe wrap these conditions in brackets rather than escaping the newline (above too)? (Like Hong HUi Xiao suggested)","commit_id":"fa762138c8d11deef2e216a573a2ed520bcef8e1"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"e4e706cd9ead35a0a64ed2d281333d3847d06d07","unresolved":false,"context_lines":[{"line_number":185,"context_line":"                    if ingress_action in flow[\u0027actions\u0027]:"},{"line_number":186,"context_line":"                        ingress_check \u003d True"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"        if l2_lookup_multicast_check is None or \\"},{"line_number":189,"context_line":"                l2_lookup_unicast_check is None or \\"},{"line_number":190,"context_line":"                ingress_check is None:"},{"line_number":191,"context_line":"            return None"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"        return True"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a6eadb0_4d8fe6cb","line":190,"range":{"start_line":188,"start_character":0,"end_line":190,"end_character":38},"updated":"2016-12-15 10:01:28.000000000","message":"pls follow the style below(line 373).","commit_id":"6ff11d0b0120c5504c2016aac4739b990b8aa599"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"e4e706cd9ead35a0a64ed2d281333d3847d06d07","unresolved":false,"context_lines":[{"line_number":250,"context_line":"                    if ingress_action in flow[\u0027actions\u0027]:"},{"line_number":251,"context_line":"                        ingress_check \u003d True"},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"        if l2_lookup_multicast_check is None or \\"},{"line_number":254,"context_line":"                l2_lookup_unicast_check is None or \\"},{"line_number":255,"context_line":"                l2_lookup_unkown_check is None or \\"},{"line_number":256,"context_line":"                egress_check is None or \\"},{"line_number":257,"context_line":"                ingress_check is None:"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"            return None"},{"line_number":260,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1a6eadb0_6dbe6266","line":257,"range":{"start_line":253,"start_character":0,"end_line":257,"end_character":38},"updated":"2016-12-15 10:01:28.000000000","message":"pls follow the style below(line 373).","commit_id":"6ff11d0b0120c5504c2016aac4739b990b8aa599"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"e4e706cd9ead35a0a64ed2d281333d3847d06d07","unresolved":false,"context_lines":[{"line_number":370,"context_line":"                    if ingress_action in flow[\u0027actions\u0027]:"},{"line_number":371,"context_line":"                        ingress_check \u003d True"},{"line_number":372,"context_line":""},{"line_number":373,"context_line":"        if (l2_lookup_multicast_check is None or \\"},{"line_number":374,"context_line":"                l2_lookup_unicast_check is None or \\"},{"line_number":375,"context_line":"                l2_lookup_unkown_check is None or \\"},{"line_number":376,"context_line":"                egress_check is None or \\"},{"line_number":377,"context_line":"                ingress_check is None):"},{"line_number":378,"context_line":"            return None"},{"line_number":379,"context_line":"        return True"},{"line_number":380,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1a6eadb0_ed04324b","line":377,"range":{"start_line":373,"start_character":0,"end_line":377,"end_character":39},"updated":"2016-12-15 10:01:28.000000000","message":"If you are using brackets, you can remove the line breaker \"\\\" in the tail of each line.","commit_id":"6ff11d0b0120c5504c2016aac4739b990b8aa599"}]}