)]}'
{"dragonflow/controller/sg_app.py":[{"author":{"_account_id":20287,"name":"hujie","email":"mike.hu@huawei.com","username":"hujie"},"change_message_id":"36af1605f2842e42a5c54ecd4e6a36c8f322128f","unresolved":false,"context_lines":[{"line_number":885,"context_line":"            return"},{"line_number":886,"context_line":""},{"line_number":887,"context_line":"        secgroup_id \u003d secgroup.get_id()"},{"line_number":888,"context_line":"        if self._is_sg_not_associated_with_local_port(secgroup_id):"},{"line_number":889,"context_line":"            LOG.debug(\"Security group %s wasn\u0027t associated with a local port\","},{"line_number":890,"context_line":"                      secgroup_id)"},{"line_number":891,"context_line":"            return"},{"line_number":892,"context_line":""},{"line_number":893,"context_line":"        LOG.info(_LI(\"Add a rule %(rule)s to security group %(secgroup)s\"),"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6eadb0_f463a43f","line":890,"range":{"start_line":888,"start_character":8,"end_line":890,"end_character":34},"updated":"2016-12-19 07:45:57.000000000","message":"I saw some places which invoke this method will print the log, but some places not, what\u0027s the distinguish? If all the places need the log, you can put the debug into the method.","commit_id":"9231560b9c5e95ed9848a6c065981fc6f353462d"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"1cbf9dbf94df78e25447cbf5d75d8ef31aca4921","unresolved":false,"context_lines":[{"line_number":885,"context_line":"            return"},{"line_number":886,"context_line":""},{"line_number":887,"context_line":"        secgroup_id \u003d secgroup.get_id()"},{"line_number":888,"context_line":"        if self._is_sg_not_associated_with_local_port(secgroup_id):"},{"line_number":889,"context_line":"            LOG.debug(\"Security group %s wasn\u0027t associated with a local port\","},{"line_number":890,"context_line":"                      secgroup_id)"},{"line_number":891,"context_line":"            return"},{"line_number":892,"context_line":""},{"line_number":893,"context_line":"        LOG.info(_LI(\"Add a rule %(rule)s to security group %(secgroup)s\"),"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6eadb0_ffbffd5d","line":890,"range":{"start_line":888,"start_character":8,"end_line":890,"end_character":34},"in_reply_to":"1a6eadb0_f463a43f","updated":"2016-12-19 08:09:13.000000000","message":"Print log in all places will be redundant, I just add log to the public method and let the private methods(heading with _) just return.","commit_id":"9231560b9c5e95ed9848a6c065981fc6f353462d"}]}