)]}'
{"dragonflow/tests/common/app_testing_objects.py":[{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"2240a94d354ea390782fe4a8d4005e7c63570e2c","unresolved":false,"context_lines":[{"line_number":22,"context_line":"from neutron.agent.common import utils"},{"line_number":23,"context_line":"from oslo_log import log"},{"line_number":24,"context_line":"import pytun"},{"line_number":25,"context_line":"import ryu.lib.packet as r_packet"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"from dragonflow._i18n import _LI, _LE"},{"line_number":28,"context_line":"from dragonflow.common import utils as d_utils"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6eadb0_6857c726","line":25,"range":{"start_line":25,"start_character":0,"end_line":25,"end_character":33},"updated":"2016-12-18 12:36:35.000000000","message":"Why not just: from ryu.lib.packet import packet ? \u0027packet\u0027 symbol isn\u0027t used in the changed method.","commit_id":"e04a280814a175eea18b602ac57e2c4cec3abadc"},{"author":{"_account_id":23235,"name":"Lihi Wishnitzer","email":"lihiwish@gmail.com","username":"lihiwish"},"change_message_id":"8cf475952690a615de99cf78a5d66ab57fefc7a3","unresolved":false,"context_lines":[{"line_number":22,"context_line":"from neutron.agent.common import utils"},{"line_number":23,"context_line":"from oslo_log import log"},{"line_number":24,"context_line":"import pytun"},{"line_number":25,"context_line":"import ryu.lib.packet as r_packet"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"from dragonflow._i18n import _LI, _LE"},{"line_number":28,"context_line":"from dragonflow.common import utils as d_utils"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6eadb0_dc617caa","line":25,"range":{"start_line":25,"start_character":0,"end_line":25,"end_character":33},"in_reply_to":"1a6eadb0_6857c726","updated":"2016-12-18 13:15:37.000000000","message":"Since not only the ryu.lib.packet.packet module is being used, I want to import the entire folder.\nHowever I changed the line to \u0027from ryu.lib import packet\u0027 in order to use the \u0027packet\u0027 symbol","commit_id":"e04a280814a175eea18b602ac57e2c4cec3abadc"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"c7773750e328a4ff239f09fed5554f81c8434dcf","unresolved":false,"context_lines":[{"line_number":22,"context_line":"from neutron.agent.common import utils"},{"line_number":23,"context_line":"from oslo_log import log"},{"line_number":24,"context_line":"import pytun"},{"line_number":25,"context_line":"from ryu.lib import packet"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"from dragonflow._i18n import _LI, _LE"},{"line_number":28,"context_line":"from dragonflow.common import utils as d_utils"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6eadb0_fcae3880","line":25,"updated":"2016-12-18 13:44:41.000000000","message":"Why not just?:\nfrom ryu.lib.packet import packet\n\nThen you wouldn\u0027t need to call packet.packet.Packet.","commit_id":"fffa7f595627967b75a01f0a7250068e0daba9b2"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"2ef3951a3eed2052e658aa5a3a224b14eba4784b","unresolved":false,"context_lines":[{"line_number":22,"context_line":"from neutron.agent.common import utils"},{"line_number":23,"context_line":"from oslo_log import log"},{"line_number":24,"context_line":"import pytun"},{"line_number":25,"context_line":"from ryu.lib import packet"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"from dragonflow._i18n import _LI, _LE"},{"line_number":28,"context_line":"from dragonflow.common import utils as d_utils"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6eadb0_15bae76e","line":25,"in_reply_to":"1a6eadb0_32ae19e8","updated":"2016-12-18 23:04:11.000000000","message":"I think Omer is right here. It is not usually to import a package(which is ryu.lib.packet here).  It is usually to import a modules.","commit_id":"fffa7f595627967b75a01f0a7250068e0daba9b2"},{"author":{"_account_id":23766,"name":"Dima Kuznetsov","email":"dima.kuznetsov@toganetworks.com","username":"dimak"},"change_message_id":"09a9a4c75ec76a0e44bdc4326501315c358e3ebf","unresolved":false,"context_lines":[{"line_number":22,"context_line":"from neutron.agent.common import utils"},{"line_number":23,"context_line":"from oslo_log import log"},{"line_number":24,"context_line":"import pytun"},{"line_number":25,"context_line":"from ryu.lib import packet"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"from dragonflow._i18n import _LI, _LE"},{"line_number":28,"context_line":"from dragonflow.common import utils as d_utils"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6eadb0_bf72f2ae","line":25,"in_reply_to":"1a6eadb0_bc5e8077","updated":"2016-12-18 15:01:25.000000000","message":"from ryu.lib.packet import (\n     arp,\n     icmp,\n     icmpv6,\n     ...\n )","commit_id":"fffa7f595627967b75a01f0a7250068e0daba9b2"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"7e0039db7dc61f85766e10593ea53f2a128311e4","unresolved":false,"context_lines":[{"line_number":22,"context_line":"from neutron.agent.common import utils"},{"line_number":23,"context_line":"from oslo_log import log"},{"line_number":24,"context_line":"import pytun"},{"line_number":25,"context_line":"from ryu.lib import packet"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"from dragonflow._i18n import _LI, _LE"},{"line_number":28,"context_line":"from dragonflow.common import utils as d_utils"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6eadb0_32ae19e8","line":25,"in_reply_to":"1a6eadb0_bf72f2ae","updated":"2016-12-18 18:03:14.000000000","message":"Actually, please only import one module per line. See http://docs.openstack.org/developer/hacking/ (H301).\n\nfrom ryu.lib.packet import arp\nfrom ryu.lib.packet import icmp\nfrom ryu.lib.packet import icmpv6\nfrom ryu.lib.packet import packet\n...","commit_id":"fffa7f595627967b75a01f0a7250068e0daba9b2"},{"author":{"_account_id":23235,"name":"Lihi Wishnitzer","email":"lihiwish@gmail.com","username":"lihiwish"},"change_message_id":"f8560013a4c108c707d390574f1a94c647a7252f","unresolved":false,"context_lines":[{"line_number":22,"context_line":"from neutron.agent.common import utils"},{"line_number":23,"context_line":"from oslo_log import log"},{"line_number":24,"context_line":"import pytun"},{"line_number":25,"context_line":"from ryu.lib import packet"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"from dragonflow._i18n import _LI, _LE"},{"line_number":28,"context_line":"from dragonflow.common import utils as d_utils"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6eadb0_bc5e8077","line":25,"in_reply_to":"1a6eadb0_fcae3880","updated":"2016-12-18 14:14:06.000000000","message":"Because packet.arp, packet.icmp, packet.icmpv6, packet.dhcp, and packet.ipv6 are also being used","commit_id":"fffa7f595627967b75a01f0a7250068e0daba9b2"}]}