)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"8c42583d11053e7984460644fb6bef2956c269b3","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2017-02-08 15:29:39 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"tunneling app spec"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ia9e3bb9d13c290d5c30ac9937eb9452c79e026c4"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"1a430d35_8ff6ec8c","line":8,"updated":"2017-02-09 06:06:41.000000000","message":"please link to launchpad bp","commit_id":"535efc27cf3a03938a6869021401b7db18cc62b5"}],"doc/source/specs/tunneling_app.rst":[{"author":{"_account_id":23235,"name":"Lihi Wishnitzer","email":"lihiwish@gmail.com","username":"lihiwish"},"change_message_id":"b531dd7ac64850d39e802f926093c3ab80b241ac","unresolved":false,"context_lines":[{"line_number":3,"context_line":""},{"line_number":4,"context_line":" http://creativecommons.org/licenses/by/3.0/legalcode"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":7,"context_line":"Tunneling App"},{"line_number":8,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":9,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"7a3c09a3_eed946f4","line":6,"range":{"start_line":6,"start_character":13,"end_line":6,"end_character":18},"updated":"2017-01-18 08:32:48.000000000","message":"Unnecessary \u003d","commit_id":"d69f70d59ceb81b786cc48a9183792110aa03d45"},{"author":{"_account_id":23235,"name":"Lihi Wishnitzer","email":"lihiwish@gmail.com","username":"lihiwish"},"change_message_id":"b531dd7ac64850d39e802f926093c3ab80b241ac","unresolved":false,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":7,"context_line":"Tunneling App"},{"line_number":8,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":" https://blueprints.launchpad.net/dragonflow/+spec/Tunneling-app"},{"line_number":11,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"7a3c09a3_ee006636","line":8,"range":{"start_line":8,"start_character":13,"end_line":8,"end_character":18},"updated":"2017-01-18 08:32:48.000000000","message":"Unnecessary \u003d","commit_id":"d69f70d59ceb81b786cc48a9183792110aa03d45"},{"author":{"_account_id":23235,"name":"Lihi Wishnitzer","email":"lihiwish@gmail.com","username":"lihiwish"},"change_message_id":"b531dd7ac64850d39e802f926093c3ab80b241ac","unresolved":false,"context_lines":[{"line_number":9,"context_line":""},{"line_number":10,"context_line":" https://blueprints.launchpad.net/dragonflow/+spec/Tunneling-app"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"The tunneling  app is taking care for the processing of segmented overlay"},{"line_number":13,"context_line":"networks."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Tunneling Application is responsible for creating and updating overlay"}],"source_content_type":"text/x-rst","patch_set":1,"id":"7a3c09a3_8ec9a2ae","line":12,"range":{"start_line":12,"start_character":13,"end_line":12,"end_character":14},"updated":"2017-01-18 08:32:48.000000000","message":"Extra space","commit_id":"d69f70d59ceb81b786cc48a9183792110aa03d45"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"feaae46f06aea0d8c4afa59e31abb93f9b520a34","unresolved":false,"context_lines":[{"line_number":13,"context_line":"networks."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Tunneling Application is responsible for creating and updating overlay"},{"line_number":16,"context_line":"connectivity with other compute hosts a.k.a chasis."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Problem Description"},{"line_number":19,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba5201f7_deb2b0e4","line":16,"range":{"start_line":16,"start_character":44,"end_line":16,"end_character":50},"updated":"2017-01-12 01:52:44.000000000","message":"chassis","commit_id":"d69f70d59ceb81b786cc48a9183792110aa03d45"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"feaae46f06aea0d8c4afa59e31abb93f9b520a34","unresolved":false,"context_lines":[{"line_number":22,"context_line":"The tunneling related flows are set when either local or remote port is updated."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Upon VM port creation, its properties such as it\u0027s overlay network membership,"},{"line_number":25,"context_line":"ports database id is used to match flows to/from it. "},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"* metadata \u003c- Unique network ID"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba5201f7_3ec2dc34","line":25,"range":{"start_line":25,"start_character":52,"end_line":25,"end_character":53},"updated":"2017-01-12 01:52:44.000000000","message":"tailing space","commit_id":"d69f70d59ceb81b786cc48a9183792110aa03d45"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"80ee40e78dddad220950884277abc2c5f5399ab5","unresolved":false,"context_lines":[{"line_number":24,"context_line":"Upon VM port creation, its properties such as it\u0027s overlay network membership,"},{"line_number":25,"context_line":"ports database id is used to match flows to/from it. "},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"* metadata \u003c- Unique network ID"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"::"},{"line_number":30,"context_line":"   (neutron) net-list"}],"source_content_type":"text/x-rst","patch_set":1,"id":"7a3c09a3_e13005eb","line":27,"range":{"start_line":27,"start_character":0,"end_line":27,"end_character":31},"updated":"2017-01-15 09:27:20.000000000","message":"To what is this bullet connected? If it\u0027s the paragraph above, where is the of the information, e.g. port id?","commit_id":"d69f70d59ceb81b786cc48a9183792110aa03d45"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"80ee40e78dddad220950884277abc2c5f5399ab5","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"* metadata \u003c- Unique network ID"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"::"},{"line_number":30,"context_line":"   (neutron) net-list"},{"line_number":31,"context_line":"   +--------------------------------------+---------------+----------------------------------------------------+"},{"line_number":32,"context_line":"   | id                                   | name          | subnets                                            |"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a57fde8_1b877e10","line":29,"updated":"2017-01-15 09:27:20.000000000","message":"You need a space after the \u0027::\u0027 line.","commit_id":"d69f70d59ceb81b786cc48a9183792110aa03d45"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"feaae46f06aea0d8c4afa59e31abb93f9b520a34","unresolved":false,"context_lines":[{"line_number":57,"context_line":"::"},{"line_number":58,"context_line":"   dump-flows  br-int table\u003d0"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"   table\u003d0, priority\u003d100,tun_id\u003d0x13 actions\u003dload:0x3-\u003eOXM_OF_METADATA[],resubmit(,7)"},{"line_number":61,"context_line":"   table\u003d0, priority\u003d100,tun_id\u003d0x49 actions\u003dload:0x1-\u003eOXM_OF_METADATA[],resubmit(,7)"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"In the ingress port lookup table, 7 a match is done according to unique "}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba5201f7_9e6908fc","line":60,"range":{"start_line":60,"start_character":0,"end_line":60,"end_character":85},"updated":"2017-01-12 01:52:44.000000000","message":"With the support of virtual tunnel port(merged), the in_port match will be added here. The in_port will match the tunnel port of specific tunnel.","commit_id":"d69f70d59ceb81b786cc48a9183792110aa03d45"},{"author":{"_account_id":23235,"name":"Lihi Wishnitzer","email":"lihiwish@gmail.com","username":"lihiwish"},"change_message_id":"b531dd7ac64850d39e802f926093c3ab80b241ac","unresolved":false,"context_lines":[{"line_number":63,"context_line":"In the ingress port lookup table, 7 a match is done according to unique "},{"line_number":64,"context_line":"network id and vm\u0027s port mac, where vm\u0027s port key is set into reg7, and sent to"},{"line_number":65,"context_line":"table 72 is the ingress conn-track table which passes the packet to ingress"},{"line_number":66,"context_line":"dispatch table  "},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"* reg7 \u003c- Unique port key"},{"line_number":69,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"7a3c09a3_4e3a5a9a","line":66,"range":{"start_line":66,"start_character":14,"end_line":66,"end_character":16},"updated":"2017-01-18 08:32:48.000000000","message":"Trailing spaces","commit_id":"d69f70d59ceb81b786cc48a9183792110aa03d45"},{"author":{"_account_id":23235,"name":"Lihi Wishnitzer","email":"lihiwish@gmail.com","username":"lihiwish"},"change_message_id":"b531dd7ac64850d39e802f926093c3ab80b241ac","unresolved":false,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":"Egress Proccessing"},{"line_number":84,"context_line":"------------------"},{"line_number":85,"context_line":"A classification flow related to egress dispatching  is set to be initially"},{"line_number":86,"context_line":"filtered by the security table the flow sets port key and network id to reg6 "},{"line_number":87,"context_line":"and metadata ovs registers"},{"line_number":88,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"7a3c09a3_4b66cc2a","line":85,"range":{"start_line":85,"start_character":52,"end_line":85,"end_character":53},"updated":"2017-01-18 08:32:48.000000000","message":"Double space","commit_id":"d69f70d59ceb81b786cc48a9183792110aa03d45"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"feaae46f06aea0d8c4afa59e31abb93f9b520a34","unresolved":false,"context_lines":[{"line_number":83,"context_line":"Egress Proccessing"},{"line_number":84,"context_line":"------------------"},{"line_number":85,"context_line":"A classification flow related to egress dispatching  is set to be initially"},{"line_number":86,"context_line":"filtered by the security table the flow sets port key and network id to reg6 "},{"line_number":87,"context_line":"and metadata ovs registers"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"::"},{"line_number":90,"context_line":"    table\u003d0, priority\u003d100,in_port\u003d8 actions\u003dload:0xa-\u003eNXM_NX_REG6[],load:0x1-\u003eOXM_OF_METADATA[],resubmit(,1)"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba5201f7_3e1e5cbb","line":87,"range":{"start_line":86,"start_character":45,"end_line":87,"end_character":12},"updated":"2017-01-12 01:52:44.000000000","message":"reword?","commit_id":"d69f70d59ceb81b786cc48a9183792110aa03d45"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"80ee40e78dddad220950884277abc2c5f5399ab5","unresolved":false,"context_lines":[{"line_number":83,"context_line":"Egress Proccessing"},{"line_number":84,"context_line":"------------------"},{"line_number":85,"context_line":"A classification flow related to egress dispatching  is set to be initially"},{"line_number":86,"context_line":"filtered by the security table the flow sets port key and network id to reg6 "},{"line_number":87,"context_line":"and metadata ovs registers"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"::"},{"line_number":90,"context_line":"    table\u003d0, priority\u003d100,in_port\u003d8 actions\u003dload:0xa-\u003eNXM_NX_REG6[],load:0x1-\u003eOXM_OF_METADATA[],resubmit(,1)"}],"source_content_type":"text/x-rst","patch_set":1,"id":"7a3c09a3_c62b1f93","line":87,"range":{"start_line":86,"start_character":45,"end_line":87,"end_character":12},"in_reply_to":"ba5201f7_3e1e5cbb","updated":"2017-01-15 09:27:20.000000000","message":"+1","commit_id":"d69f70d59ceb81b786cc48a9183792110aa03d45"},{"author":{"_account_id":23235,"name":"Lihi Wishnitzer","email":"lihiwish@gmail.com","username":"lihiwish"},"change_message_id":"b531dd7ac64850d39e802f926093c3ab80b241ac","unresolved":false,"context_lines":[{"line_number":91,"context_line":""},{"line_number":92,"context_line":"In the security table, 1 the flow makes sure that the packet has originated"},{"line_number":93,"context_line":"from VM\u0027s assigned address and prevent network address spoofing and passed"},{"line_number":94,"context_line":"to conn. track table."},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"::"},{"line_number":97,"context_line":"    table\u003d1, priority\u003d200,in_port\u003d8,dl_src\u003dfa:16:3e:95:bf:e9,nw_src\u003d10.0.0.5 actions\u003dresubmit(,3)"}],"source_content_type":"text/x-rst","patch_set":1,"id":"7a3c09a3_6e32b6a8","line":94,"range":{"start_line":94,"start_character":3,"end_line":94,"end_character":14},"updated":"2017-01-18 08:32:48.000000000","message":"I think that using \u0027connection track\u0027 is better","commit_id":"d69f70d59ceb81b786cc48a9183792110aa03d45"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"feaae46f06aea0d8c4afa59e31abb93f9b520a34","unresolved":false,"context_lines":[{"line_number":98,"context_line":""},{"line_number":99,"context_line":"The conn. track table is used to create connection tracing entry in Linux"},{"line_number":100,"context_line":"Kernel, and passes the packet to service classification table."},{"line_number":101,"context_line":"The service classification table filters out service oriented packets and pass"},{"line_number":102,"context_line":"the packet to the L2 lookup table"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"::"},{"line_number":105,"context_line":"    table\u003d3, priority\u003d1 actions\u003dresubmit(,9)"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"The service classification table filters out service oriented packets and pass"},{"line_number":108,"context_line":"the packet to the L2 lookup table"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"Egress processing - L2 lookup"},{"line_number":111,"context_line":"-----------------------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba5201f7_1e6c3834","line":108,"range":{"start_line":101,"start_character":0,"end_line":108,"end_character":33},"updated":"2017-01-12 01:52:44.000000000","message":"duplication?","commit_id":"d69f70d59ceb81b786cc48a9183792110aa03d45"},{"author":{"_account_id":23235,"name":"Lihi Wishnitzer","email":"lihiwish@gmail.com","username":"lihiwish"},"change_message_id":"b531dd7ac64850d39e802f926093c3ab80b241ac","unresolved":false,"context_lines":[{"line_number":134,"context_line":""},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"To forward the traffic via the tunnel port this flow is matched against the"},{"line_number":137,"context_line":"remote port key set in reg7. "},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"::"},{"line_number":140,"context_line":"    table\u003d64,reg7\u003d0xc actions\u003dload:0x49-\u003eNXM_NX_TUN_ID[],output:8"}],"source_content_type":"text/x-rst","patch_set":1,"id":"7a3c09a3_ce29eae7","line":137,"range":{"start_line":137,"start_character":28,"end_line":137,"end_character":29},"updated":"2017-01-18 08:32:48.000000000","message":"Trailing space","commit_id":"d69f70d59ceb81b786cc48a9183792110aa03d45"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"feaae46f06aea0d8c4afa59e31abb93f9b520a34","unresolved":false,"context_lines":[{"line_number":137,"context_line":"remote port key set in reg7. "},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"::"},{"line_number":140,"context_line":"    table\u003d64,reg7\u003d0xc actions\u003dload:0x49-\u003eNXM_NX_TUN_ID[],output:8"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"Proposed Change"},{"line_number":143,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba5201f7_1e76f8d6","line":140,"range":{"start_line":140,"start_character":0,"end_line":140,"end_character":65},"updated":"2017-01-12 01:52:44.000000000","message":"With the support of virtual tunnel port, the remote_ip of tunnel will be added in openflow.","commit_id":"d69f70d59ceb81b786cc48a9183792110aa03d45"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"80ee40e78dddad220950884277abc2c5f5399ab5","unresolved":false,"context_lines":[{"line_number":140,"context_line":"    table\u003d64,reg7\u003d0xc actions\u003dload:0x49-\u003eNXM_NX_TUN_ID[],output:8"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"Proposed Change"},{"line_number":143,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":144,"context_line":"A new tunneling application that will deal with tunneling related flows"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"*ingress processing"}],"source_content_type":"text/x-rst","patch_set":1,"id":"7a3c09a3_813bc1d0","line":143,"updated":"2017-01-15 09:27:20.000000000","message":"This section is incomplete. What exactly are the responsibilities of this applications? What actions will be taken from where into this application? What flows are we talking about?\n\nThe explanation of the current implementation is very extensive (possibly drilling down more than necessary into the pipeline description, which possibly should be moved to a devref.), but this section is lacking any gritty details, and is very high level.","commit_id":"d69f70d59ceb81b786cc48a9183792110aa03d45"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"80ee40e78dddad220950884277abc2c5f5399ab5","unresolved":false,"context_lines":[{"line_number":143,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":144,"context_line":"A new tunneling application that will deal with tunneling related flows"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"*ingress processing"},{"line_number":147,"context_line":" it will set the tunnel matching classification flow in table 0, and local"},{"line_number":148,"context_line":" port lookup in l2 lookup table 7 "},{"line_number":149,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a57fde8_4e65c6df","line":146,"updated":"2017-01-15 09:27:20.000000000","message":"Please set this as a subsection. i.e.\n*ingress processing\n-\u003e\nIngress Processing\n------------------","commit_id":"d69f70d59ceb81b786cc48a9183792110aa03d45"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"80ee40e78dddad220950884277abc2c5f5399ab5","unresolved":false,"context_lines":[{"line_number":144,"context_line":"A new tunneling application that will deal with tunneling related flows"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"*ingress processing"},{"line_number":147,"context_line":" it will set the tunnel matching classification flow in table 0, and local"},{"line_number":148,"context_line":" port lookup in l2 lookup table 7 "},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"*egress processing"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a57fde8_0eaaded4","line":147,"range":{"start_line":147,"start_character":0,"end_line":147,"end_character":1},"updated":"2017-01-15 09:27:20.000000000","message":"This space is redundant.","commit_id":"d69f70d59ceb81b786cc48a9183792110aa03d45"},{"author":{"_account_id":24229,"name":"Igor Shafran","email":"igor.shafran@toganetworks.com","username":"ishafran"},"change_message_id":"8441589d836da5f469d60c3a2dfc0c54647066a1","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Upon VM port creation, its properties such as it\u0027s overlay network membership,"},{"line_number":25,"context_line":"ports database id is used to match flows to/from it. A tunnel port is created once"},{"line_number":26,"context_line":"for a chasiss upon first VM port. As the tunnel port is shared among many networks"},{"line_number":27,"context_line":"A flow is  set to  convert segmantation id to network id  set in the metadate field of"},{"line_number":28,"context_line":"the OVS."},{"line_number":29,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a461143_a6781afa","line":26,"range":{"start_line":26,"start_character":6,"end_line":26,"end_character":13},"updated":"2017-01-25 15:38:46.000000000","message":"chassis","commit_id":"1ca8d5d42f2b48e4e8f7f11090d9e2fd603df452"},{"author":{"_account_id":24229,"name":"Igor Shafran","email":"igor.shafran@toganetworks.com","username":"ishafran"},"change_message_id":"8441589d836da5f469d60c3a2dfc0c54647066a1","unresolved":false,"context_lines":[{"line_number":52,"context_line":"-------------------"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"The classification flow should match against the in_port,tunnel port of a specific segmentation id"},{"line_number":55,"context_line":"and type and tunnel v irtual network key, and set reg 7 as unique port key to identify this port"},{"line_number":56,"context_line":"for destination matching."},{"line_number":57,"context_line":"An example classification flow, for two VMS, one is part of \"admin-private\""},{"line_number":58,"context_line":"network, with segmentation id 0x13 and the second which is part of \"private\""}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a461143_6681d28f","line":55,"range":{"start_line":55,"start_character":0,"end_line":55,"end_character":22},"updated":"2017-01-25 15:38:46.000000000","message":"syntax","commit_id":"1ca8d5d42f2b48e4e8f7f11090d9e2fd603df452"},{"author":{"_account_id":24229,"name":"Igor Shafran","email":"igor.shafran@toganetworks.com","username":"ishafran"},"change_message_id":"8441589d836da5f469d60c3a2dfc0c54647066a1","unresolved":false,"context_lines":[{"line_number":54,"context_line":"The classification flow should match against the in_port,tunnel port of a specific segmentation id"},{"line_number":55,"context_line":"and type and tunnel v irtual network key, and set reg 7 as unique port key to identify this port"},{"line_number":56,"context_line":"for destination matching."},{"line_number":57,"context_line":"An example classification flow, for two VMS, one is part of \"admin-private\""},{"line_number":58,"context_line":"network, with segmentation id 0x13 and the second which is part of \"private\""},{"line_number":59,"context_line":"network with segmentation id 0x49, the classification flows for these tunnels"},{"line_number":60,"context_line":"are:"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a461143_e69ea206","line":57,"range":{"start_line":57,"start_character":40,"end_line":57,"end_character":43},"updated":"2017-01-25 15:38:46.000000000","message":"VMs","commit_id":"1ca8d5d42f2b48e4e8f7f11090d9e2fd603df452"},{"author":{"_account_id":24229,"name":"Igor Shafran","email":"igor.shafran@toganetworks.com","username":"ishafran"},"change_message_id":"8441589d836da5f469d60c3a2dfc0c54647066a1","unresolved":false,"context_lines":[{"line_number":102,"context_line":"::"},{"line_number":103,"context_line":"    table\u003d1, priority\u003d200,in_port\u003d8,dl_src\u003dfa:16:3e:95:bf:e9,nw_src\u003d10.0.0.5 actions\u003dresubmit(,3)"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"The \u0027connection track\u0027 table is used to create connection tracing entry in Linux"},{"line_number":106,"context_line":"Kernel, and passes the packet to service classification table."},{"line_number":107,"context_line":"The service classification table filters out service oriented packets and pass"},{"line_number":108,"context_line":"the packet to the L2 lookup table"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a461143_0181d84a","line":105,"range":{"start_line":105,"start_character":58,"end_line":105,"end_character":65},"updated":"2017-01-25 15:38:46.000000000","message":"tracking","commit_id":"1ca8d5d42f2b48e4e8f7f11090d9e2fd603df452"},{"author":{"_account_id":24229,"name":"Igor Shafran","email":"igor.shafran@toganetworks.com","username":"ishafran"},"change_message_id":"8441589d836da5f469d60c3a2dfc0c54647066a1","unresolved":false,"context_lines":[{"line_number":148,"context_line":""},{"line_number":149,"context_line":"*ingress processing"},{"line_number":150,"context_line":"it will set the tunnel matching classification flow in table 0,  and forward it to l2 lookup table."},{"line_number":151,"context_line":"the looup mechnism should treat all port equily and filter according to port key."},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"*egress processing"},{"line_number":154,"context_line":"it will set the the flows  to dispatch trafice going from the chasiss to via th tunnel port upon"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a461143_e1576cc8","line":151,"range":{"start_line":151,"start_character":4,"end_line":151,"end_character":18},"updated":"2017-01-25 15:38:46.000000000","message":"fix syntax","commit_id":"1ca8d5d42f2b48e4e8f7f11090d9e2fd603df452"},{"author":{"_account_id":24229,"name":"Igor Shafran","email":"igor.shafran@toganetworks.com","username":"ishafran"},"change_message_id":"8441589d836da5f469d60c3a2dfc0c54647066a1","unresolved":false,"context_lines":[{"line_number":151,"context_line":"the looup mechnism should treat all port equily and filter according to port key."},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"*egress processing"},{"line_number":154,"context_line":"it will set the the flows  to dispatch trafice going from the chasiss to via th tunnel port upon"},{"line_number":155,"context_line":"remote port, match dispatch traffice locally. It will set egress bum traffic flows."},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"L2 application will deal with all local network flows that are unrelated to hwo tay packets are"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a461143_41c76045","line":154,"range":{"start_line":154,"start_character":62,"end_line":154,"end_character":69},"updated":"2017-01-25 15:38:46.000000000","message":"chassis","commit_id":"1ca8d5d42f2b48e4e8f7f11090d9e2fd603df452"},{"author":{"_account_id":24229,"name":"Igor Shafran","email":"igor.shafran@toganetworks.com","username":"ishafran"},"change_message_id":"8441589d836da5f469d60c3a2dfc0c54647066a1","unresolved":false,"context_lines":[{"line_number":154,"context_line":"it will set the the flows  to dispatch trafice going from the chasiss to via th tunnel port upon"},{"line_number":155,"context_line":"remote port, match dispatch traffice locally. It will set egress bum traffic flows."},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"L2 application will deal with all local network flows that are unrelated to hwo tay packets are"},{"line_number":158,"context_line":"obtained or pushed externally."},{"line_number":159,"context_line":"or provider networks"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a461143_01b9d8e9","line":157,"range":{"start_line":157,"start_character":0,"end_line":157,"end_character":53},"updated":"2017-01-25 15:38:46.000000000","message":"this may influence SNAT/DNAT traffic too. Current implementation of SNAT/DNAT manipulate L2 addresses.","commit_id":"1ca8d5d42f2b48e4e8f7f11090d9e2fd603df452"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"7b0151817cb1f2ddf9cd15888804771db0eab4d5","unresolved":false,"context_lines":[{"line_number":30,"context_line":"Set fields are:"},{"line_number":31,"context_line":"* metadata \u003c- network\u0027s Unique ID"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"::"},{"line_number":34,"context_line":"   (neutron) net-list"},{"line_number":35,"context_line":"   +--------------------------------------+---------------+----------------------------------------------------+"},{"line_number":36,"context_line":"   | id                                   | name          | subnets                                            |"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3a461143_34e4c6aa","line":33,"updated":"2017-01-29 11:36:49.000000000","message":"Still missing a newline here","commit_id":"9a85983a447dd7d81a3f50bed480656b169bfe9c"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"7b0151817cb1f2ddf9cd15888804771db0eab4d5","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"The classification flow should match against the tunnel in_port, a port of a"},{"line_number":55,"context_line":"specific segmentation id and type and tunnel\u0027s virtual network key, according"},{"line_number":56,"context_line":"to which reg 7 is set as unique port key to identify this port for destination"},{"line_number":57,"context_line":"matching."},{"line_number":58,"context_line":"An example classification flow, for two VMS, one is part of \"admin-private\""},{"line_number":59,"context_line":"network, with segmentation id 0x13 and the second which is part of \"private\""}],"source_content_type":"text/x-rst","patch_set":4,"id":"3a461143_74be4e66","line":56,"range":{"start_line":56,"start_character":9,"end_line":56,"end_character":14},"updated":"2017-01-29 11:36:49.000000000","message":"I think this is mixing ingress and egress. Please clarify this point.","commit_id":"9a85983a447dd7d81a3f50bed480656b169bfe9c"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"4409ec22aa0dc98ed9a8a7527d0e435c6e92442f","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"The classification flow should match against the tunnel in_port, a port of a"},{"line_number":55,"context_line":"specific segmentation id and type and tunnel\u0027s virtual network key, according"},{"line_number":56,"context_line":"to which reg 7 is set as unique port key to identify this port for destination"},{"line_number":57,"context_line":"matching."},{"line_number":58,"context_line":"An example classification flow, for two VMS, one is part of \"admin-private\""},{"line_number":59,"context_line":"network, with segmentation id 0x13 and the second which is part of \"private\""}],"source_content_type":"text/x-rst","patch_set":4,"id":"3a461143_821ffc6a","line":56,"range":{"start_line":56,"start_character":9,"end_line":56,"end_character":14},"in_reply_to":"3a461143_17db4ced","updated":"2017-01-29 15:53:34.000000000","message":"Sorry. Thought this was the proposed change area.","commit_id":"9a85983a447dd7d81a3f50bed480656b169bfe9c"},{"author":{"_account_id":18347,"name":"Itamar Ofek","email":"itamofek@netscape.net","username":"itamaro"},"change_message_id":"a64205813e7a0d660d9242610bc1348fe6320eab","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"The classification flow should match against the tunnel in_port, a port of a"},{"line_number":55,"context_line":"specific segmentation id and type and tunnel\u0027s virtual network key, according"},{"line_number":56,"context_line":"to which reg 7 is set as unique port key to identify this port for destination"},{"line_number":57,"context_line":"matching."},{"line_number":58,"context_line":"An example classification flow, for two VMS, one is part of \"admin-private\""},{"line_number":59,"context_line":"network, with segmentation id 0x13 and the second which is part of \"private\""}],"source_content_type":"text/x-rst","patch_set":4,"id":"3a461143_17db4ced","line":56,"range":{"start_line":56,"start_character":9,"end_line":56,"end_character":14},"in_reply_to":"3a461143_74be4e66","updated":"2017-01-29 13:42:27.000000000","message":"It is. I explains the current code.","commit_id":"9a85983a447dd7d81a3f50bed480656b169bfe9c"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"7b0151817cb1f2ddf9cd15888804771db0eab4d5","unresolved":false,"context_lines":[{"line_number":66,"context_line":"   table\u003d0, priority\u003d100,in_port\u003d4,tun_id\u003d0x13 actions\u003dload:0x3-\u003eOXM_OF_METADATA[],resubmit(,7)"},{"line_number":67,"context_line":"   table\u003d0, priority\u003d100,in_port\u003d4,tun_id\u003d0x49 actions\u003dload:0x1-\u003eOXM_OF_METADATA[],resubmit(,7)"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"In the ingress port lookup table 7, a match is done according to unique"},{"line_number":70,"context_line":"network id and vm\u0027s port mac, where vm\u0027s port key is set into reg7, and sent to"},{"line_number":71,"context_line":"table 72, the ingress conn-track table which passes the packet to ingress"},{"line_number":72,"context_line":"dispatch table"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3a461143_b4b43682","line":69,"updated":"2017-01-29 11:36:49.000000000","message":"I thought this was planned to move out of table 7, and re-use the L2 application in table 17?","commit_id":"9a85983a447dd7d81a3f50bed480656b169bfe9c"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"4409ec22aa0dc98ed9a8a7527d0e435c6e92442f","unresolved":false,"context_lines":[{"line_number":66,"context_line":"   table\u003d0, priority\u003d100,in_port\u003d4,tun_id\u003d0x13 actions\u003dload:0x3-\u003eOXM_OF_METADATA[],resubmit(,7)"},{"line_number":67,"context_line":"   table\u003d0, priority\u003d100,in_port\u003d4,tun_id\u003d0x49 actions\u003dload:0x1-\u003eOXM_OF_METADATA[],resubmit(,7)"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"In the ingress port lookup table 7, a match is done according to unique"},{"line_number":70,"context_line":"network id and vm\u0027s port mac, where vm\u0027s port key is set into reg7, and sent to"},{"line_number":71,"context_line":"table 72, the ingress conn-track table which passes the packet to ingress"},{"line_number":72,"context_line":"dispatch table"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3a461143_a210785a","line":69,"in_reply_to":"3a461143_b4b43682","updated":"2017-01-29 15:53:34.000000000","message":"Sorry. Thought this was the proposed change area.","commit_id":"9a85983a447dd7d81a3f50bed480656b169bfe9c"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"7b0151817cb1f2ddf9cd15888804771db0eab4d5","unresolved":false,"context_lines":[{"line_number":114,"context_line":"Egress processing - L2 lookup"},{"line_number":115,"context_line":"-----------------------------"},{"line_number":116,"context_line":"For locally originated traffic, the destination mac and network membership are"},{"line_number":117,"context_line":"translated to port key which is push to reg7, and passed to egress table 64,"},{"line_number":118,"context_line":"it will go through the connection track table and eventfully dispatched locally"},{"line_number":119,"context_line":"same as ingress traffic"},{"line_number":120,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"3a461143_14b0aa89","line":117,"range":{"start_line":117,"start_character":32,"end_line":117,"end_character":36},"updated":"2017-01-29 11:36:49.000000000","message":"typo: push -\u003e pushed?","commit_id":"9a85983a447dd7d81a3f50bed480656b169bfe9c"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"7b0151817cb1f2ddf9cd15888804771db0eab4d5","unresolved":false,"context_lines":[{"line_number":147,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":148,"context_line":"A new tunneling application that will deal with tunneling related flows"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"*ingress processing"},{"line_number":151,"context_line":"it will set the tunnel matching classification flow in table 0,  and forward"},{"line_number":152,"context_line":"it to l2 lookup table. The looup mechnism should treat all port equily and"},{"line_number":153,"context_line":"filter according to port key."}],"source_content_type":"text/x-rst","patch_set":4,"id":"3a461143_f48b1ec1","line":150,"updated":"2017-01-29 11:36:49.000000000","message":"This is still not a subsection","commit_id":"9a85983a447dd7d81a3f50bed480656b169bfe9c"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"7b0151817cb1f2ddf9cd15888804771db0eab4d5","unresolved":false,"context_lines":[{"line_number":149,"context_line":""},{"line_number":150,"context_line":"*ingress processing"},{"line_number":151,"context_line":"it will set the tunnel matching classification flow in table 0,  and forward"},{"line_number":152,"context_line":"it to l2 lookup table. The looup mechnism should treat all port equily and"},{"line_number":153,"context_line":"filter according to port key."},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"*egress processing"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3a461143_34a92625","line":152,"range":{"start_line":152,"start_character":64,"end_line":152,"end_character":70},"updated":"2017-01-29 11:36:49.000000000","message":"typo: equally?","commit_id":"9a85983a447dd7d81a3f50bed480656b169bfe9c"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"7b0151817cb1f2ddf9cd15888804771db0eab4d5","unresolved":false,"context_lines":[{"line_number":152,"context_line":"it to l2 lookup table. The looup mechnism should treat all port equily and"},{"line_number":153,"context_line":"filter according to port key."},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"*egress processing"},{"line_number":156,"context_line":"it will set the the flows to dispatch traffic going from the chassis to the"},{"line_number":157,"context_line":"remote port via the tunnel port."},{"line_number":158,"context_line":"match locally dispatched traffic and set egress bum traffic flows."}],"source_content_type":"text/x-rst","patch_set":4,"id":"3a461143_14898ac9","line":155,"updated":"2017-01-29 11:36:49.000000000","message":"This is still not a subsection","commit_id":"9a85983a447dd7d81a3f50bed480656b169bfe9c"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"4409ec22aa0dc98ed9a8a7527d0e435c6e92442f","unresolved":false,"context_lines":[{"line_number":157,"context_line":"remote port via the tunnel port."},{"line_number":158,"context_line":"match locally dispatched traffic and set egress bum traffic flows."},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"L2 application will deal with all local network flows that are niether related"},{"line_number":161,"context_line":"to how the packets arrived at the integration switch, nor how they leave."},{"line_number":162,"context_line":"It will be up to other application to set the flows that translte the local"},{"line_number":163,"context_line":"destintion port to reg7, and remote reg7 to pushing the packet down stream."},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"The related application are Provider Network App. Dnat App, Snat App etc.."}],"source_content_type":"text/x-rst","patch_set":4,"id":"3a461143_dd156540","line":165,"range":{"start_line":160,"start_character":0,"end_line":165,"end_character":74},"updated":"2017-01-29 15:53:34.000000000","message":"I think this should be moved to the main section (Proposed Change) and out of the subsection.","commit_id":"9a85983a447dd7d81a3f50bed480656b169bfe9c"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"83737cd9fe1abe060b5675505f32d9b1768d2e41","unresolved":false,"context_lines":[{"line_number":163,"context_line":"destintion port to reg7, and remote reg7 to pushing the packet down stream."},{"line_number":164,"context_line":"A new tunneling application that will deal with tunneling related flows"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"Ingress processing:"},{"line_number":167,"context_line":"it will set the tunnel matching classification flow in table 0,  and forward"},{"line_number":168,"context_line":"it to l2 lookup table, 17 instead of ingress port lookup table 7. The looup"},{"line_number":169,"context_line":"mechnism should treat all port equily and filter according to port key."}],"source_content_type":"text/x-rst","patch_set":5,"id":"3a461143_44a6a0ae","line":166,"updated":"2017-02-01 07:45:48.000000000","message":"Stil not a subsection. Please rewrite as:\nIngress Processing\n------------------","commit_id":"d0a22f42750ed86b493ebf4db09bdb9d31a339bc"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"83737cd9fe1abe060b5675505f32d9b1768d2e41","unresolved":false,"context_lines":[{"line_number":166,"context_line":"Ingress processing:"},{"line_number":167,"context_line":"it will set the tunnel matching classification flow in table 0,  and forward"},{"line_number":168,"context_line":"it to l2 lookup table, 17 instead of ingress port lookup table 7. The looup"},{"line_number":169,"context_line":"mechnism should treat all port equily and filter according to port key."},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"Egress processing:"},{"line_number":172,"context_line":"it will set the the flows to dispatch traffic going from the chassis to the"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3a461143_84ac088d","line":169,"updated":"2017-02-01 07:45:48.000000000","message":"Please provide an example flow","commit_id":"d0a22f42750ed86b493ebf4db09bdb9d31a339bc"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"83737cd9fe1abe060b5675505f32d9b1768d2e41","unresolved":false,"context_lines":[{"line_number":168,"context_line":"it to l2 lookup table, 17 instead of ingress port lookup table 7. The looup"},{"line_number":169,"context_line":"mechnism should treat all port equily and filter according to port key."},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"Egress processing:"},{"line_number":172,"context_line":"it will set the the flows to dispatch traffic going from the chassis to the"},{"line_number":173,"context_line":"remote port via the tunnel port and match locally dispatched traffic and set"},{"line_number":174,"context_line":"egress bum traffic flows."}],"source_content_type":"text/x-rst","patch_set":5,"id":"3a461143_04af387d","line":171,"updated":"2017-02-01 07:45:48.000000000","message":"Still not a subsection. Please rewrite as:\nEgress Processing\n-----------------","commit_id":"d0a22f42750ed86b493ebf4db09bdb9d31a339bc"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"83737cd9fe1abe060b5675505f32d9b1768d2e41","unresolved":false,"context_lines":[{"line_number":171,"context_line":"Egress processing:"},{"line_number":172,"context_line":"it will set the the flows to dispatch traffic going from the chassis to the"},{"line_number":173,"context_line":"remote port via the tunnel port and match locally dispatched traffic and set"},{"line_number":174,"context_line":"egress bum traffic flows."},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"The changes in the L2 application will affect the Provider Network App. Dnat App, Snat App etc.."}],"source_content_type":"text/x-rst","patch_set":5,"id":"3a461143_c4061085","line":174,"updated":"2017-02-01 07:45:48.000000000","message":"Please provide an example flow.","commit_id":"d0a22f42750ed86b493ebf4db09bdb9d31a339bc"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"b00ea262663cd4be2726b9bd68f92494884b3e58","unresolved":false,"context_lines":[{"line_number":157,"context_line":""},{"line_number":158,"context_line":"Proposed Change"},{"line_number":159,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":160,"context_line":"L2 application will deal with all local network flows that are niether related"},{"line_number":161,"context_line":"to how the packets arrived at the integration switch, nor how they leave."},{"line_number":162,"context_line":"It will be up to other application to set the flows that translte the local"},{"line_number":163,"context_line":"destintion port to reg7, and remote reg7 to pushing the packet down stream."}],"source_content_type":"text/x-rst","patch_set":6,"id":"1a430d35_cdeae573","line":160,"range":{"start_line":160,"start_character":63,"end_line":160,"end_character":70},"updated":"2017-02-08 13:04:45.000000000","message":"neither","commit_id":"c686781823cc848976a968003cbd5dd91dfe9148"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"b00ea262663cd4be2726b9bd68f92494884b3e58","unresolved":false,"context_lines":[{"line_number":159,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":160,"context_line":"L2 application will deal with all local network flows that are niether related"},{"line_number":161,"context_line":"to how the packets arrived at the integration switch, nor how they leave."},{"line_number":162,"context_line":"It will be up to other application to set the flows that translte the local"},{"line_number":163,"context_line":"destintion port to reg7, and remote reg7 to pushing the packet down stream."},{"line_number":164,"context_line":"A new tunneling application that will deal with tunneling related flows"},{"line_number":165,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"1a430d35_8d9b7d17","line":162,"range":{"start_line":162,"start_character":56,"end_line":162,"end_character":65},"updated":"2017-02-08 13:04:45.000000000","message":"translate","commit_id":"c686781823cc848976a968003cbd5dd91dfe9148"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"b00ea262663cd4be2726b9bd68f92494884b3e58","unresolved":false,"context_lines":[{"line_number":161,"context_line":"to how the packets arrived at the integration switch, nor how they leave."},{"line_number":162,"context_line":"It will be up to other application to set the flows that translte the local"},{"line_number":163,"context_line":"destintion port to reg7, and remote reg7 to pushing the packet down stream."},{"line_number":164,"context_line":"A new tunneling application that will deal with tunneling related flows"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"Ingress processing"},{"line_number":167,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":6,"id":"1a430d35_4da51545","line":164,"range":{"start_line":164,"start_character":0,"end_line":164,"end_character":71},"updated":"2017-02-08 13:04:45.000000000","message":"missing end of the sentence","commit_id":"c686781823cc848976a968003cbd5dd91dfe9148"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"b00ea262663cd4be2726b9bd68f92494884b3e58","unresolved":false,"context_lines":[{"line_number":165,"context_line":""},{"line_number":166,"context_line":"Ingress processing"},{"line_number":167,"context_line":"------------------"},{"line_number":168,"context_line":"it will set the tunnel matching classification flow in table 0,  and forward"},{"line_number":169,"context_line":"it to l2 lookup table, 17 instead of ingress port lookup table 7. The looup"},{"line_number":170,"context_line":"mechnism should treat all port equily and filter according to port key."},{"line_number":171,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"1a430d35_8d69bdfb","line":168,"range":{"start_line":168,"start_character":0,"end_line":168,"end_character":1},"updated":"2017-02-08 13:04:45.000000000","message":"It","commit_id":"c686781823cc848976a968003cbd5dd91dfe9148"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"b00ea262663cd4be2726b9bd68f92494884b3e58","unresolved":false,"context_lines":[{"line_number":166,"context_line":"Ingress processing"},{"line_number":167,"context_line":"------------------"},{"line_number":168,"context_line":"it will set the tunnel matching classification flow in table 0,  and forward"},{"line_number":169,"context_line":"it to l2 lookup table, 17 instead of ingress port lookup table 7. The looup"},{"line_number":170,"context_line":"mechnism should treat all port equily and filter according to port key."},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"::"}],"source_content_type":"text/x-rst","patch_set":6,"id":"1a430d35_8d37fdfd","line":169,"range":{"start_line":169,"start_character":57,"end_line":169,"end_character":64},"updated":"2017-02-08 13:04:45.000000000","message":"( TABLE 7)","commit_id":"c686781823cc848976a968003cbd5dd91dfe9148"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"b00ea262663cd4be2726b9bd68f92494884b3e58","unresolved":false,"context_lines":[{"line_number":166,"context_line":"Ingress processing"},{"line_number":167,"context_line":"------------------"},{"line_number":168,"context_line":"it will set the tunnel matching classification flow in table 0,  and forward"},{"line_number":169,"context_line":"it to l2 lookup table, 17 instead of ingress port lookup table 7. The looup"},{"line_number":170,"context_line":"mechnism should treat all port equily and filter according to port key."},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"::"}],"source_content_type":"text/x-rst","patch_set":6,"id":"1a430d35_cd14a54e","line":169,"range":{"start_line":169,"start_character":70,"end_line":169,"end_character":75},"updated":"2017-02-08 13:04:45.000000000","message":"?","commit_id":"c686781823cc848976a968003cbd5dd91dfe9148"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"b00ea262663cd4be2726b9bd68f92494884b3e58","unresolved":false,"context_lines":[{"line_number":166,"context_line":"Ingress processing"},{"line_number":167,"context_line":"------------------"},{"line_number":168,"context_line":"it will set the tunnel matching classification flow in table 0,  and forward"},{"line_number":169,"context_line":"it to l2 lookup table, 17 instead of ingress port lookup table 7. The looup"},{"line_number":170,"context_line":"mechnism should treat all port equily and filter according to port key."},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"::"}],"source_content_type":"text/x-rst","patch_set":6,"id":"1a430d35_ad43d96a","line":169,"range":{"start_line":169,"start_character":16,"end_line":169,"end_character":26},"updated":"2017-02-08 13:04:45.000000000","message":"better put in ( )","commit_id":"c686781823cc848976a968003cbd5dd91dfe9148"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"b00ea262663cd4be2726b9bd68f92494884b3e58","unresolved":false,"context_lines":[{"line_number":178,"context_line":""},{"line_number":179,"context_line":"Egress processing"},{"line_number":180,"context_line":"-----------------"},{"line_number":181,"context_line":"it will set the the flows to dispatch traffic going from the chassis to the"},{"line_number":182,"context_line":"remote port via the tunnel port and match locally dispatched traffic and set"},{"line_number":183,"context_line":"egress bum traffic flows."},{"line_number":184,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"1a430d35_a8082729","line":181,"range":{"start_line":181,"start_character":12,"end_line":181,"end_character":19},"updated":"2017-02-08 13:04:45.000000000","message":"the","commit_id":"c686781823cc848976a968003cbd5dd91dfe9148"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"b00ea262663cd4be2726b9bd68f92494884b3e58","unresolved":false,"context_lines":[{"line_number":186,"context_line":""},{"line_number":187,"context_line":"   table\u003d64, priority\u003d100,reg7\u003d0xa actions\u003dresubmit(,72)"},{"line_number":188,"context_line":"   table\u003d17, priority\u003d100,metadata\u003d0x1,dl_dst\u003d01:00:00:00:00:00/01:00:00:00:00:00 actions\u003dload:0xa-\u003eNXM_NX_REG7[],resubmit(,64),load:0x2-\u003eNXM_NX_REG7[],resubmit(,64),load:0-\u003eNXM_NX_REG7[],resubmit(,64)"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"The changes in the L2 application will affect the Provider Network App. Dnat App, Snat App etc.."}],"source_content_type":"text/x-rst","patch_set":6,"id":"1a430d35_482fc387","line":189,"updated":"2017-02-08 13:04:45.000000000","message":"Maybe add sub-section: Impact on existing Apps","commit_id":"c686781823cc848976a968003cbd5dd91dfe9148"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"b00ea262663cd4be2726b9bd68f92494884b3e58","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"1a430d35_e83dcfc4","line":191,"updated":"2017-02-08 13:04:45.000000000","message":"Please add Working Items section","commit_id":"c686781823cc848976a968003cbd5dd91dfe9148"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"905887504b67e1f028f7d71defef7fdbf1830098","unresolved":false,"context_lines":[{"line_number":21,"context_line":"L2 application for both ingress and egress packets propagation."},{"line_number":22,"context_line":"The tunneling related flows are set when either local or remote port is updated."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Upon VM port creation, its properties such as it\u0027s overlay network membership,"},{"line_number":25,"context_line":"ports database id is used to match flows to/from it. A tunnel port is created"},{"line_number":26,"context_line":"once for a chassis upon first VM port. As the tunnel port is shared among many"},{"line_number":27,"context_line":"networks. A flow is set to convert segmentation id to network id set in the"}],"source_content_type":"text/x-rst","patch_set":7,"id":"1a430d35_31056410","line":24,"range":{"start_line":24,"start_character":46,"end_line":24,"end_character":50},"updated":"2017-02-09 01:34:41.000000000","message":"its?","commit_id":"535efc27cf3a03938a6869021401b7db18cc62b5"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"905887504b67e1f028f7d71defef7fdbf1830098","unresolved":false,"context_lines":[{"line_number":22,"context_line":"The tunneling related flows are set when either local or remote port is updated."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Upon VM port creation, its properties such as it\u0027s overlay network membership,"},{"line_number":25,"context_line":"ports database id is used to match flows to/from it. A tunnel port is created"},{"line_number":26,"context_line":"once for a chassis upon first VM port. As the tunnel port is shared among many"},{"line_number":27,"context_line":"networks. A flow is set to convert segmentation id to network id set in the"},{"line_number":28,"context_line":"metadata field of the OVS."},{"line_number":29,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"1a430d35_51567006","line":26,"range":{"start_line":25,"start_character":53,"end_line":26,"end_character":38},"updated":"2017-02-09 01:34:41.000000000","message":"This is not true. The tunnel ports will be created upon the df_local_controller starts up.","commit_id":"535efc27cf3a03938a6869021401b7db18cc62b5"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"905887504b67e1f028f7d71defef7fdbf1830098","unresolved":false,"context_lines":[{"line_number":53,"context_line":"-------------------"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"The classification flow should match against the tunnel in_port, a port of a"},{"line_number":56,"context_line":"specific segmentation id and type and tunnel\u0027s virtual network key, according"},{"line_number":57,"context_line":"to which metadata will be set as network_id to identify incoming traffic being part"},{"line_number":58,"context_line":"of the network identified by the segmentation id."},{"line_number":59,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"1a430d35_b1add4ea","line":56,"range":{"start_line":56,"start_character":29,"end_line":56,"end_character":33},"updated":"2017-02-09 01:34:41.000000000","message":"Maybe I misunderstand here, how is the type matched?","commit_id":"535efc27cf3a03938a6869021401b7db18cc62b5"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"905887504b67e1f028f7d71defef7fdbf1830098","unresolved":false,"context_lines":[{"line_number":69,"context_line":"   table\u003d0, priority\u003d100,in_port\u003d4,tun_id\u003d0x13 actions\u003dload:0x3-\u003eOXM_OF_METADATA[],resubmit(,7)"},{"line_number":70,"context_line":"   table\u003d0, priority\u003d100,in_port\u003d4,tun_id\u003d0x49 actions\u003dload:0x1-\u003eOXM_OF_METADATA[],resubmit(,7)"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"Currently in the ingress port lookup table 7, a match is done according to unique"},{"line_number":73,"context_line":"network id and vm\u0027s port mac, where vm\u0027s port key is set into reg7, and sent to"},{"line_number":74,"context_line":"table 72, the ingress conn-track table which passes the packet to ingress"},{"line_number":75,"context_line":"dispatch table"}],"source_content_type":"text/x-rst","patch_set":7,"id":"1a430d35_f18afc62","line":72,"range":{"start_line":72,"start_character":37,"end_line":72,"end_character":44},"updated":"2017-02-09 01:34:41.000000000","message":"the table number has been updated recently, maybe better to demonstrate with latest table id. The same comments apply to all following table ids.\n\nhttps://review.openstack.org/#/c/420602/","commit_id":"535efc27cf3a03938a6869021401b7db18cc62b5"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"905887504b67e1f028f7d71defef7fdbf1830098","unresolved":false,"context_lines":[{"line_number":85,"context_line":"   table\u003d7, priority\u003d200,metadata\u003d0x1,dl_dst\u003dfa:16:3e:bc:5b:08 actions\u003dload:0x6-\u003eNXM_NX_REG7[],resubmit(,72)"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"Eventually the processing reaches table 78, the ingress dispatch table where"},{"line_number":88,"context_line":"the packet is matched against port\u0027s key, translated to mac and ovs port to be"},{"line_number":89,"context_line":"forwarded to the local vm port."},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"::"}],"source_content_type":"text/x-rst","patch_set":7,"id":"1a430d35_116148a9","line":88,"range":{"start_line":88,"start_character":56,"end_line":88,"end_character":59},"updated":"2017-02-09 01:34:41.000000000","message":"Maybe I misunderstand here, how is the mac translated?","commit_id":"535efc27cf3a03938a6869021401b7db18cc62b5"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"905887504b67e1f028f7d71defef7fdbf1830098","unresolved":false,"context_lines":[{"line_number":95,"context_line":"Egress Proccessing"},{"line_number":96,"context_line":"------------------"},{"line_number":97,"context_line":"A classification flow related to egress dispatching  is set to be initially"},{"line_number":98,"context_line":"filtered by the security table the flow sets port key and network id to reg6"},{"line_number":99,"context_line":"and metadata ovs registers, respectively."},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"::"}],"source_content_type":"text/x-rst","patch_set":7,"id":"1a430d35_7111ac03","line":98,"range":{"start_line":98,"start_character":30,"end_line":98,"end_character":31},"updated":"2017-02-09 01:34:41.000000000","message":"miss comma here?","commit_id":"535efc27cf3a03938a6869021401b7db18cc62b5"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"905887504b67e1f028f7d71defef7fdbf1830098","unresolved":false,"context_lines":[{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    table\u003d0, priority\u003d100,in_port\u003d8 actions\u003dload:0xa-\u003eNXM_NX_REG6[],load:0x1-\u003eOXM_OF_METADATA[],resubmit(,1)"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"In the security table, 1 the flow makes sure that the packet has originated"},{"line_number":106,"context_line":"from VM\u0027s assigned address and prevent network address spoofing and passed"},{"line_number":107,"context_line":"to \u0027connection track\u0027 table."},{"line_number":108,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"1a430d35_51259059","line":105,"range":{"start_line":105,"start_character":16,"end_line":105,"end_character":24},"updated":"2017-02-09 01:34:41.000000000","message":"table 1? also, this table id is updated recently.","commit_id":"535efc27cf3a03938a6869021401b7db18cc62b5"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"905887504b67e1f028f7d71defef7fdbf1830098","unresolved":false,"context_lines":[{"line_number":92,"context_line":""},{"line_number":93,"context_line":"   table\u003d78,  priority\u003d100,reg7\u003d0x6 actions\u003doutput:7"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"Egress Proccessing"},{"line_number":96,"context_line":"------------------"},{"line_number":97,"context_line":"A classification flow related to egress dispatching  is set to be initially"},{"line_number":98,"context_line":"filtered by the security table the flow sets port key and network id to reg6"},{"line_number":99,"context_line":"and metadata ovs registers, respectively."},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"::"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    table\u003d0, priority\u003d100,in_port\u003d8 actions\u003dload:0xa-\u003eNXM_NX_REG6[],load:0x1-\u003eOXM_OF_METADATA[],resubmit(,1)"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"In the security table, 1 the flow makes sure that the packet has originated"},{"line_number":106,"context_line":"from VM\u0027s assigned address and prevent network address spoofing and passed"},{"line_number":107,"context_line":"to \u0027connection track\u0027 table."},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"::"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    table\u003d1, priority\u003d200,in_port\u003d8,dl_src\u003dfa:16:3e:95:bf:e9,nw_src\u003d10.0.0.5 actions\u003dresubmit(,3)"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"The \u0027connection track\u0027 table is used to create a connection track entry in Linux"},{"line_number":114,"context_line":"Kernel, and pass the packet to the service classification table."},{"line_number":115,"context_line":"The service classification table filters out service oriented packets and pass"},{"line_number":116,"context_line":"the packet to the L2 lookup table"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"::"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    table\u003d3, priority\u003d1 actions\u003dresubmit(,9)"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"Egress processing - L2 lookup"},{"line_number":123,"context_line":"-----------------------------"}],"source_content_type":"text/x-rst","patch_set":7,"id":"1a430d35_31a724be","line":120,"range":{"start_line":95,"start_character":0,"end_line":120,"end_character":44},"updated":"2017-02-09 01:34:41.000000000","message":"Is it more appropriate to not describe this part. this is the same for every thing, nothing special for tunneling. I think it could just start from L2_LOOKUP_TABLE, where is the tunneling going to happen at.","commit_id":"535efc27cf3a03938a6869021401b7db18cc62b5"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"905887504b67e1f028f7d71defef7fdbf1830098","unresolved":false,"context_lines":[{"line_number":153,"context_line":""},{"line_number":154,"context_line":"::"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"    table\u003d64,reg7\u003d0xc actions\u003dload:0x49-\u003eNXM_NX_TUN_ID[],output:8"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"Proposed Change"},{"line_number":159,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":7,"id":"1a430d35_d1c34036","line":156,"range":{"start_line":156,"start_character":0,"end_line":156,"end_character":65},"updated":"2017-02-09 01:34:41.000000000","message":"The remote ip will be set here. I think your spec is based on an old implementation. pls see this spec for the change:\n\nhttps://review.openstack.org/#/c/379883/","commit_id":"535efc27cf3a03938a6869021401b7db18cc62b5"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"905887504b67e1f028f7d71defef7fdbf1830098","unresolved":false,"context_lines":[{"line_number":157,"context_line":""},{"line_number":158,"context_line":"Proposed Change"},{"line_number":159,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":160,"context_line":"L2 application will deal with all local network flows that are niether related"},{"line_number":161,"context_line":"to how the packets arrived at the integration switch, nor how they leave."},{"line_number":162,"context_line":"It will be up to other application to set the flows that translte the local"},{"line_number":163,"context_line":"destintion port to reg7, and remote reg7 to pushing the packet down stream."}],"source_content_type":"text/x-rst","patch_set":7,"id":"1a430d35_71e9acb6","line":160,"range":{"start_line":160,"start_character":63,"end_line":160,"end_character":70},"updated":"2017-02-09 01:34:41.000000000","message":"neither?","commit_id":"535efc27cf3a03938a6869021401b7db18cc62b5"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"905887504b67e1f028f7d71defef7fdbf1830098","unresolved":false,"context_lines":[{"line_number":165,"context_line":""},{"line_number":166,"context_line":"Ingress processing"},{"line_number":167,"context_line":"------------------"},{"line_number":168,"context_line":"it will set the tunnel matching classification flow in table 0,  and forward"},{"line_number":169,"context_line":"it to l2 lookup table, 17 instead of ingress port lookup table 7. The looup"},{"line_number":170,"context_line":"mechnism should treat all port equily and filter according to port key."},{"line_number":171,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"1a430d35_f1d59ce4","line":168,"range":{"start_line":168,"start_character":0,"end_line":168,"end_character":2},"updated":"2017-02-09 01:34:41.000000000","message":"It","commit_id":"535efc27cf3a03938a6869021401b7db18cc62b5"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"905887504b67e1f028f7d71defef7fdbf1830098","unresolved":false,"context_lines":[{"line_number":171,"context_line":""},{"line_number":172,"context_line":"::"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"   table\u003d0, priority\u003d100,in_port\u003d4,tun_id\u003d0x13 actions\u003dload:0x3-\u003eOXM_OF_METADATA[],resubmit(,17)"},{"line_number":176,"context_line":"   table\u003d0, priority\u003d100,in_port\u003d4,tun_id\u003d0x49 actions\u003dload:0x1-\u003eOXM_OF_METADATA[],resubmit(,17)"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"Egress processing"}],"source_content_type":"text/x-rst","patch_set":7,"id":"1a430d35_6c70f3a4","line":176,"range":{"start_line":174,"start_character":0,"end_line":176,"end_character":96},"updated":"2017-02-09 01:34:41.000000000","message":"Merging L2_LOOKUP_TABLE(table 17) and INGRESS_DESTINATION_PORT_LOOKUP_TABLE(table 7) will make the packets to router interface not work. It is better to keep them as 2 tables for now, though there are some duplicates in these 2 tables.","commit_id":"535efc27cf3a03938a6869021401b7db18cc62b5"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"905887504b67e1f028f7d71defef7fdbf1830098","unresolved":false,"context_lines":[{"line_number":189,"context_line":""},{"line_number":190,"context_line":"Impact on other DF applications"},{"line_number":191,"context_line":"-------------------------------"},{"line_number":192,"context_line":"The changes in the L2 application will affect the Provider Network App. Dnat App, Snat App etc.."}],"source_content_type":"text/x-rst","patch_set":7,"id":"1a430d35_6ca7130b","line":192,"range":{"start_line":192,"start_character":0,"end_line":192,"end_character":96},"updated":"2017-02-09 01:34:41.000000000","message":"Can you elaborate what is the impact?","commit_id":"535efc27cf3a03938a6869021401b7db18cc62b5"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"8b4993b30e50d1fd5476457aaa4f18a6f002814f","unresolved":false,"context_lines":[{"line_number":93,"context_line":""},{"line_number":94,"context_line":"Egress Proccessing"},{"line_number":95,"context_line":"------------------"},{"line_number":96,"context_line":"A classification flow related to egress dispatching  is set to be initially"},{"line_number":97,"context_line":"filtered by the security table the flow sets port key and network id to reg6,"},{"line_number":98,"context_line":"and metadata ovs registers, respectively."},{"line_number":99,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"fa31d9ce_8ae4003c","line":96,"range":{"start_line":96,"start_character":51,"end_line":96,"end_character":53},"updated":"2017-02-10 03:02:31.000000000","message":"nit: extra space","commit_id":"99492a24946175ce4bed4d5bcb7ba089748ad618"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"8b4993b30e50d1fd5476457aaa4f18a6f002814f","unresolved":false,"context_lines":[{"line_number":94,"context_line":"Egress Proccessing"},{"line_number":95,"context_line":"------------------"},{"line_number":96,"context_line":"A classification flow related to egress dispatching  is set to be initially"},{"line_number":97,"context_line":"filtered by the security table the flow sets port key and network id to reg6,"},{"line_number":98,"context_line":"and metadata ovs registers, respectively."},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"::"}],"source_content_type":"text/x-rst","patch_set":8,"id":"fa31d9ce_eac9fcad","line":97,"range":{"start_line":97,"start_character":30,"end_line":97,"end_character":31},"updated":"2017-02-10 03:02:31.000000000","message":"miss comma here?","commit_id":"99492a24946175ce4bed4d5bcb7ba089748ad618"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"8b4993b30e50d1fd5476457aaa4f18a6f002814f","unresolved":false,"context_lines":[{"line_number":116,"context_line":""},{"line_number":117,"context_line":"::"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"    table\u003d3, priority\u003d1 actions\u003dresubmit(,9)"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"Egress processing - L2 lookup"},{"line_number":122,"context_line":"-----------------------------"}],"source_content_type":"text/x-rst","patch_set":8,"id":"fa31d9ce_6a550cc5","line":119,"range":{"start_line":119,"start_character":3,"end_line":119,"end_character":11},"updated":"2017-02-10 03:02:31.000000000","message":"The table id here is not updated.","commit_id":"99492a24946175ce4bed4d5bcb7ba089748ad618"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"8b4993b30e50d1fd5476457aaa4f18a6f002814f","unresolved":false,"context_lines":[{"line_number":152,"context_line":""},{"line_number":153,"context_line":"::"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"    table\u003d75,reg7\u003d0xc actions\u003dload:0x49-\u003eNXM_NX_TUN_ID[],load:D-\u003eNXM_NX_TUN_IPV4_DST[],output:8"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"Proposed Change"},{"line_number":158,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":8,"id":"fa31d9ce_ea573cc8","line":155,"range":{"start_line":155,"start_character":62,"end_line":155,"end_character":63},"updated":"2017-02-10 03:02:31.000000000","message":"better to describe the \u0027D\u0027 here, or just change it to a actual ip.","commit_id":"99492a24946175ce4bed4d5bcb7ba089748ad618"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"8b4993b30e50d1fd5476457aaa4f18a6f002814f","unresolved":false,"context_lines":[{"line_number":156,"context_line":""},{"line_number":157,"context_line":"Proposed Change"},{"line_number":158,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":159,"context_line":"L2 application will deal with all local network flows that are niether related"},{"line_number":160,"context_line":"to how the packets arrived at the integration switch, nor how they leave."},{"line_number":161,"context_line":"It will be up to other application to set the flows that translte the local"},{"line_number":162,"context_line":"destintion port to reg7, and remote reg7 to pushing the packet down stream."}],"source_content_type":"text/x-rst","patch_set":8,"id":"fa31d9ce_4a6f6892","line":159,"range":{"start_line":159,"start_character":63,"end_line":159,"end_character":70},"updated":"2017-02-10 03:02:31.000000000","message":"neither?","commit_id":"99492a24946175ce4bed4d5bcb7ba089748ad618"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"8b4993b30e50d1fd5476457aaa4f18a6f002814f","unresolved":false,"context_lines":[{"line_number":188,"context_line":""},{"line_number":189,"context_line":"Impact on other DF applications"},{"line_number":190,"context_line":"-------------------------------"},{"line_number":191,"context_line":"The changes in the L2 application will affect the Provider Network App. Dnat App, Snat App etc.."}],"source_content_type":"text/x-rst","patch_set":8,"id":"fa31d9ce_2af954c9","line":191,"range":{"start_line":191,"start_character":0,"end_line":191,"end_character":96},"updated":"2017-02-10 03:02:31.000000000","message":"Can you elaborate what is the impact? Or maybe just delete this sentence?","commit_id":"99492a24946175ce4bed4d5bcb7ba089748ad618"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"e8119b27207ba34c2d3ec11d88da4857f373b492","unresolved":false,"context_lines":[{"line_number":153,"context_line":""},{"line_number":154,"context_line":"::"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"    table\u003d75,reg7\u003d0xc actions\u003dload:0x49-\u003eNXM_NX_TUN_ID[],load:D-\u003eNXM_NX_TUN_IPV4_DST[],output:8"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"Proposed Change"},{"line_number":159,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":9,"id":"fa31d9ce_b2949de2","line":156,"range":{"start_line":156,"start_character":62,"end_line":156,"end_character":63},"updated":"2017-02-12 08:53:27.000000000","message":"\u0027D\u0027 is still not defined.","commit_id":"b2ebb347215f90646a36586dc7c0d19c08d198e7"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"e8119b27207ba34c2d3ec11d88da4857f373b492","unresolved":false,"context_lines":[{"line_number":186,"context_line":""},{"line_number":187,"context_line":"   table\u003d75, priority\u003d100,reg7\u003d0xa actions\u003dresubmit(,105)"},{"line_number":188,"context_line":"   table\u003d100, priority\u003d100,metadata\u003d0x1,dl_dst\u003d01:00:00:00:00:00/01:00:00:00:00:00 actions\u003dload:0xa-\u003eNXM_NX_REG7[],resubmit(,75),load:0x2-\u003eNXM_NX_REG7[],resubmit(,75),load:0-\u003eNXM_NX_REG7[],resubmit(,75)"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"fa31d9ce_52a3614f","line":189,"updated":"2017-02-12 08:53:27.000000000","message":"App impact still missing. I think the impact on dNAT and sNAT is important, since it should allow us to greatly improve these applications.","commit_id":"b2ebb347215f90646a36586dc7c0d19c08d198e7"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"e8119b27207ba34c2d3ec11d88da4857f373b492","unresolved":false,"context_lines":[{"line_number":187,"context_line":"   table\u003d75, priority\u003d100,reg7\u003d0xa actions\u003dresubmit(,105)"},{"line_number":188,"context_line":"   table\u003d100, priority\u003d100,metadata\u003d0x1,dl_dst\u003d01:00:00:00:00:00/01:00:00:00:00:00 actions\u003dload:0xa-\u003eNXM_NX_REG7[],resubmit(,75),load:0x2-\u003eNXM_NX_REG7[],resubmit(,75),load:0-\u003eNXM_NX_REG7[],resubmit(,75)"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"fa31d9ce_b2fd7d3c","line":190,"updated":"2017-02-12 08:53:27.000000000","message":"Work items still missing.","commit_id":"b2ebb347215f90646a36586dc7c0d19c08d198e7"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"eabcfdceeeb2ebe12ef7235e5b250519db73af0a","unresolved":false,"context_lines":[{"line_number":191,"context_line":"-------------------------------"},{"line_number":192,"context_line":"The changes in the L2 application will affect the Provider Networks App. Dnat App, Snat App et al."},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"According to the propsed design, L2 application deals with local chassis flows, while t"},{"line_number":195,"context_line":"Provider networks"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"Work Items"},{"line_number":198,"context_line":"----------"}],"source_content_type":"text/x-rst","patch_set":11,"id":"fa31d9ce_0827f8b6","line":195,"range":{"start_line":194,"start_character":85,"end_line":195,"end_character":17},"updated":"2017-02-12 12:30:24.000000000","message":"something is missing","commit_id":"4f55c9d3309fb505971b7e659a86290a751637c6"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"eabcfdceeeb2ebe12ef7235e5b250519db73af0a","unresolved":false,"context_lines":[{"line_number":197,"context_line":"Work Items"},{"line_number":198,"context_line":"----------"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"1. Create a new tunneling application and add it to the \"Plugin.sh\"."},{"line_number":201,"context_line":"2. Remove the tunneling code from the l2 application."},{"line_number":202,"context_line":"3. Add unit tests, to refelect code changes."}],"source_content_type":"text/x-rst","patch_set":11,"id":"fa31d9ce_282afc7e","line":200,"range":{"start_line":200,"start_character":37,"end_line":200,"end_character":68},"updated":"2017-02-12 12:30:24.000000000","message":"separate item for devstack update","commit_id":"4f55c9d3309fb505971b7e659a86290a751637c6"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"eabcfdceeeb2ebe12ef7235e5b250519db73af0a","unresolved":false,"context_lines":[{"line_number":199,"context_line":""},{"line_number":200,"context_line":"1. Create a new tunneling application and add it to the \"Plugin.sh\"."},{"line_number":201,"context_line":"2. Remove the tunneling code from the l2 application."},{"line_number":202,"context_line":"3. Add unit tests, to refelect code changes."}],"source_content_type":"text/x-rst","patch_set":11,"id":"fa31d9ce_4821f09e","line":202,"range":{"start_line":202,"start_character":22,"end_line":202,"end_character":31},"updated":"2017-02-12 12:30:24.000000000","message":"reflect","commit_id":"4f55c9d3309fb505971b7e659a86290a751637c6"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"ffd52f5a3ab66a0fe7e89166d2f5b48851f37163","unresolved":false,"context_lines":[{"line_number":153,"context_line":""},{"line_number":154,"context_line":"::"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"    table\u003d75,reg7\u003d0xc actions\u003dload:0x49-\u003eNXM_NX_TUN_ID[],load:192.168.20.22-\u003eNXM_NX_TUN_IPV4_DST[],output:8"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"Proposed Change"},{"line_number":159,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":12,"id":"fa31d9ce_cfab1f88","line":156,"range":{"start_line":156,"start_character":62,"end_line":156,"end_character":75},"updated":"2017-02-13 02:24:22.000000000","message":"Instead of a string of ip address, it is actually a hex represents the ip address that is loaded here.","commit_id":"f00ee689f92b60966d0bd8b290ac738b8a56393f"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"ffd52f5a3ab66a0fe7e89166d2f5b48851f37163","unresolved":false,"context_lines":[{"line_number":192,"context_line":"The changes in the L2 application will affect the Provider Networks App. DNAT App, SNAT App et al."},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"According to the propsed design, L2 application deals with local chassis flows, while"},{"line_number":195,"context_line":"the \u0027tunnling-app\u0027, \u0027provider networks app\u0027, \u0027DNAT app\u0027 and \u0027SNAT app\u0027, should deal"},{"line_number":196,"context_line":"with setting the flows for incoming/outgoing packets to/from external nodes."},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"Work Items"}],"source_content_type":"text/x-rst","patch_set":12,"id":"fa31d9ce_2f9f5b51","line":195,"range":{"start_line":195,"start_character":5,"end_line":195,"end_character":17},"updated":"2017-02-13 02:24:22.000000000","message":"tunneling app?","commit_id":"f00ee689f92b60966d0bd8b290ac738b8a56393f"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"ffd52f5a3ab66a0fe7e89166d2f5b48851f37163","unresolved":false,"context_lines":[{"line_number":193,"context_line":""},{"line_number":194,"context_line":"According to the propsed design, L2 application deals with local chassis flows, while"},{"line_number":195,"context_line":"the \u0027tunnling-app\u0027, \u0027provider networks app\u0027, \u0027DNAT app\u0027 and \u0027SNAT app\u0027, should deal"},{"line_number":196,"context_line":"with setting the flows for incoming/outgoing packets to/from external nodes."},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"Work Items"},{"line_number":199,"context_line":"----------"}],"source_content_type":"text/x-rst","patch_set":12,"id":"fa31d9ce_afb98bcd","line":196,"range":{"start_line":196,"start_character":53,"end_line":196,"end_character":60},"updated":"2017-02-13 02:24:22.000000000","message":"nit: from/to","commit_id":"f00ee689f92b60966d0bd8b290ac738b8a56393f"}]}