)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"62bd27e64c89fa54fd5e212a85178add03ad6970","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Omer Anson \u003comer.anson@toganetworks.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-01-16 11:43:17 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Use policy_id instead of tenant_id in qos notificatio"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Neutron changed their API to not pass tenant_id here:"},{"line_number":10,"context_line":"https://review.openstack.org/#/c/382659"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7a3c09a3_ad7dfd6f","line":7,"range":{"start_line":7,"start_character":4,"end_line":7,"end_character":13},"updated":"2017-01-16 09:51:51.000000000","message":"why not project_id?","commit_id":"8ca231adac25d35500175c136c4f7d7ea59c2ca6"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"024531515d5cd6d64e65be0ef2057a9f00ec2065","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Omer Anson \u003comer.anson@toganetworks.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-01-16 11:43:17 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Use policy_id instead of tenant_id in qos notificatio"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Neutron changed their API to not pass tenant_id here:"},{"line_number":10,"context_line":"https://review.openstack.org/#/c/382659"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7a3c09a3_e480fa48","line":7,"range":{"start_line":7,"start_character":4,"end_line":7,"end_character":13},"in_reply_to":"7a3c09a3_ad7dfd6f","updated":"2017-01-16 11:27:13.000000000","message":"Typo. Will fix.","commit_id":"8ca231adac25d35500175c136c4f7d7ea59c2ca6"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"729a2766e16bb4edd13dbf2798c7d4977931ce02","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Omer Anson \u003comer.anson@toganetworks.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-01-16 14:51:33 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Use project_id instead of tenant_id in qos notificatio"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Neutron changed their API to not pass tenant_id here:"},{"line_number":10,"context_line":"https://review.openstack.org/#/c/382659"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7a3c09a3_c57215ad","line":7,"range":{"start_line":7,"start_character":52,"end_line":7,"end_character":54},"updated":"2017-01-16 13:33:22.000000000","message":"n","commit_id":"528a660da75dad9fd4fcc50f311a874f119d659e"}],"dragonflow/neutron/services/qos/notification_drivers/df_qos_notification_driver.py":[{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"729a2766e16bb4edd13dbf2798c7d4977931ce02","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        policy_neutron \u003d self._plugin.get_policy(context, policy_id)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        self.nb_api.update_qos_policy("},{"line_number":59,"context_line":"            policy_id, policy[\u0027project_id\u0027],"},{"line_number":60,"context_line":"            name\u003dpolicy[\u0027name\u0027], rules\u003dpolicy_neutron[\u0027rules\u0027],"},{"line_number":61,"context_line":"            version\u003dpolicy_neutron[\u0027revision_number\u0027])"},{"line_number":62,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7a3c09a3_45e4653a","line":59,"range":{"start_line":59,"start_character":23,"end_line":59,"end_character":44},"updated":"2017-01-16 13:33:22.000000000","message":"you have changed here the non related part, but it seems to be correct, since project_id cannot be updated","commit_id":"528a660da75dad9fd4fcc50f311a874f119d659e"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"cfa518e22aca72bfb755b1371725395303078c05","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        policy_neutron \u003d self._plugin.get_policy(context, policy_id)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        self.nb_api.update_qos_policy("},{"line_number":59,"context_line":"            policy_id, policy[\u0027project_id\u0027],"},{"line_number":60,"context_line":"            name\u003dpolicy[\u0027name\u0027], rules\u003dpolicy_neutron[\u0027rules\u0027],"},{"line_number":61,"context_line":"            version\u003dpolicy_neutron[\u0027revision_number\u0027])"},{"line_number":62,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7a3c09a3_523b429c","line":59,"range":{"start_line":59,"start_character":23,"end_line":59,"end_character":44},"in_reply_to":"7a3c09a3_45e4653a","updated":"2017-01-16 16:06:15.000000000","message":"1. My understanding was that tenant_id was removed. That\u0027s what caused the failure.\n2. It\u0027s possible that the above is true only for create_policy, but I wanted to stay consistent in the code.","commit_id":"528a660da75dad9fd4fcc50f311a874f119d659e"}],"dragonflow/tests/unit/test_df_qos_notification_driver.py":[{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"729a2766e16bb4edd13dbf2798c7d4977931ce02","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    def _test_create_policy(self):"},{"line_number":44,"context_line":"        qos_policy \u003d {\u0027policy\u0027: {\u0027name\u0027: \"policy1\","},{"line_number":45,"context_line":"                                 \u0027tenant_id\u0027: \"tenant1\","},{"line_number":46,"context_line":"                                 \u0027project_id\u0027: \u0027project1\u0027}}"},{"line_number":47,"context_line":"        qos_obj \u003d self.plugin.create_policy(self.context, qos_policy)"},{"line_number":48,"context_line":"        self.assertGreater(qos_obj[\u0027revision_number\u0027], 0)"},{"line_number":49,"context_line":"        self.driver.nb_api.create_qos_policy.assert_called_with("}],"source_content_type":"text/x-python","patch_set":4,"id":"7a3c09a3_853bad9b","line":46,"range":{"start_line":45,"start_character":32,"end_line":46,"end_character":58},"updated":"2017-01-16 13:33:22.000000000","message":"why project_id was added and not replaces tenant_id?","commit_id":"528a660da75dad9fd4fcc50f311a874f119d659e"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"cfa518e22aca72bfb755b1371725395303078c05","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    def _test_create_policy(self):"},{"line_number":44,"context_line":"        qos_policy \u003d {\u0027policy\u0027: {\u0027name\u0027: \"policy1\","},{"line_number":45,"context_line":"                                 \u0027tenant_id\u0027: \"tenant1\","},{"line_number":46,"context_line":"                                 \u0027project_id\u0027: \u0027project1\u0027}}"},{"line_number":47,"context_line":"        qos_obj \u003d self.plugin.create_policy(self.context, qos_policy)"},{"line_number":48,"context_line":"        self.assertGreater(qos_obj[\u0027revision_number\u0027], 0)"},{"line_number":49,"context_line":"        self.driver.nb_api.create_qos_policy.assert_called_with("}],"source_content_type":"text/x-python","patch_set":4,"id":"7a3c09a3_925ccaee","line":46,"range":{"start_line":45,"start_character":32,"end_line":46,"end_character":58},"in_reply_to":"7a3c09a3_853bad9b","updated":"2017-01-16 16:06:15.000000000","message":"There is no real reason. Possibly because I was distracted :)\nWill fix.","commit_id":"528a660da75dad9fd4fcc50f311a874f119d659e"}]}