)]}'
{"dragonflow/controller/df_base_app.py":[{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"1f78a300b55af0b78bc0e1f4d05322311c0cf5fc","unresolved":false,"context_lines":[{"line_number":101,"context_line":"    def _send_packet(self, datapath, port, pkt):"},{"line_number":102,"context_line":"        ofproto \u003d datapath.ofproto"},{"line_number":103,"context_line":"        parser \u003d datapath.ofproto_parser"},{"line_number":104,"context_line":"        pkt.serialize()"},{"line_number":105,"context_line":"        data \u003d pkt.data"},{"line_number":106,"context_line":"        actions \u003d [parser.OFPActionOutput(port\u003dport)]"},{"line_number":107,"context_line":"        out \u003d parser.OFPPacketOut(datapath\u003ddatapath,"},{"line_number":108,"context_line":"                                  buffer_id\u003dofproto.OFP_NO_BUFFER,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a3905b3_d7947444","side":"PARENT","line":105,"range":{"start_line":104,"start_character":0,"end_line":105,"end_character":23},"updated":"2017-01-21 13:47:58.000000000","message":"So all the calls to serialize() were redundant?","commit_id":"fa686e543f67eb8744a3be1a4c36b671b7ce0bcd"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"b707af57b189f8407e20d4fa001717548326745b","unresolved":false,"context_lines":[{"line_number":101,"context_line":"    def _send_packet(self, datapath, port, pkt):"},{"line_number":102,"context_line":"        ofproto \u003d datapath.ofproto"},{"line_number":103,"context_line":"        parser \u003d datapath.ofproto_parser"},{"line_number":104,"context_line":"        pkt.serialize()"},{"line_number":105,"context_line":"        data \u003d pkt.data"},{"line_number":106,"context_line":"        actions \u003d [parser.OFPActionOutput(port\u003dport)]"},{"line_number":107,"context_line":"        out \u003d parser.OFPPacketOut(datapath\u003ddatapath,"},{"line_number":108,"context_line":"                                  buffer_id\u003dofproto.OFP_NO_BUFFER,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a3905b3_15bd0f02","side":"PARENT","line":105,"range":{"start_line":104,"start_character":0,"end_line":105,"end_character":23},"in_reply_to":"5a3905b3_d7947444","updated":"2017-01-22 01:28:33.000000000","message":"The operation is not redundant, but the code is redundant. Ryu will do the serialization if the data is a packet. So, if it is a packet at the beginning, we can just let ryu to do the job. Will update the commit msg.\n\nhttps://github.com/osrg/ryu/blob/9ccec7bb5aa9746e74d44bbf151ae18ac7ccdd06/ryu/ofproto/ofproto_v1_3_parser.py#L2557-L2561","commit_id":"fa686e543f67eb8744a3be1a4c36b671b7ce0bcd"}]}