)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"17989917437e69dd0820e3f3fb2c08ab0460e844","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"NbApi: Use SEND_ALL_TOPIC when topic is omitted"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Chassis objects are not bound to a specific tenant (as are services in"},{"line_number":10,"context_line":"the future, and maybe other objects), so it makes sense to forward these"},{"line_number":11,"context_line":"notifications to everyone (this happens implicitly in zmq driver"},{"line_number":12,"context_line":"anyway)."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5a3905b3_75f013ff","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":70},"updated":"2017-01-22 01:24:24.000000000","message":"chassis don\u0027t use method in this patch to publish event. Actually, chassis are using method at [1] to publish event, which is implicitly \"SEND_ALL_TOPIC\". So, is this patch needed? Or maybe you want to update the commit message.\n\n[1] https://github.com/openstack/dragonflow/blob/21cbb720f9d449b77370110d916fd2932975b32a/dragonflow/db/pub_sub_api.py#L294","commit_id":"f20249d4a1733cf53b330396c988e1650a5156db"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"57ecfc9c53e79d71c3e48896157bc5e3b21e8edf","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Some models do not have a specific topic for their objects (because they"},{"line_number":10,"context_line":"do not belong to a specific tenant), but it still makes sense to"},{"line_number":11,"context_line":"distribute them (e.g. a chassis is updated). This patch enables the"},{"line_number":12,"context_line":"distribution of None-topic objects resulting from northbound refactor."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I3e5364e12baade924394a4113f620106f500422e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5a3905b3_cae674af","line":11,"range":{"start_line":11,"start_character":21,"end_line":11,"end_character":42},"updated":"2017-01-23 01:11:19.000000000","message":"As I mentioned, chassis don\u0027t use the code in this patch to distribute event. It uses the TableMonitor in df-publisher-service to broadcast the chassis event to all topics. You can say you want to distribute object without topic to all topics, but pls don\u0027t mention chassis here, which makes things confusing.","commit_id":"d7869f155d131820ad3791eef5cb9062d80db7af"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"4322a5e68204a8b81aef2a315fb0085c9e4c69a4","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Some models do not have a specific topic for their objects (because they"},{"line_number":10,"context_line":"do not belong to a specific tenant), but it still makes sense to"},{"line_number":11,"context_line":"distribute them (e.g. a chassis is updated). This patch enables the"},{"line_number":12,"context_line":"distribution of None-topic objects resulting from northbound refactor."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I3e5364e12baade924394a4113f620106f500422e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"5a3905b3_0d612da9","line":11,"range":{"start_line":11,"start_character":16,"end_line":11,"end_character":44},"updated":"2017-01-24 09:36:15.000000000","message":"It looks like you are using commit msg from PS3.","commit_id":"e86092ab993aabee2d90f4b92e8bb5a3a728c27e"},{"author":{"_account_id":23766,"name":"Dima Kuznetsov","email":"dima.kuznetsov@toganetworks.com","username":"dimak"},"change_message_id":"19c5d3db327d381b9a9137fde4cd6e1c71f78384","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Some models do not have a specific topic for their objects (because they"},{"line_number":10,"context_line":"do not belong to a specific tenant), but it still makes sense to"},{"line_number":11,"context_line":"distribute them (e.g. a chassis is updated). This patch enables the"},{"line_number":12,"context_line":"distribution of None-topic objects resulting from northbound refactor."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I3e5364e12baade924394a4113f620106f500422e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"5a3905b3_486de3ca","line":11,"range":{"start_line":11,"start_character":16,"end_line":11,"end_character":44},"in_reply_to":"5a3905b3_0d612da9","updated":"2017-01-24 12:02:14.000000000","message":"You\u0027re right, sorry, bad rebase.","commit_id":"e86092ab993aabee2d90f4b92e8bb5a3a728c27e"}],"dragonflow/db/api_nb.py":[{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"9f16e3ef2c98e0eabd7271da36da2ed3a6b2fb79","unresolved":false,"context_lines":[{"line_number":153,"context_line":"        if not self.use_pubsub:"},{"line_number":154,"context_line":"            return"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"        if not self.enable_selective_topo_dist or topic is None:"},{"line_number":157,"context_line":"            topic \u003d db_common.SEND_ALL_TOPIC"},{"line_number":158,"context_line":"        update \u003d db_common.DbUpdate(table, key, action, value, topic\u003dtopic)"},{"line_number":159,"context_line":"        self.publisher.send_event(update)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a3905b3_3309a796","line":156,"range":{"start_line":156,"start_character":7,"end_line":156,"end_character":63},"updated":"2017-01-19 16:49:27.000000000","message":"why not set topic by default to SEND_ALL?","commit_id":"f20249d4a1733cf53b330396c988e1650a5156db"},{"author":{"_account_id":23766,"name":"Dima Kuznetsov","email":"dima.kuznetsov@toganetworks.com","username":"dimak"},"change_message_id":"fe6b0eae8c39ebbd61f7749cae54670dc6fcb56d","unresolved":false,"context_lines":[{"line_number":153,"context_line":"        if not self.use_pubsub:"},{"line_number":154,"context_line":"            return"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"        if not self.enable_selective_topo_dist or topic is None:"},{"line_number":157,"context_line":"            topic \u003d db_common.SEND_ALL_TOPIC"},{"line_number":158,"context_line":"        update \u003d db_common.DbUpdate(table, key, action, value, topic\u003dtopic)"},{"line_number":159,"context_line":"        self.publisher.send_event(update)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a3905b3_8edac94a","line":156,"range":{"start_line":156,"start_character":7,"end_line":156,"end_character":63},"in_reply_to":"5a3905b3_3309a796","updated":"2017-01-22 08:19:38.000000000","message":"We can but IMO it will make the code worse.\n\nWe always call _send_db_change_event with all the parameters, where topic usually comes from neutron context\u0027s tenanat_id.\n\nTo take advantage of the default argument we\u0027ll hate to change all the call to check their topic:\n\n if topic is not None:\n     self._send_db_change_event(table, key, action, value, topic)\n else:\n     self._send_db_change_event(table, key, action, value)\n\nI don\u0027t think we add a lot of value. Other thing we can do is extract specify SEND_ALL_TOPIC as default topic when extracting it, e.g.\n\n topic \u003d current.get(\u0027tenant_id\u0027, SEND_ALL_TOPIC)\n\nBut I think None expresses lack of topic well enough.","commit_id":"f20249d4a1733cf53b330396c988e1650a5156db"}]}