)]}'
{"dragonflow/tests/common/app_testing_objects.py":[{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"a2af101e8d01dd4527efd24ce50d67e772025879","unresolved":false,"context_lines":[{"line_number":170,"context_line":"        external_net \u003d objects.find_first_network(self.neutron,"},{"line_number":171,"context_line":"                                                  {\u0027router:external\u0027: True})"},{"line_number":172,"context_line":"        if external_net:"},{"line_number":173,"context_line":"            self.exist_external_net \u003d True"},{"line_number":174,"context_line":"            external_net_id \u003d external_net[\u0027id\u0027]"},{"line_number":175,"context_line":"        else:"},{"line_number":176,"context_line":"            external_net_id \u003d self.external_network.create()"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a461143_512b2494","line":173,"range":{"start_line":173,"start_character":0,"end_line":173,"end_character":42},"updated":"2017-01-29 09:08:43.000000000","message":"Doesn\u0027t this need to be set in the else block too?","commit_id":"c6ff57f9160d5ae224bf3f01b8e70e7d5d64fb66"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"d7840c08a347bf3c8fcd2e9dd6336febc2a4b032","unresolved":false,"context_lines":[{"line_number":170,"context_line":"        external_net \u003d objects.find_first_network(self.neutron,"},{"line_number":171,"context_line":"                                                  {\u0027router:external\u0027: True})"},{"line_number":172,"context_line":"        if external_net:"},{"line_number":173,"context_line":"            self.exist_external_net \u003d True"},{"line_number":174,"context_line":"            external_net_id \u003d external_net[\u0027id\u0027]"},{"line_number":175,"context_line":"        else:"},{"line_number":176,"context_line":"            external_net_id \u003d self.external_network.create()"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a430d35_83baf621","line":173,"range":{"start_line":173,"start_character":0,"end_line":173,"end_character":42},"in_reply_to":"1a430d35_9abb7175","updated":"2017-02-05 08:01:40.000000000","message":"I see it now. Thanks.","commit_id":"c6ff57f9160d5ae224bf3f01b8e70e7d5d64fb66"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"a196f01227800c97d7a7d428ed87d9343b730120","unresolved":false,"context_lines":[{"line_number":170,"context_line":"        external_net \u003d objects.find_first_network(self.neutron,"},{"line_number":171,"context_line":"                                                  {\u0027router:external\u0027: True})"},{"line_number":172,"context_line":"        if external_net:"},{"line_number":173,"context_line":"            self.exist_external_net \u003d True"},{"line_number":174,"context_line":"            external_net_id \u003d external_net[\u0027id\u0027]"},{"line_number":175,"context_line":"        else:"},{"line_number":176,"context_line":"            external_net_id \u003d self.external_network.create()"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a430d35_9abb7175","line":173,"range":{"start_line":173,"start_character":0,"end_line":173,"end_character":42},"in_reply_to":"3a461143_512b2494","updated":"2017-02-03 02:16:48.000000000","message":"This attribute is used for reserving the existing external network. It will only be set to True when there is external network before the test. And when it is True, the external network will not be deleted when the test is torn down. So it should only be in the if block.","commit_id":"c6ff57f9160d5ae224bf3f01b8e70e7d5d64fb66"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"a2af101e8d01dd4527efd24ce50d67e772025879","unresolved":false,"context_lines":[{"line_number":190,"context_line":"        :param topology:  The topology to which the subnet belongs"},{"line_number":191,"context_line":"        :type topology:   Topology"},{"line_number":192,"context_line":"        :param subnet_id: The subnet\u0027s ID in the topology. Created by topology"},{"line_number":193,"context_line":"        :type subnet_id:  Number (Opaque)"},{"line_number":194,"context_line":"        \"\"\""},{"line_number":195,"context_line":"        self.topology \u003d topology"},{"line_number":196,"context_line":"        self.subnet_id \u003d subnet_id"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a461143_711ae07e","line":193,"updated":"2017-01-29 09:08:43.000000000","message":"I\u0027d leave the comment (may mark it as part of the kwargs). In a different patch, we should add the \u0027enable_dhcp\u0027 param as well.","commit_id":"c6ff57f9160d5ae224bf3f01b8e70e7d5d64fb66"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"a196f01227800c97d7a7d428ed87d9343b730120","unresolved":false,"context_lines":[{"line_number":190,"context_line":"        :param topology:  The topology to which the subnet belongs"},{"line_number":191,"context_line":"        :type topology:   Topology"},{"line_number":192,"context_line":"        :param subnet_id: The subnet\u0027s ID in the topology. Created by topology"},{"line_number":193,"context_line":"        :type subnet_id:  Number (Opaque)"},{"line_number":194,"context_line":"        \"\"\""},{"line_number":195,"context_line":"        self.topology \u003d topology"},{"line_number":196,"context_line":"        self.subnet_id \u003d subnet_id"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a430d35_65be2a01","line":193,"in_reply_to":"3a461143_711ae07e","updated":"2017-02-03 02:16:48.000000000","message":"Done","commit_id":"c6ff57f9160d5ae224bf3f01b8e70e7d5d64fb66"}]}