)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"e7f3c220dd86e04a839ccc802895f7e7f74b6856","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     itamaro \u003citamar.ofek@huawei.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-01-26 12:03:05 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"adding parser and ofproto porprties to df_base_app"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ifda4d4a15c568decf5389845331b6da9adf5d895"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3a461143_31fbf848","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":6},"updated":"2017-01-29 08:11:15.000000000","message":"Adding","commit_id":"c7db21abea06f34423055b49df72c765341bb26c"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"e7f3c220dd86e04a839ccc802895f7e7f74b6856","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     itamaro \u003citamar.ofek@huawei.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-01-26 12:03:05 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"adding parser and ofproto porprties to df_base_app"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ifda4d4a15c568decf5389845331b6da9adf5d895"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3a461143_11027c3d","line":7,"range":{"start_line":7,"start_character":26,"end_line":7,"end_character":35},"updated":"2017-01-29 08:11:15.000000000","message":"properties","commit_id":"c7db21abea06f34423055b49df72c765341bb26c"}],"dragonflow/controller/df_base_app.py":[{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"ccb4ef73b38d1852abef7a53b63d5561dcdfb4ae","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        \"\"\""},{"line_number":49,"context_line":"        self.add_remote_port(lport)"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    def get_datapath(self):"},{"line_number":52,"context_line":"        return self.api.datapath"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    @property"},{"line_number":55,"context_line":"    def parser(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a3905b3_30ec508f","line":52,"range":{"start_line":51,"start_character":0,"end_line":52,"end_character":32},"updated":"2017-01-25 02:53:59.000000000","message":"nit: may be this could be a property too.","commit_id":"20b722f6ed2ee5199ab9089723a94ab0bce3781c"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"e696bd6be1e974db8367172b26c07beca2ad1e07","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        \"\"\""},{"line_number":49,"context_line":"        self.add_remote_port(lport)"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    def get_datapath(self):"},{"line_number":52,"context_line":"        return self.api.datapath"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    @property"},{"line_number":55,"context_line":"    def parser(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a461143_1177dcd3","line":52,"range":{"start_line":51,"start_character":0,"end_line":52,"end_character":32},"in_reply_to":"3a461143_869e9754","updated":"2017-01-29 08:36:18.000000000","message":"Allowing this, since this is indeed not part of this patch.","commit_id":"20b722f6ed2ee5199ab9089723a94ab0bce3781c"},{"author":{"_account_id":18347,"name":"Itamar Ofek","email":"itamofek@netscape.net","username":"itamaro"},"change_message_id":"a47d0937447f716fca6da65550eb2c3e258f46c5","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        \"\"\""},{"line_number":49,"context_line":"        self.add_remote_port(lport)"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    def get_datapath(self):"},{"line_number":52,"context_line":"        return self.api.datapath"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    @property"},{"line_number":55,"context_line":"    def parser(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a461143_869e9754","line":52,"range":{"start_line":51,"start_character":0,"end_line":52,"end_character":32},"in_reply_to":"3a461143_edef3eae","updated":"2017-01-26 09:16:48.000000000","message":"Xiao. Yes I beleive this patch is in due. do you volunteer","commit_id":"20b722f6ed2ee5199ab9089723a94ab0bce3781c"},{"author":{"_account_id":14249,"name":"Lionel Zerbib","email":"ariel.zerbib@gmail.com","username":"lionelz"},"change_message_id":"609ddedd00fd0087e51ef1e2c2c274f165605692","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        \"\"\""},{"line_number":49,"context_line":"        self.add_remote_port(lport)"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    def get_datapath(self):"},{"line_number":52,"context_line":"        return self.api.datapath"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    @property"},{"line_number":55,"context_line":"    def parser(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a461143_edef3eae","line":52,"range":{"start_line":51,"start_character":0,"end_line":52,"end_character":32},"in_reply_to":"5a3905b3_30ec508f","updated":"2017-01-26 07:32:00.000000000","message":"This is not a part of this patch. Another patch may fix it and also the existing usages that need a big refactoring.","commit_id":"20b722f6ed2ee5199ab9089723a94ab0bce3781c"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"ccb4ef73b38d1852abef7a53b63d5561dcdfb4ae","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    def ofproto(self):"},{"line_number":60,"context_line":"        return self.get_datapath().ofproto"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    @property"},{"line_number":63,"context_line":"    def local_ports(self):"},{"line_number":64,"context_line":"        return self.get_datapath().local_ports"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    def add_flow_go_to_table(self, datapath,"},{"line_number":67,"context_line":"                             table, priority, goto_table_id, match\u003dNone):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a3905b3_d0ecec94","line":64,"range":{"start_line":62,"start_character":0,"end_line":64,"end_character":46},"updated":"2017-01-25 02:53:59.000000000","message":"Has it ever been used? Also, I doubt that datapath has such attribute \"local_ports\"","commit_id":"20b722f6ed2ee5199ab9089723a94ab0bce3781c"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"e696bd6be1e974db8367172b26c07beca2ad1e07","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    def ofproto(self):"},{"line_number":60,"context_line":"        return self.get_datapath().ofproto"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    @property"},{"line_number":63,"context_line":"    def local_ports(self):"},{"line_number":64,"context_line":"        return self.get_datapath().local_ports"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    def add_flow_go_to_table(self, datapath,"},{"line_number":67,"context_line":"                             table, priority, goto_table_id, match\u003dNone):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a461143_3180588b","line":64,"range":{"start_line":62,"start_character":0,"end_line":64,"end_character":46},"in_reply_to":"3a461143_06c2a733","updated":"2017-01-29 08:36:18.000000000","message":"@xiao, in general you are correct. But this patch was a part of a larger patch, which got out of hand. I asked @itamaro to split it up to facilitate review. There should also be followup patches to use these properties.\n\nIn order not to driver commiters crazy, I am passing this.","commit_id":"20b722f6ed2ee5199ab9089723a94ab0bce3781c"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"363603a5daae001fc3fcbcc1af4f9caef5c88f7c","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    def ofproto(self):"},{"line_number":60,"context_line":"        return self.get_datapath().ofproto"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    @property"},{"line_number":63,"context_line":"    def local_ports(self):"},{"line_number":64,"context_line":"        return self.get_datapath().local_ports"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    def add_flow_go_to_table(self, datapath,"},{"line_number":67,"context_line":"                             table, priority, goto_table_id, match\u003dNone):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a461143_9025edc3","line":64,"range":{"start_line":62,"start_character":0,"end_line":64,"end_character":46},"in_reply_to":"3a461143_4d35b244","updated":"2017-01-26 08:26:57.000000000","message":"Then I think it should be moved to the next change which really uses it. Also I don\u0027t think it is good to pollute datapath to add some cache data. What if datapath itself has such attribute, that will make debug very difficult.","commit_id":"20b722f6ed2ee5199ab9089723a94ab0bce3781c"},{"author":{"_account_id":18347,"name":"Itamar Ofek","email":"itamofek@netscape.net","username":"itamaro"},"change_message_id":"a47d0937447f716fca6da65550eb2c3e258f46c5","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    def ofproto(self):"},{"line_number":60,"context_line":"        return self.get_datapath().ofproto"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    @property"},{"line_number":63,"context_line":"    def local_ports(self):"},{"line_number":64,"context_line":"        return self.get_datapath().local_ports"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    def add_flow_go_to_table(self, datapath,"},{"line_number":67,"context_line":"                             table, priority, goto_table_id, match\u003dNone):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a461143_06c2a733","line":64,"range":{"start_line":62,"start_character":0,"end_line":64,"end_character":46},"in_reply_to":"3a461143_9025edc3","updated":"2017-01-26 09:16:48.000000000","message":"I would think it defy the purpose of a small patches. This change a key for next changes.","commit_id":"20b722f6ed2ee5199ab9089723a94ab0bce3781c"},{"author":{"_account_id":14249,"name":"Lionel Zerbib","email":"ariel.zerbib@gmail.com","username":"lionelz"},"change_message_id":"609ddedd00fd0087e51ef1e2c2c274f165605692","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    def ofproto(self):"},{"line_number":60,"context_line":"        return self.get_datapath().ofproto"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    @property"},{"line_number":63,"context_line":"    def local_ports(self):"},{"line_number":64,"context_line":"        return self.get_datapath().local_ports"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    def add_flow_go_to_table(self, datapath,"},{"line_number":67,"context_line":"                             table, priority, goto_table_id, match\u003dNone):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a461143_4d35b244","line":64,"range":{"start_line":62,"start_character":0,"end_line":64,"end_character":46},"in_reply_to":"5a3905b3_d0ecec94","updated":"2017-01-26 07:32:00.000000000","message":"This patch is a preparation of next changes that uses it.","commit_id":"20b722f6ed2ee5199ab9089723a94ab0bce3781c"}]}