)]}'
{"dragonflow/controller/common/constants.py":[{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"8cabe1dce490a88f842019158ee8a20da50a28ec","unresolved":false,"context_lines":[{"line_number":49,"context_line":"# Translate destination mac and port key to reg7 and forward packet to table"},{"line_number":50,"context_line":"# L3_LOOKUP_TABLE. Duplicate broadcase packets."},{"line_number":51,"context_line":"L2_LOOKUP_TABLE \u003d 55"},{"line_number":52,"context_line":"L2_LOOKUP_CONT_TABLE \u003d 56"},{"line_number":53,"context_line":"# Filter packet based on destination IP address."},{"line_number":54,"context_line":"L3_LOOKUP_TABLE \u003d 60"},{"line_number":55,"context_line":"# Filter packet based on destination IP address in proactive way ;)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a430d35_303f4b88","line":52,"range":{"start_line":52,"start_character":0,"end_line":52,"end_character":25},"updated":"2017-02-08 09:30:07.000000000","message":"Use table 57 or 58, to leave room between tables.","commit_id":"698b1d5ffcfefe2ecf3c7f7aa513e3f3ee77d006"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"8cabe1dce490a88f842019158ee8a20da50a28ec","unresolved":false,"context_lines":[{"line_number":59,"context_line":"# Depending on reg7, packet is pushed localy to EGRESS_EXTERNAL_TABLE or"},{"line_number":60,"context_line":"# translated to tunnel."},{"line_number":61,"context_line":"EGRESS_TABLE \u003d 75"},{"line_number":62,"context_line":"EGRESS_CONT_TABLE \u003d 76"},{"line_number":63,"context_line":"# Push packet to local ovs port."},{"line_number":64,"context_line":"EGRESS_EXTERNAL_TABLE \u003d 80"},{"line_number":65,"context_line":"# All packets that come from remote host will go through this table"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a430d35_f05f83e2","line":62,"range":{"start_line":62,"start_character":0,"end_line":62,"end_character":22},"updated":"2017-02-08 09:30:07.000000000","message":"Same here, table 77-78.","commit_id":"698b1d5ffcfefe2ecf3c7f7aa513e3f3ee77d006"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"ed5702d3f1868157062a3d32244717d2eb46dcd7","unresolved":false,"context_lines":[{"line_number":49,"context_line":"# Translate destination mac and port key to reg7 and forward packet to table"},{"line_number":50,"context_line":"# L3_LOOKUP_TABLE. Duplicate broadcast packets."},{"line_number":51,"context_line":"L2_LOOKUP_TABLE \u003d 55"},{"line_number":52,"context_line":"L2_LOOKUP_CONT_TABLE \u003d 56"},{"line_number":53,"context_line":"# Filter packet based on destination IP address."},{"line_number":54,"context_line":"L3_LOOKUP_TABLE \u003d 60"},{"line_number":55,"context_line":"# Filter packet based on destination IP address in proactive way ;)"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a30ddce_68518d62","line":52,"updated":"2017-03-07 09:53:01.000000000","message":"My comment from PS1 was to answered.","commit_id":"8705713cc4428c682c3b07a95e16cdcd51ebd265"},{"author":{"_account_id":23766,"name":"Dima Kuznetsov","email":"dima.kuznetsov@toganetworks.com","username":"dimak"},"change_message_id":"c6d107e986292f1df00175ba2afd1f80d287d9aa","unresolved":false,"context_lines":[{"line_number":49,"context_line":"# Translate destination mac and port key to reg7 and forward packet to table"},{"line_number":50,"context_line":"# L3_LOOKUP_TABLE. Duplicate broadcast packets."},{"line_number":51,"context_line":"L2_LOOKUP_TABLE \u003d 55"},{"line_number":52,"context_line":"L2_LOOKUP_CONT_TABLE \u003d 56"},{"line_number":53,"context_line":"# Filter packet based on destination IP address."},{"line_number":54,"context_line":"L3_LOOKUP_TABLE \u003d 60"},{"line_number":55,"context_line":"# Filter packet based on destination IP address in proactive way ;)"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a30ddce_70b5b42f","line":52,"in_reply_to":"9a30ddce_68518d62","updated":"2017-03-08 12:13:15.000000000","message":"Sorry, I missed the comments on this patch.\n\nI chose this approach to because what I want to achieve in the next patch is:\n\nI have a packet from A to B going through the L2 lookup table and there\u0027s a port chain that has a classifier for all packets from A to B.\nWe take the packet and traverse it through chain, and once we\u0027re done its still a packet from A to B, and it goes again through the L2 lookup table (we have to do L2 in case our chain changed the destination).\n\nNow we have to make sure we don\u0027t classify the packet again into the SFC since we\u0027ll end up with an infinite loop.\n\nSo this patch splits the tables to one where we classify our flows from, and another table where we send our packets to after we\u0027re done with them.\n\n+-------+   no           +--------+\n|       |   classifier   |        |\n|  L2   +----------------\u003e  L2    |\n|       |                | cont   |\n+-----+-+                +-^------+\n      |                    |\n      |classifier          |\n      |present             |\n    +-v--------------------+-+\n    |                        |\n    |        SFC             |\n    |                        |\n    +------------------------+\n\nAnother thing we can do is try utilizing a bit in one of the registers, s.t. we classify packets that are only bit zero, and once we\u0027re out of an SFC we set it to 1 so the packet will not be classified again.\n\nWe\u0027ll need to dedicate a specific bit or write some reg-bits allocator like we did with cookies.","commit_id":"8705713cc4428c682c3b07a95e16cdcd51ebd265"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"620642e37fed493e1e7264b7e8eeab7bb037077a","unresolved":false,"context_lines":[{"line_number":49,"context_line":"# Translate destination mac and port key to reg7 and forward packet to table"},{"line_number":50,"context_line":"# L3_LOOKUP_TABLE. Duplicate broadcast packets."},{"line_number":51,"context_line":"L2_LOOKUP_TABLE \u003d 55"},{"line_number":52,"context_line":"L2_LOOKUP_CONT_TABLE \u003d 56"},{"line_number":53,"context_line":"# Filter packet based on destination IP address."},{"line_number":54,"context_line":"L3_LOOKUP_TABLE \u003d 60"},{"line_number":55,"context_line":"# Filter packet based on destination IP address in proactive way ;)"}],"source_content_type":"text/x-python","patch_set":9,"id":"ffe62b97_74a4d7b9","line":52,"in_reply_to":"9a30ddce_70b5b42f","updated":"2017-03-27 09:27:18.000000000","message":"I\u0027d like to wait for more opinions on this.","commit_id":"8705713cc4428c682c3b07a95e16cdcd51ebd265"}]}