)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"b7f5d5bbb62bd277b20531884bf925d00b10abf4","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     jingting \u003ckangjingting@huawei.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-02-15 12:38:52 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Use provision_blocks to track port status"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I615a0015f5bb62ccc49993911dd9d9ffcb8b2f69"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"fa31d9ce_58e7823f","line":7,"updated":"2017-02-15 09:12:19.000000000","message":"Please add an explanation on what is a provision_block, and maybe a link for more information.\n\nWithout understanding the feature, it is very difficult to pass an effective review.","commit_id":"03c79a85a07c3515afc275cdb196c5a0f6907d48"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"75577d4458223e6dc0514234eefd2c7dfc8a19f5","unresolved":false,"context_lines":[{"line_number":13,"context_line":"entities to be tracked that need to be involved to make a transition"},{"line_number":14,"context_line":"to ACTIVE happen."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"So we shoud obey neutron design to make sure port status is not active"},{"line_number":17,"context_line":"until DF is ready in case there are many modules need to get their jobs"},{"line_number":18,"context_line":"done."},{"line_number":19,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"da36d5c6_41dd5b13","line":16,"range":{"start_line":16,"start_character":6,"end_line":16,"end_character":11},"updated":"2017-02-21 08:08:42.000000000","message":"should","commit_id":"aca1cfbc409d07f230b6f2395f8ceac291962437"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"75577d4458223e6dc0514234eefd2c7dfc8a19f5","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"For more information about provision_block, please refer to:"},{"line_number":21,"context_line":"https://github.com/openstack/neutron/blob/master/doc/source/devref/provisioning_blocks.rst"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Change-Id: I615a0015f5bb62ccc49993911dd9d9ffcb8b2f69"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"da36d5c6_e1c72f43","line":22,"updated":"2017-02-21 08:08:42.000000000","message":"please open bug in dragonflow launchpad to trace this issue","commit_id":"aca1cfbc409d07f230b6f2395f8ceac291962437"}],"dragonflow/neutron/ml2/mech_driver.py":[{"author":{"_account_id":20153,"name":"Duan Kebo","email":"duankebo@gmail.com"},"change_message_id":"f18f6ae7bb414d710bc69b92c33dd9fdc2a2e33f","unresolved":false,"context_lines":[{"line_number":521,"context_line":"        vnic_type \u003d port.get(portbindings.VNIC_TYPE, portbindings.VNIC_NORMAL)"},{"line_number":522,"context_line":""},{"line_number":523,"context_line":"        if vnic_type not in self.supported_vnic_types:"},{"line_number":524,"context_line":"            LOG.debug(\"No provisioning block due to unspported vnic_type: %s \","},{"line_number":525,"context_line":"                      vnic_type)"},{"line_number":526,"context_line":"            return"},{"line_number":527,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"fa31d9ce_8bf55f58","line":524,"range":{"start_line":524,"start_character":16,"end_line":524,"end_character":21},"updated":"2017-02-14 06:30:34.000000000","message":"error log? printing self.supported_vnic_types will be helpful","commit_id":"537134da42b3319fb37c9d1eae17ca3aad49789c"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"6dc59e8f030e03492f2c19809137ec707c18effe","unresolved":false,"context_lines":[{"line_number":516,"context_line":"        return supported_allowed_address_pairs"},{"line_number":517,"context_line":""},{"line_number":518,"context_line":"    def _insert_port_provision_block(self, port):"},{"line_number":519,"context_line":"        vnic_type \u003d port.get(portbindings.VNIC_TYPE, portbindings.VNIC_NORMAL)"},{"line_number":520,"context_line":""},{"line_number":521,"context_line":"        if vnic_type not in self.supported_vnic_types:"},{"line_number":522,"context_line":"            LOG.error(_LE(\"No provisioning block due to unspported\""},{"line_number":523,"context_line":"                          \"vnic_type: %(type)s in %(types)s\"),"},{"line_number":524,"context_line":"                      {\u0027type\u0027: vnic_type,"},{"line_number":525,"context_line":"                       \u0027types\u0027: self.supported_vnic_types})"},{"line_number":526,"context_line":"            return"},{"line_number":527,"context_line":""},{"line_number":528,"context_line":"        # Insert a provisioning block to prevent the port from"},{"line_number":529,"context_line":"        # transitioning to active until DF reports back that"}],"source_content_type":"text/x-python","patch_set":14,"id":"9a30ddce_02363203","line":526,"range":{"start_line":519,"start_character":0,"end_line":526,"end_character":18},"updated":"2017-03-07 09:18:16.000000000","message":"Not sure I understand why this is done here?\n\nIf the vnic_type test is only relevant for provisioning_blocks, then this should be a warning, and the code in set_port_status_up should fall back to the previous behaviour. If the test is relevant for the DF mech driver as a whole, it should be in create_port_postcommit and affect the entire port creation, not just the provisioning_block code.","commit_id":"65452fc6848163d47bf7bf62a60a4429d09a562f"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"6dc59e8f030e03492f2c19809137ec707c18effe","unresolved":false,"context_lines":[{"line_number":530,"context_line":"        # the port is up"},{"line_number":531,"context_line":"        if port[\u0027status\u0027] !\u003d n_const.PORT_STATUS_ACTIVE:"},{"line_number":532,"context_line":"            provisioning_blocks.add_provisioning_component("},{"line_number":533,"context_line":"                n_context.get_admin_context,"},{"line_number":534,"context_line":"                port[\u0027id\u0027], resources.PORT,"},{"line_number":535,"context_line":"                provisioning_blocks.L2_AGENT_ENTITY)"},{"line_number":536,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"9a30ddce_82514265","line":533,"range":{"start_line":533,"start_character":26,"end_line":533,"end_character":43},"updated":"2017-03-07 09:18:16.000000000","message":"Not a function call?","commit_id":"65452fc6848163d47bf7bf62a60a4429d09a562f"}]}