)]}'
{"dragonflow/controller/df_local_controller.py":[{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"d03a1e532d6a7bf676eb8b09998491a3f7ed1ef7","unresolved":false,"context_lines":[{"line_number":218,"context_line":"                self.update,"},{"line_number":219,"context_line":"                self.delete_by_id,"},{"line_number":220,"context_line":"            ),"},{"line_number":221,"context_line":"            db_consistent.ModelHandler("},{"line_number":222,"context_line":"                models.QosPolicy,"},{"line_number":223,"context_line":"                self.db_store.get_qos_policies,"},{"line_number":224,"context_line":"                self.nb_api.get_qos_policies,"},{"line_number":225,"context_line":"                self.update,"},{"line_number":226,"context_line":"                self.delete_by_id,"},{"line_number":227,"context_line":"            ),"},{"line_number":228,"context_line":"        ]"},{"line_number":229,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"ba2be162_a56680ea","line":226,"range":{"start_line":221,"start_character":0,"end_line":226,"end_character":34},"updated":"2017-03-06 01:41:21.000000000","message":"I think the db consistency should use same order as object refresher. After all, they are both db sync in different scenario. And you miss active port here, though it is not present before refactor.","commit_id":"2f6a2dda96e4cf37e26590ad04d7b51e7c44d636"},{"author":{"_account_id":23766,"name":"Dima Kuznetsov","email":"dima.kuznetsov@toganetworks.com","username":"dimak"},"change_message_id":"9d70c666ba1ec7a43e7a241d7625626d5503ccde","unresolved":false,"context_lines":[{"line_number":218,"context_line":"                self.update,"},{"line_number":219,"context_line":"                self.delete_by_id,"},{"line_number":220,"context_line":"            ),"},{"line_number":221,"context_line":"            db_consistent.ModelHandler("},{"line_number":222,"context_line":"                models.QosPolicy,"},{"line_number":223,"context_line":"                self.db_store.get_qos_policies,"},{"line_number":224,"context_line":"                self.nb_api.get_qos_policies,"},{"line_number":225,"context_line":"                self.update,"},{"line_number":226,"context_line":"                self.delete_by_id,"},{"line_number":227,"context_line":"            ),"},{"line_number":228,"context_line":"        ]"},{"line_number":229,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"ba2be162_03666150","line":226,"range":{"start_line":221,"start_character":0,"end_line":226,"end_character":34},"in_reply_to":"ba2be162_a56680ea","updated":"2017-03-06 07:12:02.000000000","message":"I\u0027ll change the order to match refresher, I think adding active port should be considered separately to see how well it works","commit_id":"2f6a2dda96e4cf37e26590ad04d7b51e7c44d636"}],"dragonflow/db/db_consistent.py":[{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"12210cd7629133dcc0e5a1e985f737c9943e9277","unresolved":false,"context_lines":[{"line_number":26,"context_line":"MIN_SYNC_INTERVAL_TIME \u003d 60"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"class ModelHandler(object):"},{"line_number":30,"context_line":"    def __init__(self, model, db_store_func, nb_api_func,"},{"line_number":31,"context_line":"                 update_handler, delete_handler):"},{"line_number":32,"context_line":"        self._model \u003d model"}],"source_content_type":"text/x-python","patch_set":13,"id":"ba2be162_d9aa31d4","line":29,"updated":"2017-03-01 12:09:34.000000000","message":"please add docstring","commit_id":"39bf3ac0290721ab032f2bd48768f268eeb124a4"},{"author":{"_account_id":23766,"name":"Dima Kuznetsov","email":"dima.kuznetsov@toganetworks.com","username":"dimak"},"change_message_id":"6d245c4b3b11e84639dabf041ec5c2bc43f9c064","unresolved":false,"context_lines":[{"line_number":26,"context_line":"MIN_SYNC_INTERVAL_TIME \u003d 60"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"class ModelHandler(object):"},{"line_number":30,"context_line":"    def __init__(self, model, db_store_func, nb_api_func,"},{"line_number":31,"context_line":"                 update_handler, delete_handler):"},{"line_number":32,"context_line":"        self._model \u003d model"}],"source_content_type":"text/x-python","patch_set":13,"id":"ba2be162_aca6ef0d","line":29,"in_reply_to":"ba2be162_d9aa31d4","updated":"2017-03-02 08:30:21.000000000","message":"Done","commit_id":"39bf3ac0290721ab032f2bd48768f268eeb124a4"}],"dragonflow/tests/unit/test_db_consistent.py":[{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"9fefbbd8893ddd8b7544f2877ecc8b29ab3d746d","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        self.db_consistent \u003d db_consistent.DBConsistencyManager("},{"line_number":32,"context_line":"                self.controller)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def test_db_comparison(self):"},{"line_number":35,"context_line":"        df_obj0 \u003d FakeDfLocalObj(self.lport_id0, 0)"},{"line_number":36,"context_line":"        df_obj1 \u003d FakeDfLocalObj(self.lport_id1, 1)"},{"line_number":37,"context_line":"        df_obj2 \u003d FakeDfLocalObj(self.lport_id2, 2)"}],"source_content_type":"text/x-python","patch_set":17,"id":"ba2be162_d2c7bf93","line":34,"updated":"2017-03-05 07:53:55.000000000","message":"nit: I don\u0027t feel these tests are complete. What about version mismatch and versionless objects? What about new objects?\n\nHowever, since these tests did not exist before the refactor, it can/should be added as another patch.","commit_id":"0476b83ee0c36a49bbe34ab6525ebdba7e48c05e"}]}