)]}'
{"dragonflow/controller/df_local_controller.py":[{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"7cb285187cae41224d40f125c245b9c763405f51","unresolved":false,"context_lines":[{"line_number":119,"context_line":"        self._register_old_model_refreshers()"},{"line_number":120,"context_line":"        self.db_sync_loop()"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    def _register_old_model_refreshers(self):"},{"line_number":123,"context_line":"        for refresher in ["},{"line_number":124,"context_line":"            df_db_objects_refresh.DfObjectRefresher("},{"line_number":125,"context_line":"                \u0027QoS Policies\u0027,"}],"source_content_type":"text/x-python","patch_set":11,"id":"da36d5c6_64afe394","line":122,"range":{"start_line":122,"start_character":18,"end_line":122,"end_character":21},"updated":"2017-02-28 11:15:44.000000000","message":"nit: I think this is legacy now","commit_id":"45a2d8ea64eaeaea273968147fcd61de96a462b5"},{"author":{"_account_id":23766,"name":"Dima Kuznetsov","email":"dima.kuznetsov@toganetworks.com","username":"dimak"},"change_message_id":"cd4f3878b98de0cae987e5eb24a045c0202e6a37","unresolved":false,"context_lines":[{"line_number":119,"context_line":"        self._register_old_model_refreshers()"},{"line_number":120,"context_line":"        self.db_sync_loop()"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    def _register_old_model_refreshers(self):"},{"line_number":123,"context_line":"        for refresher in ["},{"line_number":124,"context_line":"            df_db_objects_refresh.DfObjectRefresher("},{"line_number":125,"context_line":"                \u0027QoS Policies\u0027,"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba2be162_887337b4","line":122,"range":{"start_line":122,"start_character":18,"end_line":122,"end_character":21},"in_reply_to":"da36d5c6_64afe394","updated":"2017-03-01 08:30:39.000000000","message":"Will change","commit_id":"45a2d8ea64eaeaea273968147fcd61de96a462b5"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"7cb285187cae41224d40f125c245b9c763405f51","unresolved":false,"context_lines":[{"line_number":120,"context_line":"        self.db_sync_loop()"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    def _register_old_model_refreshers(self):"},{"line_number":123,"context_line":"        for refresher in ["},{"line_number":124,"context_line":"            df_db_objects_refresh.DfObjectRefresher("},{"line_number":125,"context_line":"                \u0027QoS Policies\u0027,"},{"line_number":126,"context_line":"                self.db_store.get_qos_policy_keys,"},{"line_number":127,"context_line":"                self.nb_api.get_qos_policies,"},{"line_number":128,"context_line":"                self.update_qospolicy,"},{"line_number":129,"context_line":"                self.delete_qospolicy,"},{"line_number":130,"context_line":"            ),"},{"line_number":131,"context_line":"            df_db_objects_refresh.DfObjectRefresher("},{"line_number":132,"context_line":"                \u0027Switches\u0027,"},{"line_number":133,"context_line":"                self.db_store.get_lswitch_keys,"},{"line_number":134,"context_line":"                self.nb_api.get_all_logical_switches,"},{"line_number":135,"context_line":"                self.update_lswitch,"},{"line_number":136,"context_line":"                self.delete_lswitch,"},{"line_number":137,"context_line":"            ),"},{"line_number":138,"context_line":"            df_db_objects_refresh.DfObjectRefresher("},{"line_number":139,"context_line":"                \u0027Security Groups\u0027,"},{"line_number":140,"context_line":"                self.db_store.get_security_group_keys,"},{"line_number":141,"context_line":"                self.nb_api.get_security_groups,"},{"line_number":142,"context_line":"                self.update_secgroup,"},{"line_number":143,"context_line":"                self.delete_secgroup,"},{"line_number":144,"context_line":"            ),"},{"line_number":145,"context_line":"            df_db_objects_refresh.DfObjectRefresher("},{"line_number":146,"context_line":"                \u0027Ports\u0027,"},{"line_number":147,"context_line":"                self.db_store.get_port_keys,"},{"line_number":148,"context_line":"                self.nb_api.get_all_logical_ports,"},{"line_number":149,"context_line":"                self.update_lport,"},{"line_number":150,"context_line":"                self.delete_lport,"},{"line_number":151,"context_line":"            ),"},{"line_number":152,"context_line":"            df_db_objects_refresh.DfObjectRefresher("},{"line_number":153,"context_line":"                \u0027Routers\u0027,"},{"line_number":154,"context_line":"                self.db_store.get_router_keys,"},{"line_number":155,"context_line":"                self.nb_api.get_routers,"},{"line_number":156,"context_line":"                self.update_lrouter,"},{"line_number":157,"context_line":"                self.delete_lrouter,"},{"line_number":158,"context_line":"            ),"},{"line_number":159,"context_line":"            df_db_objects_refresh.DfObjectRefresher("},{"line_number":160,"context_line":"                \u0027Floating IPs\u0027,"},{"line_number":161,"context_line":"                self.db_store.get_floatingip_keys,"},{"line_number":162,"context_line":"                self.nb_api.get_floatingips,"},{"line_number":163,"context_line":"                self.update_floatingip,"},{"line_number":164,"context_line":"                self.delete_floatingip,"},{"line_number":165,"context_line":"            ),"},{"line_number":166,"context_line":"            df_db_objects_refresh.DfObjectRefresher("},{"line_number":167,"context_line":"                \u0027Active Ports\u0027,"},{"line_number":168,"context_line":"                self.db_store.get_active_port_keys,"},{"line_number":169,"context_line":"                self.nb_api.get_active_ports,"},{"line_number":170,"context_line":"                self.update_activeport,"},{"line_number":171,"context_line":"                self.delete_activeport,"},{"line_number":172,"context_line":"            ),"},{"line_number":173,"context_line":"        ]:"},{"line_number":174,"context_line":"            df_db_objects_refresh.add_refresher(refresher)"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"    def db_sync_loop(self):"}],"source_content_type":"text/x-python","patch_set":11,"id":"da36d5c6_a4e39b04","line":173,"range":{"start_line":123,"start_character":25,"end_line":173,"end_character":9},"updated":"2017-02-28 11:15:44.000000000","message":"Please create this list outside of the for-loop definition.","commit_id":"45a2d8ea64eaeaea273968147fcd61de96a462b5"},{"author":{"_account_id":23766,"name":"Dima Kuznetsov","email":"dima.kuznetsov@toganetworks.com","username":"dimak"},"change_message_id":"cd4f3878b98de0cae987e5eb24a045c0202e6a37","unresolved":false,"context_lines":[{"line_number":120,"context_line":"        self.db_sync_loop()"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    def _register_old_model_refreshers(self):"},{"line_number":123,"context_line":"        for refresher in ["},{"line_number":124,"context_line":"            df_db_objects_refresh.DfObjectRefresher("},{"line_number":125,"context_line":"                \u0027QoS Policies\u0027,"},{"line_number":126,"context_line":"                self.db_store.get_qos_policy_keys,"},{"line_number":127,"context_line":"                self.nb_api.get_qos_policies,"},{"line_number":128,"context_line":"                self.update_qospolicy,"},{"line_number":129,"context_line":"                self.delete_qospolicy,"},{"line_number":130,"context_line":"            ),"},{"line_number":131,"context_line":"            df_db_objects_refresh.DfObjectRefresher("},{"line_number":132,"context_line":"                \u0027Switches\u0027,"},{"line_number":133,"context_line":"                self.db_store.get_lswitch_keys,"},{"line_number":134,"context_line":"                self.nb_api.get_all_logical_switches,"},{"line_number":135,"context_line":"                self.update_lswitch,"},{"line_number":136,"context_line":"                self.delete_lswitch,"},{"line_number":137,"context_line":"            ),"},{"line_number":138,"context_line":"            df_db_objects_refresh.DfObjectRefresher("},{"line_number":139,"context_line":"                \u0027Security Groups\u0027,"},{"line_number":140,"context_line":"                self.db_store.get_security_group_keys,"},{"line_number":141,"context_line":"                self.nb_api.get_security_groups,"},{"line_number":142,"context_line":"                self.update_secgroup,"},{"line_number":143,"context_line":"                self.delete_secgroup,"},{"line_number":144,"context_line":"            ),"},{"line_number":145,"context_line":"            df_db_objects_refresh.DfObjectRefresher("},{"line_number":146,"context_line":"                \u0027Ports\u0027,"},{"line_number":147,"context_line":"                self.db_store.get_port_keys,"},{"line_number":148,"context_line":"                self.nb_api.get_all_logical_ports,"},{"line_number":149,"context_line":"                self.update_lport,"},{"line_number":150,"context_line":"                self.delete_lport,"},{"line_number":151,"context_line":"            ),"},{"line_number":152,"context_line":"            df_db_objects_refresh.DfObjectRefresher("},{"line_number":153,"context_line":"                \u0027Routers\u0027,"},{"line_number":154,"context_line":"                self.db_store.get_router_keys,"},{"line_number":155,"context_line":"                self.nb_api.get_routers,"},{"line_number":156,"context_line":"                self.update_lrouter,"},{"line_number":157,"context_line":"                self.delete_lrouter,"},{"line_number":158,"context_line":"            ),"},{"line_number":159,"context_line":"            df_db_objects_refresh.DfObjectRefresher("},{"line_number":160,"context_line":"                \u0027Floating IPs\u0027,"},{"line_number":161,"context_line":"                self.db_store.get_floatingip_keys,"},{"line_number":162,"context_line":"                self.nb_api.get_floatingips,"},{"line_number":163,"context_line":"                self.update_floatingip,"},{"line_number":164,"context_line":"                self.delete_floatingip,"},{"line_number":165,"context_line":"            ),"},{"line_number":166,"context_line":"            df_db_objects_refresh.DfObjectRefresher("},{"line_number":167,"context_line":"                \u0027Active Ports\u0027,"},{"line_number":168,"context_line":"                self.db_store.get_active_port_keys,"},{"line_number":169,"context_line":"                self.nb_api.get_active_ports,"},{"line_number":170,"context_line":"                self.update_activeport,"},{"line_number":171,"context_line":"                self.delete_activeport,"},{"line_number":172,"context_line":"            ),"},{"line_number":173,"context_line":"        ]:"},{"line_number":174,"context_line":"            df_db_objects_refresh.add_refresher(refresher)"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"    def db_sync_loop(self):"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba2be162_48621fda","line":173,"range":{"start_line":123,"start_character":25,"end_line":173,"end_character":9},"in_reply_to":"da36d5c6_a4e39b04","updated":"2017-03-01 08:30:39.000000000","message":"Ok","commit_id":"45a2d8ea64eaeaea273968147fcd61de96a462b5"}],"dragonflow/tests/unit/test_topology.py":[{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"7cb285187cae41224d40f125c245b9c763405f51","unresolved":false,"context_lines":[{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        self.fake_invalid_ovs_port.get_ofport.return_value \u003d -1"},{"line_number":81,"context_line":"        self.controller.update_lport.reset_mock()"},{"line_number":82,"context_line":"        self._reset_refresher()"},{"line_number":83,"context_line":"        self.topology.ovs_port_updated(self.fake_invalid_ovs_port)"},{"line_number":84,"context_line":"        self.controller.update_lport.assert_not_called()"},{"line_number":85,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"da36d5c6_c4ac0f8f","line":82,"range":{"start_line":82,"start_character":0,"end_line":82,"end_character":31},"updated":"2017-02-28 11:15:44.000000000","message":"Why is this needed?","commit_id":"45a2d8ea64eaeaea273968147fcd61de96a462b5"},{"author":{"_account_id":23766,"name":"Dima Kuznetsov","email":"dima.kuznetsov@toganetworks.com","username":"dimak"},"change_message_id":"cd4f3878b98de0cae987e5eb24a045c0202e6a37","unresolved":false,"context_lines":[{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        self.fake_invalid_ovs_port.get_ofport.return_value \u003d -1"},{"line_number":81,"context_line":"        self.controller.update_lport.reset_mock()"},{"line_number":82,"context_line":"        self._reset_refresher()"},{"line_number":83,"context_line":"        self.topology.ovs_port_updated(self.fake_invalid_ovs_port)"},{"line_number":84,"context_line":"        self.controller.update_lport.assert_not_called()"},{"line_number":85,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"ba2be162_d9107b51","line":82,"range":{"start_line":82,"start_character":0,"end_line":82,"end_character":31},"in_reply_to":"da36d5c6_c4ac0f8f","updated":"2017-03-01 08:30:39.000000000","message":"It is not, removing","commit_id":"45a2d8ea64eaeaea273968147fcd61de96a462b5"}]}