)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":23766,"name":"Dima Kuznetsov","email":"dima.kuznetsov@toganetworks.com","username":"dimak"},"change_message_id":"eecd0e6465d95a139ca984389433e1500a1188a7","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"The correct way is using args[0][1]."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"In addition, this commit also changes \u0027id\u0027 to \u0027uuid\u0027 for the lock,"},{"line_number":18,"context_line":"because \u0027id\u0027 is a build-in keyword and not a good variable name."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: I9250a25f1cefa1e575ae99fece848361b5fff419"},{"line_number":21,"context_line":"Closes-Bug: #1667996"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da36d5c6_3c11c404","line":18,"range":{"start_line":17,"start_character":0,"end_line":18,"end_character":64},"updated":"2017-02-26 08:49:18.000000000","message":"nit: This is a bit of piggybacking","commit_id":"62026cf2d60c6aa8e0b24192c9debde68b407259"}],"dragonflow/db/neutron/lockedobjects_db.py":[{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"a5af91a6c34f15a599372cb05a6840777bf2b1e3","unresolved":false,"context_lines":[{"line_number":95,"context_line":""},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"def _get_lock_id_by_resource_type(resource_type, *args, **kwargs):"},{"line_number":98,"context_line":"    if RESOURCE_DF_PLUGIN \u003d\u003d resource_type:"},{"line_number":99,"context_line":"        lock_id \u003d args[0][1].project_id"},{"line_number":100,"context_line":"    elif RESOURCE_ML2_NETWORK_OR_PORT \u003d\u003d resource_type:"},{"line_number":101,"context_line":"        lock_id \u003d args[0][1].current[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"da36d5c6_7ff6ce8f","line":98,"updated":"2017-02-26 13:41:07.000000000","message":"it could be helpful to have docstring for explaining the params","commit_id":"32100427d5931e8aefc4c1914bb27862c90e84a5"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"aa1a12fe22d59a8168d853774cf0c0e5efb6520d","unresolved":false,"context_lines":[{"line_number":95,"context_line":""},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"def _get_lock_id_by_resource_type(resource_type, *args, **kwargs):"},{"line_number":98,"context_line":"    if RESOURCE_DF_PLUGIN \u003d\u003d resource_type:"},{"line_number":99,"context_line":"        lock_id \u003d args[0][1].project_id"},{"line_number":100,"context_line":"    elif RESOURCE_ML2_NETWORK_OR_PORT \u003d\u003d resource_type:"},{"line_number":101,"context_line":"        lock_id \u003d args[0][1].current[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"da36d5c6_ff7e3ee2","line":98,"in_reply_to":"da36d5c6_1f0b127e","updated":"2017-02-26 13:49:37.000000000","message":"without entering into the details, this method can mention what is the expected content of the args, otherwise its sort of a magical code. Maybe unit tests are more appropriate here","commit_id":"32100427d5931e8aefc4c1914bb27862c90e84a5"},{"author":{"_account_id":7805,"name":"Li Ma","email":"skywalker.nick@gmail.com","username":"Nick"},"change_message_id":"bcd2b092127affe3e4e91fe2ca2efe3244eeaa03","unresolved":false,"context_lines":[{"line_number":95,"context_line":""},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"def _get_lock_id_by_resource_type(resource_type, *args, **kwargs):"},{"line_number":98,"context_line":"    if RESOURCE_DF_PLUGIN \u003d\u003d resource_type:"},{"line_number":99,"context_line":"        lock_id \u003d args[0][1].project_id"},{"line_number":100,"context_line":"    elif RESOURCE_ML2_NETWORK_OR_PORT \u003d\u003d resource_type:"},{"line_number":101,"context_line":"        lock_id \u003d args[0][1].current[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"da36d5c6_52764a07","line":98,"in_reply_to":"da36d5c6_517adabd","updated":"2017-02-27 14:46:13.000000000","message":"OK, thanks, I will keep in mind to add it, but it really takes time to verify each case.","commit_id":"32100427d5931e8aefc4c1914bb27862c90e84a5"},{"author":{"_account_id":7805,"name":"Li Ma","email":"skywalker.nick@gmail.com","username":"Nick"},"change_message_id":"04fd4145bf61a8ccc8d4e5629ef66c3591768135","unresolved":false,"context_lines":[{"line_number":95,"context_line":""},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"def _get_lock_id_by_resource_type(resource_type, *args, **kwargs):"},{"line_number":98,"context_line":"    if RESOURCE_DF_PLUGIN \u003d\u003d resource_type:"},{"line_number":99,"context_line":"        lock_id \u003d args[0][1].project_id"},{"line_number":100,"context_line":"    elif RESOURCE_ML2_NETWORK_OR_PORT \u003d\u003d resource_type:"},{"line_number":101,"context_line":"        lock_id \u003d args[0][1].current[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"da36d5c6_1f0b127e","line":98,"in_reply_to":"da36d5c6_7ff6ce8f","updated":"2017-02-26 13:47:13.000000000","message":"different api has different params. i suggest to submit another commit.","commit_id":"32100427d5931e8aefc4c1914bb27862c90e84a5"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"3ca0f02dd07c5c123282c9bea50d3763510a815a","unresolved":false,"context_lines":[{"line_number":95,"context_line":""},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"def _get_lock_id_by_resource_type(resource_type, *args, **kwargs):"},{"line_number":98,"context_line":"    if RESOURCE_DF_PLUGIN \u003d\u003d resource_type:"},{"line_number":99,"context_line":"        lock_id \u003d args[0][1].project_id"},{"line_number":100,"context_line":"    elif RESOURCE_ML2_NETWORK_OR_PORT \u003d\u003d resource_type:"},{"line_number":101,"context_line":"        lock_id \u003d args[0][1].current[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"da36d5c6_517adabd","line":98,"in_reply_to":"da36d5c6_ff7e3ee2","updated":"2017-02-27 03:25:46.000000000","message":"+1 to add some ut for this code, the lock_id here highly depends on the parameter that neutron pass in. Some cases in fullstack implicitly test this function, but we can test is more explicitly in UT to verity the lock_id is what we want. But that could be a following RFE bug.","commit_id":"32100427d5931e8aefc4c1914bb27862c90e84a5"}]}