)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"b6d431b166bd2c7847f4c2165e4d0bed93e1462a","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[01/xx] Introduce add_group/del_group in DFlowApp"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add OpenFlow group manipulation methods."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: Ib636c2787aeaadf42f9ef81e5afdd68a4d68815d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9a30ddce_b31776ec","line":9,"updated":"2017-03-07 10:11:16.000000000","message":"Do you have a link to the relevant section in the docs for this? e.g. ryu\u0027s OFPGroupMod and ovs\u0027 modify group command?","commit_id":"a1707cc8bac80575d499667a6439bc3ff026ed76"},{"author":{"_account_id":23766,"name":"Dima Kuznetsov","email":"dima.kuznetsov@toganetworks.com","username":"dimak"},"change_message_id":"37dd7764a1964fdc1d608d5702b8e1639a420c26","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[01/xx] Introduce add_group/del_group in DFlowApp"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add OpenFlow group manipulation methods."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: Ib636c2787aeaadf42f9ef81e5afdd68a4d68815d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9a30ddce_f5f6f6f7","line":9,"in_reply_to":"9a30ddce_b31776ec","updated":"2017-03-08 11:41:43.000000000","message":"Will add","commit_id":"a1707cc8bac80575d499667a6439bc3ff026ed76"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"37541aec7e40b58f0702464017c67e564dc76b82","unresolved":false,"context_lines":[{"line_number":7,"context_line":"[01/xx] Introduce add_group/del_group in DFlowApp"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add OpenFlow group manipulation methods."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: Ib636c2787aeaadf42f9ef81e5afdd68a4d68815d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"1a1ced50_e5d1fffc","line":10,"updated":"2017-03-18 01:10:28.000000000","message":"The bp link should be added here.","commit_id":"d0f020acdb528f7ebf1c74a17695338b8ad28253"},{"author":{"_account_id":23766,"name":"Dima Kuznetsov","email":"dima.kuznetsov@toganetworks.com","username":"dimak"},"change_message_id":"fcc570d7d1e240a7b07361deb213691855753a4f","unresolved":false,"context_lines":[{"line_number":7,"context_line":"[01/xx] Introduce add_group/del_group in DFlowApp"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add OpenFlow group manipulation methods."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: Ib636c2787aeaadf42f9ef81e5afdd68a4d68815d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"1a1ced50_1f83bb05","line":10,"in_reply_to":"1a1ced50_e5d1fffc","updated":"2017-03-19 09:07:02.000000000","message":"Will add.","commit_id":"d0f020acdb528f7ebf1c74a17695338b8ad28253"}],"dragonflow/controller/df_base_app.py":[{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"b6d431b166bd2c7847f4c2165e4d0bed93e1462a","unresolved":false,"context_lines":[{"line_number":150,"context_line":""},{"line_number":151,"context_line":"        datapath.send_msg(message)"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"    def add_group(self, group_id, group_type, buckets):"},{"line_number":154,"context_line":"        self._mod_group("},{"line_number":155,"context_line":"            command\u003dself.ofproto.OFPGC_ADD,"},{"line_number":156,"context_line":"            group_id\u003dgroup_id,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a30ddce_930352b8","line":153,"updated":"2017-03-07 10:11:16.000000000","message":"Docstring missing in all three methods.","commit_id":"a1707cc8bac80575d499667a6439bc3ff026ed76"},{"author":{"_account_id":23766,"name":"Dima Kuznetsov","email":"dima.kuznetsov@toganetworks.com","username":"dimak"},"change_message_id":"37dd7764a1964fdc1d608d5702b8e1639a420c26","unresolved":false,"context_lines":[{"line_number":150,"context_line":""},{"line_number":151,"context_line":"        datapath.send_msg(message)"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"    def add_group(self, group_id, group_type, buckets):"},{"line_number":154,"context_line":"        self._mod_group("},{"line_number":155,"context_line":"            command\u003dself.ofproto.OFPGC_ADD,"},{"line_number":156,"context_line":"            group_id\u003dgroup_id,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a30ddce_35d96e84","line":153,"in_reply_to":"9a30ddce_930352b8","updated":"2017-03-08 11:41:43.000000000","message":"Adding","commit_id":"a1707cc8bac80575d499667a6439bc3ff026ed76"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"37541aec7e40b58f0702464017c67e564dc76b82","unresolved":false,"context_lines":[{"line_number":154,"context_line":""},{"line_number":155,"context_line":"        datapath.send_msg(message)"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"    def add_group(self, group_id, group_type, buckets):"},{"line_number":158,"context_line":"        \"\"\"Add an entry to the groups table:"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"            :param group_id:    ID for the new group"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a1ced50_a5446774","line":157,"range":{"start_line":157,"start_character":8,"end_line":157,"end_character":17},"updated":"2017-03-18 01:10:28.000000000","message":"Where will this method be used? Is there a functional test for the openflow group?","commit_id":"d0f020acdb528f7ebf1c74a17695338b8ad28253"},{"author":{"_account_id":23766,"name":"Dima Kuznetsov","email":"dima.kuznetsov@toganetworks.com","username":"dimak"},"change_message_id":"fcc570d7d1e240a7b07361deb213691855753a4f","unresolved":false,"context_lines":[{"line_number":154,"context_line":""},{"line_number":155,"context_line":"        datapath.send_msg(message)"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"    def add_group(self, group_id, group_type, buckets):"},{"line_number":158,"context_line":"        \"\"\"Add an entry to the groups table:"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"            :param group_id:    ID for the new group"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a1ced50_bf72a747","line":157,"range":{"start_line":157,"start_character":8,"end_line":157,"end_character":17},"in_reply_to":"1a1ced50_a5446774","updated":"2017-03-19 09:07:02.000000000","message":"This is used by the SFC app in [1], I prefer to separate this code to another patch as [1] is bit enough as it is.\n\nAbout the tests, I did not plan testing those 2 functions separately. The functions do not contain any DF logic, just sending a packet serialized by Ryu to OVS..\n\n\n[1] https://review.openstack.org/#/c/424146/","commit_id":"d0f020acdb528f7ebf1c74a17695338b8ad28253"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"37541aec7e40b58f0702464017c67e564dc76b82","unresolved":false,"context_lines":[{"line_number":190,"context_line":"                command\u003dcommand,"},{"line_number":191,"context_line":"                group_id\u003dgroup_id,"},{"line_number":192,"context_line":"                type_\u003dgroup_type,"},{"line_number":193,"context_line":"                buckets\u003dbuckets or [],"},{"line_number":194,"context_line":"            )"},{"line_number":195,"context_line":"        )"},{"line_number":196,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"1a1ced50_6560af36","line":193,"range":{"start_line":193,"start_character":31,"end_line":193,"end_character":37},"updated":"2017-03-18 01:10:28.000000000","message":"This is not required, as ryu has such code:\n\nbuckets \u003d buckets if buckets else []","commit_id":"d0f020acdb528f7ebf1c74a17695338b8ad28253"},{"author":{"_account_id":23766,"name":"Dima Kuznetsov","email":"dima.kuznetsov@toganetworks.com","username":"dimak"},"change_message_id":"fcc570d7d1e240a7b07361deb213691855753a4f","unresolved":false,"context_lines":[{"line_number":190,"context_line":"                command\u003dcommand,"},{"line_number":191,"context_line":"                group_id\u003dgroup_id,"},{"line_number":192,"context_line":"                type_\u003dgroup_type,"},{"line_number":193,"context_line":"                buckets\u003dbuckets or [],"},{"line_number":194,"context_line":"            )"},{"line_number":195,"context_line":"        )"},{"line_number":196,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"1a1ced50_5f7d331b","line":193,"range":{"start_line":193,"start_character":31,"end_line":193,"end_character":37},"in_reply_to":"1a1ced50_6560af36","updated":"2017-03-19 09:07:02.000000000","message":"Ok will remove","commit_id":"d0f020acdb528f7ebf1c74a17695338b8ad28253"}]}