)]}'
{"dragonflow/db/model_proxy.py":[{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"0d128536eddb37670720960dc8bd8166ed7c2710","unresolved":false,"context_lines":[{"line_number":106,"context_line":"    \u003e\u003e\u003e ref_to_lport.name"},{"line_number":107,"context_line":"    \u0027port-name\u0027"},{"line_number":108,"context_line":"    \"\"\""},{"line_number":109,"context_line":"    if not kwargs or not kwargs.get(\u0027id\u0027, None):"},{"line_number":110,"context_line":"        return None"},{"line_number":111,"context_line":"    reference_model \u003d create_model_proxy(model)"},{"line_number":112,"context_line":"    instance \u003d reference_model(lazy\u003dlazy, **kwargs)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba2be162_6bbf8bfb","line":109,"range":{"start_line":109,"start_character":25,"end_line":109,"end_character":47},"updated":"2017-03-02 01:23:32.000000000","message":"\"get\" method returns None by default","commit_id":"d0fba9db6208c80f854e10d4570c6f118902c031"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"f6e6b19f45cc3863a0e1335c7865cb35b7aff46b","unresolved":false,"context_lines":[{"line_number":106,"context_line":"    \u003e\u003e\u003e ref_to_lport.name"},{"line_number":107,"context_line":"    \u0027port-name\u0027"},{"line_number":108,"context_line":"    \"\"\""},{"line_number":109,"context_line":"    if not kwargs or not kwargs.get(\u0027id\u0027, None):"},{"line_number":110,"context_line":"        return None"},{"line_number":111,"context_line":"    reference_model \u003d create_model_proxy(model)"},{"line_number":112,"context_line":"    instance \u003d reference_model(lazy\u003dlazy, **kwargs)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba2be162_4ca49aa5","line":109,"range":{"start_line":109,"start_character":25,"end_line":109,"end_character":47},"in_reply_to":"ba2be162_6bbf8bfb","updated":"2017-03-02 05:05:07.000000000","message":"Yes, I forgot. Fixed.","commit_id":"d0fba9db6208c80f854e10d4570c6f118902c031"},{"author":{"_account_id":23766,"name":"Dima Kuznetsov","email":"dima.kuznetsov@toganetworks.com","username":"dimak"},"change_message_id":"36c6365505059830e109dfda916f94b95dfb32ed","unresolved":false,"context_lines":[{"line_number":106,"context_line":"    \u003e\u003e\u003e ref_to_lport.name"},{"line_number":107,"context_line":"    \u0027port-name\u0027"},{"line_number":108,"context_line":"    \"\"\""},{"line_number":109,"context_line":"    if not kwargs or not kwargs.get(\u0027id\u0027):"},{"line_number":110,"context_line":"        return None"},{"line_number":111,"context_line":"    reference_model \u003d create_model_proxy(model)"},{"line_number":112,"context_line":"    instance \u003d reference_model(lazy\u003dlazy, **kwargs)"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba2be162_4fee45ed","line":109,"range":{"start_line":109,"start_character":21,"end_line":109,"end_character":42},"updated":"2017-03-02 08:48:16.000000000","message":"I think \u0027id\u0027 not in kwargs is preferable","commit_id":"69b6ccd8997dc8289850490cf293f8a8870ea2b0"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"8a827c4353b5b0d75b276573584d114cefba167a","unresolved":false,"context_lines":[{"line_number":106,"context_line":"    \u003e\u003e\u003e ref_to_lport.name"},{"line_number":107,"context_line":"    \u0027port-name\u0027"},{"line_number":108,"context_line":"    \"\"\""},{"line_number":109,"context_line":"    if not kwargs or not kwargs.get(\u0027id\u0027):"},{"line_number":110,"context_line":"        return None"},{"line_number":111,"context_line":"    reference_model \u003d create_model_proxy(model)"},{"line_number":112,"context_line":"    instance \u003d reference_model(lazy\u003dlazy, **kwargs)"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba2be162_5b17e3ec","line":109,"range":{"start_line":109,"start_character":21,"end_line":109,"end_character":42},"in_reply_to":"ba2be162_4fee45ed","updated":"2017-03-02 10:02:04.000000000","message":"Will do","commit_id":"69b6ccd8997dc8289850490cf293f8a8870ea2b0"},{"author":{"_account_id":23766,"name":"Dima Kuznetsov","email":"dima.kuznetsov@toganetworks.com","username":"dimak"},"change_message_id":"36c6365505059830e109dfda916f94b95dfb32ed","unresolved":false,"context_lines":[{"line_number":107,"context_line":"    \u0027port-name\u0027"},{"line_number":108,"context_line":"    \"\"\""},{"line_number":109,"context_line":"    if not kwargs or not kwargs.get(\u0027id\u0027):"},{"line_number":110,"context_line":"        return None"},{"line_number":111,"context_line":"    reference_model \u003d create_model_proxy(model)"},{"line_number":112,"context_line":"    instance \u003d reference_model(lazy\u003dlazy, **kwargs)"},{"line_number":113,"context_line":"    return instance"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba2be162_4fc56559","line":110,"range":{"start_line":110,"start_character":8,"end_line":110,"end_character":19},"updated":"2017-03-02 08:48:16.000000000","message":"Any specific reason you want it to return rather than raise?","commit_id":"69b6ccd8997dc8289850490cf293f8a8870ea2b0"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"8a827c4353b5b0d75b276573584d114cefba167a","unresolved":false,"context_lines":[{"line_number":107,"context_line":"    \u0027port-name\u0027"},{"line_number":108,"context_line":"    \"\"\""},{"line_number":109,"context_line":"    if not kwargs or not kwargs.get(\u0027id\u0027):"},{"line_number":110,"context_line":"        return None"},{"line_number":111,"context_line":"    reference_model \u003d create_model_proxy(model)"},{"line_number":112,"context_line":"    instance \u003d reference_model(lazy\u003dlazy, **kwargs)"},{"line_number":113,"context_line":"    return instance"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba2be162_fb21774e","line":110,"range":{"start_line":110,"start_character":8,"end_line":110,"end_character":19},"in_reply_to":"ba2be162_4fc56559","updated":"2017-03-02 10:02:04.000000000","message":"Yes. The use-case is create_preference(mode, lazy, id) where ID is taken from the parent model in the neutron code. I don\u0027t test ID, just pass it here. If it is None, None should be returned. (Otherwise I have to move the test/try-catch logic to the client code which breaks the idea of syntactic sugar)","commit_id":"69b6ccd8997dc8289850490cf293f8a8870ea2b0"},{"author":{"_account_id":23766,"name":"Dima Kuznetsov","email":"dima.kuznetsov@toganetworks.com","username":"dimak"},"change_message_id":"36c6365505059830e109dfda916f94b95dfb32ed","unresolved":false,"context_lines":[{"line_number":108,"context_line":"    \"\"\""},{"line_number":109,"context_line":"    if not kwargs or not kwargs.get(\u0027id\u0027):"},{"line_number":110,"context_line":"        return None"},{"line_number":111,"context_line":"    reference_model \u003d create_model_proxy(model)"},{"line_number":112,"context_line":"    instance \u003d reference_model(lazy\u003dlazy, **kwargs)"},{"line_number":113,"context_line":"    return instance"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba2be162_af27c162","line":111,"range":{"start_line":111,"start_character":22,"end_line":111,"end_character":40},"updated":"2017-03-02 08:48:16.000000000","message":"A bit out of scope but I think we should memoize this, so each ref won\u0027t end up with a different type..","commit_id":"69b6ccd8997dc8289850490cf293f8a8870ea2b0"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"8a827c4353b5b0d75b276573584d114cefba167a","unresolved":false,"context_lines":[{"line_number":108,"context_line":"    \"\"\""},{"line_number":109,"context_line":"    if not kwargs or not kwargs.get(\u0027id\u0027):"},{"line_number":110,"context_line":"        return None"},{"line_number":111,"context_line":"    reference_model \u003d create_model_proxy(model)"},{"line_number":112,"context_line":"    instance \u003d reference_model(lazy\u003dlazy, **kwargs)"},{"line_number":113,"context_line":"    return instance"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba2be162_dbaf5392","line":111,"range":{"start_line":111,"start_character":22,"end_line":111,"end_character":40},"in_reply_to":"ba2be162_af27c162","updated":"2017-03-02 10:02:04.000000000","message":"Sure. Will do.","commit_id":"69b6ccd8997dc8289850490cf293f8a8870ea2b0"}]}