)]}'
{"dragonflow/tests/fullstack/test_base.py":[{"author":{"_account_id":23766,"name":"Dima Kuznetsov","email":"dima.kuznetsov@toganetworks.com","username":"dimak"},"change_message_id":"205df319306cb0cf184403dd8e3ba6aa218fff2a","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        if cfg.CONF.df.enable_selective_topology_distribution:"},{"line_number":72,"context_line":"            self.start_subscribing()"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    def check_active_port_detection_app(self):"},{"line_number":75,"context_line":"        apps_list \u003d cfg.CONF.df.apps_list"},{"line_number":76,"context_line":"        if ctrl_utils.ACTIVE_PORT_DETECTION_APP in apps_list:"},{"line_number":77,"context_line":"            return True"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a1ff146_250db737","line":74,"range":{"start_line":74,"start_character":8,"end_line":74,"end_character":39},"updated":"2017-03-16 08:54:04.000000000","message":"I think we can implement this got other apps as well, e.g.\n\nself._check_app_loaded(app_name)\n\nAnd use it in other tests in test_apps.","commit_id":"7974b0f76019ebf6dda84e848dd39e265da1ca39"},{"author":{"_account_id":23235,"name":"Lihi Wishnitzer","email":"lihiwish@gmail.com","username":"lihiwish"},"change_message_id":"3d804edb053e2227da717575ac2ce4c1628e35e4","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        if cfg.CONF.df.enable_selective_topology_distribution:"},{"line_number":72,"context_line":"            self.start_subscribing()"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    def check_active_port_detection_app(self):"},{"line_number":75,"context_line":"        apps_list \u003d cfg.CONF.df.apps_list"},{"line_number":76,"context_line":"        if ctrl_utils.ACTIVE_PORT_DETECTION_APP in apps_list:"},{"line_number":77,"context_line":"            return True"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a1ff146_488acac0","line":74,"range":{"start_line":74,"start_character":8,"end_line":74,"end_character":39},"in_reply_to":"3a1ff146_250db737","updated":"2017-03-16 09:46:05.000000000","message":"+1","commit_id":"7974b0f76019ebf6dda84e848dd39e265da1ca39"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"527d8e6cc3ba2ae344a5048b48676edc7a8f91d9","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        if cfg.CONF.df.enable_selective_topology_distribution:"},{"line_number":72,"context_line":"            self.start_subscribing()"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    def check_active_port_detection_app(self):"},{"line_number":75,"context_line":"        apps_list \u003d cfg.CONF.df.apps_list"},{"line_number":76,"context_line":"        if ctrl_utils.ACTIVE_PORT_DETECTION_APP in apps_list:"},{"line_number":77,"context_line":"            return True"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a1ced50_c52b232f","line":74,"range":{"start_line":74,"start_character":8,"end_line":74,"end_character":39},"in_reply_to":"3a1ff146_488acac0","updated":"2017-03-18 00:26:42.000000000","message":"there is such a function in [1], but it is not used after some refactor. Maybe [1] can be used here. Or as Dima and Lihi pointed out, [1] can be changed to a general check and used in this patch.\n\n\n[1] https://github.com/openstack/dragonflow/blob/be507fa1fe10128bb163eeb80a540d64f47750c6/dragonflow/controller/common/utils.py#L71-L75","commit_id":"7974b0f76019ebf6dda84e848dd39e265da1ca39"}]}