)]}'
{"dragonflow/db/model_framework.py":[{"author":{"_account_id":23766,"name":"Dima Kuznetsov","email":"dima.kuznetsov@toganetworks.com","username":"dimak"},"change_message_id":"3de6ef33e480f7e259a1aba89b5de3046e10deeb","unresolved":false,"context_lines":[{"line_number":202,"context_line":"                        # model(derived from ModelBase), we it is considered as"},{"line_number":203,"context_line":"                        # non-first class model. And its dependency"},{"line_number":204,"context_line":"                        # will be treated as current model\u0027s dependency."},{"line_number":205,"context_line":"                        deps |\u003d field_type.dependencies()"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"        return deps"},{"line_number":208,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ffe62b97_3543a36e","line":205,"range":{"start_line":205,"start_character":32,"end_line":205,"end_character":42},"updated":"2017-03-28 14:46:20.000000000","message":"I think we should be adding field_type itself as well.","commit_id":"a39cf7324ba5b8aebc29acca4ae0ba424c0a07c9"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"47aca0e5068e73070cceb8329696cc3c9f2d9ca0","unresolved":false,"context_lines":[{"line_number":202,"context_line":"                        # model(derived from ModelBase), we it is considered as"},{"line_number":203,"context_line":"                        # non-first class model. And its dependency"},{"line_number":204,"context_line":"                        # will be treated as current model\u0027s dependency."},{"line_number":205,"context_line":"                        deps |\u003d field_type.dependencies()"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"        return deps"},{"line_number":208,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ffe62b97_cda5f848","line":205,"range":{"start_line":205,"start_character":32,"end_line":205,"end_character":42},"in_reply_to":"ffe62b97_3543a36e","updated":"2017-03-28 23:12:06.000000000","message":"In this case, field_type may be a second class db model(e.g. LogicalRouterPort). If it is added as dependency, there will be no update/delete method in controller to match it.","commit_id":"a39cf7324ba5b8aebc29acca4ae0ba424c0a07c9"},{"author":{"_account_id":23766,"name":"Dima Kuznetsov","email":"dima.kuznetsov@toganetworks.com","username":"dimak"},"change_message_id":"b753028b5385bf0d6081f4d36fdeadae855e4498","unresolved":false,"context_lines":[{"line_number":202,"context_line":"                        # model(derived from ModelBase), we it is considered as"},{"line_number":203,"context_line":"                        # non-first class model. And its dependency"},{"line_number":204,"context_line":"                        # will be treated as current model\u0027s dependency."},{"line_number":205,"context_line":"                        deps |\u003d field_type.dependencies()"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"        return deps"},{"line_number":208,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ffe62b97_91fca33e","line":205,"range":{"start_line":205,"start_character":32,"end_line":205,"end_character":42},"in_reply_to":"ffe62b97_cda5f848","updated":"2017-03-29 07:06:39.000000000","message":"I understand.","commit_id":"a39cf7324ba5b8aebc29acca4ae0ba424c0a07c9"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"cf32520f258ec10c524f540cf28293087484549d","unresolved":false,"context_lines":[{"line_number":207,"context_line":"                except AttributeError:"},{"line_number":208,"context_line":"                    if issubclass(field_type, ModelBase):"},{"line_number":209,"context_line":"                        # If the field is not a reference, and it is a df"},{"line_number":210,"context_line":"                        # model(derived from ModelBase), we it is considered as"},{"line_number":211,"context_line":"                        # non-first class model. And its dependency"},{"line_number":212,"context_line":"                        # will be treated as current model\u0027s dependency."},{"line_number":213,"context_line":"                        deps |\u003d field_type.dependencies()"}],"source_content_type":"text/x-python","patch_set":4,"id":"dfeb2761_41ec2e8e","line":210,"range":{"start_line":210,"start_character":57,"end_line":210,"end_character":59},"updated":"2017-04-05 08:14:54.000000000","message":"nit: Remove?","commit_id":"f8a9a5a8b9f439dc686ab900918368ae5f34dd49"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"a2d1754349cba8b4fe961a2e4dfd251ffe6e6001","unresolved":false,"context_lines":[{"line_number":207,"context_line":"                except AttributeError:"},{"line_number":208,"context_line":"                    if issubclass(field_type, ModelBase):"},{"line_number":209,"context_line":"                        # If the field is not a reference, and it is a df"},{"line_number":210,"context_line":"                        # model(derived from ModelBase), we it is considered as"},{"line_number":211,"context_line":"                        # non-first class model. And its dependency"},{"line_number":212,"context_line":"                        # will be treated as current model\u0027s dependency."},{"line_number":213,"context_line":"                        deps |\u003d field_type.dependencies()"}],"source_content_type":"text/x-python","patch_set":4,"id":"dfeb2761_8515999e","line":210,"range":{"start_line":210,"start_character":57,"end_line":210,"end_character":59},"in_reply_to":"dfeb2761_41ec2e8e","updated":"2017-04-05 11:26:24.000000000","message":"Done","commit_id":"f8a9a5a8b9f439dc686ab900918368ae5f34dd49"}],"dragonflow/tests/unit/test_model_framework.py":[{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"cf32520f258ec10c524f540cf28293087484549d","unresolved":false,"context_lines":[{"line_number":400,"context_line":"        self.assertLess("},{"line_number":401,"context_line":"            sorted_models.index(ReffedModel),"},{"line_number":402,"context_line":"            sorted_models.index(ReffingModel3)"},{"line_number":403,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":4,"id":"dfeb2761_a11bfa7e","line":403,"updated":"2017-04-05 08:14:54.000000000","message":"Maybe also add a test case: assertIn(ReffedModel, ReffingModel3.dependencies()) ?","commit_id":"f8a9a5a8b9f439dc686ab900918368ae5f34dd49"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"a2d1754349cba8b4fe961a2e4dfd251ffe6e6001","unresolved":false,"context_lines":[{"line_number":400,"context_line":"        self.assertLess("},{"line_number":401,"context_line":"            sorted_models.index(ReffedModel),"},{"line_number":402,"context_line":"            sorted_models.index(ReffingModel3)"},{"line_number":403,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":4,"id":"dfeb2761_857a39ee","line":403,"in_reply_to":"dfeb2761_a11bfa7e","updated":"2017-04-05 11:26:24.000000000","message":"Done","commit_id":"f8a9a5a8b9f439dc686ab900918368ae5f34dd49"}]}