)]}'
{"dragonflow/neutron/services/bgp/bgp_plugin.py":[{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"d0b790bc5c0955de7e733666a72c24cdb6b4e7b2","unresolved":false,"context_lines":[{"line_number":206,"context_line":"        bgp_speaker \u003d self.nb_api.get(bgp.BGPSpeaker(id\u003dbgp_speaker_id,"},{"line_number":207,"context_line":"                                                     topic\u003dtopic))"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"        fip_routes \u003d [r for r in bgp_speaker.routes"},{"line_number":210,"context_line":"                      if r.destination.size \u003d\u003d 1]"},{"line_number":211,"context_line":"        bgp_speaker.routes \u003d routes + fip_routes"},{"line_number":212,"context_line":"        self.nb_api.update(bgp_speaker, skip_send_event\u003dTrue)"},{"line_number":213,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5ff73747_220f288a","line":210,"range":{"start_line":209,"start_character":0,"end_line":210,"end_character":49},"updated":"2017-04-26 07:14:28.000000000","message":"Maybe it would be better to add a \u0027source\u0027 parameter for routes? Then you can filter them with (r.source !\u003d SOURCE_NETWORK_ROUTER). This might make adding new route sources easier, e.g. manual routing updates.","commit_id":"733dd68ae30ddbc9d16b72122e8e2d10aec78c4d"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"1cd986259d0bdec8c648505bd06e1db502e09d0d","unresolved":false,"context_lines":[{"line_number":206,"context_line":"        bgp_speaker \u003d self.nb_api.get(bgp.BGPSpeaker(id\u003dbgp_speaker_id,"},{"line_number":207,"context_line":"                                                     topic\u003dtopic))"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"        fip_routes \u003d [r for r in bgp_speaker.routes"},{"line_number":210,"context_line":"                      if r.destination.size \u003d\u003d 1]"},{"line_number":211,"context_line":"        bgp_speaker.routes \u003d routes + fip_routes"},{"line_number":212,"context_line":"        self.nb_api.update(bgp_speaker, skip_send_event\u003dTrue)"},{"line_number":213,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5ff73747_ad6e8992","line":210,"range":{"start_line":209,"start_character":0,"end_line":210,"end_character":49},"in_reply_to":"5ff73747_220f288a","updated":"2017-04-26 07:35:58.000000000","message":"That is what I thought when writing this patch. I think maybe I can add two fields in bgp_speaker, one is prefix_routes, the other is host_routes.","commit_id":"733dd68ae30ddbc9d16b72122e8e2d10aec78c4d"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"7cd749ea353f8a3b852b3c85f25b5593089b6169","unresolved":false,"context_lines":[{"line_number":206,"context_line":"        bgp_speaker \u003d self.nb_api.get(bgp.BGPSpeaker(id\u003dbgp_speaker_id,"},{"line_number":207,"context_line":"                                                     topic\u003dtopic))"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"        fip_routes \u003d [r for r in bgp_speaker.routes"},{"line_number":210,"context_line":"                      if r.destination.size \u003d\u003d 1]"},{"line_number":211,"context_line":"        bgp_speaker.routes \u003d routes + fip_routes"},{"line_number":212,"context_line":"        self.nb_api.update(bgp_speaker, skip_send_event\u003dTrue)"},{"line_number":213,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5ff73747_b8f924c9","line":210,"range":{"start_line":209,"start_character":0,"end_line":210,"end_character":49},"in_reply_to":"5ff73747_ad6e8992","updated":"2017-04-26 10:58:32.000000000","message":"Sounds good.","commit_id":"733dd68ae30ddbc9d16b72122e8e2d10aec78c4d"}]}
