)]}'
{"dragonflow/tests/unit/test_model_proxy.py":[{"author":{"_account_id":23235,"name":"Lihi Wishnitzer","email":"lihiwish@gmail.com","username":"lihiwish"},"change_message_id":"3861db83e21c6d65861f7f744a427793fd892c11","unresolved":false,"context_lines":[{"line_number":116,"context_line":"        m \u003d RefferingModel(other_field\u003d\u0027hi there\u0027)"},{"line_number":117,"context_line":"        ref \u003d ModelTest(id\u003d\u00271234\u0027, topic\u003d\u00273\u0027)"},{"line_number":118,"context_line":"        m1 \u003d RefferingModel(model_test\u003dref)"},{"line_number":119,"context_line":"        m.update(m1)"},{"line_number":120,"context_line":"        self.assertEqual(\u00271234\u0027, m.model_test.id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5ff73747_dd608c35","line":120,"range":{"start_line":119,"start_character":8,"end_line":120,"end_character":49},"updated":"2017-04-25 10:54:14.000000000","message":"Isn\u0027t  \nself.assertEqual(m, None)\na more accurate test for this scenario?","commit_id":"8c59edca362ebcf8e3fba67670d9220084bfd0e4"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"d748e5c6a527a873f21ffac8a924ad26129eb9fa","unresolved":false,"context_lines":[{"line_number":116,"context_line":"        m \u003d RefferingModel(other_field\u003d\u0027hi there\u0027)"},{"line_number":117,"context_line":"        ref \u003d ModelTest(id\u003d\u00271234\u0027, topic\u003d\u00273\u0027)"},{"line_number":118,"context_line":"        m1 \u003d RefferingModel(model_test\u003dref)"},{"line_number":119,"context_line":"        m.update(m1)"},{"line_number":120,"context_line":"        self.assertEqual(\u00271234\u0027, m.model_test.id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5ff73747_d543c4ae","line":120,"range":{"start_line":119,"start_character":8,"end_line":120,"end_character":49},"in_reply_to":"5ff73747_dd608c35","updated":"2017-04-25 11:32:36.000000000","message":"I\u0027ll add self.assertNotEqual(ref, None) and self.assertNotEqual(None, ref)","commit_id":"8c59edca362ebcf8e3fba67670d9220084bfd0e4"},{"author":{"_account_id":23766,"name":"Dima Kuznetsov","email":"dima.kuznetsov@toganetworks.com","username":"dimak"},"change_message_id":"9bcbe9adb728d80d2f52df9ab5948271d4efc863","unresolved":false,"context_lines":[{"line_number":116,"context_line":"        m \u003d RefferingModel(other_field\u003d\u0027hi there\u0027)"},{"line_number":117,"context_line":"        ref \u003d ModelTest(id\u003d\u00271234\u0027, topic\u003d\u00273\u0027)"},{"line_number":118,"context_line":"        m1 \u003d RefferingModel(model_test\u003dref)"},{"line_number":119,"context_line":"        m.update(m1)"},{"line_number":120,"context_line":"        self.assertEqual(\u00271234\u0027, m.model_test.id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5ff73747_f576c006","line":120,"range":{"start_line":119,"start_character":8,"end_line":120,"end_character":49},"in_reply_to":"5ff73747_dd608c35","updated":"2017-04-25 11:30:32.000000000","message":"Or assertIs(Not)None","commit_id":"8c59edca362ebcf8e3fba67670d9220084bfd0e4"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"8508fef1157296d92ce19fb050e4666c4b33b66e","unresolved":false,"context_lines":[{"line_number":113,"context_line":"                            model_proxy.create_model_proxy(ModelTest2))"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    def test_null_comparison(self):"},{"line_number":116,"context_line":"        self.assertNotEqual(model_proxy.create_reference(ModelTest, \u00274321\u0027),"},{"line_number":117,"context_line":"                         None)  # noqa: H203"},{"line_number":118,"context_line":"        m \u003d RefferingModel(other_field\u003d\u0027hi there\u0027)"},{"line_number":119,"context_line":"        ref \u003d ModelTest(id\u003d\u00271234\u0027, topic\u003d\u00273\u0027)"},{"line_number":120,"context_line":"        m1 \u003d RefferingModel(model_test\u003dref)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5ff73747_1b74a067","line":117,"range":{"start_line":116,"start_character":8,"end_line":117,"end_character":44},"updated":"2017-04-26 01:17:55.000000000","message":"why not just use the convention that H203 suggested.\n\nself.assertIsNotNone(model_proxy.create_reference(ModelTest, \u00274321\u0027))","commit_id":"64c2d5af9281ee1664e781b3ec9ec5c42a5de3a9"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"de40ea1f9b548a5ce7c496943fb4cb25537c1ba2","unresolved":false,"context_lines":[{"line_number":113,"context_line":"                            model_proxy.create_model_proxy(ModelTest2))"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    def test_null_comparison(self):"},{"line_number":116,"context_line":"        self.assertNotEqual(model_proxy.create_reference(ModelTest, \u00274321\u0027),"},{"line_number":117,"context_line":"                         None)  # noqa: H203"},{"line_number":118,"context_line":"        m \u003d RefferingModel(other_field\u003d\u0027hi there\u0027)"},{"line_number":119,"context_line":"        ref \u003d ModelTest(id\u003d\u00271234\u0027, topic\u003d\u00273\u0027)"},{"line_number":120,"context_line":"        m1 \u003d RefferingModel(model_test\u003dref)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5ff73747_e2db80ea","line":117,"range":{"start_line":116,"start_character":8,"end_line":117,"end_character":44},"in_reply_to":"5ff73747_0260ac31","updated":"2017-04-26 07:16:08.000000000","message":"Will do","commit_id":"64c2d5af9281ee1664e781b3ec9ec5c42a5de3a9"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"d91b51b734b26a88160bdff98b7ab348b4d01da4","unresolved":false,"context_lines":[{"line_number":113,"context_line":"                            model_proxy.create_model_proxy(ModelTest2))"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    def test_null_comparison(self):"},{"line_number":116,"context_line":"        self.assertNotEqual(model_proxy.create_reference(ModelTest, \u00274321\u0027),"},{"line_number":117,"context_line":"                         None)  # noqa: H203"},{"line_number":118,"context_line":"        m \u003d RefferingModel(other_field\u003d\u0027hi there\u0027)"},{"line_number":119,"context_line":"        ref \u003d ModelTest(id\u003d\u00271234\u0027, topic\u003d\u00273\u0027)"},{"line_number":120,"context_line":"        m1 \u003d RefferingModel(model_test\u003dref)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5ff73747_dff97fc8","line":117,"range":{"start_line":116,"start_character":8,"end_line":117,"end_character":44},"in_reply_to":"5ff73747_1b74a067","updated":"2017-04-26 06:08:20.000000000","message":"assertIsNotNone doesn\u0027t go through the __eq__ function. I suspect it uses \u0027is\u0027 to test if the argument is None (This is the case in unittest2[1]). The flow being tested here must use \u0027\u003d\u003d\u0027 to go through the __eq__ function.\n\n[1] https://pypi.python.org/pypi/unittest2","commit_id":"64c2d5af9281ee1664e781b3ec9ec5c42a5de3a9"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"e1400ef00e48770c117bc621b937c1b2ff696a7e","unresolved":false,"context_lines":[{"line_number":113,"context_line":"                            model_proxy.create_model_proxy(ModelTest2))"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    def test_null_comparison(self):"},{"line_number":116,"context_line":"        self.assertNotEqual(model_proxy.create_reference(ModelTest, \u00274321\u0027),"},{"line_number":117,"context_line":"                         None)  # noqa: H203"},{"line_number":118,"context_line":"        m \u003d RefferingModel(other_field\u003d\u0027hi there\u0027)"},{"line_number":119,"context_line":"        ref \u003d ModelTest(id\u003d\u00271234\u0027, topic\u003d\u00273\u0027)"},{"line_number":120,"context_line":"        m1 \u003d RefferingModel(model_test\u003dref)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5ff73747_0260ac31","line":117,"range":{"start_line":116,"start_character":8,"end_line":117,"end_character":44},"in_reply_to":"5ff73747_dff97fc8","updated":"2017-04-26 07:15:12.000000000","message":"If so, maybe add some comments here to make others understand it?","commit_id":"64c2d5af9281ee1664e781b3ec9ec5c42a5de3a9"}]}