)]}'
{"dragonflow/controller/topology.py":[{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"58b41c156051d657009fe8d6a9cdef3a1681d4e3","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        self.chassis_name \u003d controller.get_chassis_name()"},{"line_number":44,"context_line":"        self.db_store2 \u003d db_store2.get_instance()"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"        ovs.OvsPort.register_updated(self.ovs_port_updated)"},{"line_number":47,"context_line":"        ovs.OvsPort.register_deleted(self.ovs_port_deleted)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    def ovs_port_updated(self, ovs_port):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5ff73747_c2ad2432","line":46,"range":{"start_line":46,"start_character":0,"end_line":46,"end_character":59},"updated":"2017-04-26 07:56:29.000000000","message":"nit: Would it be more readable as a decorator?\n\n@ovs.OvsPort.register_updated\ndef ovs_port_updated(self, ovs_port):\n    ...\n\n(I am not sure, but I want it discussed)","commit_id":"f25862d21669477761fc638b7718a0da3404cfc7"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"665f882b088fa4821b48bca122a148f39d893b9e","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        self.chassis_name \u003d controller.get_chassis_name()"},{"line_number":44,"context_line":"        self.db_store2 \u003d db_store2.get_instance()"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"        ovs.OvsPort.register_updated(self.ovs_port_updated)"},{"line_number":47,"context_line":"        ovs.OvsPort.register_deleted(self.ovs_port_deleted)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    def ovs_port_updated(self, ovs_port):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5ff73747_0af091fd","line":46,"range":{"start_line":46,"start_character":0,"end_line":46,"end_character":59},"in_reply_to":"5ff73747_4d502533","updated":"2017-04-27 11:57:40.000000000","message":"Right.","commit_id":"f25862d21669477761fc638b7718a0da3404cfc7"},{"author":{"_account_id":23766,"name":"Dima Kuznetsov","email":"dima.kuznetsov@toganetworks.com","username":"dimak"},"change_message_id":"4cac88021bc5d5307fa440a8d850152ebcb6664f","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        self.chassis_name \u003d controller.get_chassis_name()"},{"line_number":44,"context_line":"        self.db_store2 \u003d db_store2.get_instance()"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"        ovs.OvsPort.register_updated(self.ovs_port_updated)"},{"line_number":47,"context_line":"        ovs.OvsPort.register_deleted(self.ovs_port_deleted)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    def ovs_port_updated(self, ovs_port):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5ff73747_4d502533","line":46,"range":{"start_line":46,"start_character":0,"end_line":46,"end_character":59},"in_reply_to":"5ff73747_c2ad2432","updated":"2017-04-26 12:16:16.000000000","message":"It can\u0027t be done this way, we need ovs_port_updated bound to instance of Topology..","commit_id":"f25862d21669477761fc638b7718a0da3404cfc7"}],"dragonflow/db/api_nb.py":[{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"58b41c156051d657009fe8d6a9cdef3a1681d4e3","unresolved":false,"context_lines":[{"line_number":286,"context_line":"                self.controller.update(obj)"},{"line_number":287,"context_line":"            return"},{"line_number":288,"context_line":""},{"line_number":289,"context_line":"        if \u0027ovsinterface\u0027 \u003d\u003d table:"},{"line_number":290,"context_line":"            # FIXME(dimak) use \u0027ovs_port\u0027 table to avoid custom code path"},{"line_number":291,"context_line":"            if action in (\u0027set\u0027, \u0027create\u0027):"},{"line_number":292,"context_line":"                self.controller.update("}],"source_content_type":"text/x-python","patch_set":3,"id":"5ff73747_eddb71ea","line":289,"range":{"start_line":289,"start_character":12,"end_line":289,"end_character":24},"updated":"2017-04-26 07:56:29.000000000","message":"Maybe use OvsPort model name here?","commit_id":"f25862d21669477761fc638b7718a0da3404cfc7"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"665f882b088fa4821b48bca122a148f39d893b9e","unresolved":false,"context_lines":[{"line_number":286,"context_line":"                self.controller.update(obj)"},{"line_number":287,"context_line":"            return"},{"line_number":288,"context_line":""},{"line_number":289,"context_line":"        if \u0027ovsinterface\u0027 \u003d\u003d table:"},{"line_number":290,"context_line":"            # FIXME(dimak) use \u0027ovs_port\u0027 table to avoid custom code path"},{"line_number":291,"context_line":"            if action in (\u0027set\u0027, \u0027create\u0027):"},{"line_number":292,"context_line":"                self.controller.update("}],"source_content_type":"text/x-python","patch_set":3,"id":"5ff73747_6ae4b53c","line":289,"range":{"start_line":289,"start_character":12,"end_line":289,"end_character":24},"in_reply_to":"5ff73747_b6237505","updated":"2017-04-27 11:57:40.000000000","message":"All right","commit_id":"f25862d21669477761fc638b7718a0da3404cfc7"},{"author":{"_account_id":23766,"name":"Dima Kuznetsov","email":"dima.kuznetsov@toganetworks.com","username":"dimak"},"change_message_id":"4cac88021bc5d5307fa440a8d850152ebcb6664f","unresolved":false,"context_lines":[{"line_number":286,"context_line":"                self.controller.update(obj)"},{"line_number":287,"context_line":"            return"},{"line_number":288,"context_line":""},{"line_number":289,"context_line":"        if \u0027ovsinterface\u0027 \u003d\u003d table:"},{"line_number":290,"context_line":"            # FIXME(dimak) use \u0027ovs_port\u0027 table to avoid custom code path"},{"line_number":291,"context_line":"            if action in (\u0027set\u0027, \u0027create\u0027):"},{"line_number":292,"context_line":"                self.controller.update("}],"source_content_type":"text/x-python","patch_set":3,"id":"5ff73747_b6237505","line":289,"range":{"start_line":289,"start_character":12,"end_line":289,"end_character":24},"in_reply_to":"5ff73747_eddb71ea","updated":"2017-04-26 12:16:16.000000000","message":"We need a table name to piggyback ovs_sync events on, I think this can stay the same until we refactor this code and take non-db events out of this code path.","commit_id":"f25862d21669477761fc638b7718a0da3404cfc7"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"390bcf631735c0db97c28879f8865e4d18be1f89","unresolved":false,"context_lines":[{"line_number":256,"context_line":"                self.controller.update(obj)"},{"line_number":257,"context_line":"            return"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"        if action \u003d\u003d \u0027ovs_sync_finished\u0027:"},{"line_number":260,"context_line":"            self.controller.ovs_sync_finished()"},{"line_number":261,"context_line":"        elif action \u003d\u003d \u0027ovs_sync_started\u0027:"},{"line_number":262,"context_line":"            self.controller.ovs_sync_started()"},{"line_number":263,"context_line":"        # Added lport migration for VM migration flag"},{"line_number":264,"context_line":"        elif \u0027lport_migration\u0027 \u003d\u003d table:"},{"line_number":265,"context_line":"            if action \u003d\u003d \u0027migrate\u0027:"}],"source_content_type":"text/x-python","patch_set":12,"id":"ff0f0b1f_f2db971e","line":262,"range":{"start_line":259,"start_character":0,"end_line":262,"end_character":46},"updated":"2017-05-26 07:58:57.000000000","message":"Is it better to move these lines to line 244. So we will have all events that not related to any table be together.","commit_id":"bd1c0e7086c42b71f21c3a795eaaddd8f25c5e11"},{"author":{"_account_id":23766,"name":"Dima Kuznetsov","email":"dima.kuznetsov@toganetworks.com","username":"dimak"},"change_message_id":"9cc225a3587c40d48a96100af8d72ac31d66b582","unresolved":false,"context_lines":[{"line_number":256,"context_line":"                self.controller.update(obj)"},{"line_number":257,"context_line":"            return"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"        if action \u003d\u003d \u0027ovs_sync_finished\u0027:"},{"line_number":260,"context_line":"            self.controller.ovs_sync_finished()"},{"line_number":261,"context_line":"        elif action \u003d\u003d \u0027ovs_sync_started\u0027:"},{"line_number":262,"context_line":"            self.controller.ovs_sync_started()"},{"line_number":263,"context_line":"        # Added lport migration for VM migration flag"},{"line_number":264,"context_line":"        elif \u0027lport_migration\u0027 \u003d\u003d table:"},{"line_number":265,"context_line":"            if action \u003d\u003d \u0027migrate\u0027:"}],"source_content_type":"text/x-python","patch_set":12,"id":"ff0f0b1f_9e3904f4","line":262,"range":{"start_line":259,"start_character":0,"end_line":262,"end_character":46},"in_reply_to":"ff0f0b1f_f2db971e","updated":"2017-05-28 14:38:58.000000000","message":"Agree","commit_id":"bd1c0e7086c42b71f21c3a795eaaddd8f25c5e11"}],"dragonflow/db/models/all.py":[{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"390bcf631735c0db97c28879f8865e4d18be1f89","unresolved":false,"context_lines":[{"line_number":14,"context_line":"from dragonflow.db.models import l2  # noqa"},{"line_number":15,"context_line":"from dragonflow.db.models import l3  # noqa"},{"line_number":16,"context_line":"from dragonflow.db.models import legacy  # noqa"},{"line_number":17,"context_line":"from dragonflow.db.models import ovs  # noqa"},{"line_number":18,"context_line":"from dragonflow.db.models import qos  # noqa"},{"line_number":19,"context_line":"from dragonflow.db.models import secgroups  # noqa"},{"line_number":20,"context_line":"from dragonflow.db.models import service  # noqa"}],"source_content_type":"text/x-python","patch_set":12,"id":"ff0f0b1f_f2d15731","line":17,"updated":"2017-05-26 07:58:57.000000000","message":"should ovs be added here? It is not a model that will be stored in nb db.","commit_id":"bd1c0e7086c42b71f21c3a795eaaddd8f25c5e11"},{"author":{"_account_id":23766,"name":"Dima Kuznetsov","email":"dima.kuznetsov@toganetworks.com","username":"dimak"},"change_message_id":"9cc225a3587c40d48a96100af8d72ac31d66b582","unresolved":false,"context_lines":[{"line_number":14,"context_line":"from dragonflow.db.models import l2  # noqa"},{"line_number":15,"context_line":"from dragonflow.db.models import l3  # noqa"},{"line_number":16,"context_line":"from dragonflow.db.models import legacy  # noqa"},{"line_number":17,"context_line":"from dragonflow.db.models import ovs  # noqa"},{"line_number":18,"context_line":"from dragonflow.db.models import qos  # noqa"},{"line_number":19,"context_line":"from dragonflow.db.models import secgroups  # noqa"},{"line_number":20,"context_line":"from dragonflow.db.models import service  # noqa"}],"source_content_type":"text/x-python","patch_set":12,"id":"df140735_e501a1b1","line":17,"in_reply_to":"ff0f0b1f_f2d15731","updated":"2017-05-28 14:38:58.000000000","message":"Done","commit_id":"bd1c0e7086c42b71f21c3a795eaaddd8f25c5e11"}],"dragonflow/ovsdb/impl_idl.py":[{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"58b41c156051d657009fe8d6a9cdef3a1681d4e3","unresolved":false,"context_lines":[{"line_number":94,"context_line":"        action \u003d event if event !\u003d \u0027update\u0027 else \u0027set\u0027"},{"line_number":95,"context_line":"        if self._is_handle_interface_update(local_interface):"},{"line_number":96,"context_line":"            self.nb_api.db_change_callback("},{"line_number":97,"context_line":"                constants.OVS_INTERFACE,"},{"line_number":98,"context_line":"                local_interface.id,"},{"line_number":99,"context_line":"                action,"},{"line_number":100,"context_line":"                local_interface,"}],"source_content_type":"text/x-python","patch_set":3,"id":"5ff73747_ad50c95e","line":97,"range":{"start_line":97,"start_character":16,"end_line":97,"end_character":39},"updated":"2017-04-26 07:56:29.000000000","message":"Maybe use OvsPort model name here?","commit_id":"f25862d21669477761fc638b7718a0da3404cfc7"},{"author":{"_account_id":23766,"name":"Dima Kuznetsov","email":"dima.kuznetsov@toganetworks.com","username":"dimak"},"change_message_id":"4cac88021bc5d5307fa440a8d850152ebcb6664f","unresolved":false,"context_lines":[{"line_number":94,"context_line":"        action \u003d event if event !\u003d \u0027update\u0027 else \u0027set\u0027"},{"line_number":95,"context_line":"        if self._is_handle_interface_update(local_interface):"},{"line_number":96,"context_line":"            self.nb_api.db_change_callback("},{"line_number":97,"context_line":"                constants.OVS_INTERFACE,"},{"line_number":98,"context_line":"                local_interface.id,"},{"line_number":99,"context_line":"                action,"},{"line_number":100,"context_line":"                local_interface,"}],"source_content_type":"text/x-python","patch_set":3,"id":"5ff73747_367d25e7","line":97,"range":{"start_line":97,"start_character":16,"end_line":97,"end_character":39},"in_reply_to":"5ff73747_ad50c95e","updated":"2017-04-26 12:16:16.000000000","message":"See comment in api_nb.py","commit_id":"f25862d21669477761fc638b7718a0da3404cfc7"}]}