)]}'
{"devstack/override-defaults":[{"author":{"_account_id":7805,"name":"Li Ma","email":"skywalker.nick@gmail.com","username":"Nick"},"change_message_id":"fca05554e4ea5af83b539250e7a1a4b79473f75a","unresolved":false,"context_lines":[{"line_number":15,"context_line":"}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"if is_service_enabled df-l3-agent ; then"},{"line_number":18,"context_line":"    AGENT_L3_BINARY\u003d${AGENT_L3_BINARY:-\"$NEUTRON_BIN_DIR/df-l3-agent\"}"},{"line_number":19,"context_line":"    enable_service q-l3"},{"line_number":20,"context_line":"fi"},{"line_number":21,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":5,"id":"5ff73747_142a778f","line":18,"range":{"start_line":18,"start_character":41,"end_line":18,"end_character":56},"updated":"2017-05-03 02:24:03.000000000","message":"it seems this variable is none.","commit_id":"419245e64a62d3a2f8aa37e7228acffc94fa8e7c"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"6e1539f69cf099f6dee66a1a9178ee01c49f4bc5","unresolved":false,"context_lines":[{"line_number":15,"context_line":"}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"if is_service_enabled df-l3-agent ; then"},{"line_number":18,"context_line":"    AGENT_L3_BINARY\u003d${AGENT_L3_BINARY:-\"$NEUTRON_BIN_DIR/df-l3-agent\"}"},{"line_number":19,"context_line":"    enable_service q-l3"},{"line_number":20,"context_line":"fi"},{"line_number":21,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":5,"id":"5ff73747_c3ec4f2b","line":18,"range":{"start_line":18,"start_character":41,"end_line":18,"end_character":56},"in_reply_to":"5ff73747_142a778f","updated":"2017-05-03 06:37:31.000000000","message":"yeah, override-defaults runs before lib/neutron-legacy, where NEUTRON_BIN_DIR is defined.","commit_id":"419245e64a62d3a2f8aa37e7228acffc94fa8e7c"}],"dragonflow/neutron/services/qos/drivers/df_qos.py":[{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"0df6ef576c5ac0807fb523ca3cf9ddd69d8bbf4f","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        qos_consts.MAX_BURST: {"},{"line_number":32,"context_line":"            \u0027type:range\u0027: [0, constants.DB_INTEGER_MAX_VALUE],"},{"line_number":33,"context_line":"        },"},{"line_number":34,"context_line":"        qos_consts.DIRECTION: {"},{"line_number":35,"context_line":"            \u0027type:values\u0027: [constants.EGRESS_DIRECTION],"},{"line_number":36,"context_line":"        },"},{"line_number":37,"context_line":"    },"}],"source_content_type":"text/x-python","patch_set":3,"id":"5ff73747_952a41d8","line":34,"range":{"start_line":34,"start_character":19,"end_line":34,"end_character":28},"updated":"2017-04-30 07:39:38.000000000","message":"I think you need to add \u0027direction\u0027 as a field to the model QosPolicyRule[1]\n\nhttps://github.com/openstack/dragonflow/blob/master/dragonflow/db/models/qos.py#L27","commit_id":"413e13d0e78a921f5083adef747a279b59dbb8a6"}]}