)]}'
{"dragonflow/controller/topology.py":[{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"bc748763597d63d9df654971d38ca7dce70f50ad","unresolved":false,"context_lines":[{"line_number":32,"context_line":"# tenant (or project)."},{"line_number":33,"context_line":"OvsLportMapping \u003d collections.namedtuple(\u0027OvsLportMapping\u0027,"},{"line_number":34,"context_line":"                                         (\u0027lport_id\u0027, \u0027topic\u0027))"},{"line_number":35,"context_line":"_PROVIDER_ID \u003d object()"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"class Topology(object):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f201791_b3c9cf26","line":35,"range":{"start_line":35,"start_character":0,"end_line":35,"end_character":23},"updated":"2017-06-28 10:53:50.000000000","message":"This global needs a docstring","commit_id":"c60b1e7db44d636467842f0ba84551dd164bf943"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"bc748763597d63d9df654971d38ca7dce70f50ad","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        ovs.OvsPort.register_deleted(self.ovs_port_deleted)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"        if self.enable_selective_topo_dist:"},{"line_number":63,"context_line":"            self._provider_topics \u003d (\u0027\u0027,) + tuple("},{"line_number":64,"context_line":"                self._get_provider_network_topics())"},{"line_number":65,"context_line":"            for topic in self._provider_topics:"},{"line_number":66,"context_line":"                self._add_to_topic_subscribed(topic, _PROVIDER_ID)"},{"line_number":67,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5f201791_332a5fda","line":64,"range":{"start_line":63,"start_character":0,"end_line":64,"end_character":52},"updated":"2017-06-28 10:53:50.000000000","message":"This is strange and very difficult to understand. Maybe make it explicit? Also why not just leave it as a set?","commit_id":"c60b1e7db44d636467842f0ba84551dd164bf943"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"bc748763597d63d9df654971d38ca7dce70f50ad","unresolved":false,"context_lines":[{"line_number":369,"context_line":"        bridge_mappings \u003d helpers.parse_mappings("},{"line_number":370,"context_line":"                cfg.CONF.df_provider_networks.bridge_mappings)"},{"line_number":371,"context_line":""},{"line_number":372,"context_line":"        local_external_apps \u003d ["},{"line_number":373,"context_line":"            l for l in lswitches"},{"line_number":374,"context_line":"            if l.is_external and l.physical_network in bridge_mappings"},{"line_number":375,"context_line":"        ]"},{"line_number":376,"context_line":"        return set(l.topic for l in local_external_apps)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f201791_13f7638d","line":376,"range":{"start_line":372,"start_character":0,"end_line":376,"end_character":56},"updated":"2017-06-28 10:53:50.000000000","message":"Why not just do:\nlocal_external_apps \u003d set(\n    l.topic for l in lswitches\n    if l.is_external and l.physical_network in bridges_mappings\n)\nreturn local_external_apps ?","commit_id":"c60b1e7db44d636467842f0ba84551dd164bf943"}]}