)]}'
{"doc/source/specs/extra_dhcp_opts.rst":[{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"d9257edec327bf2a648a2b4047ec11641eded94b","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"in the proposed change we want to:"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"* Define language that acceptable as dhcp tag by the df-dhcp-app (the"},{"line_number":52,"context_line":"  numbers 0-255 and all the supported-fields as they defined in the RFC [2]_)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"* In the L2 plugin - add code that translate the opt_name to the language"},{"line_number":55,"context_line":"  that described above (in case of unknown option - port creation should fail)"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f1d235d_6db2d296","line":52,"range":{"start_line":51,"start_character":0,"end_line":52,"end_character":77},"updated":"2017-07-02 08:28:46.000000000","message":"Does this mean that the NB db will store the information using tag number/DHCP field name rather than the name provided by the user?","commit_id":"567320eda55f66350a908207d1557cd701a6a2f5"},{"author":{"_account_id":26131,"name":"Eyal Leshem","email":"eyal.leshem@toganetworks.com","username":"leyal"},"change_message_id":"9142d08bdb9042e3e4c37f85a304b84bf2dec512","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"in the proposed change we want to:"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"* Define language that acceptable as dhcp tag by the df-dhcp-app (the"},{"line_number":52,"context_line":"  numbers 0-255 and all the supported-fields as they defined in the RFC [2]_)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"* In the L2 plugin - add code that translate the opt_name to the language"},{"line_number":55,"context_line":"  that described above (in case of unknown option - port creation should fail)"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f1d235d_b18cc07f","line":52,"range":{"start_line":51,"start_character":0,"end_line":52,"end_character":77},"in_reply_to":"3f1d235d_6db2d296","updated":"2017-07-02 15:03:46.000000000","message":"yep ,added to the doc","commit_id":"567320eda55f66350a908207d1557cd701a6a2f5"},{"author":{"_account_id":23235,"name":"Lihi Wishnitzer","email":"lihiwish@gmail.com","username":"lihiwish"},"change_message_id":"1d9e47f19d3efb86ef92f988bea3309beb4f4f67","unresolved":false,"context_lines":[{"line_number":52,"context_line":"  numbers 0-255 and all the supported-fields as they defined in the RFC [2]_)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"* In the L2 plugin - add code that translate the opt_name to the language"},{"line_number":55,"context_line":"  that described above (in case of unknown option - port creation should fail)"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"* add type of dhcp-opts-dictonary to the NB-db"},{"line_number":58,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f1d235d_113c94c6","line":55,"range":{"start_line":55,"start_character":24,"end_line":55,"end_character":77},"updated":"2017-07-02 14:34:58.000000000","message":"How this was handled previously?","commit_id":"567320eda55f66350a908207d1557cd701a6a2f5"},{"author":{"_account_id":26131,"name":"Eyal Leshem","email":"eyal.leshem@toganetworks.com","username":"leyal"},"change_message_id":"9142d08bdb9042e3e4c37f85a304b84bf2dec512","unresolved":false,"context_lines":[{"line_number":52,"context_line":"  numbers 0-255 and all the supported-fields as they defined in the RFC [2]_)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"* In the L2 plugin - add code that translate the opt_name to the language"},{"line_number":55,"context_line":"  that described above (in case of unknown option - port creation should fail)"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"* add type of dhcp-opts-dictonary to the NB-db"},{"line_number":58,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f1d235d_11ddb46f","line":55,"range":{"start_line":55,"start_character":24,"end_line":55,"end_character":77},"in_reply_to":"3f1d235d_113c94c6","updated":"2017-07-02 15:03:46.000000000","message":"We didn\u0027t validate the extra-dhcp-opts at all..\n(So unvalid opt didn\u0027t create any impact .. )","commit_id":"567320eda55f66350a908207d1557cd701a6a2f5"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"d9257edec327bf2a648a2b4047ec11641eded94b","unresolved":false,"context_lines":[{"line_number":54,"context_line":"* In the L2 plugin - add code that translate the opt_name to the language"},{"line_number":55,"context_line":"  that described above (in case of unknown option - port creation should fail)"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"* add type of dhcp-opts-dictonary to the NB-db"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"* In the DHCP app - add code that answer to dhcp requests according to"},{"line_number":60,"context_line":"  the configured dhcp-opts"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f1d235d_8dbbee70","line":57,"range":{"start_line":57,"start_character":0,"end_line":57,"end_character":46},"updated":"2017-07-02 08:28:46.000000000","message":"Could you please expand on this?","commit_id":"567320eda55f66350a908207d1557cd701a6a2f5"},{"author":{"_account_id":26131,"name":"Eyal Leshem","email":"eyal.leshem@toganetworks.com","username":"leyal"},"change_message_id":"9142d08bdb9042e3e4c37f85a304b84bf2dec512","unresolved":false,"context_lines":[{"line_number":54,"context_line":"* In the L2 plugin - add code that translate the opt_name to the language"},{"line_number":55,"context_line":"  that described above (in case of unknown option - port creation should fail)"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"* add type of dhcp-opts-dictonary to the NB-db"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"* In the DHCP app - add code that answer to dhcp requests according to"},{"line_number":60,"context_line":"  the configured dhcp-opts"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f1d235d_d1e61c45","line":57,"range":{"start_line":57,"start_character":0,"end_line":57,"end_character":46},"in_reply_to":"3f1d235d_8dbbee70","updated":"2017-07-02 15:03:46.000000000","message":"Done.","commit_id":"567320eda55f66350a908207d1557cd701a6a2f5"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"d9257edec327bf2a648a2b4047ec11641eded94b","unresolved":false,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":"References"},{"line_number":64,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":65,"context_line":".. [#] https://specs.openstack.org/openstack/neutron-specs/specs/api/extra_dhcp_options__extra-dhcp-opt_.html"},{"line_number":66,"context_line":".. [#] https://tools.ietf.org/html/rfc2131"},{"line_number":67,"context_line":".. [#] https://tools.ietf.org/html/rfc2132"},{"line_number":68,"context_line":".. [#] https://github.com/openstack/dragonflow/blob/master/doc/source/distributed_dhcp.rst"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f1d235d_cd66862a","line":65,"range":{"start_line":65,"start_character":0,"end_line":65,"end_character":109},"updated":"2017-07-02 08:28:46.000000000","message":"My rst viewer throws an error when parsing this link. Could you please verify?","commit_id":"567320eda55f66350a908207d1557cd701a6a2f5"},{"author":{"_account_id":26131,"name":"Eyal Leshem","email":"eyal.leshem@toganetworks.com","username":"leyal"},"change_message_id":"9142d08bdb9042e3e4c37f85a304b84bf2dec512","unresolved":false,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":"References"},{"line_number":64,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":65,"context_line":".. [#] https://specs.openstack.org/openstack/neutron-specs/specs/api/extra_dhcp_options__extra-dhcp-opt_.html"},{"line_number":66,"context_line":".. [#] https://tools.ietf.org/html/rfc2131"},{"line_number":67,"context_line":".. [#] https://tools.ietf.org/html/rfc2132"},{"line_number":68,"context_line":".. [#] https://github.com/openstack/dragonflow/blob/master/doc/source/distributed_dhcp.rst"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f1d235d_b1e1602d","line":65,"range":{"start_line":65,"start_character":0,"end_line":65,"end_character":109},"in_reply_to":"3f1d235d_cd66862a","updated":"2017-07-02 15:03:46.000000000","message":"fixed.","commit_id":"567320eda55f66350a908207d1557cd701a6a2f5"},{"author":{"_account_id":23766,"name":"Dima Kuznetsov","email":"dima.kuznetsov@toganetworks.com","username":"dimak"},"change_message_id":"fc6a4c7c10dedffb61bbc029c6fac2f3237ea0eb","unresolved":false,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":".. code-block:: json"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"  {\"extra_dhcp_opts\":{\"67\": \"testfile.1\"}}"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"* The lport will be stored in the NB-db."},{"line_number":86,"context_line":"* The dhcp-app will use that value for answering request that ask for"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f1d235d_0baa1cd1","line":83,"range":{"start_line":83,"start_character":21,"end_line":83,"end_character":42},"updated":"2017-07-03 07:31:31.000000000","message":"I\u0027m not sure it is the best idea but I\u0027d like to bring it up.\n\nWe can store this in the following format:\n {\n     \"tag\": \u003cinteger tag\u003e,\n     \"option_name\": \u003cstring key name\u003e,\n     \"value\": \u003cbytes\u003e\n }\n\nwhere tag and option_name are mutually exclusive and value is mandatory. This way we can store tags without casting them to string.","commit_id":"771771e1a6aa3709523cfbd265ec4220e1872296"},{"author":{"_account_id":26131,"name":"Eyal Leshem","email":"eyal.leshem@toganetworks.com","username":"leyal"},"change_message_id":"5a3e5e23c5ab9a24ac76f6b6b826e58ed0cf113d","unresolved":false,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":".. code-block:: json"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"  {\"extra_dhcp_opts\":{\"67\": \"testfile.1\"}}"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"* The lport will be stored in the NB-db."},{"line_number":86,"context_line":"* The dhcp-app will use that value for answering request that ask for"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f1d235d_0e9eaa53","line":83,"range":{"start_line":83,"start_character":21,"end_line":83,"end_character":42},"in_reply_to":"3f1d235d_0baa1cd1","updated":"2017-07-03 08:20:38.000000000","message":"I think that we don\u0027t need to store the option name at all .. the idea was to store it in dictionary for enable more easy lookup in the controller(the dhcp-app)..","commit_id":"771771e1a6aa3709523cfbd265ec4220e1872296"},{"author":{"_account_id":23766,"name":"Dima Kuznetsov","email":"dima.kuznetsov@toganetworks.com","username":"dimak"},"change_message_id":"0eb2c538b72c521df2e56b0c6ee7369f5049675b","unresolved":false,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":".. code-block:: json"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"  {\"extra_dhcp_opts\":{\"67\": \"testfile.1\"}}"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"* The lport will be stored in the NB-db."},{"line_number":86,"context_line":"* The dhcp-app will use that value for answering request that ask for"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f1d235d_c4df71d4","line":83,"range":{"start_line":83,"start_character":21,"end_line":83,"end_character":42},"in_reply_to":"3f1d235d_0e9eaa53","updated":"2017-07-03 09:18:45.000000000","message":"Oh, right, for some reason I though the controller was doing the translation, but that doesn\u0027t make much sense. Ignore this.","commit_id":"771771e1a6aa3709523cfbd265ec4220e1872296"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"7352e8d9b1f40ebde6b79d9b1820b78348fe67df","unresolved":false,"context_lines":[{"line_number":20,"context_line":"(for example RFC 2132 [3]_ define list dhcp options"},{"line_number":21,"context_line":"for BOOTP vendor-extensions)."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Neutron spec define the  extra-extra-dhcp-opts as a set of pairs"},{"line_number":24,"context_line":"that each pair combined form opt_name and opt_value [1]_ , but the spec"},{"line_number":25,"context_line":"didn\u0027t not define how opt_name should be translated to dhcp-opt number."},{"line_number":26,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"3f1d235d_86a73a50","line":23,"range":{"start_line":23,"start_character":13,"end_line":23,"end_character":19},"updated":"2017-07-03 12:01:37.000000000","message":"defines","commit_id":"3b5ae01540351260d0c4929c8d808d04cfdfb32a"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"7352e8d9b1f40ebde6b79d9b1820b78348fe67df","unresolved":false,"context_lines":[{"line_number":21,"context_line":"for BOOTP vendor-extensions)."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Neutron spec define the  extra-extra-dhcp-opts as a set of pairs"},{"line_number":24,"context_line":"that each pair combined form opt_name and opt_value [1]_ , but the spec"},{"line_number":25,"context_line":"didn\u0027t not define how opt_name should be translated to dhcp-opt number."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"According to the examples in the spec, and according to neutron reference"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3f1d235d_0671eae0","line":24,"range":{"start_line":24,"start_character":15,"end_line":24,"end_character":22},"updated":"2017-07-03 12:01:37.000000000","message":"combines","commit_id":"3b5ae01540351260d0c4929c8d808d04cfdfb32a"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"7352e8d9b1f40ebde6b79d9b1820b78348fe67df","unresolved":false,"context_lines":[{"line_number":27,"context_line":"According to the examples in the spec, and according to neutron reference"},{"line_number":28,"context_line":"implementation, the format of the option names is derived from the"},{"line_number":29,"context_line":"configuration file of dnsmsq-dhcp server ( as it used as the server in the"},{"line_number":30,"context_line":"reference implementation ) . in addition that configuration enable to"},{"line_number":31,"context_line":"configure fields in the dhcp-packet itself (the  \"server-ip-address\""},{"line_number":32,"context_line":"as it change the  siaddr -  that isn\u0027t part of the"},{"line_number":33,"context_line":"options-scope in the dhcp-packet [2]_)."}],"source_content_type":"text/x-rst","patch_set":4,"id":"3f1d235d_664d3e99","line":30,"range":{"start_line":30,"start_character":29,"end_line":30,"end_character":30},"updated":"2017-07-03 12:01:37.000000000","message":"In","commit_id":"3b5ae01540351260d0c4929c8d808d04cfdfb32a"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"7352e8d9b1f40ebde6b79d9b1820b78348fe67df","unresolved":false,"context_lines":[{"line_number":27,"context_line":"According to the examples in the spec, and according to neutron reference"},{"line_number":28,"context_line":"implementation, the format of the option names is derived from the"},{"line_number":29,"context_line":"configuration file of dnsmsq-dhcp server ( as it used as the server in the"},{"line_number":30,"context_line":"reference implementation ) . in addition that configuration enable to"},{"line_number":31,"context_line":"configure fields in the dhcp-packet itself (the  \"server-ip-address\""},{"line_number":32,"context_line":"as it change the  siaddr -  that isn\u0027t part of the"},{"line_number":33,"context_line":"options-scope in the dhcp-packet [2]_)."}],"source_content_type":"text/x-rst","patch_set":4,"id":"3f1d235d_064a0a7f","line":30,"range":{"start_line":30,"start_character":60,"end_line":30,"end_character":66},"updated":"2017-07-03 12:01:37.000000000","message":"enables","commit_id":"3b5ae01540351260d0c4929c8d808d04cfdfb32a"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"7352e8d9b1f40ebde6b79d9b1820b78348fe67df","unresolved":false,"context_lines":[{"line_number":27,"context_line":"According to the examples in the spec, and according to neutron reference"},{"line_number":28,"context_line":"implementation, the format of the option names is derived from the"},{"line_number":29,"context_line":"configuration file of dnsmsq-dhcp server ( as it used as the server in the"},{"line_number":30,"context_line":"reference implementation ) . in addition that configuration enable to"},{"line_number":31,"context_line":"configure fields in the dhcp-packet itself (the  \"server-ip-address\""},{"line_number":32,"context_line":"as it change the  siaddr -  that isn\u0027t part of the"},{"line_number":33,"context_line":"options-scope in the dhcp-packet [2]_)."}],"source_content_type":"text/x-rst","patch_set":4,"id":"3f1d235d_867cdab5","line":30,"range":{"start_line":30,"start_character":26,"end_line":30,"end_character":27},"updated":"2017-07-03 12:01:37.000000000","message":"space","commit_id":"3b5ae01540351260d0c4929c8d808d04cfdfb32a"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"7352e8d9b1f40ebde6b79d9b1820b78348fe67df","unresolved":false,"context_lines":[{"line_number":33,"context_line":"options-scope in the dhcp-packet [2]_)."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"In dragonflow we are using custom dhcp-app for supporting our"},{"line_number":36,"context_line":"distributed-dhcp solution [4]_ . That app currently return a"},{"line_number":37,"context_line":"pre-defined set of dhcp-optios , ans not using the lport the extra-dhcp-opt"},{"line_number":38,"context_line":"attribute."},{"line_number":39,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"3f1d235d_6632de12","line":36,"range":{"start_line":36,"start_character":33,"end_line":36,"end_character":37},"updated":"2017-07-03 12:01:37.000000000","message":"This","commit_id":"3b5ae01540351260d0c4929c8d808d04cfdfb32a"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"7352e8d9b1f40ebde6b79d9b1820b78348fe67df","unresolved":false,"context_lines":[{"line_number":33,"context_line":"options-scope in the dhcp-packet [2]_)."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"In dragonflow we are using custom dhcp-app for supporting our"},{"line_number":36,"context_line":"distributed-dhcp solution [4]_ . That app currently return a"},{"line_number":37,"context_line":"pre-defined set of dhcp-optios , ans not using the lport the extra-dhcp-opt"},{"line_number":38,"context_line":"attribute."},{"line_number":39,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"3f1d235d_a62fd69f","line":36,"range":{"start_line":36,"start_character":52,"end_line":36,"end_character":58},"updated":"2017-07-03 12:01:37.000000000","message":"returns","commit_id":"3b5ae01540351260d0c4929c8d808d04cfdfb32a"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"7352e8d9b1f40ebde6b79d9b1820b78348fe67df","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"In dragonflow we are using custom dhcp-app for supporting our"},{"line_number":36,"context_line":"distributed-dhcp solution [4]_ . That app currently return a"},{"line_number":37,"context_line":"pre-defined set of dhcp-optios , ans not using the lport the extra-dhcp-opt"},{"line_number":38,"context_line":"attribute."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"We want to propose a new implementation that support the extra-dhcp-option -"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3f1d235d_e625cec3","line":37,"range":{"start_line":37,"start_character":33,"end_line":37,"end_character":36},"updated":"2017-07-03 12:01:37.000000000","message":"and","commit_id":"3b5ae01540351260d0c4929c8d808d04cfdfb32a"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"7352e8d9b1f40ebde6b79d9b1820b78348fe67df","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"In dragonflow we are using custom dhcp-app for supporting our"},{"line_number":36,"context_line":"distributed-dhcp solution [4]_ . That app currently return a"},{"line_number":37,"context_line":"pre-defined set of dhcp-optios , ans not using the lport the extra-dhcp-opt"},{"line_number":38,"context_line":"attribute."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"We want to propose a new implementation that support the extra-dhcp-option -"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3f1d235d_2615064b","line":37,"range":{"start_line":37,"start_character":51,"end_line":37,"end_character":60},"updated":"2017-07-03 12:01:37.000000000","message":"lports\u0027","commit_id":"3b5ae01540351260d0c4929c8d808d04cfdfb32a"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"7352e8d9b1f40ebde6b79d9b1820b78348fe67df","unresolved":false,"context_lines":[{"line_number":37,"context_line":"pre-defined set of dhcp-optios , ans not using the lport the extra-dhcp-opt"},{"line_number":38,"context_line":"attribute."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"We want to propose a new implementation that support the extra-dhcp-option -"},{"line_number":41,"context_line":"By supporting the opt-name in format of dnsmasq-conf , alongside with other"},{"line_number":42,"context_line":"configurations format (for example: dhcpd.conf format or by supplying the tags"},{"line_number":43,"context_line":"directly as a number - \"11\" for dhcp-opt 11)."}],"source_content_type":"text/x-rst","patch_set":4,"id":"3f1d235d_0618ca7e","line":40,"range":{"start_line":40,"start_character":45,"end_line":40,"end_character":52},"updated":"2017-07-03 12:01:37.000000000","message":"supports","commit_id":"3b5ae01540351260d0c4929c8d808d04cfdfb32a"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"7352e8d9b1f40ebde6b79d9b1820b78348fe67df","unresolved":false,"context_lines":[{"line_number":58,"context_line":"  supported-fields, and a dictionary (string-\u003estring) When each key in"},{"line_number":59,"context_line":"  the dictionary must be validate against supported-fields set."},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"* In the L2 plugin - add code that translate the opt_name  from the"},{"line_number":62,"context_line":"  api supported language to the language that supported by"},{"line_number":63,"context_line":"  the dhcp-app  that described above (in case of unknown option -"},{"line_number":64,"context_line":"  port creation should fail)"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3f1d235d_e93c81c9","line":61,"range":{"start_line":61,"start_character":9,"end_line":61,"end_character":18},"updated":"2017-07-03 12:01:37.000000000","message":"We have l2 mech driver, but better to see if you can do it in the extension driver","commit_id":"3b5ae01540351260d0c4929c8d808d04cfdfb32a"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"7352e8d9b1f40ebde6b79d9b1820b78348fe67df","unresolved":false,"context_lines":[{"line_number":63,"context_line":"  the dhcp-app  that described above (in case of unknown option -"},{"line_number":64,"context_line":"  port creation should fail)"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"* In the DHCP app - add code that answer to dhcp requests according to"},{"line_number":67,"context_line":"  the configured dhcp-opts."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"3f1d235d_89318def","line":66,"range":{"start_line":66,"start_character":34,"end_line":66,"end_character":40},"updated":"2017-07-03 12:01:37.000000000","message":"answers","commit_id":"3b5ae01540351260d0c4929c8d808d04cfdfb32a"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"7352e8d9b1f40ebde6b79d9b1820b78348fe67df","unresolved":false,"context_lines":[{"line_number":63,"context_line":"  the dhcp-app  that described above (in case of unknown option -"},{"line_number":64,"context_line":"  port creation should fail)"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"* In the DHCP app - add code that answer to dhcp requests according to"},{"line_number":67,"context_line":"  the configured dhcp-opts."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"3f1d235d_29583930","line":66,"range":{"start_line":66,"start_character":43,"end_line":66,"end_character":48},"updated":"2017-07-03 12:01:37.000000000","message":"the dhcp","commit_id":"3b5ae01540351260d0c4929c8d808d04cfdfb32a"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"7352e8d9b1f40ebde6b79d9b1820b78348fe67df","unresolved":false,"context_lines":[{"line_number":67,"context_line":"  the configured dhcp-opts."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"flow for example:"},{"line_number":71,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"* user generate an  neutron-lport-create api-request with :"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3f1d235d_a94b2957","line":70,"range":{"start_line":70,"start_character":0,"end_line":70,"end_character":16},"updated":"2017-07-03 12:01:37.000000000","message":"Execution workflow?","commit_id":"3b5ae01540351260d0c4929c8d808d04cfdfb32a"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"7352e8d9b1f40ebde6b79d9b1820b78348fe67df","unresolved":false,"context_lines":[{"line_number":70,"context_line":"flow for example:"},{"line_number":71,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"* user generate an  neutron-lport-create api-request with :"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":".. code-block:: json"},{"line_number":76,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"3f1d235d_09745d98","line":73,"range":{"start_line":73,"start_character":2,"end_line":73,"end_character":15},"updated":"2017-07-03 12:01:37.000000000","message":"User generates","commit_id":"3b5ae01540351260d0c4929c8d808d04cfdfb32a"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"b97428c0c65677ab53d713185dde00ff93a4cddf","unresolved":false,"context_lines":[{"line_number":20,"context_line":"(for example RFC 2132 [3]_ defines list dhcp options"},{"line_number":21,"context_line":"for BOOTP vendor-extensions)."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Neutron spec define the  extra-extra-dhcp-opts as a set of pairs"},{"line_number":24,"context_line":"that each pair combined from opt_name and opt_value [1]_ , but the spec"},{"line_number":25,"context_line":"didn\u0027t not define how opt_name should be translated to dhcp-opt number."},{"line_number":26,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f1d235d_0766c452","line":23,"range":{"start_line":23,"start_character":24,"end_line":23,"end_character":36},"updated":"2017-07-10 07:23:42.000000000","message":"double extra?","commit_id":"bb2440a9aff8b01567da781c75644789c5b73d57"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"b97428c0c65677ab53d713185dde00ff93a4cddf","unresolved":false,"context_lines":[{"line_number":38,"context_line":"attribute."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"We want to propose a new implementation that supports the extra-dhcp-option -"},{"line_number":41,"context_line":"By supporting the opt-name in format of dnsmasq-conf , alongside with other"},{"line_number":42,"context_line":"configurations format (for example: dhcpd.conf format or by supplying the tags"},{"line_number":43,"context_line":"directly as a number - \"11\" for dhcp-opt 11)."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"Proposed Change"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f1d235d_e7e8687d","line":43,"range":{"start_line":41,"start_character":0,"end_line":43,"end_character":45},"updated":"2017-07-10 07:23:42.000000000","message":"both options from the beginning?","commit_id":"bb2440a9aff8b01567da781c75644789c5b73d57"},{"author":{"_account_id":26131,"name":"Eyal Leshem","email":"eyal.leshem@toganetworks.com","username":"leyal"},"change_message_id":"848ab11f2a1d2c76a6813b932de53abc61c741fa","unresolved":false,"context_lines":[{"line_number":38,"context_line":"attribute."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"We want to propose a new implementation that supports the extra-dhcp-option -"},{"line_number":41,"context_line":"By supporting the opt-name in format of dnsmasq-conf , alongside with other"},{"line_number":42,"context_line":"configurations format (for example: dhcpd.conf format or by supplying the tags"},{"line_number":43,"context_line":"directly as a number - \"11\" for dhcp-opt 11)."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"Proposed Change"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f1d235d_4435c8f6","line":43,"range":{"start_line":41,"start_character":0,"end_line":43,"end_character":45},"in_reply_to":"3f1d235d_e7e8687d","updated":"2017-07-10 16:05:52.000000000","message":"Yes , I think the declare it\u0027s the strait-forward way , And also support others formats as DnsMasq - and dhcpd  ..","commit_id":"bb2440a9aff8b01567da781c75644789c5b73d57"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"b97428c0c65677ab53d713185dde00ff93a4cddf","unresolved":false,"context_lines":[{"line_number":46,"context_line":"Proposed Change"},{"line_number":47,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"in the proposed change we want to:"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"* Define language that acceptable as dhcp-tag by the df-dhcp-app in"},{"line_number":52,"context_line":"  controller  (The numbers 0-255 and all the supported-fields as they"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f1d235d_c7ed6c8c","line":49,"range":{"start_line":49,"start_character":0,"end_line":49,"end_character":1},"updated":"2017-07-10 07:23:42.000000000","message":"In","commit_id":"bb2440a9aff8b01567da781c75644789c5b73d57"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"b97428c0c65677ab53d713185dde00ff93a4cddf","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"in the proposed change we want to:"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"* Define language that acceptable as dhcp-tag by the df-dhcp-app in"},{"line_number":52,"context_line":"  controller  (The numbers 0-255 and all the supported-fields as they"},{"line_number":53,"context_line":"  defined in the RFC [2]_). that language will be used for storing"},{"line_number":54,"context_line":"  the objects in the Nb-api."}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f1d235d_2719c087","line":51,"range":{"start_line":51,"start_character":9,"end_line":51,"end_character":17},"updated":"2017-07-10 07:23:42.000000000","message":"object?","commit_id":"bb2440a9aff8b01567da781c75644789c5b73d57"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"b97428c0c65677ab53d713185dde00ff93a4cddf","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"* Define language that acceptable as dhcp-tag by the df-dhcp-app in"},{"line_number":52,"context_line":"  controller  (The numbers 0-255 and all the supported-fields as they"},{"line_number":53,"context_line":"  defined in the RFC [2]_). that language will be used for storing"},{"line_number":54,"context_line":"  the objects in the Nb-api."},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"* For defining that language, a field type of dhcp-parameters will"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f1d235d_87ff7433","line":53,"range":{"start_line":53,"start_character":28,"end_line":53,"end_character":30},"updated":"2017-07-10 07:23:42.000000000","message":"That","commit_id":"bb2440a9aff8b01567da781c75644789c5b73d57"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"b97428c0c65677ab53d713185dde00ff93a4cddf","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"* Define language that acceptable as dhcp-tag by the df-dhcp-app in"},{"line_number":52,"context_line":"  controller  (The numbers 0-255 and all the supported-fields as they"},{"line_number":53,"context_line":"  defined in the RFC [2]_). that language will be used for storing"},{"line_number":54,"context_line":"  the objects in the Nb-api."},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"* For defining that language, a field type of dhcp-parameters will"},{"line_number":57,"context_line":"  be added to the NB-db. That field will be composed from the supported"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f1d235d_279420e8","line":54,"range":{"start_line":53,"start_character":33,"end_line":54,"end_character":28},"updated":"2017-07-10 07:23:42.000000000","message":"Sentence does not make sense, please rephrase","commit_id":"bb2440a9aff8b01567da781c75644789c5b73d57"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"b97428c0c65677ab53d713185dde00ff93a4cddf","unresolved":false,"context_lines":[{"line_number":53,"context_line":"  defined in the RFC [2]_). that language will be used for storing"},{"line_number":54,"context_line":"  the objects in the Nb-api."},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"* For defining that language, a field type of dhcp-parameters will"},{"line_number":57,"context_line":"  be added to the NB-db. That field will be composed from the supported"},{"line_number":58,"context_line":"  dhcp-parameters (currently: siaddr , dhcp-ops), and value that suite for"},{"line_number":59,"context_line":"  that parameters.(for dhcp-opt - dictionary that mapping opt tag"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f1d235d_929330a4","line":56,"range":{"start_line":56,"start_character":19,"end_line":56,"end_character":28},"updated":"2017-07-10 07:23:42.000000000","message":"DB object?","commit_id":"bb2440a9aff8b01567da781c75644789c5b73d57"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"b97428c0c65677ab53d713185dde00ff93a4cddf","unresolved":false,"context_lines":[{"line_number":53,"context_line":"  defined in the RFC [2]_). that language will be used for storing"},{"line_number":54,"context_line":"  the objects in the Nb-api."},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"* For defining that language, a field type of dhcp-parameters will"},{"line_number":57,"context_line":"  be added to the NB-db. That field will be composed from the supported"},{"line_number":58,"context_line":"  dhcp-parameters (currently: siaddr , dhcp-ops), and value that suite for"},{"line_number":59,"context_line":"  that parameters.(for dhcp-opt - dictionary that mapping opt tag"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f1d235d_d2f648fa","line":56,"range":{"start_line":56,"start_character":6,"end_line":56,"end_character":14},"updated":"2017-07-10 07:23:42.000000000","message":"So here you define DF API, correct?","commit_id":"bb2440a9aff8b01567da781c75644789c5b73d57"},{"author":{"_account_id":26131,"name":"Eyal Leshem","email":"eyal.leshem@toganetworks.com","username":"leyal"},"change_message_id":"848ab11f2a1d2c76a6813b932de53abc61c741fa","unresolved":false,"context_lines":[{"line_number":53,"context_line":"  defined in the RFC [2]_). that language will be used for storing"},{"line_number":54,"context_line":"  the objects in the Nb-api."},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"* For defining that language, a field type of dhcp-parameters will"},{"line_number":57,"context_line":"  be added to the NB-db. That field will be composed from the supported"},{"line_number":58,"context_line":"  dhcp-parameters (currently: siaddr , dhcp-ops), and value that suite for"},{"line_number":59,"context_line":"  that parameters.(for dhcp-opt - dictionary that mapping opt tag"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f1d235d_3118c9d1","line":56,"range":{"start_line":56,"start_character":6,"end_line":56,"end_character":14},"in_reply_to":"3f1d235d_d2f648fa","updated":"2017-07-10 16:05:52.000000000","message":"Changed to DB object.\nIsn\u0027t it like all DF-objects that processed by the mech-driver, and then forward to the api?","commit_id":"bb2440a9aff8b01567da781c75644789c5b73d57"},{"author":{"_account_id":23235,"name":"Lihi Wishnitzer","email":"lihiwish@gmail.com","username":"lihiwish"},"change_message_id":"783bd27905cf93d3fdb0dfa463b3419e40fb1824","unresolved":false,"context_lines":[{"line_number":56,"context_line":"* For defining that language, a field type of dhcp-parameters will"},{"line_number":57,"context_line":"  be added to the NB-db. That field will be composed from the supported"},{"line_number":58,"context_line":"  dhcp-parameters (currently: siaddr , dhcp-ops), and value that suite for"},{"line_number":59,"context_line":"  that parameters.(for dhcp-opt - dictionary that mapping opt tag"},{"line_number":60,"context_line":"  to  value (int(0-255)-\u003estring) , and ip-adders field that will"},{"line_number":61,"context_line":"  represent the siaddr value )"},{"line_number":62,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f1d235d_18c5fe5b","line":59,"range":{"start_line":59,"start_character":18,"end_line":59,"end_character":19},"updated":"2017-07-10 09:37:10.000000000","message":"Please consider changing this to inner bullets. It will make this paragraph easier to understand","commit_id":"bb2440a9aff8b01567da781c75644789c5b73d57"},{"author":{"_account_id":26131,"name":"Eyal Leshem","email":"eyal.leshem@toganetworks.com","username":"leyal"},"change_message_id":"848ab11f2a1d2c76a6813b932de53abc61c741fa","unresolved":false,"context_lines":[{"line_number":56,"context_line":"* For defining that language, a field type of dhcp-parameters will"},{"line_number":57,"context_line":"  be added to the NB-db. That field will be composed from the supported"},{"line_number":58,"context_line":"  dhcp-parameters (currently: siaddr , dhcp-ops), and value that suite for"},{"line_number":59,"context_line":"  that parameters.(for dhcp-opt - dictionary that mapping opt tag"},{"line_number":60,"context_line":"  to  value (int(0-255)-\u003estring) , and ip-adders field that will"},{"line_number":61,"context_line":"  represent the siaddr value )"},{"line_number":62,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f1d235d_711d21bc","line":59,"range":{"start_line":59,"start_character":18,"end_line":59,"end_character":19},"in_reply_to":"3f1d235d_18c5fe5b","updated":"2017-07-10 16:05:52.000000000","message":"changed to inner bullet , hope that it\u0027s more clear now ..","commit_id":"bb2440a9aff8b01567da781c75644789c5b73d57"},{"author":{"_account_id":23235,"name":"Lihi Wishnitzer","email":"lihiwish@gmail.com","username":"lihiwish"},"change_message_id":"783bd27905cf93d3fdb0dfa463b3419e40fb1824","unresolved":false,"context_lines":[{"line_number":57,"context_line":"  be added to the NB-db. That field will be composed from the supported"},{"line_number":58,"context_line":"  dhcp-parameters (currently: siaddr , dhcp-ops), and value that suite for"},{"line_number":59,"context_line":"  that parameters.(for dhcp-opt - dictionary that mapping opt tag"},{"line_number":60,"context_line":"  to  value (int(0-255)-\u003estring) , and ip-adders field that will"},{"line_number":61,"context_line":"  represent the siaddr value )"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"* In the L2 mech-driver - add code that translate the opt_name  from the"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f1d235d_78dbd27c","line":60,"range":{"start_line":60,"start_character":42,"end_line":60,"end_character":48},"updated":"2017-07-10 09:37:10.000000000","message":"address?","commit_id":"bb2440a9aff8b01567da781c75644789c5b73d57"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"b97428c0c65677ab53d713185dde00ff93a4cddf","unresolved":false,"context_lines":[{"line_number":72,"context_line":"Execution workflow:"},{"line_number":73,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"* User generate an  neutron-lport-create api-request with :"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":".. code-block:: json"},{"line_number":78,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f1d235d_edcf2927","line":75,"range":{"start_line":75,"start_character":7,"end_line":75,"end_character":15},"updated":"2017-07-10 07:23:42.000000000","message":"generates","commit_id":"bb2440a9aff8b01567da781c75644789c5b73d57"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"b97428c0c65677ab53d713185dde00ff93a4cddf","unresolved":false,"context_lines":[{"line_number":91,"context_line":"    }"},{"line_number":92,"context_line":"  }"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"* The lport will be stored in the NB-db."},{"line_number":95,"context_line":"* The dhcp-app will use that value for answering request that ask for"},{"line_number":96,"context_line":"  dhcp-option 67."},{"line_number":97,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f1d235d_cded8d8c","line":94,"range":{"start_line":94,"start_character":2,"end_line":94,"end_character":40},"updated":"2017-07-10 07:23:42.000000000","message":"with dhcp opt attributes?","commit_id":"bb2440a9aff8b01567da781c75644789c5b73d57"}]}