)]}'
{"dragonflow/controller/l3_app_base.py":[{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"2a1eb4a53699c83fd2fdf741203915e245b18ab6","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        )"},{"line_number":85,"context_line":"        router_port_ip \u003d None"},{"line_number":86,"context_line":"        for port in lrouter.ports:"},{"line_number":87,"context_line":"            if port.mac \u003d\u003d e_pkt.dst:"},{"line_number":88,"context_line":"                router_port_ip \u003d port.network.ip"},{"line_number":89,"context_line":"                break"},{"line_number":90,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3f1d235d_00084e25","line":87,"range":{"start_line":87,"start_character":0,"end_line":87,"end_character":37},"updated":"2017-07-06 05:04:53.000000000","message":"Wouldn\u0027t it be better to compare port.lswitch.unique_key and msg.match.get(\u0027metadata\u0027) in addition?\n\nTou could also keep the mapping, but search by (reg5, metadata) rather than mac, and rather than looping over all router ports.","commit_id":"75b517bee348cb0ddf35afcbcff301e8dd9784da"},{"author":{"_account_id":23766,"name":"Dima Kuznetsov","email":"dima.kuznetsov@toganetworks.com","username":"dimak"},"change_message_id":"69934f82e898d3871b350443acb7f85ce2cead99","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        )"},{"line_number":85,"context_line":"        router_port_ip \u003d None"},{"line_number":86,"context_line":"        for port in lrouter.ports:"},{"line_number":87,"context_line":"            if port.mac \u003d\u003d e_pkt.dst:"},{"line_number":88,"context_line":"                router_port_ip \u003d port.network.ip"},{"line_number":89,"context_line":"                break"},{"line_number":90,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3f1d235d_7b9d7364","line":87,"range":{"start_line":87,"start_character":0,"end_line":87,"end_character":37},"in_reply_to":"3f1d235d_00084e25","updated":"2017-07-06 06:00:35.000000000","message":"I\u0027ll change it to match metadata, but I think we can avoid maintaining another lookup.","commit_id":"75b517bee348cb0ddf35afcbcff301e8dd9784da"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"bb2c7fe00c9bd3a4ab53c1a1284ddef5acc0863f","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        )"},{"line_number":85,"context_line":"        router_port_ip \u003d None"},{"line_number":86,"context_line":"        for port in lrouter.ports:"},{"line_number":87,"context_line":"            if port.mac \u003d\u003d e_pkt.dst:"},{"line_number":88,"context_line":"                router_port_ip \u003d port.network.ip"},{"line_number":89,"context_line":"                break"},{"line_number":90,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3f1d235d_a6af7228","line":87,"range":{"start_line":87,"start_character":0,"end_line":87,"end_character":37},"in_reply_to":"3f1d235d_7b9d7364","updated":"2017-07-06 06:40:34.000000000","message":"Sure.","commit_id":"75b517bee348cb0ddf35afcbcff301e8dd9784da"}]}