)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":26131,"name":"Eyal Leshem","email":"eyal.leshem@toganetworks.com","username":"leyal"},"change_message_id":"cd25b6571ed7990472a384385b7a4381d5611965","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Omer Anson \u003comer.anson@toganetworks.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-07-11 14:19:21 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Classifier to use OvsPort events"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Partial-Bug: #1690775"},{"line_number":10,"context_line":"Closes-Bug: #1702426"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3f1d235d_151fd970","line":7,"updated":"2017-07-11 12:36:34.000000000","message":"Why it\u0027s better that lport events?","commit_id":"3d1cd5b69fe8914516292eda7f392ddc602a7833"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"abd4b5660c324acd603a51a7d4644c39e08c18c3","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Omer Anson \u003comer.anson@toganetworks.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-07-11 14:19:21 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Classifier to use OvsPort events"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Partial-Bug: #1690775"},{"line_number":10,"context_line":"Closes-Bug: #1702426"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1f1a1f67_b13e2c27","line":7,"in_reply_to":"3f1d235d_151fd970","updated":"2017-07-13 05:02:30.000000000","message":"The classifier needs both OvsPort and LogicalPort info. The OvsPort provides the ofport. The LogicalPort provides the port key. However, there is a reference from the OvsPort to the LogicalPort, and the OvsPort does not exist without a LogicalPort (The LogicalPort must be created first).\n\nIf I respin, I\u0027ll add this info to the commit message.","commit_id":"3d1cd5b69fe8914516292eda7f392ddc602a7833"}],"dragonflow/controller/apps/classifier.py":[{"author":{"_account_id":26131,"name":"Eyal Leshem","email":"eyal.leshem@toganetworks.com","username":"leyal"},"change_message_id":"cd25b6571ed7990472a384385b7a4381d5611965","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        ofport \u003d ovs_port.ofport"},{"line_number":40,"context_line":"        lport_id \u003d ovs_port.iface_id"},{"line_number":41,"context_line":"        if not ofport:"},{"line_number":42,"context_line":"            return  # Not ready yet"},{"line_number":43,"context_line":"        if not lport_id:"},{"line_number":44,"context_line":"            return  # Not relevant"},{"line_number":45,"context_line":"        lport \u003d self.nb_api.get(l2.LogicalPort(id\u003dlport_id))"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f1d235d_5548b185","line":42,"updated":"2017-07-11 12:36:34.000000000","message":"1. Why it\u0027s can happened ?  \n2. Is it will create other event when the port will be ready?","commit_id":"3d1cd5b69fe8914516292eda7f392ddc602a7833"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"abd4b5660c324acd603a51a7d4644c39e08c18c3","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        ofport \u003d ovs_port.ofport"},{"line_number":40,"context_line":"        lport_id \u003d ovs_port.iface_id"},{"line_number":41,"context_line":"        if not ofport:"},{"line_number":42,"context_line":"            return  # Not ready yet"},{"line_number":43,"context_line":"        if not lport_id:"},{"line_number":44,"context_line":"            return  # Not relevant"},{"line_number":45,"context_line":"        lport \u003d self.nb_api.get(l2.LogicalPort(id\u003dlport_id))"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f1a1f67_3179fcfb","line":42,"in_reply_to":"3f1d235d_5548b185","updated":"2017-07-13 05:02:30.000000000","message":"1. Sometimes the OvsPort record is created in the OVSDB before it is assigned an ofport.\n\n2. Yes.","commit_id":"3d1cd5b69fe8914516292eda7f392ddc602a7833"}],"dragonflow/tests/unit/test_classifier_app.py":[{"author":{"_account_id":26131,"name":"Eyal Leshem","email":"eyal.leshem@toganetworks.com","username":"leyal"},"change_message_id":"9fa3a26c8d2202c60b5fffb02c215318be31f4de","unresolved":false,"context_lines":[{"line_number":67,"context_line":"            match\u003dmatch)"},{"line_number":68,"context_line":"        self.app.mod_flow.reset_mock()"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    def test_classifier_for_vlan_port2(self):"},{"line_number":71,"context_line":"        fake_local_vlan_port \u003d make_fake_local_port("},{"line_number":72,"context_line":"            lswitch\u003d\u0027fake_vlan_switch1\u0027)"},{"line_number":73,"context_line":"        self.controller.update(fake_local_vlan_port)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f1a1f67_404f03bd","line":70,"updated":"2017-07-13 06:27:45.000000000","message":"test_classifier_for_vlan_port2 and test_classifier_for_vlan_port \nlooks exactly same(in test2 it\u0027s delete the vlan port bewfore the ofport - but is that matter? ) ..","commit_id":"a252ae33e1a24eb340b984acc547244b83eee476"},{"author":{"_account_id":26131,"name":"Eyal Leshem","email":"eyal.leshem@toganetworks.com","username":"leyal"},"change_message_id":"4ed9573e9555da1da615dfe632a5f506e58730e8","unresolved":false,"context_lines":[{"line_number":67,"context_line":"            match\u003dmatch)"},{"line_number":68,"context_line":"        self.app.mod_flow.reset_mock()"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    def test_classifier_for_vlan_port2(self):"},{"line_number":71,"context_line":"        fake_local_vlan_port \u003d make_fake_local_port("},{"line_number":72,"context_line":"            lswitch\u003d\u0027fake_vlan_switch1\u0027)"},{"line_number":73,"context_line":"        self.controller.update(fake_local_vlan_port)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f1a1f67_c90a1725","line":70,"in_reply_to":"1f1a1f67_29b2abe7","updated":"2017-07-17 10:52:04.000000000","message":"So maybe export the other shared to function -  or at least reflect the difference between the tests in function names..","commit_id":"a252ae33e1a24eb340b984acc547244b83eee476"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"d6c9dd8e5578a90b175a98aa4b062108777541ce","unresolved":false,"context_lines":[{"line_number":67,"context_line":"            match\u003dmatch)"},{"line_number":68,"context_line":"        self.app.mod_flow.reset_mock()"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    def test_classifier_for_vlan_port2(self):"},{"line_number":71,"context_line":"        fake_local_vlan_port \u003d make_fake_local_port("},{"line_number":72,"context_line":"            lswitch\u003d\u0027fake_vlan_switch1\u0027)"},{"line_number":73,"context_line":"        self.controller.update(fake_local_vlan_port)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f1a1f67_29b2abe7","line":70,"in_reply_to":"1f1a1f67_404f03bd","updated":"2017-07-13 10:13:30.000000000","message":"Yes. That\u0027s the only difference between the tests: The order in which the ports are deleted.","commit_id":"a252ae33e1a24eb340b984acc547244b83eee476"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"61b24638df186f24761b8dd20588933b54c6ea10","unresolved":false,"context_lines":[{"line_number":67,"context_line":"            match\u003dmatch)"},{"line_number":68,"context_line":"        self.app.mod_flow.reset_mock()"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    def test_classifier_for_vlan_port2(self):"},{"line_number":71,"context_line":"        fake_local_vlan_port \u003d make_fake_local_port("},{"line_number":72,"context_line":"            lswitch\u003d\u0027fake_vlan_switch1\u0027)"},{"line_number":73,"context_line":"        self.controller.update(fake_local_vlan_port)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f1a1f67_adf64362","line":70,"in_reply_to":"1f1a1f67_c90a1725","updated":"2017-07-18 09:19:21.000000000","message":"I couldn\u0027t think of a way to do this elegantly, but I\u0027ll take another look at it.","commit_id":"a252ae33e1a24eb340b984acc547244b83eee476"}]}