)]}'
{"devstack/zookeeper.service.ubuntu":[{"author":{"_account_id":17880,"name":"Shachar Snapiri","email":"shachar.snapiri@toganetworks.com","username":"snapiri"},"change_message_id":"92f754681452c3a6d3cc5f2d2cac268af9fbcca7","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[Unit]"},{"line_number":2,"context_line":"Description\u003dZookeeper Service"},{"line_number":3,"context_line":"After\u003dnetwork.target"},{"line_number":4,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":2,"id":"7f96bb07_69cbb51d","line":1,"updated":"2018-01-15 10:24:37.000000000","message":"Why have this file at all? we do not use it any more in Ubuntu.\nWill it not be better to just remove it?","commit_id":"30e85e97baafb41584978f9775289520be35da8e"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"0dc5dc7fe54cc28beb6d733b991aa686b50a5bcf","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[Unit]"},{"line_number":2,"context_line":"Description\u003dZookeeper Service"},{"line_number":3,"context_line":"After\u003dnetwork.target"},{"line_number":4,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":2,"id":"7f96bb07_757847c3","line":1,"in_reply_to":"7f96bb07_69cbb51d","updated":"2018-01-16 07:51:40.000000000","message":"+1","commit_id":"30e85e97baafb41584978f9775289520be35da8e"},{"author":{"_account_id":23235,"name":"Lihi Wishnitzer","email":"lihiwish@gmail.com","username":"lihiwish"},"change_message_id":"9dac55147479e140d8b198ff640b297b79de85e2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[Unit]"},{"line_number":2,"context_line":"Description\u003dZookeeper Service"},{"line_number":3,"context_line":"After\u003dnetwork.target"},{"line_number":4,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":2,"id":"7f96bb07_8943536c","line":1,"in_reply_to":"7f96bb07_757847c3","updated":"2018-01-17 09:50:01.000000000","message":"Done","commit_id":"30e85e97baafb41584978f9775289520be35da8e"}],"devstack/zookeeper_driver":[{"author":{"_account_id":23766,"name":"Dima Kuznetsov","email":"dima.kuznetsov@toganetworks.com","username":"dimak"},"change_message_id":"72cb4b6fc5074f1cc1d05325d81b46428544e358","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"function _zookeeper_env {"},{"line_number":20,"context_line":"    export ZOOKEEPER_IP\u003d${REMOTE_DB_IP:-${HOST_IP}}"},{"line_number":21,"context_line":"    export ZOOKEEPER_PORT\u003d${REMOTE_DB_PORT:-2181}"},{"line_number":22,"context_line":"    export ZOOKEEPER_DATA_DIR\u003d\"/var/lib/zookeeper\""},{"line_number":23,"context_line":"    export ZOOKEEPER_LOG_DIR\u003d\"/var/log/zookeeper\""},{"line_number":24,"context_line":"    export ZOOKEEPER_DIR\u003d\"/etc/zookeeper\""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"bf3e73b7_e203c80e","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":1},"updated":"2017-08-06 17:39:25.000000000","message":"Conflicted about this. If REMOTE_DB_PORT is not set, it will not be written to configuration..","commit_id":"dcdb09431341ad1ed345d2222f550070ba8031d1"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"06179f6504ed057e56c2605b774e0da6b0ea0d2d","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"function _zookeeper_env {"},{"line_number":20,"context_line":"    export ZOOKEEPER_IP\u003d${REMOTE_DB_IP:-${HOST_IP}}"},{"line_number":21,"context_line":"    export ZOOKEEPER_PORT\u003d${REMOTE_DB_PORT:-2181}"},{"line_number":22,"context_line":"    export ZOOKEEPER_DATA_DIR\u003d\"/var/lib/zookeeper\""},{"line_number":23,"context_line":"    export ZOOKEEPER_LOG_DIR\u003d\"/var/log/zookeeper\""},{"line_number":24,"context_line":"    export ZOOKEEPER_DIR\u003d\"/etc/zookeeper\""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"9f436f4f_17a9ea8e","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":1},"in_reply_to":"bf3e73b7_e203c80e","updated":"2017-08-23 08:11:46.000000000","message":"Yes, I think it\u0027s better to set the default in plugin.sh.","commit_id":"dcdb09431341ad1ed345d2222f550070ba8031d1"},{"author":{"_account_id":23766,"name":"Dima Kuznetsov","email":"dima.kuznetsov@toganetworks.com","username":"dimak"},"change_message_id":"72cb4b6fc5074f1cc1d05325d81b46428544e358","unresolved":false,"context_lines":[{"line_number":34,"context_line":"            ZOOKEEPER_CONF_SAMPLE_DIR\u003d\"/etc/zookeeper/conf_example\""},{"line_number":35,"context_line":"            sudo mkdir -p $ZOOKEEPER_DATA_DIR"},{"line_number":36,"context_line":"            sudo mkdir -p $ZOOKEEPER_LOG_DIR"},{"line_number":37,"context_line":"            sudo mkdir -p $ZOOKEEPER_CONF_DIR"},{"line_number":38,"context_line":"            install_package zookeeperd"},{"line_number":39,"context_line":"            stop_service zookeeper"},{"line_number":40,"context_line":"            if [ $UBUNTU_RELEASE_BASE_NUM -ge 16 ] ; then"},{"line_number":41,"context_line":"                sudo cp $DEST/dragonflow/devstack/zookeeper.service.ubuntu /etc/systemd/system/zookeeper.service"},{"line_number":42,"context_line":"                sudo systemctl daemon-reload"},{"line_number":43,"context_line":"            fi"},{"line_number":44,"context_line":"            if [ -d $ZOOKEEPER_CONF_SAMPLE_DIR ] ; then"},{"line_number":45,"context_line":"                sudo cp $ZOOKEEPER_CONF_SAMPLE_DIR/* $ZOOKEEPER_CONF_DIR/ -rf"},{"line_number":46,"context_line":"            fi"},{"line_number":47,"context_line":"        elif is_fedora; then"},{"line_number":48,"context_line":"            ZOOKEEPER_CONF_DIR\u003d\"${ZOOKEEPER_DIR}\""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"bf3e73b7_420df43c","line":45,"range":{"start_line":37,"start_character":7,"end_line":45,"end_character":21},"updated":"2017-08-06 17:39:25.000000000","message":"Worth checking on Ubuntu as well","commit_id":"dcdb09431341ad1ed345d2222f550070ba8031d1"},{"author":{"_account_id":17880,"name":"Shachar Snapiri","email":"shachar.snapiri@toganetworks.com","username":"snapiri"},"change_message_id":"92f754681452c3a6d3cc5f2d2cac268af9fbcca7","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        uninstall_package -y zookeeperd"},{"line_number":63,"context_line":"    elif is_fedora; then"},{"line_number":64,"context_line":"        uninstall_package -y zookeeper"},{"line_number":65,"context_line":"    fi"},{"line_number":66,"context_line":"    if [ -f \"/etc/systemd/system/zookeeper.service\" ] ; then"},{"line_number":67,"context_line":"        sudo rm /etc/systemd/system/zookeeper.service"},{"line_number":68,"context_line":"        sudo systemctl daemon-reload"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"7f96bb07_e96fc58f","line":65,"range":{"start_line":65,"start_character":4,"end_line":65,"end_character":6},"updated":"2018-01-15 10:24:37.000000000","message":"How about adding this, just for code completion?\nelse\n     die $LINENO \"Other distributions are not supported\"\nfi","commit_id":"30e85e97baafb41584978f9775289520be35da8e"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"0dc5dc7fe54cc28beb6d733b991aa686b50a5bcf","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        uninstall_package -y zookeeperd"},{"line_number":63,"context_line":"    elif is_fedora; then"},{"line_number":64,"context_line":"        uninstall_package -y zookeeper"},{"line_number":65,"context_line":"    fi"},{"line_number":66,"context_line":"    if [ -f \"/etc/systemd/system/zookeeper.service\" ] ; then"},{"line_number":67,"context_line":"        sudo rm /etc/systemd/system/zookeeper.service"},{"line_number":68,"context_line":"        sudo systemctl daemon-reload"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"7f96bb07_f5645724","line":65,"range":{"start_line":65,"start_character":4,"end_line":65,"end_character":6},"in_reply_to":"7f96bb07_0b60de31","updated":"2018-01-16 07:51:40.000000000","message":"We also shouldn\u0027t reach this point since devstack failed in stack stage, and we don\u0027t want to fail unstack - just let it go and let whoever\u0027s trying to stack on a strange distribution deal with it.","commit_id":"30e85e97baafb41584978f9775289520be35da8e"},{"author":{"_account_id":23766,"name":"Dima Kuznetsov","email":"dima.kuznetsov@toganetworks.com","username":"dimak"},"change_message_id":"fed8fb09d8c4493630166ec3be40461509c3ff88","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        uninstall_package -y zookeeperd"},{"line_number":63,"context_line":"    elif is_fedora; then"},{"line_number":64,"context_line":"        uninstall_package -y zookeeper"},{"line_number":65,"context_line":"    fi"},{"line_number":66,"context_line":"    if [ -f \"/etc/systemd/system/zookeeper.service\" ] ; then"},{"line_number":67,"context_line":"        sudo rm /etc/systemd/system/zookeeper.service"},{"line_number":68,"context_line":"        sudo systemctl daemon-reload"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"7f96bb07_0b60de31","line":65,"range":{"start_line":65,"start_character":4,"end_line":65,"end_character":6},"in_reply_to":"7f96bb07_e96fc58f","updated":"2018-01-15 15:31:31.000000000","message":"I don\u0027t think devstack supports anything other than fedora/ubuntu, so there\u0027s not much to gain.. just blows up the code.","commit_id":"30e85e97baafb41584978f9775289520be35da8e"},{"author":{"_account_id":17880,"name":"Shachar Snapiri","email":"shachar.snapiri@toganetworks.com","username":"snapiri"},"change_message_id":"92f754681452c3a6d3cc5f2d2cac268af9fbcca7","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        uninstall_package -y zookeeper"},{"line_number":65,"context_line":"    fi"},{"line_number":66,"context_line":"    if [ -f \"/etc/systemd/system/zookeeper.service\" ] ; then"},{"line_number":67,"context_line":"        sudo rm /etc/systemd/system/zookeeper.service"},{"line_number":68,"context_line":"        sudo systemctl daemon-reload"},{"line_number":69,"context_line":"    fi"},{"line_number":70,"context_line":"}"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"7f96bb07_c956895d","line":67,"range":{"start_line":67,"start_character":8,"end_line":67,"end_character":53},"updated":"2018-01-15 10:24:37.000000000","message":"Since we are no longer installing this file, why remove it?","commit_id":"30e85e97baafb41584978f9775289520be35da8e"},{"author":{"_account_id":23235,"name":"Lihi Wishnitzer","email":"lihiwish@gmail.com","username":"lihiwish"},"change_message_id":"9dac55147479e140d8b198ff640b297b79de85e2","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        uninstall_package -y zookeeper"},{"line_number":65,"context_line":"    fi"},{"line_number":66,"context_line":"    if [ -f \"/etc/systemd/system/zookeeper.service\" ] ; then"},{"line_number":67,"context_line":"        sudo rm /etc/systemd/system/zookeeper.service"},{"line_number":68,"context_line":"        sudo systemctl daemon-reload"},{"line_number":69,"context_line":"    fi"},{"line_number":70,"context_line":"}"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"7f96bb07_a96f2ffa","line":67,"range":{"start_line":67,"start_character":8,"end_line":67,"end_character":53},"in_reply_to":"7f96bb07_b5b56f80","updated":"2018-01-17 09:50:01.000000000","message":"Done","commit_id":"30e85e97baafb41584978f9775289520be35da8e"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"0dc5dc7fe54cc28beb6d733b991aa686b50a5bcf","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        uninstall_package -y zookeeper"},{"line_number":65,"context_line":"    fi"},{"line_number":66,"context_line":"    if [ -f \"/etc/systemd/system/zookeeper.service\" ] ; then"},{"line_number":67,"context_line":"        sudo rm /etc/systemd/system/zookeeper.service"},{"line_number":68,"context_line":"        sudo systemctl daemon-reload"},{"line_number":69,"context_line":"    fi"},{"line_number":70,"context_line":"}"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"7f96bb07_b5b56f80","line":67,"range":{"start_line":67,"start_character":8,"end_line":67,"end_character":53},"in_reply_to":"7f96bb07_c956895d","updated":"2018-01-16 07:51:40.000000000","message":"+1. We might end up removing a system-installed file.","commit_id":"30e85e97baafb41584978f9775289520be35da8e"}]}